)]}'
{"neutron/agent/linux/interface.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c3fba5f5d31df42493faf2df33a9896a40d2b76","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    @abc.abstractmethod"},{"line_number":258,"context_line":"    def plug_new(self, network_id, port_id, device_name, mac_address,"},{"line_number":259,"context_line":"                 bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone,"},{"line_number":260,"context_line":"                 link_up\u003dTrue):"},{"line_number":261,"context_line":"        \"\"\"Plug in the interface only for new devices that don\u0027t exist yet.\"\"\""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def plug(self, network_id, port_id, device_name, mac_address,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_07ad2b9a","line":260,"range":{"start_line":260,"start_character":17,"end_line":260,"end_character":29},"updated":"2020-05-20 09:59:25.000000000","message":"So the goal now is to give all 3rd party drivers time to update the method definition. Perfect!","commit_id":"30d573d5abeb4a5251d08dc5384f5c0ff372eff8"}],"neutron/tests/unit/agent/linux/test_interface.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"be592e351e1edd6a59a45664d9f7be00b083ef4f","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                    \u002701234567-1234-1234-99\u0027, \u0027port-1234\u0027, \u0027tap0\u0027,"},{"line_number":686,"context_line":"                    \u0027aa:bb:cc:dd:ee:ff\u0027)"},{"line_number":687,"context_line":"            except TypeError:"},{"line_number":688,"context_line":"                self.fail(\"LinuxInterfaceDriver class can\u0027t call properly \""},{"line_number":689,"context_line":"                          \"plug_new method from the legacy drivers which \""},{"line_number":690,"context_line":"                          \"don\u0027t accepts \u0027link_up\u0027 parameter yet.\")"},{"line_number":691,"context_line":"            log.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_92d22927","line":688,"range":{"start_line":688,"start_character":54,"end_line":688,"end_character":73},"updated":"2020-05-19 20:35:36.000000000","message":"nit: can not properly call\n\nBetter to not use contractions in formal writing","commit_id":"020b2f00a71f45e1cb67cf722679275db22dbb9b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"076f65e0bdd7495f9a2a24db9442e05e8e70b466","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                    \u002701234567-1234-1234-99\u0027, \u0027port-1234\u0027, \u0027tap0\u0027,"},{"line_number":686,"context_line":"                    \u0027aa:bb:cc:dd:ee:ff\u0027)"},{"line_number":687,"context_line":"            except TypeError:"},{"line_number":688,"context_line":"                self.fail(\"LinuxInterfaceDriver class can\u0027t call properly \""},{"line_number":689,"context_line":"                          \"plug_new method from the legacy drivers which \""},{"line_number":690,"context_line":"                          \"don\u0027t accepts \u0027link_up\u0027 parameter yet.\")"},{"line_number":691,"context_line":"            log.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_4d6f52fb","line":688,"range":{"start_line":688,"start_character":54,"end_line":688,"end_character":73},"in_reply_to":"ff570b3c_92d22927","updated":"2020-05-19 21:28:03.000000000","message":"Done","commit_id":"020b2f00a71f45e1cb67cf722679275db22dbb9b"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"be592e351e1edd6a59a45664d9f7be00b083ef4f","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                    \u0027aa:bb:cc:dd:ee:ff\u0027)"},{"line_number":687,"context_line":"            except TypeError:"},{"line_number":688,"context_line":"                self.fail(\"LinuxInterfaceDriver class can\u0027t call properly \""},{"line_number":689,"context_line":"                          \"plug_new method from the legacy drivers which \""},{"line_number":690,"context_line":"                          \"don\u0027t accepts \u0027link_up\u0027 parameter yet.\")"},{"line_number":691,"context_line":"            log.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_7292f558","line":690,"range":{"start_line":689,"start_character":43,"end_line":690,"end_character":65},"updated":"2020-05-19 20:35:36.000000000","message":"nit: from the legacy drivers that do not yet accept the \u0027link_up\u0027 parameter","commit_id":"020b2f00a71f45e1cb67cf722679275db22dbb9b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"076f65e0bdd7495f9a2a24db9442e05e8e70b466","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                    \u0027aa:bb:cc:dd:ee:ff\u0027)"},{"line_number":687,"context_line":"            except TypeError:"},{"line_number":688,"context_line":"                self.fail(\"LinuxInterfaceDriver class can\u0027t call properly \""},{"line_number":689,"context_line":"                          \"plug_new method from the legacy drivers which \""},{"line_number":690,"context_line":"                          \"don\u0027t accepts \u0027link_up\u0027 parameter yet.\")"},{"line_number":691,"context_line":"            log.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0d527a3b","line":690,"range":{"start_line":689,"start_character":43,"end_line":690,"end_character":65},"in_reply_to":"ff570b3c_7292f558","updated":"2020-05-19 21:28:03.000000000","message":"Done","commit_id":"020b2f00a71f45e1cb67cf722679275db22dbb9b"}]}
