)]}'
{"neutron/services/externaldns/drivers/designate/driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            rec_type \u003d \u0027A\u0027"},{"line_number":100,"context_line":"            proj_id \u003d context.project_id"},{"line_number":101,"context_line":"            if v6:"},{"line_number":102,"context_line":"                 rec_type \u003d \u0027AAAA\u0027"},{"line_number":103,"context_line":"            updated_ids \u003d self._insert_records_under_dns_name(proj_id,"},{"line_number":104,"context_line":"                dns_domain, dns_name, records, rec_type, designate)"},{"line_number":105,"context_line":"            if not updated_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_024220ab","line":102,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E111 indentation is not a multiple of four","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            rec_type \u003d \u0027A\u0027"},{"line_number":100,"context_line":"            proj_id \u003d context.project_id"},{"line_number":101,"context_line":"            if v6:"},{"line_number":102,"context_line":"                 rec_type \u003d \u0027AAAA\u0027"},{"line_number":103,"context_line":"            updated_ids \u003d self._insert_records_under_dns_name(proj_id,"},{"line_number":104,"context_line":"                dns_domain, dns_name, records, rec_type, designate)"},{"line_number":105,"context_line":"            if not updated_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_62167caa","line":102,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E117 over-indented","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        designate, designate_admin \u003d get_clients(context)"},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            ids_to_delete \u003d self._get_ids_ips_to_delete("},{"line_number":160,"context_line":"                dns_domain, \u0027%s.%s\u0027 % (dns_name, dns_domain), records, designate)"},{"line_number":161,"context_line":"        except dns_exc.DuplicateRecordSet:"},{"line_number":162,"context_line":"            self._do_partial_recordset_delete(dns_name, dns_domain, records)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_4219b8d4","line":160,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            recordsets \u003d designate_client.recordsets.list("},{"line_number":178,"context_line":"                dns_domain, criterion\u003d{\"name\": \"%s\" % name,"},{"line_number":179,"context_line":"                                       \"type\"; \"%s\" % rec_type})"},{"line_number":180,"context_line":"        except d_exc.NotFound:"},{"line_number":181,"context_line":"            raise dns_exc.DNSDomainNotFound(dns_domain\u003ddns_domain)"},{"line_number":182,"context_line":"        # it will be one record (two records with the same dns_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a20c1494","line":179,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E702 multiple statements on one line (semicolon)","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            recordsets \u003d designate_client.recordsets.list("},{"line_number":178,"context_line":"                dns_domain, criterion\u003d{\"name\": \"%s\" % name,"},{"line_number":179,"context_line":"                                       \"type\"; \"%s\" % rec_type})"},{"line_number":180,"context_line":"        except d_exc.NotFound:"},{"line_number":181,"context_line":"            raise dns_exc.DNSDomainNotFound(dns_domain\u003ddns_domain)"},{"line_number":182,"context_line":"        # it will be one record (two records with the same dns_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_820f5086","line":179,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E999 SyntaxError: invalid syntax","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        except d_exc.NotFound:"},{"line_number":181,"context_line":"            raise dns_exc.DNSDomainNotFound(dns_domain\u003ddns_domain)"},{"line_number":182,"context_line":"        # it will be one record (two records with the same dns_name"},{"line_number":183,"context_line":"        # and record type will be dns_conflict in designate) "},{"line_number":184,"context_line":"        ids \u003d [rec[\u0027id\u0027] for rec in recordsets if \\"},{"line_number":185,"context_line":"               rec[\u0027project_id\u0027] \u003d\u003d project_id]"},{"line_number":186,"context_line":"        # empty nothing to do"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e229ece5","line":183,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: W291 trailing whitespace","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            raise dns_exc.DNSDomainNotFound(dns_domain\u003ddns_domain)"},{"line_number":182,"context_line":"        # it will be one record (two records with the same dns_name"},{"line_number":183,"context_line":"        # and record type will be dns_conflict in designate) "},{"line_number":184,"context_line":"        ids \u003d [rec[\u0027id\u0027] for rec in recordsets if \\"},{"line_number":185,"context_line":"               rec[\u0027project_id\u0027] \u003d\u003d project_id]"},{"line_number":186,"context_line":"        # empty nothing to do"},{"line_number":187,"context_line":"        if not ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_c224a80f","line":184,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E502 the backslash is redundant between brackets","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            return ids"},{"line_number":189,"context_line":"        ips \u003d [str(ip) for rec in recordsets for ip in rec[\u0027records\u0027]]"},{"line_number":190,"context_line":"        ips.append(records)"},{"line_number":191,"context_line":"        update \u003d {\"records\" : ips}"},{"line_number":192,"context_line":"        for rec_id in ids:"},{"line_number":193,"context_line":"            designate_client.update(dns_domain, rec_id, update)"},{"line_number":194,"context_line":"        return ids"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_222004f7","line":191,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            designate_client.update(dns_domain, rec_id, update)"},{"line_number":194,"context_line":"        return ids"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _do_partial_recordset_delete(name, dns_domain, records) "},{"line_number":197,"context_line":"        recordsets \u003d designate_client.recordsets.list(dns_domain, "},{"line_number":198,"context_line":"            criterion\u003d{\"name\": \"%s\" % name})"},{"line_number":199,"context_line":"        records_to_delete \u003d set(records)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_021b40c9","line":196,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: W291 trailing whitespace","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        return ids"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _do_partial_recordset_delete(name, dns_domain, records) "},{"line_number":197,"context_line":"        recordsets \u003d designate_client.recordsets.list(dns_domain, "},{"line_number":198,"context_line":"            criterion\u003d{\"name\": \"%s\" % name})"},{"line_number":199,"context_line":"        records_to_delete \u003d set(records)"},{"line_number":200,"context_line":"        for rec in recordsets:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_627b1cf4","line":197,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E113 unexpected indentation","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        return ids"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _do_partial_recordset_delete(name, dns_domain, records) "},{"line_number":197,"context_line":"        recordsets \u003d designate_client.recordsets.list(dns_domain, "},{"line_number":198,"context_line":"            criterion\u003d{\"name\": \"%s\" % name})"},{"line_number":199,"context_line":"        records_to_delete \u003d set(records)"},{"line_number":200,"context_line":"        for rec in recordsets:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_427ed8e3","line":197,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: W291 trailing whitespace","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            if ips !\u003d ips_to_keep:"},{"line_number":204,"context_line":"                update \u003d {\u0027records\u0027: list(ips_to_keep)}"},{"line_number":205,"context_line":"                designate_client.update(dns_domain, rec_id, update)"},{"line_number":206,"context_line":"            "},{"line_number":207,"context_line":"        "},{"line_number":208,"context_line":"    def _get_ids_ips_to_delete(self, dns_domain, name, records,"},{"line_number":209,"context_line":"                               designate_client):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a281b4c5","line":206,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                update \u003d {\u0027records\u0027: list(ips_to_keep)}"},{"line_number":205,"context_line":"                designate_client.update(dns_domain, rec_id, update)"},{"line_number":206,"context_line":"            "},{"line_number":207,"context_line":"        "},{"line_number":208,"context_line":"    def _get_ids_ips_to_delete(self, dns_domain, name, records,"},{"line_number":209,"context_line":"                               designate_client):"},{"line_number":210,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_828470d4","line":207,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1d8a5f488192049ce55345d83ee499020f413b5b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                designate_client.update(dns_domain, rec_id, update)"},{"line_number":206,"context_line":"            "},{"line_number":207,"context_line":"        "},{"line_number":208,"context_line":"    def _get_ids_ips_to_delete(self, dns_domain, name, records,"},{"line_number":209,"context_line":"                               designate_client):"},{"line_number":210,"context_line":"        try:"},{"line_number":211,"context_line":"            recordsets \u003d designate_client.recordsets.list("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e26e0c2d","line":208,"updated":"2020-05-21 10:23:45.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"1b9a2de0eac1d362eec1d9fe102c5dcf84d044e0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e450caede87f62c5968e95578ea82e35bf8e4ca3","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        return updated_ids"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _do_partial_recordset_delete(name, dns_domain, records):"},{"line_number":192,"context_line":"        recordsets \u003d designate_client.recordsets.list(dns_domain,"},{"line_number":193,"context_line":"            criterion\u003d{\"name\": \"%s\" % name})"},{"line_number":194,"context_line":"        records_to_delete \u003d set(records)"},{"line_number":195,"context_line":"        for rec in recordsets:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_43188c83","line":192,"updated":"2020-05-22 01:49:44.000000000","message":"pep8: F821 undefined name \u0027designate_client\u0027","commit_id":"b7f56e2594d91080578d24f4b3f44b3e6cbcf46e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e450caede87f62c5968e95578ea82e35bf8e4ca3","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            ips_to_keep \u003d ips.difference(records_to_delete)"},{"line_number":198,"context_line":"            if ips !\u003d ips_to_keep:"},{"line_number":199,"context_line":"                update \u003d {\u0027records\u0027: list(ips_to_keep)}"},{"line_number":200,"context_line":"                designate_client.update(dns_domain, rec_id, update)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _get_ids_ips_to_delete(self, dns_domain, name, records,"},{"line_number":203,"context_line":"                               designate_client):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_231d9873","line":200,"updated":"2020-05-22 01:49:44.000000000","message":"pep8: F821 undefined name \u0027designate_client\u0027","commit_id":"b7f56e2594d91080578d24f4b3f44b3e6cbcf46e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e450caede87f62c5968e95578ea82e35bf8e4ca3","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            ips_to_keep \u003d ips.difference(records_to_delete)"},{"line_number":198,"context_line":"            if ips !\u003d ips_to_keep:"},{"line_number":199,"context_line":"                update \u003d {\u0027records\u0027: list(ips_to_keep)}"},{"line_number":200,"context_line":"                designate_client.update(dns_domain, rec_id, update)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _get_ids_ips_to_delete(self, dns_domain, name, records,"},{"line_number":203,"context_line":"                               designate_client):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_8312a461","line":200,"updated":"2020-05-22 01:49:44.000000000","message":"pep8: F821 undefined name \u0027rec_id\u0027","commit_id":"b7f56e2594d91080578d24f4b3f44b3e6cbcf46e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c225898b6f7bee70dee4ba859cc74c5e2da67c88","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            ids_to_delete \u003d self._get_ids_ips_to_delete(dns_domain,"},{"line_number":160,"context_line":"                \u0027%s.%s\u0027 % (dns_name, dns_domain), records, designate)"},{"line_number":161,"context_line":"        except dns_exc.DuplicateRecordSet:"},{"line_number":162,"context_line":"            self._do_partial_recordset_delete(dns_name, dns_domain, records,"},{"line_number":163,"context_line":"                                              designate)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        for _id in ids_to_delete:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_7a0c4e3b","line":162,"updated":"2020-05-22 11:51:41.000000000","message":"pep8: E1121: Too many positional arguments for method call (too-many-function-args)","commit_id":"e17aff1d01fcb44effd4128f3e7d7a370add502c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"630047de95608689571aea742f4d11a9c05480dc","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            designate_client.recordsets.update(dns_domain, rec[\u0027id\u0027],"},{"line_number":189,"context_line":"                                               update)"},{"line_number":190,"context_line":"            updated_ids.append(rec[\u0027id\u0027])"},{"line_number":191,"context_line":"        return updated_ids"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _do_partial_recordset_delete(self, name, dns_domain, records,"},{"line_number":194,"context_line":"                                     designate_client):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_badcd846","line":191,"updated":"2020-05-27 20:48:47.000000000","message":"I don\u0027t know designate, but please tell me if my understanding is correct:\nif there was conflict raised in L93 or L95 You will here get all records for specific domain name and type (\"A\" or \"AAAA\") and You will update it adding one more A field with new IP address for this domain. Is that correct?\n\nIf my above understanding is correct, it will work kind of like \"round robin\" loadbalancer but is that always intentional behavior for users?","commit_id":"03886a1752adb4382d1d23e64243fa763be26095"}]}