)]}'
{"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b0ab0f0d19b01ded01b7ac1cd4af6f0c9db659f0","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        port_sg_rules \u003d self._get_port_sg_rules(port)"},{"line_number":400,"context_line":"        if self._are_sg_rules_stateful(port_sg_rules):"},{"line_number":401,"context_line":"            # comment to prevent duplicate warnings for different devices using"},{"line_number":402,"context_line":"            # same bridge. truncate start to remove prefixes"},{"line_number":403,"context_line":"            comment \u003d \u0027Set zone for %s\u0027 % port[\u0027device\u0027]"},{"line_number":404,"context_line":"            conntrack \u003d \u0027--zone %s\u0027 % self.ipconntrack.get_device_zone(port)"},{"line_number":405,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_6e68e220","line":402,"updated":"2020-05-26 15:18:41.000000000","message":"I still can\u0027t tell why this was done in c76164c058a0cfeee3eb46b523a9ad012f93dd51 but this comment went along with it.","commit_id":"15e439c18863c10821f6a504dc56bad7b0da8533"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"921c8fded7a53e83ec6abcb786f7897b51fd9334","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        port_sg_rules \u003d self._get_port_sg_rules(port)"},{"line_number":400,"context_line":"        if self._are_sg_rules_stateful(port_sg_rules):"},{"line_number":401,"context_line":"            # comment to prevent duplicate warnings for different devices using"},{"line_number":402,"context_line":"            # same bridge. truncate start to remove prefixes"},{"line_number":403,"context_line":"            comment \u003d \u0027Set zone for %s\u0027 % port[\u0027device\u0027]"},{"line_number":404,"context_line":"            conntrack \u003d \u0027--zone %s\u0027 % self.ipconntrack.get_device_zone(port)"},{"line_number":405,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_6dd1e857","line":402,"in_reply_to":"ff570b3c_6e68e220","updated":"2020-05-27 21:45:11.000000000","message":"I think that it was like that due to iptables driver (not iptables_hybrid) in which case in \"device\" there is \"tap_XXXXX\" stored.\n\nIMO it looks a bit strange when You have there something which looks kind of like port_id but it misses first 4 chars. After some more thinking about this, I don\u0027t want to change this behaviour for e.g. Linuxbridge agent so I added small helper method to do it properly only for hybrid driver.","commit_id":"15e439c18863c10821f6a504dc56bad7b0da8533"}]}