)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"93b665b681a99b2f79432a810b776b09e679bb59","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tamerlan Abu \u003ctamerlanabu@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-27 19:03:19 +0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Closes-Bug: #1880934"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1c5dcd1642019cb8c327722819f753b2b5b7137c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_c18c3881","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2020-05-28 07:24:28.000000000","message":"Please follow this [1] wiki page to refactor the commit message.\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"4ad2912a75ba9d79ae7108991082cfa9733c0fb9"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"3920d5e3d5af07fcab265a707b984a97cc0942c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tamerlan Abu \u003ctamerlanabu@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-27 19:03:19 +0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Closes-Bug: #1880934"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1c5dcd1642019cb8c327722819f753b2b5b7137c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_92f45089","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"in_reply_to":"ff570b3c_c18c3881","updated":"2020-05-28 10:48:02.000000000","message":"Most importantly just write a sentence or two at the beginning of the commit message about what this change intends to.","commit_id":"4ad2912a75ba9d79ae7108991082cfa9733c0fb9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e8510d123d4f1a2f654225c2d85cd95d0868dae6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tamerlan Abu \u003ctamerlanabu@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-29 06:18:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The configuration variable \"rpc_response_max_timeout\" is not defined in the Linux Bridge agent."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It results in multiple errors that look like this:"},{"line_number":10,"context_line":"ERROR neutron.plugins.ml2.drivers.agent._common_agent NoSuchOptError: no such option rpc_response_max_timeout in group [DEFAULT]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_33c6154b","line":7,"updated":"2020-05-29 08:28:10.000000000","message":"Thanks for the bug report and this change.\n\nPlease, take a look at https://wiki.openstack.org/wiki/GitCommitMessages\n\nTitle: one line, up to 50 chars (could be more, not a problem, but always under 72 chars).\n\nRest of the commit message: lines under 72 chars.","commit_id":"8325950b6f48e10f245b88ccb99c40e9e46ff8ab"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"684d1066639923d299e8a3cba7e35eaefdf001f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"No rpc_response_max_timeout in LB-agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for rpc_response_max_timeout in LB-agent. "},{"line_number":10,"context_line":"Change-Id: I1c5dcd1642019cb8c327722819f753b2b5b7137c"},{"line_number":11,"context_line":"Closes-Bug: #1880934"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_9201be09","line":9,"range":{"start_line":9,"start_character":54,"end_line":9,"end_character":55},"updated":"2020-06-01 14:23:06.000000000","message":"tiny nit: the trailing space could be deleted","commit_id":"dcc8f6fb8da2fa2cb113c1e09ab85714dce306b5"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"3920d5e3d5af07fcab265a707b984a97cc0942c0","unresolved":false,"context_lines":[{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"    common_config.setup_logging()"},{"line_number":1034,"context_line":"    agent_config.setup_privsep()"},{"line_number":1035,"context_line":"    service_conf.register_service_opts(service_conf.RPC_EXTRA_OPTS, cfg.CONF)"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    try:"},{"line_number":1038,"context_line":"        interface_mappings \u003d helpers.parse_mappings("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_f2daec14","line":1035,"updated":"2020-05-28 10:48:02.000000000","message":"While this solves the immediate problem, I\u0027m wondering if this would be at a better place in neutron/common/config.py or even in neutron_lib/rpc.py?","commit_id":"4ad2912a75ba9d79ae7108991082cfa9733c0fb9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d3a1fdb0a1dc1c738fc624715f23669012ad7a4","unresolved":false,"context_lines":[{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"    common_config.setup_logging()"},{"line_number":1034,"context_line":"    agent_config.setup_privsep()"},{"line_number":1035,"context_line":"    service_conf.register_service_opts(service_conf.RPC_EXTRA_OPTS, cfg.CONF)"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    try:"},{"line_number":1038,"context_line":"        interface_mappings \u003d helpers.parse_mappings("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_f8bc63dd","line":1035,"in_reply_to":"ff570b3c_3b7b7828","updated":"2020-06-01 09:10:22.000000000","message":"I agree with both:\n- this could be addressed in a general config place, like neutron.common.config. This is called from the servers and the agents too. This could be a good place to register a generic parameter like the RPC timeout.\n- this request should be addressed in a separate bug","commit_id":"4ad2912a75ba9d79ae7108991082cfa9733c0fb9"},{"author":{"_account_id":31870,"name":"Tamerlan Abu","email":"tamerlanabu@gmail.com","username":"tabu"},"change_message_id":"5ad25afafac8143a0634b5a2783bc93efac68ddf","unresolved":false,"context_lines":[{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"    common_config.setup_logging()"},{"line_number":1034,"context_line":"    agent_config.setup_privsep()"},{"line_number":1035,"context_line":"    service_conf.register_service_opts(service_conf.RPC_EXTRA_OPTS, cfg.CONF)"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    try:"},{"line_number":1038,"context_line":"        interface_mappings \u003d helpers.parse_mappings("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_3b7b7828","line":1035,"in_reply_to":"ff570b3c_f2daec14","updated":"2020-06-01 05:09:20.000000000","message":"The same way of options registering could also be found here:\n\nhttps://opendev.org/openstack/neutron/src/branch/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py\n\nWhile I agree that it should be unified, I propose opening a different bug report since changes would be out of the scope of this commit.","commit_id":"4ad2912a75ba9d79ae7108991082cfa9733c0fb9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"21b3b182f6ea852ffd6347656d00bd24793cb1b1","unresolved":false,"context_lines":[{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"    common_config.setup_logging()"},{"line_number":1034,"context_line":"    agent_config.setup_privsep()"},{"line_number":1035,"context_line":"    service_conf.register_service_opts(service_conf.RPC_EXTRA_OPTS, cfg.CONF)"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    try:"},{"line_number":1038,"context_line":"        interface_mappings \u003d helpers.parse_mappings("}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_4c94c644","line":1035,"range":{"start_line":1035,"start_character":0,"end_line":1035,"end_character":77},"updated":"2020-05-29 12:44:03.000000000","message":"Could you please consider Bence\u0027s comment here:\nhttps://review.opendev.org/#/c/731194/1/neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py@1035 ?","commit_id":"dcc8f6fb8da2fa2cb113c1e09ab85714dce306b5"}]}