)]}'
{"neutron/cmd/ipset_cleanup.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5585776bc35bfd7feab71a555a7d8d4ed9187fe5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    from the main config that do not apply during clean-up."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    conf \u003d cfg.CONF"},{"line_number":35,"context_line":"    cfg.CONF.register_opts(agent_config.ROOT_HELPER_OPTS, group\u003d\u0027AGENT\u0027)"},{"line_number":36,"context_line":"    command.register_cmd_opts(command.ip_opts, conf)"},{"line_number":37,"context_line":"    return conf"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_218fa92a","line":35,"updated":"2020-06-02 15:26:42.000000000","message":"Good catch!\n\nThere is a method to register those options. This should be:\n  agent_config.register_root_helper(conf\u003dconf)","commit_id":"925260a9ea1c5a3ea02fa4f569f7d49b862ce1cf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"23741cd9ac593b0fa82c6dc2f6d7b6a51ee783d7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    from the main config that do not apply during clean-up."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    conf \u003d cfg.CONF"},{"line_number":35,"context_line":"    cfg.CONF.register_opts(agent_config.ROOT_HELPER_OPTS, group\u003d\u0027AGENT\u0027)"},{"line_number":36,"context_line":"    command.register_cmd_opts(command.ip_opts, conf)"},{"line_number":37,"context_line":"    return conf"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_dcf6965d","line":35,"in_reply_to":"ff570b3c_218fa92a","updated":"2020-06-02 15:39:59.000000000","message":"Done","commit_id":"925260a9ea1c5a3ea02fa4f569f7d49b862ce1cf"}],"neutron/tests/functional/cmd/test_ipset_cleanup.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5585776bc35bfd7feab71a555a7d8d4ed9187fe5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.assertEqual(ipset_manager.NET_PREFIX, self.conf.prefix)"},{"line_number":29,"context_line":"        # This will throw an exception if the `AGENT` group is not registered"},{"line_number":30,"context_line":"        # ref LP: #1881771"},{"line_number":31,"context_line":"        self.assertTrue(self.conf.AGENT is not None)"},{"line_number":32,"context_line":"        # to unregister opts"},{"line_number":33,"context_line":"        self.conf.reset()"},{"line_number":34,"context_line":"        self.conf.unregister_opts(cmd.ip_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5c0a861f","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":39},"updated":"2020-06-02 15:26:42.000000000","message":"\"self.conf.AGENT\" section is already, regardless of the registration of the root helper.\n\nI would not add this test.","commit_id":"925260a9ea1c5a3ea02fa4f569f7d49b862ce1cf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"71b18c11830c4618e4ab17e80f7f2b69758bb5ff","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.assertEqual(ipset_manager.NET_PREFIX, self.conf.prefix)"},{"line_number":29,"context_line":"        # This will throw an exception if the `AGENT` group is not registered"},{"line_number":30,"context_line":"        # ref LP: #1881771"},{"line_number":31,"context_line":"        self.assertTrue(self.conf.AGENT is not None)"},{"line_number":32,"context_line":"        # to unregister opts"},{"line_number":33,"context_line":"        self.conf.reset()"},{"line_number":34,"context_line":"        self.conf.unregister_opts(cmd.ip_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_fc46fa4f","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":39},"in_reply_to":"ff570b3c_5c0a861f","updated":"2020-06-02 15:27:14.000000000","message":"is already registered*","commit_id":"925260a9ea1c5a3ea02fa4f569f7d49b862ce1cf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"23741cd9ac593b0fa82c6dc2f6d7b6a51ee783d7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.assertEqual(ipset_manager.NET_PREFIX, self.conf.prefix)"},{"line_number":29,"context_line":"        # This will throw an exception if the `AGENT` group is not registered"},{"line_number":30,"context_line":"        # ref LP: #1881771"},{"line_number":31,"context_line":"        self.assertTrue(self.conf.AGENT is not None)"},{"line_number":32,"context_line":"        # to unregister opts"},{"line_number":33,"context_line":"        self.conf.reset()"},{"line_number":34,"context_line":"        self.conf.unregister_opts(cmd.ip_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_fcf9da4d","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":39},"in_reply_to":"ff570b3c_fc46fa4f","updated":"2020-06-02 15:39:59.000000000","message":"I\u0027ll drop the test, have validated that it works manually.","commit_id":"925260a9ea1c5a3ea02fa4f569f7d49b862ce1cf"}]}