)]}'
{"etc/neutron/plugins/ml2/ml2_conf_cisco.ini":[{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"5309e0b927131aacc0aecec9e5b5a0a9f46d2480","unresolved":false,"context_lines":[{"line_number":46,"context_line":"[ml2_cisco_apic]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Hostname for the APIC controller"},{"line_number":49,"context_line":"apic_host\u003d1.1.1.1"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Username for the APIC controller"},{"line_number":52,"context_line":"apic_username\u003duser"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAUX%2F%2FXK0%3D","line":49,"updated":"2014-02-13 18:23:50.000000000","message":"All these values should be commented out.","commit_id":"1e0bf638a915253e0e866ddff025e685546fde60"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"89df852afe92e715e80bbc4e36337161e6989fae","unresolved":false,"context_lines":[{"line_number":46,"context_line":"[ml2_cisco_apic]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Hostname for the APIC controller"},{"line_number":49,"context_line":"apic_host\u003d1.1.1.1"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Username for the APIC controller"},{"line_number":52,"context_line":"apic_username\u003duser"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAUX%2F%2FWjo%3D","line":49,"in_reply_to":"AAAAUX%2F%2FXK0%3D","updated":"2014-02-13 19:31:18.000000000","message":"Done","commit_id":"1e0bf638a915253e0e866ddff025e685546fde60"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"5309e0b927131aacc0aecec9e5b5a0a9f46d2480","unresolved":false,"context_lines":[{"line_number":64,"context_line":"apic_function_profile\u003dopenstack_function"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Specify your network topology."},{"line_number":67,"context_line":"# This section indicates how your compute nodes are connected to the fabric\u0027s "},{"line_number":68,"context_line":"# switches and ports. The format is as follows:"},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [switch:\u003cswich_id_from_the_apic\u003e]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAUX%2F%2FXKs%3D","line":67,"updated":"2014-02-13 18:23:50.000000000","message":"white space at end of line","commit_id":"1e0bf638a915253e0e866ddff025e685546fde60"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"89df852afe92e715e80bbc4e36337161e6989fae","unresolved":false,"context_lines":[{"line_number":64,"context_line":"apic_function_profile\u003dopenstack_function"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Specify your network topology."},{"line_number":67,"context_line":"# This section indicates how your compute nodes are connected to the fabric\u0027s "},{"line_number":68,"context_line":"# switches and ports. The format is as follows:"},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [switch:\u003cswich_id_from_the_apic\u003e]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAUX%2F%2FWjk%3D","line":67,"in_reply_to":"AAAAUX%2F%2FXKs%3D","updated":"2014-02-13 19:31:18.000000000","message":"Done","commit_id":"1e0bf638a915253e0e866ddff025e685546fde60"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"65f17e4bd1224199da31cf33765a156f934971c7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# [switch:\u003cswich_id_from_the_apic\u003e]"},{"line_number":72,"context_line":"# \u003ccompute_host\u003e,\u003ccompute_host\u003e\u003d\u003cswitchport_the_host(s)_are_connected_to\u003e"},{"line_number":73,"context_line":"#"},{"line_number":74,"context_line":"# You can have multiple sections, on for each switch in your fabric that is"},{"line_number":75,"context_line":"# participating in Openstack. e.g."},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# [switch:17]"}],"source_content_type":"text/x-properties","patch_set":4,"id":"AAAAUX%2F%2FV4Y%3D","line":74,"updated":"2014-02-13 21:03:40.000000000","message":"Nit: \"one\" instead of \"on\" here.","commit_id":"59efc0060fe976ef3a22a41c79b3aeb73316c983"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"dc01f25443c09da60785772971123a5180c12cb1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# Port for the APIC Controller"},{"line_number":58,"context_line":"# apic_port\u003d80"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Names for APIC objects used by Neutron"},{"line_number":61,"context_line":"# apic_vmm_domain\u003dopenstack"},{"line_number":62,"context_line":"# apic_vlan_ns_name\u003dopenstack_ns"},{"line_number":63,"context_line":"# apic_node_profile\u003dopenstack_profile"}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAUX%2F%2B%2FGY%3D","line":60,"updated":"2014-02-17 20:01:15.000000000","message":"I think it will be good to mention here as to which of the following need to be unique across OpenStack deployments which talk to the same APIC controller.","commit_id":"eaefcb636c423358bf3d955465abd379db637754"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8eaf1490557d147abd477008937f9b6d336d3e3f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# Port for the APIC Controller"},{"line_number":58,"context_line":"# apic_port\u003d80"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Names for APIC objects used by Neutron"},{"line_number":61,"context_line":"# apic_vmm_domain\u003dopenstack"},{"line_number":62,"context_line":"# apic_vlan_ns_name\u003dopenstack_ns"},{"line_number":63,"context_line":"# apic_node_profile\u003dopenstack_profile"}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAUX%2F%2B0gA%3D","line":60,"in_reply_to":"AAAAUX%2F%2B%2FGY%3D","updated":"2014-02-18 20:08:55.000000000","message":"Done","commit_id":"eaefcb636c423358bf3d955465abd379db637754"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"87cf5fce61797dc753cfcb6782e1c83171b0862c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"[ml2_cisco_apic]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Hostname for the APIC controller"},{"line_number":49,"context_line":"# apic_host\u003d1.1.1.1"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Username for the APIC controller"},{"line_number":52,"context_line":"# apic_username\u003duser"}],"source_content_type":"text/x-properties","patch_set":13,"id":"AAAAU3%2F%2F3wI%3D","line":49,"updated":"2014-02-24 11:29:24.000000000","message":"Is the apic_ prefix needed for all these, since it has that indication in the section?","commit_id":"7a60000f697e780999aa3e50454f6d9b4f8ee274"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a5c9ec24a445b5e7b8c1bbdcbe2a91b9a1b12b90","unresolved":false,"context_lines":[{"line_number":46,"context_line":"[ml2_cisco_apic]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Hostname for the APIC controller"},{"line_number":49,"context_line":"# apic_host\u003d1.1.1.1"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Username for the APIC controller"},{"line_number":52,"context_line":"# apic_username\u003duser"}],"source_content_type":"text/x-properties","patch_set":13,"id":"AAAAU3%2F%2FzuQ%3D","line":49,"in_reply_to":"AAAAU3%2F%2F3wI%3D","updated":"2014-02-24 17:38:14.000000000","message":"It is not strictly needed, but for now we\u0027re going to leave it like this. An overall strategy for configuring multiple cisco products is being worked on, but has not been finalized yet. A bug/bp will be opened for any changes that are needed.","commit_id":"7a60000f697e780999aa3e50454f6d9b4f8ee274"}],"neutron/db/migration/alembic_migrations/versions/1b837a7125a9_cisco_apic_driver.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"27ece0b95dbb008f3094eb5e8cd2be6cd56187fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FRD4%3D","line":1,"updated":"2014-02-14 12:33:34.000000000","message":"Remove VIM line from all new files (new requirement).","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPSI%3D","line":1,"in_reply_to":"AAAAUX%2F%2FRD4%3D","updated":"2014-02-14 17:22:59.000000000","message":"I will remove it. Note that this was generated by the neutron-db-manage script. I guess I\u0027ll open a bug for that.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"6cb411385635527a5da1f284520d8a619183a18e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# revision identifiers, used by Alembic."},{"line_number":25,"context_line":"revision \u003d \u00271b837a7125a9\u0027"},{"line_number":26,"context_line":"down_revision \u003d \u00271b2580001654\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"migration_for_plugins \u003d ["},{"line_number":29,"context_line":"    \u0027neutron.plugins.ml2.plugin.Ml2Plugin\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVn%2F%2FzZw%3D","line":26,"updated":"2014-03-04 03:25:08.000000000","message":"lastest down revision: fcac4c42e2cc\n\n(i guess it will change a few more times)","commit_id":"69514ad0478b3c0b01105d80c9ec5b1b09e46da6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9b5c4399b103b38f1e55f92567eec577cfc170f2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# revision identifiers, used by Alembic."},{"line_number":25,"context_line":"revision \u003d \u00271b837a7125a9\u0027"},{"line_number":26,"context_line":"down_revision \u003d \u00271b2580001654\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"migration_for_plugins \u003d ["},{"line_number":29,"context_line":"    \u0027neutron.plugins.ml2.plugin.Ml2Plugin\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVn%2F%2Fyak%3D","line":26,"in_reply_to":"AAAAVn%2F%2FzZw%3D","updated":"2014-03-04 05:03:59.000000000","message":"Done","commit_id":"69514ad0478b3c0b01105d80c9ec5b1b09e46da6"}],"neutron/plugins/ml2/drivers/cisco/apic/apic_client.py":[{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"5309e0b927131aacc0aecec9e5b5a0a9f46d2480","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def unicode2str(data):"},{"line_number":158,"context_line":"    \"\"\""},{"line_number":159,"context_line":"    Recursively convert all unicode strings to byte strings in data."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    This converter is intended for use with data that has been decoded from"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FXC0%3D","line":158,"updated":"2014-02-13 18:23:50.000000000","message":"i thought that with block doc strings that a single line desc method/class follows the opening \"\"\"\nhttp://www.python.org/dev/peps/pep-0008/#documentation-strings","commit_id":"1e0bf638a915253e0e866ddff025e685546fde60"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"89df852afe92e715e80bbc4e36337161e6989fae","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def unicode2str(data):"},{"line_number":158,"context_line":"    \"\"\""},{"line_number":159,"context_line":"    Recursively convert all unicode strings to byte strings in data."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    This converter is intended for use with data that has been decoded from"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FWjc%3D","line":158,"in_reply_to":"AAAAUX%2F%2FXC0%3D","updated":"2014-02-13 19:31:18.000000000","message":"Done","commit_id":"1e0bf638a915253e0e866ddff025e685546fde60"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"27ece0b95dbb008f3094eb5e8cd2be6cd56187fb","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"supported_mos \u003d {"},{"line_number":50,"context_line":"    \u0027fvTenant\u0027: MoPath(None, \u0027tn-%s\u0027),"},{"line_number":51,"context_line":"    \u0027fvBD\u0027: MoPath(\u0027fvTenant\u0027, \u0027BD-%s\u0027),"},{"line_number":52,"context_line":"    \u0027fvRsBd\u0027: MoPath(\u0027fvAEPg\u0027, \u0027rsbd\u0027),"},{"line_number":53,"context_line":"    \u0027fvSubnet\u0027: MoPath(\u0027fvBD\u0027, \u0027subnet-[%s]\u0027),"},{"line_number":54,"context_line":"    \u0027fvCtx\u0027: MoPath(\u0027fvTenant\u0027, \u0027ctx-%s\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FRBw%3D","line":51,"updated":"2014-02-14 12:33:34.000000000","message":"Any decoder ring for naming of keys?","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"supported_mos \u003d {"},{"line_number":50,"context_line":"    \u0027fvTenant\u0027: MoPath(None, \u0027tn-%s\u0027),"},{"line_number":51,"context_line":"    \u0027fvBD\u0027: MoPath(\u0027fvTenant\u0027, \u0027BD-%s\u0027),"},{"line_number":52,"context_line":"    \u0027fvRsBd\u0027: MoPath(\u0027fvAEPg\u0027, \u0027rsbd\u0027),"},{"line_number":53,"context_line":"    \u0027fvSubnet\u0027: MoPath(\u0027fvBD\u0027, \u0027subnet-[%s]\u0027),"},{"line_number":54,"context_line":"    \u0027fvCtx\u0027: MoPath(\u0027fvTenant\u0027, \u0027ctx-%s\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPQ4%3D","line":51,"in_reply_to":"AAAAUX%2F%2FRBw%3D","updated":"2014-02-14 17:22:59.000000000","message":"Yes, the APIC Model Reference. :) I have a pre-release copy, but hopefully soon it will be published somewhere on cisco.com.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"27ece0b95dbb008f3094eb5e8cd2be6cd56187fb","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        else:"},{"line_number":341,"context_line":"            err_code \u003d attributes[\u0027code\u0027]"},{"line_number":342,"context_line":"            err_text \u003d attributes[\u0027text\u0027]"},{"line_number":343,"context_line":"            if (err_code \u003d\u003d \u0027403\u0027 and"},{"line_number":344,"context_line":"                    err_text.lower().startswith(\u0027token was invalid\u0027)):"},{"line_number":345,"context_line":"                # This means the token timed out, so log in again."},{"line_number":346,"context_line":"                LOG.debug(_(\"APIC session timed-out, logging in again.\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FQ70%3D","line":343,"updated":"2014-02-14 12:33:34.000000000","message":"Do you want to use the Requests error code here?","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        else:"},{"line_number":341,"context_line":"            err_code \u003d attributes[\u0027code\u0027]"},{"line_number":342,"context_line":"            err_text \u003d attributes[\u0027text\u0027]"},{"line_number":343,"context_line":"            if (err_code \u003d\u003d \u0027403\u0027 and"},{"line_number":344,"context_line":"                    err_text.lower().startswith(\u0027token was invalid\u0027)):"},{"line_number":345,"context_line":"                # This means the token timed out, so log in again."},{"line_number":346,"context_line":"                LOG.debug(_(\"APIC session timed-out, logging in again.\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPOM%3D","line":343,"in_reply_to":"AAAAUX%2F%2FQ70%3D","updated":"2014-02-14 17:22:59.000000000","message":"The requests (http) error code is on response.status_code, while this err_code is an APIC error code. I did not create constants for the APIC error codes since \u0027403\u0027 is the only one I check for. (The APIC uses 403 for a few different reasons, hence the need to check the err_text string also. I don\u0027t like it but it\u0027s the best I could come up with.)","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"27ece0b95dbb008f3094eb5e8cd2be6cd56187fb","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def _mo_attributes(self, obj_data):"},{"line_number":389,"context_line":"        if (self.mo.klass_name in obj_data"},{"line_number":390,"context_line":"                and \u0027attributes\u0027 in obj_data[self.mo.klass_name]):"},{"line_number":391,"context_line":"            return obj_data[self.mo.klass_name][\u0027attributes\u0027]"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def get(self, *params):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FQ6k%3D","line":390,"updated":"2014-02-14 12:33:34.000000000","message":"Would it help readability with the \"and\" on the previous line?\n\nIs it just Gerrit or is there indentation issues in this file (see a few places)?\n\nI guess PEP8 would catch.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def _mo_attributes(self, obj_data):"},{"line_number":389,"context_line":"        if (self.mo.klass_name in obj_data"},{"line_number":390,"context_line":"                and \u0027attributes\u0027 in obj_data[self.mo.klass_name]):"},{"line_number":391,"context_line":"            return obj_data[self.mo.klass_name][\u0027attributes\u0027]"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def get(self, *params):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPLA%3D","line":390,"in_reply_to":"AAAAUX%2F%2FQ6k%3D","updated":"2014-02-14 17:22:59.000000000","message":"Will move the and. For the indentation I am complying with PEP8 E125.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"dc01f25443c09da60785772971123a5180c12cb1","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        \"\"\"Log in to controller. Save user name and authentication.\"\"\""},{"line_number":316,"context_line":"        name_pwd \u003d self._make_data(\u0027aaaUser\u0027, name\u003dusr, pwd\u003dpwd)"},{"line_number":317,"context_line":"        url \u003d self._api_url(\u0027aaaLogin\u0027)"},{"line_number":318,"context_line":"        response \u003d self.session.post(url, data\u003dname_pwd)"},{"line_number":319,"context_line":"        attributes \u003d self._save_cookie(\u0027aaaLogin\u0027, response)"},{"line_number":320,"context_line":"        if response.status_code \u003d\u003d wexc.HTTPOk.code:"},{"line_number":321,"context_line":"            self.username \u003d usr"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2B%2FEA%3D","line":318,"updated":"2014-02-17 20:01:15.000000000","message":"Per our discussion, do we need to set a configurable time out for this request? Also, how do we handle a timeout?","commit_id":"eaefcb636c423358bf3d955465abd379db637754"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8eaf1490557d147abd477008937f9b6d336d3e3f","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        \"\"\"Log in to controller. Save user name and authentication.\"\"\""},{"line_number":316,"context_line":"        name_pwd \u003d self._make_data(\u0027aaaUser\u0027, name\u003dusr, pwd\u003dpwd)"},{"line_number":317,"context_line":"        url \u003d self._api_url(\u0027aaaLogin\u0027)"},{"line_number":318,"context_line":"        response \u003d self.session.post(url, data\u003dname_pwd)"},{"line_number":319,"context_line":"        attributes \u003d self._save_cookie(\u0027aaaLogin\u0027, response)"},{"line_number":320,"context_line":"        if response.status_code \u003d\u003d wexc.HTTPOk.code:"},{"line_number":321,"context_line":"            self.username \u003d usr"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2B0gI%3D","line":318,"in_reply_to":"AAAAUX%2F%2B%2FEA%3D","updated":"2014-02-18 20:08:55.000000000","message":"Done","commit_id":"eaefcb636c423358bf3d955465abd379db637754"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Cisco Systems"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2B9s%3D","line":1,"updated":"2014-02-27 01:19:48.000000000","message":"In general I find the this file hard to follow as there are lots of abbreviations that make the usage of some python constructs here harder to evaluate.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Cisco Systems"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2s4%3D","line":1,"in_reply_to":"AAAAVX%2F%2F%2B9s%3D","updated":"2014-02-27 22:18:37.000000000","message":"Thanks for pointing this out. I would like it to be easier to follow and have tried to improve the comments and naming. Please provide more feedback for further readability improvements if you have time.\n\nI encourage others to do the same.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import time"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"import json"},{"line_number":34,"context_line":"import logging"},{"line_number":35,"context_line":"import requests"},{"line_number":36,"context_line":"import requests.exceptions"},{"line_number":37,"context_line":"from webob import exc as wexc"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FPI%3D","line":34,"updated":"2014-02-27 01:19:48.000000000","message":"You should be importing the standard logging:\n\nfrom neutron.openstack.common import log as logging","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import time"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"import json"},{"line_number":34,"context_line":"import logging"},{"line_number":35,"context_line":"import requests"},{"line_number":36,"context_line":"import requests.exceptions"},{"line_number":37,"context_line":"from webob import exc as wexc"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2vY%3D","line":34,"in_reply_to":"AAAAVX%2F%2F%2FPI%3D","updated":"2014-02-27 22:18:37.000000000","message":"Done","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import logging"},{"line_number":35,"context_line":"import requests"},{"line_number":36,"context_line":"import requests.exceptions"},{"line_number":37,"context_line":"from webob import exc as wexc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import exceptions as cexc"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FPs%3D","line":37,"updated":"2014-02-27 01:19:48.000000000","message":"You should be using the error handling from requests and not webob.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import logging"},{"line_number":35,"context_line":"import requests"},{"line_number":36,"context_line":"import requests.exceptions"},{"line_number":37,"context_line":"from webob import exc as wexc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import exceptions as cexc"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2vU%3D","line":37,"in_reply_to":"AAAAVX%2F%2F%2FPs%3D","updated":"2014-02-27 22:18:37.000000000","message":"Done","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Info about a MO\u0027s RN format and container class"},{"line_number":46,"context_line":"class MoPath(namedtuple(\u0027MoPath\u0027, [\u0027container\u0027, \u0027rn_fmt\u0027, \u0027can_create\u0027])):"},{"line_number":47,"context_line":"    def __new__(cls, container, rn_fmt, can_create\u003dTrue):"},{"line_number":48,"context_line":"        return super(MoPath, cls).__new__(cls, container, rn_fmt, can_create)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FKc%3D","line":46,"updated":"2014-02-27 01:19:48.000000000","message":"MO?  ManagedObject would more descriptive.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Info about a MO\u0027s RN format and container class"},{"line_number":46,"context_line":"class MoPath(namedtuple(\u0027MoPath\u0027, [\u0027container\u0027, \u0027rn_fmt\u0027, \u0027can_create\u0027])):"},{"line_number":47,"context_line":"    def __new__(cls, container, rn_fmt, can_create\u003dTrue):"},{"line_number":48,"context_line":"        return super(MoPath, cls).__new__(cls, container, rn_fmt, can_create)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2vM%3D","line":46,"in_reply_to":"AAAAVX%2F%2F%2FKc%3D","updated":"2014-02-27 22:18:37.000000000","message":"Done","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    # intentional. It persists for the life of MoClass to cache instances."},{"line_number":123,"context_line":"    # noinspection PyDefaultArgument"},{"line_number":124,"context_line":"    def __new__(cls, mo_class, _inst_cache\u003d{}):"},{"line_number":125,"context_line":"        \"\"\"Ensure we create only one instance per mo_class.\"\"\""},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            return _inst_cache[mo_class]"},{"line_number":128,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2B94%3D","line":125,"updated":"2014-02-27 01:19:48.000000000","message":"Why must we enforce singletons?","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    # intentional. It persists for the life of MoClass to cache instances."},{"line_number":123,"context_line":"    # noinspection PyDefaultArgument"},{"line_number":124,"context_line":"    def __new__(cls, mo_class, _inst_cache\u003d{}):"},{"line_number":125,"context_line":"        \"\"\"Ensure we create only one instance per mo_class.\"\"\""},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            return _inst_cache[mo_class]"},{"line_number":128,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2nc%3D","line":125,"in_reply_to":"AAAAVX%2F%2F%2B94%3D","updated":"2014-02-27 22:18:37.000000000","message":"This Python class describes the managed object classes in the APIC. An instance of this Python class represents one managed  object class in the APIC. There is only one instance of each managed object class.\n\nI am not sure if I am explaining things well. Please continue to ask questions if more clarification is needed. It\u0027s quite possible that I have made things too complicated.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            return new_inst"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def __init__(self, mo_class):"},{"line_number":135,"context_line":"        global supported_mos"},{"line_number":136,"context_line":"        self.klass \u003d mo_class"},{"line_number":137,"context_line":"        self.klass_name \u003d mo_class.split(\u0027__\u0027)[0]"},{"line_number":138,"context_line":"        mo \u003d supported_mos[mo_class]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FSE%3D","line":135,"updated":"2014-02-27 01:19:48.000000000","message":"why is this a global?  Instance object should not access globals.  If you need shared state between instances of the same object, use a class variable.  Even that can get cause more problems than it solves.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            return new_inst"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def __init__(self, mo_class):"},{"line_number":135,"context_line":"        global supported_mos"},{"line_number":136,"context_line":"        self.klass \u003d mo_class"},{"line_number":137,"context_line":"        self.klass_name \u003d mo_class.split(\u0027__\u0027)[0]"},{"line_number":138,"context_line":"        mo \u003d supported_mos[mo_class]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2mI%3D","line":135,"in_reply_to":"AAAAVX%2F%2F%2FSE%3D","updated":"2014-02-27 22:18:37.000000000","message":"Thanks, the global is indeed ugly. I have moved the table into this class. I think it\u0027s OK to have it as a class variable here since, as pointed out above, there is only one instance of this class per entry in the table.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.can_create \u003d rn_has_param and mo.can_create"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _dn_fmt(self):"},{"line_number":147,"context_line":"        \"\"\"Recursively build the DN format using container and RN."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        Also make a list of the required parameters."},{"line_number":150,"context_line":"        Note: Call this method only once at init."}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FOU%3D","line":147,"updated":"2014-02-27 01:19:48.000000000","message":"Nothing about this method is recursive.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.can_create \u003d rn_has_param and mo.can_create"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _dn_fmt(self):"},{"line_number":147,"context_line":"        \"\"\"Recursively build the DN format using container and RN."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        Also make a list of the required parameters."},{"line_number":150,"context_line":"        Note: Call this method only once at init."}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2kU%3D","line":147,"in_reply_to":"AAAAVX%2F%2F%2FOU%3D","updated":"2014-02-27 22:18:37.000000000","message":"The recursion comes about when I create the container object at line 154 below. I have reworded this comment in the next patch, let me know if you think it is OK.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        param \u003d [self.klass] if \u0027%s\u0027 in self.rn_fmt else []"},{"line_number":153,"context_line":"        if self.container:"},{"line_number":154,"context_line":"            container \u003d MoClass(self.container)"},{"line_number":155,"context_line":"            dn_fmt \u003d \u0027/\u0027.join([container.dn_fmt, self.rn_fmt])"},{"line_number":156,"context_line":"            params \u003d container.params + param"},{"line_number":157,"context_line":"            return dn_fmt, params"},{"line_number":158,"context_line":"        return \u0027uni/\u0027 + self.rn_fmt, param"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FNo%3D","line":155,"updated":"2014-02-27 01:19:48.000000000","message":".join() is expensive for a 2 item list.\n\ndn_fmt \u003d \u0027%s/%s\u0027 % (container.dn_fmt, self.rn_fmt)","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        param \u003d [self.klass] if \u0027%s\u0027 in self.rn_fmt else []"},{"line_number":153,"context_line":"        if self.container:"},{"line_number":154,"context_line":"            container \u003d MoClass(self.container)"},{"line_number":155,"context_line":"            dn_fmt \u003d \u0027/\u0027.join([container.dn_fmt, self.rn_fmt])"},{"line_number":156,"context_line":"            params \u003d container.params + param"},{"line_number":157,"context_line":"            return dn_fmt, params"},{"line_number":158,"context_line":"        return \u0027uni/\u0027 + self.rn_fmt, param"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2j8%3D","line":155,"in_reply_to":"AAAAVX%2F%2F%2FNo%3D","updated":"2014-02-27 22:18:37.000000000","message":"Aargh, I know this. Thanks for catching it.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return self.dn_fmt % params"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"def unicode2str(data):"},{"line_number":166,"context_line":"    \"\"\"Recursively convert all unicode strings to byte strings in data."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    This converter is intended for use with data that has been decoded from"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FD0%3D","line":165,"updated":"2014-02-27 01:19:48.000000000","message":"This is needless see below.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return self.dn_fmt % params"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"def unicode2str(data):"},{"line_number":166,"context_line":"    \"\"\"Recursively convert all unicode strings to byte strings in data."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    This converter is intended for use with data that has been decoded from"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2jg%3D","line":165,"in_reply_to":"AAAAVX%2F%2F%2FD0%3D","updated":"2014-02-27 22:18:37.000000000","message":"This is so embarrassing. Completely forgot I still had it here. Thanks.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0d1ad9eb2a15a4aa77bd45a39b8bef1ba3367007","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        Reset the session timeout deadline."},{"line_number":191,"context_line":"        Extract the data from the response and return it."},{"line_number":192,"context_line":"    \"\"\""},{"line_number":193,"context_line":"    def wrapper(self, *args, **kwargs):"},{"line_number":194,"context_line":"        if not self.authentication:"},{"line_number":195,"context_line":"            raise cexc.ApicSessionNotLoggedIn"},{"line_number":196,"context_line":"        if time.time() \u003e self.session_deadline:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAU3%2F%2FcRM%3D","line":193,"updated":"2014-02-26 16:24:42.000000000","message":"This decorator will only work if applied to ApicSession, because of the existence of self.refresh; a decorator definition should strive to be as general as possible. Please consider reworking it either by taking \u0027self\u0027 out of the equation or choosing another pattern for refreshing your session.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        Reset the session timeout deadline."},{"line_number":191,"context_line":"        Extract the data from the response and return it."},{"line_number":192,"context_line":"    \"\"\""},{"line_number":193,"context_line":"    def wrapper(self, *args, **kwargs):"},{"line_number":194,"context_line":"        if not self.authentication:"},{"line_number":195,"context_line":"            raise cexc.ApicSessionNotLoggedIn"},{"line_number":196,"context_line":"        if time.time() \u003e self.session_deadline:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2hI%3D","line":193,"in_reply_to":"AAAAU3%2F%2FcRM%3D","updated":"2014-02-27 22:18:37.000000000","message":"Thank you! Your comment forced me to revisit this, and I am glad. The decorator started out small and grew into a monster. This is not a good use of a decorator, so it\u0027s gone in the next patch.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        else:"},{"line_number":207,"context_line":"            request \u003d \u0027%s, data\u003d%s\u0027 % (url, data)"},{"line_number":208,"context_line":"            LOG.debug(\"data \u003d %s\", data)"},{"line_number":209,"context_line":"        imdata \u003d unicode2str(response.json()).get(\u0027imdata\u0027)"},{"line_number":210,"context_line":"        LOG.debug(\"Response: %s\", imdata)"},{"line_number":211,"context_line":"        if response.status_code !\u003d wexc.HTTPOk.code:"},{"line_number":212,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FBU%3D","line":209,"updated":"2014-02-27 01:19:48.000000000","message":"I\u0027m interested to know why ascii must be forced since python generally handles simple \u003c\u003e unicode items for you. \n\nIf you must, you should pass a method to .json() to decode into ascii for you.  See (http://stackoverflow.com/questions/956867/how-to-get-string-objects-instead-of-unicode-ones-from-json-in-python/6633651#6633651)","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        else:"},{"line_number":207,"context_line":"            request \u003d \u0027%s, data\u003d%s\u0027 % (url, data)"},{"line_number":208,"context_line":"            LOG.debug(\"data \u003d %s\", data)"},{"line_number":209,"context_line":"        imdata \u003d unicode2str(response.json()).get(\u0027imdata\u0027)"},{"line_number":210,"context_line":"        LOG.debug(\"Response: %s\", imdata)"},{"line_number":211,"context_line":"        if response.status_code !\u003d wexc.HTTPOk.code:"},{"line_number":212,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2g8%3D","line":209,"in_reply_to":"AAAAVX%2F%2F%2FBU%3D","updated":"2014-02-27 22:18:37.000000000","message":":hangs head in shame:","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"cc196632b51e3a8471fdfea4cf0b751f40fea251","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            request \u003d url"},{"line_number":214,"context_line":"        else:"},{"line_number":215,"context_line":"            request \u003d \u0027%s, data\u003d%s\u0027 % (url, data)"},{"line_number":216,"context_line":"            LOG.debug(\"data \u003d %s\", data)"},{"line_number":217,"context_line":"        # imdata is where the APIC returns the useful information"},{"line_number":218,"context_line":"        imdata \u003d response.json().get(\u0027imdata\u0027)"},{"line_number":219,"context_line":"        LOG.debug(\"Response: %s\", imdata)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVX%2F%2FtTY%3D","line":216,"updated":"2014-02-28 21:26:07.000000000","message":"All LOG.debug messages under ml2/ follow this syntax\nLOG.debug(_(\"...)\nhttp://docs.openstack.org/trunk/openstack-ops/content/logging_monitoring.html","commit_id":"31fea543a7960f0443a55890a970995d62f87478"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"25265d66c8f550d5271b827fc94753ae7b09ded8","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            request \u003d url"},{"line_number":214,"context_line":"        else:"},{"line_number":215,"context_line":"            request \u003d \u0027%s, data\u003d%s\u0027 % (url, data)"},{"line_number":216,"context_line":"            LOG.debug(\"data \u003d %s\", data)"},{"line_number":217,"context_line":"        # imdata is where the APIC returns the useful information"},{"line_number":218,"context_line":"        imdata \u003d response.json().get(\u0027imdata\u0027)"},{"line_number":219,"context_line":"        LOG.debug(\"Response: %s\", imdata)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVX%2F%2F0Po%3D","line":216,"updated":"2014-02-28 03:55:31.000000000","message":"I18n, here and L219. Check others. 280, 325...","commit_id":"31fea543a7960f0443a55890a970995d62f87478"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"86bef63c28803f358cab607caa64cf4443ab422e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            request \u003d url"},{"line_number":214,"context_line":"        else:"},{"line_number":215,"context_line":"            request \u003d \u0027%s, data\u003d%s\u0027 % (url, data)"},{"line_number":216,"context_line":"            LOG.debug(\"data \u003d %s\", data)"},{"line_number":217,"context_line":"        # imdata is where the APIC returns the useful information"},{"line_number":218,"context_line":"        imdata \u003d response.json().get(\u0027imdata\u0027)"},{"line_number":219,"context_line":"        LOG.debug(\"Response: %s\", imdata)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVX%2F%2F0HA%3D","line":216,"in_reply_to":"AAAAVX%2F%2F0Po%3D","updated":"2014-02-28 04:19:32.000000000","message":"http://lists.openstack.org/pipermail/openstack-dev/2014-February/026136.html\n\nAfter reading that my takeaway is that we shouldn\u0027t translate debug messages. My opinion is that debug messages are for developers, and as a developer I don\u0027t want to end up in a situation where I have to trouble-shoot something where the debug messages have been translated.","commit_id":"31fea543a7960f0443a55890a970995d62f87478"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b27f88d5524e6a46b1108aa23a0a2c485f584b4a","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            request \u003d url"},{"line_number":214,"context_line":"        else:"},{"line_number":215,"context_line":"            request \u003d \u0027%s, data\u003d%s\u0027 % (url, data)"},{"line_number":216,"context_line":"            LOG.debug(\"data \u003d %s\", data)"},{"line_number":217,"context_line":"        # imdata is where the APIC returns the useful information"},{"line_number":218,"context_line":"        imdata \u003d response.json().get(\u0027imdata\u0027)"},{"line_number":219,"context_line":"        LOG.debug(\"Response: %s\", imdata)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVX%2F%2FtQg%3D","line":216,"in_reply_to":"AAAAVX%2F%2FtTY%3D","updated":"2014-02-28 21:42:11.000000000","message":"Done (reluctantly)","commit_id":"31fea543a7960f0443a55890a970995d62f87478"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d0917c5e4ee1eda8c61cdde6a48e8495cc045aef","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# @author: Henry Gessau, Cisco Systems"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from collections import namedtuple"},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXH%2F%2FBjQ%3D","line":18,"updated":"2014-04-24 21:22:20.000000000","message":"There is other H302 working going on and we need to be importing modules only.\n\nimport collections","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c4f06dc85374b75449d29183cac1671d39701cd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# @author: Henry Gessau, Cisco Systems"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from collections import namedtuple"},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F6A8%3D","line":18,"in_reply_to":"AAAAXH%2F%2FBjQ%3D","updated":"2014-04-25 13:42:55.000000000","message":"Done","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d0917c5e4ee1eda8c61cdde6a48e8495cc045aef","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from collections import namedtuple"},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import requests.exceptions"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXH%2F%2FBj4%3D","line":21,"updated":"2014-04-24 21:22:20.000000000","message":"from neutron.openstack.common import jsonutils as json","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c4f06dc85374b75449d29183cac1671d39701cd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from collections import namedtuple"},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import requests.exceptions"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F6Ao%3D","line":21,"in_reply_to":"AAAAXH%2F%2FBj4%3D","updated":"2014-04-25 13:42:55.000000000","message":"Done","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d0917c5e4ee1eda8c61cdde6a48e8495cc045aef","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            attributes \u003d imdata[0][\u0027aaaLogin\u0027][\u0027attributes\u0027]"},{"line_number":285,"context_line":"            if \u0027token\u0027 not in attributes:"},{"line_number":286,"context_line":"                raise cexc.ApicResponseNoCookie(request\u003drequest)"},{"line_number":287,"context_line":"            self.cookie \u003d {\u0027APIC-Cookie\u0027: attributes[\u0027token\u0027]}"},{"line_number":288,"context_line":"            timeout \u003d int(attributes[\u0027refreshTimeoutSeconds\u0027])"},{"line_number":289,"context_line":"            LOG.debug(_(\"APIC session will expire in %d seconds\"), timeout)"},{"line_number":290,"context_line":"            # Give ourselves a few seconds to refresh before timing out"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F%2Fhs%3D","line":287,"updated":"2014-04-24 21:22:20.000000000","message":"try:\n    self.cookie \u003d {\u0027APIC-Cookie\u0027: attributes[\u0027token\u0027]}\nexcept KeyError:\n    raise cexc.ApicResponseNoCookie(request\u003drequest)","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c4f06dc85374b75449d29183cac1671d39701cd","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            attributes \u003d imdata[0][\u0027aaaLogin\u0027][\u0027attributes\u0027]"},{"line_number":285,"context_line":"            if \u0027token\u0027 not in attributes:"},{"line_number":286,"context_line":"                raise cexc.ApicResponseNoCookie(request\u003drequest)"},{"line_number":287,"context_line":"            self.cookie \u003d {\u0027APIC-Cookie\u0027: attributes[\u0027token\u0027]}"},{"line_number":288,"context_line":"            timeout \u003d int(attributes[\u0027refreshTimeoutSeconds\u0027])"},{"line_number":289,"context_line":"            LOG.debug(_(\"APIC session will expire in %d seconds\"), timeout)"},{"line_number":290,"context_line":"            # Give ourselves a few seconds to refresh before timing out"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F6AQ%3D","line":287,"in_reply_to":"AAAAXX%2F%2F%2Fhs%3D","updated":"2014-04-25 13:42:55.000000000","message":"Done","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d0917c5e4ee1eda8c61cdde6a48e8495cc045aef","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                container._create_container(*container_params)"},{"line_number":369,"context_line":"                container.session.post_mo(container.mo, *container_params)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def create(self, *params, **attrs):"},{"line_number":372,"context_line":"        self._create_container(*params)"},{"line_number":373,"context_line":"        if self.mo.can_create and \u0027status\u0027 not in attrs:"},{"line_number":374,"context_line":"            attrs[\u0027status\u0027] \u003d \u0027created\u0027"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F%2Fio%3D","line":371,"updated":"2014-04-24 21:22:20.000000000","message":"Why is this not *args and **kwrags?  The corresponding parameters in .po_mo() is *args and **kwargs","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c4f06dc85374b75449d29183cac1671d39701cd","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                container._create_container(*container_params)"},{"line_number":369,"context_line":"                container.session.post_mo(container.mo, *container_params)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def create(self, *params, **attrs):"},{"line_number":372,"context_line":"        self._create_container(*params)"},{"line_number":373,"context_line":"        if self.mo.can_create and \u0027status\u0027 not in attrs:"},{"line_number":374,"context_line":"            attrs[\u0027status\u0027] \u003d \u0027created\u0027"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F56M%3D","line":371,"in_reply_to":"AAAAXX%2F%2F%2Fio%3D","updated":"2014-04-25 13:42:55.000000000","message":"No good reason. Changed entire file to use args \u0026 kwargs.","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d0917c5e4ee1eda8c61cdde6a48e8495cc045aef","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                \u0027attributes\u0027 in obj_data[self.mo.klass_name]):"},{"line_number":380,"context_line":"            return obj_data[self.mo.klass_name][\u0027attributes\u0027]"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def get(self, *params):"},{"line_number":383,"context_line":"        \"\"\"Return a dict of the MO\u0027s attributes, or None.\"\"\""},{"line_number":384,"context_line":"        imdata \u003d self.session.get_mo(self.mo, *params)"},{"line_number":385,"context_line":"        if imdata:"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F%2FjQ%3D","line":382,"updated":"2014-04-24 21:22:20.000000000","message":"Why is this not *args?  The corresponding attr in .get_mo() is *args.","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c4f06dc85374b75449d29183cac1671d39701cd","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                \u0027attributes\u0027 in obj_data[self.mo.klass_name]):"},{"line_number":380,"context_line":"            return obj_data[self.mo.klass_name][\u0027attributes\u0027]"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def get(self, *params):"},{"line_number":383,"context_line":"        \"\"\"Return a dict of the MO\u0027s attributes, or None.\"\"\""},{"line_number":384,"context_line":"        imdata \u003d self.session.get_mo(self.mo, *params)"},{"line_number":385,"context_line":"        if imdata:"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F56E%3D","line":382,"in_reply_to":"AAAAXX%2F%2F%2FjQ%3D","updated":"2014-04-25 13:42:55.000000000","message":"Done","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d0917c5e4ee1eda8c61cdde6a48e8495cc045aef","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\"Establish a session with the APIC.\"\"\""},{"line_number":408,"context_line":"        super(RestClient, self).__init__(host, port, usr, pwd, ssl)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        # TODO(Henry): Instantiate supported MOs on demand instead of"},{"line_number":411,"context_line":"        #              creating all of them up front here."},{"line_number":412,"context_line":"        # Supported objects for OpenStack Neutron"},{"line_number":413,"context_line":"        for mo_class in ManagedObjectClass.supported_mos:"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F%2Fjc%3D","line":410,"updated":"2014-04-24 21:22:20.000000000","message":"Might be better to do that here.  As of now, you\u0027re creating lots of cyclical references to instances.","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c4f06dc85374b75449d29183cac1671d39701cd","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\"Establish a session with the APIC.\"\"\""},{"line_number":408,"context_line":"        super(RestClient, self).__init__(host, port, usr, pwd, ssl)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        # TODO(Henry): Instantiate supported MOs on demand instead of"},{"line_number":411,"context_line":"        #              creating all of them up front here."},{"line_number":412,"context_line":"        # Supported objects for OpenStack Neutron"},{"line_number":413,"context_line":"        for mo_class in ManagedObjectClass.supported_mos:"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F5fk%3D","line":410,"in_reply_to":"AAAAXX%2F%2F%2Fjc%3D","updated":"2014-04-25 13:42:55.000000000","message":"Done","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"}],"neutron/plugins/ml2/drivers/cisco/apic/apic_model.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"5abc1123097077c72b39b0b7cff5aaf3b890bfef","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_epgs\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    network_id \u003d sa.Column(sa.String(64), nullable\u003dFalse,"},{"line_number":30,"context_line":"                           primary_key\u003dTrue)"},{"line_number":31,"context_line":"    epg_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":32,"context_line":"    segmentation_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":33,"context_line":"    provider \u003d sa.Column(sa.Boolean, default\u003dFalse, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPEA%3D","line":30,"updated":"2014-02-14 16:47:41.000000000","message":"Might wanna change this to String(255) to match neutron network_ids","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_epgs\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    network_id \u003d sa.Column(sa.String(64), nullable\u003dFalse,"},{"line_number":30,"context_line":"                           primary_key\u003dTrue)"},{"line_number":31,"context_line":"    epg_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":32,"context_line":"    segmentation_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":33,"context_line":"    provider \u003d sa.Column(sa.Boolean, default\u003dFalse, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FO9Q%3D","line":30,"in_reply_to":"AAAAUX%2F%2FPEA%3D","updated":"2014-02-14 17:22:59.000000000","message":"Done","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"5abc1123097077c72b39b0b7cff5aaf3b890bfef","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_port_profiles\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    node_id \u003d sa.Column(sa.String(64), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":42,"context_line":"    profile_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":43,"context_line":"    hpselc_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":44,"context_line":"    module \u003d sa.Column(sa.String(10), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPDs%3D","line":41,"updated":"2014-02-14 16:47:41.000000000","message":"Could change this to String(255) just in case node names get crazy.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_port_profiles\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    node_id \u003d sa.Column(sa.String(64), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":42,"context_line":"    profile_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":43,"context_line":"    hpselc_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":44,"context_line":"    module \u003d sa.Column(sa.String(10), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FO8s%3D","line":41,"in_reply_to":"AAAAUX%2F%2FPDs%3D","updated":"2014-02-14 17:22:59.000000000","message":"I shall bow to the whims of verbose admins.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"27ece0b95dbb008f3094eb5e8cd2be6cd56187fb","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_contracts\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    tenant_id \u003d sa.Column(sa.String(64), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":55,"context_line":"    contract_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":56,"context_line":"    filter_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FQ2s%3D","line":54,"updated":"2014-02-14 12:33:34.000000000","message":"Should this be including models_v2.HasTenant as a mixin?\nAlso, tenant_id is 255, if you do use the HasTenant mixin.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_contracts\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    tenant_id \u003d sa.Column(sa.String(64), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":55,"context_line":"    contract_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":56,"context_line":"    filter_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPEE%3D","line":54,"in_reply_to":"AAAAUX%2F%2FQ2s%3D","updated":"2014-02-14 17:22:59.000000000","message":"I cannot use HasTenant because it does not mark it as a primary key. However, I will up this to length 255.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0d1ad9eb2a15a4aa77bd45a39b8bef1ba3367007","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    to_port \u003d sa.Column(sa.Integer(10), nullable\u003dFalse)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class TenantContract(model_base.BASEV2):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    \"\"\"Contracts (and Filters) created on the APIC.\"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAU3%2F%2FcNA%3D","line":50,"updated":"2014-02-26 16:24:42.000000000","message":"please consider using models_v2.HasTenant to this class.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    to_port \u003d sa.Column(sa.Integer(10), nullable\u003dFalse)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class TenantContract(model_base.BASEV2):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    \"\"\"Contracts (and Filters) created on the APIC.\"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2B9c%3D","line":50,"in_reply_to":"AAAAU3%2F%2FcNA%3D","updated":"2014-02-27 01:19:48.000000000","message":"+1","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    to_port \u003d sa.Column(sa.Integer(10), nullable\u003dFalse)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class TenantContract(model_base.BASEV2):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    \"\"\"Contracts (and Filters) created on the APIC.\"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2VI%3D","line":50,"in_reply_to":"AAAAVX%2F%2F%2B9c%3D","updated":"2014-02-27 22:18:37.000000000","message":"OK, but note that this makes setting it as the primary key rather clunky.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0d1ad9eb2a15a4aa77bd45a39b8bef1ba3367007","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_contracts\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    tenant_id \u003d sa.Column(sa.String(255), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":57,"context_line":"    contract_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":58,"context_line":"    filter_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAU3%2F%2FcMs%3D","line":56,"updated":"2014-02-26 16:24:42.000000000","message":"what is meant to use as primary key here, just the tenant? Shouldn\u0027t be the contract_id or both? Could you clarify?","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"afb1cf0713c763b61199b18593582525e74cd63f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_contracts\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    tenant_id \u003d sa.Column(sa.String(255), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":57,"context_line":"    contract_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":58,"context_line":"    filter_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2FnE%3D","line":56,"in_reply_to":"AAAAU3%2F%2FcMs%3D","updated":"2014-02-26 23:28:12.000000000","message":"It\u0027s a 1-1 relationship, one contract per tenant. This table is used to check if a contract for a tenant has been already created. Contract id itself is a generated uuid so no use making it the primary key.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"66d9c085815e2a59cc991180d3dcbf9f496fff4f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_contracts\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    tenant_id \u003d sa.Column(sa.String(255), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":57,"context_line":"    contract_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":58,"context_line":"    filter_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F9bA%3D","line":56,"in_reply_to":"AAAAVX%2F%2F%2FnE%3D","updated":"2014-02-27 06:02:38.000000000","message":"So contract could be the primary key then and use HasTenant as suggested above.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b8103daa7ea1c9c8ac30dffd5a6262d695a9999f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_contracts\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    tenant_id \u003d sa.Column(sa.String(255), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":57,"context_line":"    contract_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":58,"context_line":"    filter_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F180%3D","line":56,"in_reply_to":"AAAAVX%2F%2F2cE%3D","updated":"2014-02-27 22:08:45.000000000","message":"Making a decision at the conceptual level, that is making the tenant primary based on the practical need of avoiding the creation of an index, sounds wrong in principle, but I see what you\u0027re saying now.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"ddd247375f8d3ad4a5e7efac0bbc93d0a6234503","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    __tablename__ \u003d \u0027cisco_ml2_apic_contracts\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    tenant_id \u003d sa.Column(sa.String(255), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":57,"context_line":"    contract_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":58,"context_line":"    filter_id \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2cE%3D","line":56,"in_reply_to":"AAAAVX%2F%2F9bA%3D","updated":"2014-02-27 20:42:11.000000000","message":"No, contract id\u0027s are generated on the fly for tenants that do not have already have a contract created for them, they don\u0027t have any significance within neutron/openstack anywhere, it\u0027s just a name to be supplied to the controller when creating a tenant contract.\n\nOn certain requests that use contracts, the plugin scans this table looking for an entry corresponding to a tenant and if not found, autogenerates one dynamically. Setting contracts to the primary key has no purpose here as there will never be a search on contract_id, only tenant_id.\n\nIf we set contract_id to primary_key, we still need unique tenant_id\u0027s and an index on tenant_id\u0027s. Rather set tenant_id to primary and solve all our problems.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a1d7e463c50664ff191f419410589b3c05e320dc","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def delete_profile_for_node(self, node_id):"},{"line_number":172,"context_line":"        \"\"\"Deletes the port profile for a node.\"\"\""},{"line_number":173,"context_line":"        profile \u003d self.session.query(PortProfile).filter_by("},{"line_number":174,"context_line":"            node_id\u003dnode_id).first()"},{"line_number":175,"context_line":"        if profile:"},{"line_number":176,"context_line":"            self.session.delete(profile)"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAVn%2F%2FYq0%3D","line":173,"updated":"2014-03-06 13:23:28.000000000","message":"Can you just do the delete, w/o test? My understanding is that the delete will not raise an exception, if the entry does not exist.","commit_id":"e79d1c7831b37436ab1f10136dd0e024ff957272"}],"neutron/plugins/ml2/drivers/cisco/apic/config.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def get_switch_and_port_for_host(host_id):"},{"line_number":51,"context_line":"    switch_dict \u003d ML2MechApicConfig.switch_dict"},{"line_number":52,"context_line":"    for switch in switch_dict:"},{"line_number":53,"context_line":"        for port in switch_dict[switch]:"},{"line_number":54,"context_line":"            if host_id in switch_dict[switch][port]:"},{"line_number":55,"context_line":"                return switch, port"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2B70%3D","line":52,"updated":"2014-02-27 01:19:48.000000000","message":"Less key accesses:\n\nfor switch_name, switch in switch_dict.item():\n    for port_name, port in switch.items():\n        if host_id in port:\n            return switch_name, port_name","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def get_switch_and_port_for_host(host_id):"},{"line_number":51,"context_line":"    switch_dict \u003d ML2MechApicConfig.switch_dict"},{"line_number":52,"context_line":"    for switch in switch_dict:"},{"line_number":53,"context_line":"        for port in switch_dict[switch]:"},{"line_number":54,"context_line":"            if host_id in switch_dict[switch][port]:"},{"line_number":55,"context_line":"                return switch, port"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2Pc%3D","line":52,"in_reply_to":"AAAAVX%2F%2F%2B70%3D","updated":"2014-02-27 22:18:37.000000000","message":"nice, thanks","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                return switch, port"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class ML2MechApicConfig(object):"},{"line_number":59,"context_line":"    switch_dict \u003d {}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2B6M%3D","line":58,"updated":"2014-02-27 01:19:48.000000000","message":"Why is this even a class?  Looking at Part 2 this should be a method that returns the dict directly as making a class does not add value.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                return switch, port"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class ML2MechApicConfig(object):"},{"line_number":59,"context_line":"    switch_dict \u003d {}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2PY%3D","line":58,"in_reply_to":"AAAAVX%2F%2F%2B6M%3D","updated":"2014-02-27 22:18:37.000000000","message":"Done","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"6cb411385635527a5da1f284520d8a619183a18e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    cfg.StrOpt(\u0027apic_username\u0027,"},{"line_number":25,"context_line":"               help\u003d_(\"Username for the APIC controller\")),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027apic_password\u0027,"},{"line_number":27,"context_line":"               help\u003d_(\"Password for the APIC controller\")),"},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027apic_port\u0027,"},{"line_number":29,"context_line":"               help\u003d_(\"Communication port for the APIC controller\")),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027apic_vmm_provider\u0027, default\u003d\u0027VMware\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVn%2F%2Fy7M%3D","line":27,"updated":"2014-03-04 03:25:08.000000000","message":"shouldnt secrete be set to true for this?","commit_id":"69514ad0478b3c0b01105d80c9ec5b1b09e46da6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9b5c4399b103b38f1e55f92567eec577cfc170f2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    cfg.StrOpt(\u0027apic_username\u0027,"},{"line_number":25,"context_line":"               help\u003d_(\"Username for the APIC controller\")),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027apic_password\u0027,"},{"line_number":27,"context_line":"               help\u003d_(\"Password for the APIC controller\")),"},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027apic_port\u0027,"},{"line_number":29,"context_line":"               help\u003d_(\"Communication port for the APIC controller\")),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027apic_vmm_provider\u0027, default\u003d\u0027VMware\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVn%2F%2Fyaw%3D","line":27,"in_reply_to":"AAAAVn%2F%2Fy7M%3D","updated":"2014-03-04 05:03:59.000000000","message":"I did not know of this flag. Thanks!","commit_id":"69514ad0478b3c0b01105d80c9ec5b1b09e46da6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"0132cbb5dbbc51501948541365a3c3bb689aa527","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    cfg.StrOpt(\u0027apic_vmm_provider\u0027, default\u003d\u0027VMware\u0027,"},{"line_number":31,"context_line":"               help\u003d_(\"Name for the VMM domain provider\")),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027apic_vmm_domain\u0027, default\u003d\u0027openstack\u0027,"},{"line_number":33,"context_line":"               help\u003d_(\"Name for the VMM domain to be created for Openstack\")),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027apic_vlan_ns_name\u0027, default\u003d\u0027openstack_ns\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\"Name for the vlan namespace to be used for openstack\")),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027apic_vlan_range\u0027, default\u003d\u00272:4093\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAXH%2F%2F4D8%3D","line":33,"updated":"2014-04-16 19:17:04.000000000","message":"Nit: could remove the \"for Openstack\" on these help strings.","commit_id":"61426eace4d5cf3eaaf6206a422fe96641ceb597"}],"neutron/plugins/ml2/drivers/cisco/apic/exceptions.py":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"65f17e4bd1224199da31cf33765a156f934971c7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# @author: Henry Gessau, Cisco Systems"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\"Exceptions used by Cisco Nexus ML2 mechanism driver.\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import exceptions"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FV8U%3D","line":18,"updated":"2014-02-13 21:03:40.000000000","message":"Nit: Cisco APIC ML2 mechanism driver.","commit_id":"59efc0060fe976ef3a22a41c79b3aeb73316c983"}],"neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_client.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"27ece0b95dbb008f3094eb5e8cd2be6cd56187fb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertTrue(self.apic.api_base.startswith(\u0027https://\u0027))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_client_session_login_fail(self):"},{"line_number":70,"context_line":"        self.mock_error_post_response(wexc.HTTPError.code,"},{"line_number":71,"context_line":"                                      code\u003d\u0027599\u0027,"},{"line_number":72,"context_line":"                                      text\u003du\u0027Fake error\u0027)"},{"line_number":73,"context_line":"        self.assertRaises(cexc.ApicResponseNotOk, self.apic.login,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FQ0A%3D","line":70,"updated":"2014-02-14 12:33:34.000000000","message":"Use 401 Unauthorized as code?","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertTrue(self.apic.api_base.startswith(\u0027https://\u0027))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_client_session_login_fail(self):"},{"line_number":70,"context_line":"        self.mock_error_post_response(wexc.HTTPError.code,"},{"line_number":71,"context_line":"                                      code\u003d\u0027599\u0027,"},{"line_number":72,"context_line":"                                      text\u003du\u0027Fake error\u0027)"},{"line_number":73,"context_line":"        self.assertRaises(cexc.ApicResponseNotOk, self.apic.login,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPD8%3D","line":70,"in_reply_to":"AAAAUX%2F%2FQ0A%3D","updated":"2014-02-14 17:22:59.000000000","message":"Done","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import requests"},{"line_number":20,"context_line":"import requests.exceptions"},{"line_number":21,"context_line":"from webob import exc as wexc"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import apic_client as apic"},{"line_number":24,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import exceptions as cexc"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2B40%3D","line":21,"updated":"2014-02-27 01:19:48.000000000","message":"requests should be used and not WebOb here.","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import requests"},{"line_number":20,"context_line":"import requests.exceptions"},{"line_number":21,"context_line":"from webob import exc as wexc"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import apic_client as apic"},{"line_number":24,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import exceptions as cexc"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F2Nk%3D","line":21,"in_reply_to":"AAAAVX%2F%2F%2B40%3D","updated":"2014-02-27 22:18:37.000000000","message":"Done","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d0917c5e4ee1eda8c61cdde6a48e8495cc045aef","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.apic \u003d apic.RestClient(mocked.APIC_HOST)"},{"line_number":35,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _mock_authenticate(self, timeout\u003dNone):"},{"line_number":38,"context_line":"        if timeout is None:"},{"line_number":39,"context_line":"            timeout \u003d 300"},{"line_number":40,"context_line":"        self.reset_reponses()"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F%2Fes%3D","line":37,"updated":"2014-04-24 21:22:20.000000000","message":"timeout\u003d300 and remove 38-39","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c4f06dc85374b75449d29183cac1671d39701cd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.apic \u003d apic.RestClient(mocked.APIC_HOST)"},{"line_number":35,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _mock_authenticate(self, timeout\u003dNone):"},{"line_number":38,"context_line":"        if timeout is None:"},{"line_number":39,"context_line":"            timeout \u003d 300"},{"line_number":40,"context_line":"        self.reset_reponses()"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F5Yg%3D","line":37,"in_reply_to":"AAAAXX%2F%2F%2Fes%3D","updated":"2014-04-25 13:42:55.000000000","message":"Done","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d0917c5e4ee1eda8c61cdde6a48e8495cc045aef","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.mock_append_to_response(\u0027fvTenant\u0027, name\u003d\u0027t2\u0027)"},{"line_number":178,"context_line":"        tlist \u003d self.apic.fvTenant.list_all()"},{"line_number":179,"context_line":"        self.assertIsNotNone(tlist)"},{"line_number":180,"context_line":"        self.assertEqual(len(tlist), 2)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_list_mo_names_ok(self):"},{"line_number":183,"context_line":"        self._mock_authenticate()"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F%2Fd8%3D","line":180,"updated":"2014-04-24 21:22:20.000000000","message":"Shouldn\u0027t we validate what is in the list?","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c4f06dc85374b75449d29183cac1671d39701cd","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.mock_append_to_response(\u0027fvTenant\u0027, name\u003d\u0027t2\u0027)"},{"line_number":178,"context_line":"        tlist \u003d self.apic.fvTenant.list_all()"},{"line_number":179,"context_line":"        self.assertIsNotNone(tlist)"},{"line_number":180,"context_line":"        self.assertEqual(len(tlist), 2)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_list_mo_names_ok(self):"},{"line_number":183,"context_line":"        self._mock_authenticate()"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAXX%2F%2F5a8%3D","line":180,"in_reply_to":"AAAAXX%2F%2F%2Fd8%3D","updated":"2014-04-25 13:42:55.000000000","message":"Done","commit_id":"45485b30b0591b771b4b773d1038e0cbd124c090"}],"neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_common.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"27ece0b95dbb008f3094eb5e8cd2be6cd56187fb","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ControllerMixin(object):"},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    Mock the controller for APIC driver and service unit tests."},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FQzc%3D","line":76,"updated":"2014-02-14 12:33:34.000000000","message":"PEP257 has single line doc strings with quotes on same line as string. Also, for classes, it indicates a blank line before and after the docstring. Here and in other files.","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d6005459d554479b43c4be680022d4ef01ae6aa5","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ControllerMixin(object):"},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    Mock the controller for APIC driver and service unit tests."},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FPCI%3D","line":76,"in_reply_to":"AAAAUX%2F%2FQzc%3D","updated":"2014-02-14 17:22:59.000000000","message":"Done","commit_id":"0ed7a8a84276ec16236266f7ab18fea43611d919"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"593898cc839e3d501f7c248d43a1b39c99ea6dc0","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import requests"},{"line_number":20,"context_line":"from webob import exc as wexc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F%2B4Y%3D","line":20,"updated":"2014-02-27 01:19:48.000000000","message":"same comment about WebOb","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cd1691f47c0fafe38102a893827b65ddfae2eaff","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import requests"},{"line_number":20,"context_line":"from webob import exc as wexc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVX%2F%2F14o%3D","line":20,"in_reply_to":"AAAAVX%2F%2F%2B4Y%3D","updated":"2014-02-27 22:18:37.000000000","message":"Done","commit_id":"6a00df8d92b48cebe17e3b156a5d3f7db0e80b32"}]}
