)]}'
{"neutron/cmd/runtime_checks.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"71a6247fcd55a6ff121321dbccab1f11b6665ae2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    return True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# TODO(ralonsoh): migrate"},{"line_number":42,"context_line":"def dnsmasq_host_tag_support():"},{"line_number":43,"context_line":"    cmd \u003d [\u0027dnsmasq\u0027, \u0027--test\u0027, \u0027--dhcp-host\u003dtag:foo\u0027]"},{"line_number":44,"context_line":"    env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027, \u0027PATH\u0027: \u0027/sbin:/usr/sbin\u0027}"},{"line_number":45,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_311e906f","line":42,"updated":"2020-06-05 21:06:14.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"342ffb09521045c3cb3094cd1b5f17c142f20450"}],"neutron/privileged/agent/linux/dhcp.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e7f392822ead65a6f2e300d5d149d6cf8caf729e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def dhcp_release6_supported():"},{"line_number":45,"context_line":"    cmd \u003d [\u0027env\u0027, \u0027LC_ALL\u003dC\u0027, \u0027dhcp_release6\u0027, \u0027--help\u0027]"},{"line_number":46,"context_line":"    result \u003d processutils.execute(*cmd, check_exit_code\u003dFalse)"},{"line_number":47,"context_line":"    return False if result[1] else True"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_9a8e8d30","line":47,"updated":"2020-06-07 21:44:47.000000000","message":"pep8: R1719: The if expression can be replaced with \u0027not test\u0027 (simplifiable-if-expression)","commit_id":"9e0602afb0eee6e6d830fad5d29ae17e930eed41"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c352a52b9a89c9f1119003da2abbc4ba8503a75a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        cmd +\u003d [\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, namespace]"},{"line_number":24,"context_line":"    cmd +\u003d [\u0027dhcp_release\u0027, interface_name, ip_address, mac_address]"},{"line_number":25,"context_line":"    if client_id:"},{"line_number":26,"context_line":"        cmd +\u003d client_id"},{"line_number":27,"context_line":"    log_errors \u003d processutils.LOG_FINAL_ERROR"},{"line_number":28,"context_line":"    return processutils.execute(*cmd, log_errors\u003dlog_errors)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_d2082f2e","line":26,"updated":"2020-09-23 23:38:51.000000000","message":"client_id is a string, not a list. So this results in the following command, which fails:\n\n  Command: ip netns exec qdhcp-5885eb4e-3b5c-48e6-ae40-8a1eeb6629a1 dhcp_release tapa3753962-c7 10.1.0.27 52:54:00:f5:77:63 0 1 : 5 2 : 5 4 : 0 0 : f 5 : 7 7 : 6 3\n\nHere it is in the wild https://zuul.opendev.org/t/openstack/build/ee0efe9616b04dc384aa3f4d0ca62168/log/controller/logs/screen-q-dhcp.txt#4142","commit_id":"e332054d63cfc6a2f8f65b1b9de192ae0df9ebb3"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3036c0c742f109574389a707a746ca14f39c1fd6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                  ipv6_ra_mode\u003d\u0027slaac\u0027, ipv6_address_mode\u003dNone)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"fake_meta_subnet \u003d dhcp.DictModel(dict(id\u003d\u0027bbbbbbbb-1111-2222-bbbbbbbbbbbb\u0027,"},{"line_number":91,"context_line":"                                       network_id\u003dFAKE_NETWORK_UUID,"},{"line_number":92,"context_line":"                                       cidr\u003d\u0027169.254.169.252/30\u0027,"},{"line_number":93,"context_line":"                                       gateway_ip\u003d\u0027169.254.169.253\u0027,"},{"line_number":94,"context_line":"                                       enable_dhcp\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_0022c301","line":91,"updated":"2020-07-06 08:24:13.000000000","message":"nit: the indentation changes seems unrelated and unnecessary","commit_id":"e332054d63cfc6a2f8f65b1b9de192ae0df9ebb3"}]}