)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cd8bf350b64d6608819a630584346d51efc80c38","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"        iptables_mgr \u003d iptables_manager.IptablesManager(use_ipv6\u003dTrue,"},{"line_number":1740,"context_line":"                                                        nat\u003dFalse,"},{"line_number":1741,"context_line":"                                                        namespace\u003dnamespace)"},{"line_number":1742,"context_line":"        # NOTE(haleyb): Fix after bug 1882588 is fixed in neutron-lib"},{"line_number":1743,"context_line":"        ipv4_rule \u003d (\u0027-p udp -m udp --dport %d -j CHECKSUM --checksum-fill\u0027"},{"line_number":1744,"context_line":"                     % 68)"},{"line_number":1745,"context_line":"        ipv6_rule \u003d (\u0027-p udp -m udp --dport %d -j CHECKSUM --checksum-fill\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_dfd8ecf1","line":1742,"updated":"2020-06-30 13:10:43.000000000","message":"seems like this is already fixed in neutron-lib https://bugs.launchpad.net/neutron/+bug/1882588 so should we update this now before merging?","commit_id":"f53b4758ed325c2cc8ed9ef0602ce6b5a4402b44"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe3f006d609da93cfbe2f5e19c3c5af2d00633c5","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"        iptables_mgr \u003d iptables_manager.IptablesManager(use_ipv6\u003dTrue,"},{"line_number":1740,"context_line":"                                                        nat\u003dFalse,"},{"line_number":1741,"context_line":"                                                        namespace\u003dnamespace)"},{"line_number":1742,"context_line":"        # NOTE(haleyb): Fix after bug 1882588 is fixed in neutron-lib"},{"line_number":1743,"context_line":"        ipv4_rule \u003d (\u0027-p udp -m udp --dport %d -j CHECKSUM --checksum-fill\u0027"},{"line_number":1744,"context_line":"                     % 68)"},{"line_number":1745,"context_line":"        ipv6_rule \u003d (\u0027-p udp -m udp --dport %d -j CHECKSUM --checksum-fill\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0eb4f434","line":1742,"in_reply_to":"bf51134e_82173b52","updated":"2020-06-30 16:18:54.000000000","message":"Option 2 sounds good for me :)","commit_id":"f53b4758ed325c2cc8ed9ef0602ce6b5a4402b44"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd9ced0ee564ed659776ae196f3366dcded7e14c","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"        iptables_mgr \u003d iptables_manager.IptablesManager(use_ipv6\u003dTrue,"},{"line_number":1740,"context_line":"                                                        nat\u003dFalse,"},{"line_number":1741,"context_line":"                                                        namespace\u003dnamespace)"},{"line_number":1742,"context_line":"        # NOTE(haleyb): Fix after bug 1882588 is fixed in neutron-lib"},{"line_number":1743,"context_line":"        ipv4_rule \u003d (\u0027-p udp -m udp --dport %d -j CHECKSUM --checksum-fill\u0027"},{"line_number":1744,"context_line":"                     % 68)"},{"line_number":1745,"context_line":"        ipv6_rule \u003d (\u0027-p udp -m udp --dport %d -j CHECKSUM --checksum-fill\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_82173b52","line":1742,"in_reply_to":"bf51134e_dfd8ecf1","updated":"2020-06-30 14:04:34.000000000","message":"So I guess there\u0027s two options.\n\n1) merge this, then Bernard\u0027s change, then my revert\n\n2) change this review to bump neutron-lib, changing below to use DHCP_CLIENT_PORT at the same time so we don\u0027t break things.  I\u0027d also squash the small other changes in my revert to actually use more constants here as well.  Then rebase Bernard\u0027s change.\n\nJust ping me as I can get option 2 done in a few minutes.","commit_id":"f53b4758ed325c2cc8ed9ef0602ce6b5a4402b44"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cd8bf350b64d6608819a630584346d51efc80c38","unresolved":false,"context_lines":[{"line_number":1859,"context_line":""},{"line_number":1860,"context_line":"    def test_setup_calls_fill_dhcp_udp_checksums_v4(self):"},{"line_number":1861,"context_line":"        self._test_setup_helper(False)"},{"line_number":1862,"context_line":"        # NOTE(haleyb): Fix after bug 1882588 is fixed in neutron-lib"},{"line_number":1863,"context_line":"        rule \u003d (\u0027-p udp -m udp --dport %d -j CHECKSUM --checksum-fill\u0027"},{"line_number":1864,"context_line":"                % 68)"},{"line_number":1865,"context_line":"        expected \u003d [mock.call.add_rule(\u0027POSTROUTING\u0027, rule)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_bfd538ba","line":1862,"updated":"2020-06-30 13:10:43.000000000","message":"same here","commit_id":"f53b4758ed325c2cc8ed9ef0602ce6b5a4402b44"}]}