)]}'
{"neutron/cmd/eventlet/agents/l3.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7575b7156672823283674eb7c2941c6151722768","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def main():"},{"line_number":19,"context_line":"    proctitle \u003d \"neutron-l3-agent (%s)\" % setproctitle.getproctitle()"},{"line_number":20,"context_line":"    setproctitle.setproctitle(proctitle)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    l3_agent.main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c20e5331","line":19,"updated":"2020-06-15 07:59:04.000000000","message":"\"binary\" name is used also in agent\u0027s state dict used in report_state function. It\u0027s also hardcoded value there, see e.g. neutron/agent/l3/agent.py for L3 agent, but it\u0027s similar for e.g. Metadata or DHCP agents.\nMaybe it\u0027s good time to move it to some constant and use the same in both places?","commit_id":"6340fa529fc2b505285a3146efbb3d683f35788c"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"983c18375766ebed5dac5f0f10fef2b9df914012","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def main():"},{"line_number":19,"context_line":"    proctitle \u003d \"neutron-l3-agent (%s)\" % setproctitle.getproctitle()"},{"line_number":20,"context_line":"    setproctitle.setproctitle(proctitle)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    l3_agent.main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a2b51ff1","line":19,"in_reply_to":"bf51134e_c20e5331","updated":"2020-06-15 08:22:52.000000000","message":"Yes, I was toying with that idea too. neutron_lib constants seems like a good place, along with the existing AGENT_TYPE_* ones","commit_id":"6340fa529fc2b505285a3146efbb3d683f35788c"}],"neutron/tests/unit/plugins/ml2/drivers/macvtap/agent/test_macvtap_neutron_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0f05a464fb96f7c99ddfa7e31bbf63762b6e75b2","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            self.assertTrue(mock_pim.called)"},{"line_number":254,"context_line":"            mock_manager.assert_called_with(INTERFACE_MAPPINGS)"},{"line_number":255,"context_line":"            mock_loop.assert_called_with(mock_manager_return, 2, 1,"},{"line_number":256,"context_line":"                                         \u0027Macvtap agent\u0027,"},{"line_number":257,"context_line":"                                         constants.AGENT_PROCESS_MACVTAP)"},{"line_number":258,"context_line":"            self.assertTrue(mock_launch.called)"},{"line_number":259,"context_line":"            self.assertTrue(mock_launch_return.wait.called)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_79997877","line":256,"range":{"start_line":256,"start_character":42,"end_line":256,"end_character":49},"updated":"2020-06-22 13:20:29.000000000","message":"shouldn\u0027t this be constants.AGENT_TYPE_MACVTAP?","commit_id":"17520d73e60c593c1f9fc2c18442710d87bba8a5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"6bc9e894aef622ce051e22ca05842ab73baa99d5","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            self.assertTrue(mock_pim.called)"},{"line_number":254,"context_line":"            mock_manager.assert_called_with(INTERFACE_MAPPINGS)"},{"line_number":255,"context_line":"            mock_loop.assert_called_with(mock_manager_return, 2, 1,"},{"line_number":256,"context_line":"                                         \u0027Macvtap agent\u0027,"},{"line_number":257,"context_line":"                                         constants.AGENT_PROCESS_MACVTAP)"},{"line_number":258,"context_line":"            self.assertTrue(mock_launch.called)"},{"line_number":259,"context_line":"            self.assertTrue(mock_launch_return.wait.called)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_c60091ae","line":256,"range":{"start_line":256,"start_character":42,"end_line":256,"end_character":49},"in_reply_to":"bf51134e_79997877","updated":"2020-06-23 09:05:05.000000000","message":"Indeed, fixing and checking the other agents too","commit_id":"17520d73e60c593c1f9fc2c18442710d87bba8a5"}],"releasenotes/notes/setproctitle_agents-47d7957688f0365d.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0f05a464fb96f7c99ddfa7e31bbf63762b6e75b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    process name formatted this way (showing both old style proces name and"},{"line_number":8,"context_line":"    full process name visible in recent releases)"},{"line_number":9,"context_line":"    ``neutron-agent-name`` ( ``original process name including interpreter``)"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    See bug `1881297 \u003chttps://bugs.launchpad.net/neutron/+bug/1881297\u003e`_"},{"line_number":12,"context_line":"    for more details."},{"line_number":13,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_d98b641c","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2020-06-22 13:20:29.000000000","message":"red block!!","commit_id":"17520d73e60c593c1f9fc2c18442710d87bba8a5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"6bc9e894aef622ce051e22ca05842ab73baa99d5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    process name formatted this way (showing both old style proces name and"},{"line_number":8,"context_line":"    full process name visible in recent releases)"},{"line_number":9,"context_line":"    ``neutron-agent-name`` ( ``original process name including interpreter``)"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    See bug `1881297 \u003chttps://bugs.launchpad.net/neutron/+bug/1881297\u003e`_"},{"line_number":12,"context_line":"    for more details."},{"line_number":13,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_265a2d29","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"in_reply_to":"bf51134e_d98b641c","updated":"2020-06-23 09:05:05.000000000","message":"Oh the horror! Fixed","commit_id":"17520d73e60c593c1f9fc2c18442710d87bba8a5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9877a18b731176b603736e6158d3abcc26ee28f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A previous change to set neutron-server child processes names also modified"},{"line_number":5,"context_line":"    neutron agents\u0027 ones. This can impact monitoring systems relying on"},{"line_number":6,"context_line":"    /proc/PID/environ formatting or `ps -e` output. Now neutron agents all have"},{"line_number":7,"context_line":"    process name formatted this way (showing both old style proces name and"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_b1864065","line":4,"range":{"start_line":4,"start_character":50,"end_line":4,"end_character":59},"updated":"2020-06-25 18:21:21.000000000","message":"s/process","commit_id":"d4fb9a47060c75c81b5e850f45096f41932cdb8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9877a18b731176b603736e6158d3abcc26ee28f8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A previous change to set neutron-server child processes names also modified"},{"line_number":5,"context_line":"    neutron agents\u0027 ones. This can impact monitoring systems relying on"},{"line_number":6,"context_line":"    /proc/PID/environ formatting or `ps -e` output. Now neutron agents all have"},{"line_number":7,"context_line":"    process name formatted this way (showing both old style proces name and"},{"line_number":8,"context_line":"    full process name visible in recent releases)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_91897c76","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":19},"updated":"2020-06-25 18:21:21.000000000","message":"s/agent","commit_id":"d4fb9a47060c75c81b5e850f45096f41932cdb8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9877a18b731176b603736e6158d3abcc26ee28f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    A previous change to set neutron-server child processes names also modified"},{"line_number":5,"context_line":"    neutron agents\u0027 ones. This can impact monitoring systems relying on"},{"line_number":6,"context_line":"    /proc/PID/environ formatting or `ps -e` output. Now neutron agents all have"},{"line_number":7,"context_line":"    process name formatted this way (showing both old style proces name and"},{"line_number":8,"context_line":"    full process name visible in recent releases)"},{"line_number":9,"context_line":"    ``neutron-agent-name`` ( ``original process name including interpreter``)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_91ee9c1f","line":7,"range":{"start_line":7,"start_character":50,"end_line":7,"end_character":53},"updated":"2020-06-25 18:21:21.000000000","message":"s/an old","commit_id":"d4fb9a47060c75c81b5e850f45096f41932cdb8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9877a18b731176b603736e6158d3abcc26ee28f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    A previous change to set neutron-server child processes names also modified"},{"line_number":5,"context_line":"    neutron agents\u0027 ones. This can impact monitoring systems relying on"},{"line_number":6,"context_line":"    /proc/PID/environ formatting or `ps -e` output. Now neutron agents all have"},{"line_number":7,"context_line":"    process name formatted this way (showing both old style proces name and"},{"line_number":8,"context_line":"    full process name visible in recent releases)"},{"line_number":9,"context_line":"    ``neutron-agent-name`` ( ``original process name including interpreter``)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_518b6466","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":16},"updated":"2020-06-25 18:21:21.000000000","message":"s/names","commit_id":"d4fb9a47060c75c81b5e850f45096f41932cdb8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9877a18b731176b603736e6158d3abcc26ee28f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    A previous change to set neutron-server child processes names also modified"},{"line_number":5,"context_line":"    neutron agents\u0027 ones. This can impact monitoring systems relying on"},{"line_number":6,"context_line":"    /proc/PID/environ formatting or `ps -e` output. Now neutron agents all have"},{"line_number":7,"context_line":"    process name formatted this way (showing both old style proces name and"},{"line_number":8,"context_line":"    full process name visible in recent releases)"},{"line_number":9,"context_line":"    ``neutron-agent-name`` ( ``original process name including interpreter``)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_d17f7463","line":7,"range":{"start_line":7,"start_character":60,"end_line":7,"end_character":66},"updated":"2020-06-25 18:21:21.000000000","message":"s/process","commit_id":"d4fb9a47060c75c81b5e850f45096f41932cdb8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9877a18b731176b603736e6158d3abcc26ee28f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    /proc/PID/environ formatting or `ps -e` output. Now neutron agents all have"},{"line_number":7,"context_line":"    process name formatted this way (showing both old style proces name and"},{"line_number":8,"context_line":"    full process name visible in recent releases)"},{"line_number":9,"context_line":"    ``neutron-agent-name`` ( ``original process name including interpreter``)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    See bug `1881297 \u003chttps://bugs.launchpad.net/neutron/+bug/1881297\u003e`_"},{"line_number":12,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_319a30b8","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":29},"updated":"2020-06-25 18:21:21.000000000","message":"blank space","commit_id":"d4fb9a47060c75c81b5e850f45096f41932cdb8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9877a18b731176b603736e6158d3abcc26ee28f8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Monitoring tools relying on exact process names should be checked after"},{"line_number":16,"context_line":"    upgrade, and modified if needed"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_11956c87","line":16,"updated":"2020-06-25 18:21:21.000000000","message":"missing trailing period","commit_id":"d4fb9a47060c75c81b5e850f45096f41932cdb8a"}]}
