)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a1a160b7de18fd3627f300c38df9d243b7fcda0f","unresolved":false,"context_lines":[{"line_number":878,"context_line":"        if up and ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":879,"context_line":"            mac \u003d nat[\u0027external_ids\u0027][ovn_const.OVN_FIP_EXT_MAC_KEY]"},{"line_number":880,"context_line":"            LOG.debug(\"Setting external_mac of port %s to %s\","},{"line_number":881,"context_line":"                      port_id, mac)"},{"line_number":882,"context_line":"            if nat[\u0027external_mac\u0027] !\u003d mac:"},{"line_number":883,"context_line":"                self._nb_ovn.db_set("},{"line_number":884,"context_line":"                    \u0027NAT\u0027, nat[\u0027_uuid\u0027], (\u0027external_mac\u0027, mac)).execute("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f0d6b6c3","line":881,"updated":"2020-06-15 16:39:41.000000000","message":"nit: i think this and L887 should be under the if()\u0027s since there might not be any operation done.","commit_id":"87ae8eaf43718c6514083da3fff8e6dfeb973671"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8a365992ee4869e91b24600b02809b146118d67a","unresolved":false,"context_lines":[{"line_number":878,"context_line":"        if up and ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":879,"context_line":"            mac \u003d nat[\u0027external_ids\u0027][ovn_const.OVN_FIP_EXT_MAC_KEY]"},{"line_number":880,"context_line":"            LOG.debug(\"Setting external_mac of port %s to %s\","},{"line_number":881,"context_line":"                      port_id, mac)"},{"line_number":882,"context_line":"            if nat[\u0027external_mac\u0027] !\u003d mac:"},{"line_number":883,"context_line":"                self._nb_ovn.db_set("},{"line_number":884,"context_line":"                    \u0027NAT\u0027, nat[\u0027_uuid\u0027], (\u0027external_mac\u0027, mac)).execute("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_392e59a5","line":881,"in_reply_to":"bf51134e_f0d6b6c3","updated":"2020-06-15 19:25:11.000000000","message":"++\n\nGood point!","commit_id":"87ae8eaf43718c6514083da3fff8e6dfeb973671"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"faa40528e750709f372dc03b2cf7b733aa3466a6","unresolved":false,"context_lines":[{"line_number":866,"context_line":"            return"},{"line_number":867,"context_line":"        # We take first entry as one port can only have one FIP"},{"line_number":868,"context_line":"        nat \u003d nat[0]"},{"line_number":869,"context_line":"        # If the external_id doesn\u0027t exist, let\u0027s create at this point."},{"line_number":870,"context_line":"        # TODO(dalvarez): Remove this code in T cycle when we\u0027re sure that"},{"line_number":871,"context_line":"        # all DNAT entries have the external_id."},{"line_number":872,"context_line":"        if not nat[\u0027external_ids\u0027].get(ovn_const.OVN_FIP_EXT_MAC_KEY):"},{"line_number":873,"context_line":"            self._nb_ovn.db_set(\u0027NAT\u0027, nat[\u0027_uuid\u0027],"},{"line_number":874,"context_line":"                                (\u0027external_ids\u0027,"},{"line_number":875,"context_line":"                                {ovn_const.OVN_FIP_EXT_MAC_KEY:"},{"line_number":876,"context_line":"                                 nat[\u0027external_mac\u0027]})).execute()"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        if up and ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":879,"context_line":"            mac \u003d nat[\u0027external_ids\u0027][ovn_const.OVN_FIP_EXT_MAC_KEY]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_406a2980","line":876,"range":{"start_line":869,"start_character":9,"end_line":876,"end_character":65},"updated":"2020-06-16 07:14:10.000000000","message":"Maybe its time remove it :)","commit_id":"26f6b90930509314cece4c237e4280b60bae278f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"60d83452d090e04c5e66eb88b14c166067d42f0e","unresolved":false,"context_lines":[{"line_number":866,"context_line":"            return"},{"line_number":867,"context_line":"        # We take first entry as one port can only have one FIP"},{"line_number":868,"context_line":"        nat \u003d nat[0]"},{"line_number":869,"context_line":"        # If the external_id doesn\u0027t exist, let\u0027s create at this point."},{"line_number":870,"context_line":"        # TODO(dalvarez): Remove this code in T cycle when we\u0027re sure that"},{"line_number":871,"context_line":"        # all DNAT entries have the external_id."},{"line_number":872,"context_line":"        if not nat[\u0027external_ids\u0027].get(ovn_const.OVN_FIP_EXT_MAC_KEY):"},{"line_number":873,"context_line":"            self._nb_ovn.db_set(\u0027NAT\u0027, nat[\u0027_uuid\u0027],"},{"line_number":874,"context_line":"                                (\u0027external_ids\u0027,"},{"line_number":875,"context_line":"                                {ovn_const.OVN_FIP_EXT_MAC_KEY:"},{"line_number":876,"context_line":"                                 nat[\u0027external_mac\u0027]})).execute()"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        if up and ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":879,"context_line":"            mac \u003d nat[\u0027external_ids\u0027][ovn_const.OVN_FIP_EXT_MAC_KEY]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_e5a7a10a","line":876,"range":{"start_line":869,"start_character":9,"end_line":876,"end_character":65},"in_reply_to":"bf51134e_406a2980","updated":"2020-06-22 09:02:12.000000000","message":"Yeah, but leave for another review perhaps ?","commit_id":"26f6b90930509314cece4c237e4280b60bae278f"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e637fa3c93c94f44839eea9f4417cd18188d0d83","unresolved":false,"context_lines":[{"line_number":866,"context_line":"            return"},{"line_number":867,"context_line":"        # We take first entry as one port can only have one FIP"},{"line_number":868,"context_line":"        nat \u003d nat[0]"},{"line_number":869,"context_line":"        # If the external_id doesn\u0027t exist, let\u0027s create at this point."},{"line_number":870,"context_line":"        # TODO(dalvarez): Remove this code in T cycle when we\u0027re sure that"},{"line_number":871,"context_line":"        # all DNAT entries have the external_id."},{"line_number":872,"context_line":"        if not nat[\u0027external_ids\u0027].get(ovn_const.OVN_FIP_EXT_MAC_KEY):"},{"line_number":873,"context_line":"            self._nb_ovn.db_set(\u0027NAT\u0027, nat[\u0027_uuid\u0027],"},{"line_number":874,"context_line":"                                (\u0027external_ids\u0027,"},{"line_number":875,"context_line":"                                {ovn_const.OVN_FIP_EXT_MAC_KEY:"},{"line_number":876,"context_line":"                                 nat[\u0027external_mac\u0027]})).execute()"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        if up and ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":879,"context_line":"            mac \u003d nat[\u0027external_ids\u0027][ovn_const.OVN_FIP_EXT_MAC_KEY]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_45de4d6d","line":876,"range":{"start_line":869,"start_character":9,"end_line":876,"end_character":65},"in_reply_to":"bf51134e_e5a7a10a","updated":"2020-06-22 09:05:49.000000000","message":"Yes :) Lets do it after this review. We could clean a lot of old code here.","commit_id":"26f6b90930509314cece4c237e4280b60bae278f"}]}