)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9294a42c33a52bce012bdaa2cc99b8339d8840b8","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                            \" networking-ovn-metadata-agent status/logs.\","},{"line_number":1055,"context_line":"                            port_id)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    def agent_alive(self, chassis, type_, update\u003dTrue):"},{"line_number":1058,"context_line":"        nb_cfg \u003d chassis.nb_cfg"},{"line_number":1059,"context_line":"        key \u003d ovn_const.OVN_LIVENESS_CHECK_EXT_ID_KEY"},{"line_number":1060,"context_line":"        if type_ \u003d\u003d ovn_const.OVN_METADATA_AGENT:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4d6d4f97","line":1057,"range":{"start_line":1057,"start_character":42,"end_line":1057,"end_character":48},"updated":"2020-06-15 15:30:59.000000000","message":"nit: maybe update_db ? Just so we know what update we are talking about here. Or even a docstring to help clarifying it :D","commit_id":"b63a50283d30e87bcee210c5b1e5defa6f7cd794"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"a44ed1baadfbc39b073794de15fcc4c81fd7f874","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                            \" networking-ovn-metadata-agent status/logs.\","},{"line_number":1055,"context_line":"                            port_id)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    def agent_alive(self, chassis, type_, update\u003dTrue):"},{"line_number":1058,"context_line":"        nb_cfg \u003d chassis.nb_cfg"},{"line_number":1059,"context_line":"        key \u003d ovn_const.OVN_LIVENESS_CHECK_EXT_ID_KEY"},{"line_number":1060,"context_line":"        if type_ \u003d\u003d ovn_const.OVN_METADATA_AGENT:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2d9bbb72","line":1057,"range":{"start_line":1057,"start_character":42,"end_line":1057,"end_character":48},"in_reply_to":"bf51134e_4d6d4f97","updated":"2020-06-15 15:36:16.000000000","message":"fair!","commit_id":"b63a50283d30e87bcee210c5b1e5defa6f7cd794"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9294a42c33a52bce012bdaa2cc99b8339d8840b8","unresolved":false,"context_lines":[{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":1072,"context_line":"        # to avoid false positives."},{"line_number":1073,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":1074,"context_line":"            if update:"},{"line_number":1075,"context_line":"                # Update the time of our successful check"},{"line_number":1076,"context_line":"                value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":1077,"context_line":"                self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8d3647b4","line":1074,"range":{"start_line":1073,"start_character":0,"end_line":1074,"end_character":22},"updated":"2020-06-15 15:30:59.000000000","message":"if update and self._nb_ovn...","commit_id":"b63a50283d30e87bcee210c5b1e5defa6f7cd794"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"a44ed1baadfbc39b073794de15fcc4c81fd7f874","unresolved":false,"context_lines":[{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":1072,"context_line":"        # to avoid false positives."},{"line_number":1073,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":1074,"context_line":"            if update:"},{"line_number":1075,"context_line":"                # Update the time of our successful check"},{"line_number":1076,"context_line":"                value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":1077,"context_line":"                self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ed90a351","line":1074,"range":{"start_line":1073,"start_character":0,"end_line":1074,"end_character":22},"in_reply_to":"bf51134e_8d3647b4","updated":"2020-06-15 15:36:16.000000000","message":"hmm i think I want separate checks because I\u0027ll return True if the first one holds but i may or may not skip the update","commit_id":"b63a50283d30e87bcee210c5b1e5defa6f7cd794"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9d4d11637fcdececded8f7e133ec78ecc99211de","unresolved":false,"context_lines":[{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":1072,"context_line":"        # to avoid false positives."},{"line_number":1073,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":1074,"context_line":"            if update:"},{"line_number":1075,"context_line":"                # Update the time of our successful check"},{"line_number":1076,"context_line":"                value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":1077,"context_line":"                self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ad9d0b5b","line":1074,"range":{"start_line":1073,"start_character":0,"end_line":1074,"end_character":22},"in_reply_to":"bf51134e_ed90a351","updated":"2020-06-15 15:37:43.000000000","message":"Ah sorry I missed the return there. You are right!","commit_id":"b63a50283d30e87bcee210c5b1e5defa6f7cd794"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"108ed86de2eacf65e115c99f9a4108e287248ebf","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                            \" networking-ovn-metadata-agent status/logs.\","},{"line_number":1055,"context_line":"                            port_id)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    def agent_alive(self, chassis, type_, update_db\u003dTrue):"},{"line_number":1058,"context_line":"        nb_cfg \u003d chassis.nb_cfg"},{"line_number":1059,"context_line":"        key \u003d ovn_const.OVN_LIVENESS_CHECK_EXT_ID_KEY"},{"line_number":1060,"context_line":"        if type_ \u003d\u003d ovn_const.OVN_METADATA_AGENT:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_0dbe9064","line":1057,"range":{"start_line":1057,"start_character":51,"end_line":1057,"end_character":56},"updated":"2020-06-17 11:28:35.000000000","message":"Do we need the default? Seems like we always pass a value","commit_id":"8ebcd34cc4964973c27458a6124f2f3e3959e1ff"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5fb2342a16d21a45af64f2fe35d6817c8b69e2c2","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                            \" networking-ovn-metadata-agent status/logs.\","},{"line_number":1055,"context_line":"                            port_id)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    def agent_alive(self, chassis, type_, update_db\u003dTrue):"},{"line_number":1058,"context_line":"        nb_cfg \u003d chassis.nb_cfg"},{"line_number":1059,"context_line":"        key \u003d ovn_const.OVN_LIVENESS_CHECK_EXT_ID_KEY"},{"line_number":1060,"context_line":"        if type_ \u003d\u003d ovn_const.OVN_METADATA_AGENT:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_633bdb37","line":1057,"range":{"start_line":1057,"start_character":51,"end_line":1057,"end_character":56},"in_reply_to":"bf51134e_0dbe9064","updated":"2020-06-17 12:55:54.000000000","message":"right good point, i can change it","commit_id":"8ebcd34cc4964973c27458a6124f2f3e3959e1ff"}]}