)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"88f87edc7064a3c16a8175bae01d342ad4ef0809","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This patch adds possibility to specify from which tag/branch OVS and OVN"},{"line_number":23,"context_line":"should be checkout."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I83688031951b97bfe64f3aaa761ad7afc1d5ea55"},{"line_number":26,"context_line":"Closes-Bug: #1883601"},{"line_number":27,"context_line":"Closes-Bug: #1878160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf51134e_b1f184d0","line":24,"updated":"2020-06-19 15:11:57.000000000","message":"@Maciej, you should add yourself as co-author","commit_id":"3dcaa8d4647921fb152f2cc77a15a6fa5bea413c"}],"devstack/lib/ovn_agent":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c9ee373487ae59b802ae6fff09097cee8f312ef6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# There are some ovs functions OVN depends on that must be sourced from"},{"line_number":20,"context_line":"# the ovs neutron plugins. After doing this, the OVN overrides must be"},{"line_number":21,"context_line":"# re-sourced."},{"line_number":22,"context_line":"source ${TOP_DIR}/lib/neutron_plugins/ovs_base"},{"line_number":23,"context_line":"source ${TOP_DIR}/lib/neutron_plugins/openvswitch_agent"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"bf51134e_948eeecd","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":9},"updated":"2020-06-19 14:08:24.000000000","message":"Is it needed in this patch?","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e5544c1bbe8069ffecb4e9658844f96fbd0c548b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# There are some ovs functions OVN depends on that must be sourced from"},{"line_number":20,"context_line":"# the ovs neutron plugins. After doing this, the OVN overrides must be"},{"line_number":21,"context_line":"# re-sourced."},{"line_number":22,"context_line":"source ${TOP_DIR}/lib/neutron_plugins/ovs_base"},{"line_number":23,"context_line":"source ${TOP_DIR}/lib/neutron_plugins/openvswitch_agent"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"bf51134e_d72b487f","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":9},"in_reply_to":"bf51134e_948eeecd","updated":"2020-06-19 14:16:26.000000000","message":"Nope, sorry, I\u0027ll drop if we\u0027ll need recheck.","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"}],"tools/configure_for_func_testing.sh":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d712c4b437ceea2a4e966584cd60c816b3215b47","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":112,"context_line":"        remove_ovs_packages"},{"line_number":113,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":114,"context_line":"        OVS_BRANCH\u003d\"51e9479da62edb04a5be47a7655de75c299b9fa1\""},{"line_number":115,"context_line":"        compile_ovs False /usr /var"},{"line_number":116,"context_line":"    else"},{"line_number":117,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"},{"line_number":118,"context_line":"        PACKAGES\u003d$(echo $PACKAGES | perl -pe \u0027s|python-(?!dev)[^ ]*||g\u0027)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_b50d1037","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":35},"updated":"2020-06-18 08:44:22.000000000","message":"I think this is out of scope for this patch. The problem of using OVS/OVN 2.12 can be fixed on a separated patch than this workaround to make the gate happy again.","commit_id":"e0a66c0f238034d93e7b153db23f72f94e05c843"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"280bbdedc0352eb7618db3fc1eedce90277d9a89","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":112,"context_line":"        remove_ovs_packages"},{"line_number":113,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":114,"context_line":"        OVS_BRANCH\u003d\"51e9479da62edb04a5be47a7655de75c299b9fa1\""},{"line_number":115,"context_line":"        compile_ovs False /usr /var"},{"line_number":116,"context_line":"    else"},{"line_number":117,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"},{"line_number":118,"context_line":"        PACKAGES\u003d$(echo $PACKAGES | perl -pe \u0027s|python-(?!dev)[^ ]*||g\u0027)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_956d6c06","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":35},"in_reply_to":"bf51134e_55b8f4c6","updated":"2020-06-18 09:30:55.000000000","message":"I think we should continue to use OVS 2.12 for this review, this already include OVN and it\u0027s schema files.\n\nIn a separated review we can work on bumping the version of OVN here, making sure that both are compiled (OVS and OVN). That will also include the schema files.","commit_id":"e0a66c0f238034d93e7b153db23f72f94e05c843"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"66d8cb34bad7c5632f8868bc48fc80b213ebeb74","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":112,"context_line":"        remove_ovs_packages"},{"line_number":113,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":114,"context_line":"        OVS_BRANCH\u003d\"51e9479da62edb04a5be47a7655de75c299b9fa1\""},{"line_number":115,"context_line":"        compile_ovs False /usr /var"},{"line_number":116,"context_line":"    else"},{"line_number":117,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"},{"line_number":118,"context_line":"        PACKAGES\u003d$(echo $PACKAGES | perl -pe \u0027s|python-(?!dev)[^ ]*||g\u0027)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_b58350a9","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":35},"in_reply_to":"bf51134e_55b8f4c6","updated":"2020-06-18 09:29:11.000000000","message":"That\u0027s a good point. I think it was working for now just by a chance.","commit_id":"e0a66c0f238034d93e7b153db23f72f94e05c843"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"086f6b984ccc9149ef69ffdd23a2b801246a0e1a","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":112,"context_line":"        remove_ovs_packages"},{"line_number":113,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":114,"context_line":"        OVS_BRANCH\u003d\"51e9479da62edb04a5be47a7655de75c299b9fa1\""},{"line_number":115,"context_line":"        compile_ovs False /usr /var"},{"line_number":116,"context_line":"    else"},{"line_number":117,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"},{"line_number":118,"context_line":"        PACKAGES\u003d$(echo $PACKAGES | perl -pe \u0027s|python-(?!dev)[^ ]*||g\u0027)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_38873764","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":35},"in_reply_to":"bf51134e_956d6c06","updated":"2020-06-18 09:57:09.000000000","message":"allright :) I just wanted to leave a note that yesterday on PS1:\nneutron-fullstack RETRY_LIMIT in 11m 25s\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_410/735799/1/check/neutron-fullstack/410977b/job-output.txt\n\nIt failed on missing python-six package while installing OVS from 2.12.0 for fullstack tests. Fullstack tests are using the same methods as functional ones (for compilation of ovs), so that is why I updated the hash here from 2.12.0 to 51e9479da62edb04a5be47a7655de75c299b9fa1.\n\nToday we found that we have missing OVN schema files in functional tests because new tag doesn\u0027t ship OVN.\n\n\nToday while looking at reviews like this one:\nhttps://review.opendev.org/#/c/735982/\n\nwe may notice that fullstack and functional tests are passing! It smells fishy to me... Looks like something has change and was roll backed from devstack in meantime, that first blocked python-six installation and then added it again :D","commit_id":"e0a66c0f238034d93e7b153db23f72f94e05c843"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"96e27eaf6d8e2d8c1daff78374c6b00ee6a45d6d","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":112,"context_line":"        remove_ovs_packages"},{"line_number":113,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":114,"context_line":"        OVS_BRANCH\u003d\"51e9479da62edb04a5be47a7655de75c299b9fa1\""},{"line_number":115,"context_line":"        compile_ovs False /usr /var"},{"line_number":116,"context_line":"    else"},{"line_number":117,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"},{"line_number":118,"context_line":"        PACKAGES\u003d$(echo $PACKAGES | perl -pe \u0027s|python-(?!dev)[^ ]*||g\u0027)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_f55e6810","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":35},"in_reply_to":"bf51134e_b50d1037","updated":"2020-06-18 08:54:41.000000000","message":"Yeah, but for now we have functional tests failing because we checkout v2.12.0 that compilation doesn\u0027t work.\n\nWe can for now disable the functional tests within this patch and solve the problem it other patch with enabling those back.","commit_id":"e0a66c0f238034d93e7b153db23f72f94e05c843"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a1e6455df7edc1a255d6d81da99186167c324a0b","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":112,"context_line":"        remove_ovs_packages"},{"line_number":113,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":114,"context_line":"        OVS_BRANCH\u003d\"51e9479da62edb04a5be47a7655de75c299b9fa1\""},{"line_number":115,"context_line":"        compile_ovs False /usr /var"},{"line_number":116,"context_line":"    else"},{"line_number":117,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"},{"line_number":118,"context_line":"        PACKAGES\u003d$(echo $PACKAGES | perl -pe \u0027s|python-(?!dev)[^ ]*||g\u0027)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_55b8f4c6","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":35},"in_reply_to":"bf51134e_b5a990de","updated":"2020-06-18 09:20:11.000000000","message":"Hi folks. Maybe I\u0027m adding noise to this conversation.\n\nRelated to the FT failures. If OVN is not compile and ovsdbapp is looking for both NB and SB schemes, where can we retrieve the installed schemes files? We should not use github OVN master but the exact schemes being used.","commit_id":"e0a66c0f238034d93e7b153db23f72f94e05c843"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16f96d63160e0bbafe3b93cd156ccc4d3f182cd5","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":112,"context_line":"        remove_ovs_packages"},{"line_number":113,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":114,"context_line":"        OVS_BRANCH\u003d\"51e9479da62edb04a5be47a7655de75c299b9fa1\""},{"line_number":115,"context_line":"        compile_ovs False /usr /var"},{"line_number":116,"context_line":"    else"},{"line_number":117,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"},{"line_number":118,"context_line":"        PACKAGES\u003d$(echo $PACKAGES | perl -pe \u0027s|python-(?!dev)[^ ]*||g\u0027)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_b5a990de","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":35},"in_reply_to":"bf51134e_f55e6810","updated":"2020-06-18 08:58:35.000000000","message":"hmm ok I might be missing something then, I was looking at patch-set #1 and the functional job was happy:\n\nneutron-functional SUCCESS in 37m 15s\nneutron-functional-with-uwsgi SUCCESS in 51m 55s","commit_id":"e0a66c0f238034d93e7b153db23f72f94e05c843"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cce8b639e7d24d92357e139d65de9c219671fc79","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    TOP_DIR\u003d$DEVSTACK_PATH"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if [ -f $DEVSTACK_PATH/local.conf ]; then"},{"line_number":86,"context_line":"        source $DEVSTACK_PATH/local.conf 2\u003e /dev/null || true"},{"line_number":87,"context_line":"    fi"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    source $DEVSTACK_PATH/stackrc"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf51134e_b755f4c8","line":86,"range":{"start_line":86,"start_character":54,"end_line":86,"end_character":61},"updated":"2020-06-19 14:29:26.000000000","message":"Is this to not fail on errors in the local.conf?","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"1ab18082f814501c8de5e2913bea805d3cd0938f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    TOP_DIR\u003d$DEVSTACK_PATH"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if [ -f $DEVSTACK_PATH/local.conf ]; then"},{"line_number":86,"context_line":"        source $DEVSTACK_PATH/local.conf 2\u003e /dev/null || true"},{"line_number":87,"context_line":"    fi"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    source $DEVSTACK_PATH/stackrc"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf51134e_f7ddac14","line":86,"range":{"start_line":86,"start_character":54,"end_line":86,"end_character":61},"in_reply_to":"bf51134e_b755f4c8","updated":"2020-06-19 14:43:59.000000000","message":"Yeah... Try to source local.conf file like this one and you\u0027ll see :D \n\nhttp://paste.openstack.org/show/795007/\n\nIt will produce an error and exit the script.","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"}],"zuul.d/base.yaml":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c9ee373487ae59b802ae6fff09097cee8f312ef6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - ^neutron/locale/.*$"},{"line_number":19,"context_line":"      - ^releasenotes/.*$"},{"line_number":20,"context_line":"    vars:"},{"line_number":21,"context_line":"      OVN_BRANCH: v20.03.0"},{"line_number":22,"context_line":"      # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created."},{"line_number":23,"context_line":"      OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":24,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_f4be4a63","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"updated":"2020-06-19 14:08:24.000000000","message":"I would stick to convention to keep ansible vars lowercase and shell vars uppercase","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"c2a1a64bc880ed88d503c022d28ea5b05f545deb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - ^neutron/locale/.*$"},{"line_number":19,"context_line":"      - ^releasenotes/.*$"},{"line_number":20,"context_line":"    vars:"},{"line_number":21,"context_line":"      OVN_BRANCH: v20.03.0"},{"line_number":22,"context_line":"      # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created."},{"line_number":23,"context_line":"      OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":24,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_e2632c19","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"in_reply_to":"bf51134e_2271a4aa","updated":"2020-06-19 15:32:39.000000000","message":"That is a solution, but what if we would like to run the functional tests from branches different than the release one (default one)? \n\nThe goal on my patch proposed [1] was to make it configurable. Not only just for fun :D but to have a possibility of running code with the Core OVN version having the required feature.\n\n[1] https://review.opendev.org/#/c/727193/","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7fa5e5511d6067bcd77b30f5100163f40bd6fc33","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - ^neutron/locale/.*$"},{"line_number":19,"context_line":"      - ^releasenotes/.*$"},{"line_number":20,"context_line":"    vars:"},{"line_number":21,"context_line":"      OVN_BRANCH: v20.03.0"},{"line_number":22,"context_line":"      # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created."},{"line_number":23,"context_line":"      OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":24,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_2329a637","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"in_reply_to":"bf51134e_88fed1ab","updated":"2020-06-19 17:14:18.000000000","message":"++ to unblock the gate.","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"88f87edc7064a3c16a8175bae01d342ad4ef0809","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - ^neutron/locale/.*$"},{"line_number":19,"context_line":"      - ^releasenotes/.*$"},{"line_number":20,"context_line":"    vars:"},{"line_number":21,"context_line":"      OVN_BRANCH: v20.03.0"},{"line_number":22,"context_line":"      # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created."},{"line_number":23,"context_line":"      OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":24,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_2271a4aa","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"in_reply_to":"bf51134e_97727010","updated":"2020-06-19 15:11:57.000000000","message":"Good discussion.\n\nJust throwing another idea here, do we care about being able to configure the OVN/OVS version for the functional/fullstack job at the zuul level ?\n\nDifferent than tempest, we do not run functional-ovn-released and functional-ovn-master jobs (same for fullstack), also not sure we want to do it.\n\nIf all we care is running functional with the latest released versions of OVN/OVS, perhaps we could just use the default from the DevStack module [0][1], it\u0027s less places to update once we want to bump the OVN version. To do that we need to source the DevStack module at [2] as this patch already does and get rid of those {OVS, OVN}_BRANCH variabels from there and from this file here.\n\nWhat do you think ?\n\n[0] https://github.com/openstack/neutron/blob/78e16c77428e071ac14fbd3727840cd6348d1e7a/devstack/lib/ovn_agent#L33\n\n[1] https://github.com/openstack/neutron/blob/78e16c77428e071ac14fbd3727840cd6348d1e7a/devstack/lib/ovn_agent#L43\n\n[2] https://review.opendev.org/#/c/735799/6/roles/configure_functional_tests/tasks/main.yaml a","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"1ab18082f814501c8de5e2913bea805d3cd0938f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - ^neutron/locale/.*$"},{"line_number":19,"context_line":"      - ^releasenotes/.*$"},{"line_number":20,"context_line":"    vars:"},{"line_number":21,"context_line":"      OVN_BRANCH: v20.03.0"},{"line_number":22,"context_line":"      # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created."},{"line_number":23,"context_line":"      OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":24,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_97727010","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"in_reply_to":"bf51134e_b76e9492","updated":"2020-06-19 14:43:59.000000000","message":"The point is that functional/fullstack jobs are a bit messy. Lemme show how it works for now.\n\n1. Zuul spawns VM, performs a few playbooks that configures the host, generates the local.conf (under stack user) and clones code to:\n/home/zuul/opendev.org/openstack/devstack,neutron,ovn\n\n2. Zuul runs this set of playbooks under \u0027zuul\u0027 user:\nhttps://github.com/openstack/neutron/blob/master/zuul.d/base.yaml#L12\n\na) configure functional jobs with ovn/ovs compilation\nhttps://github.com/openstack/neutron/blob/master/playbooks/run_functional_job.yaml#L3\n\nb) do devstack stack.sh (under stack user this time...) with all the thingies disabled\n\nc) run tox -e dsvm-functional.\n\n\nOn stage a) we don\u0027t rally have access to generated local.conf, because it is under different users home dir (/opt/stack) instead /home/zuul... So we need to send those variables somehow, that is why I added those into ansible vars.\n\n\nI can re-name it to lower-case, but please wait for first test results if this makes sense at all.","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cce8b639e7d24d92357e139d65de9c219671fc79","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - ^neutron/locale/.*$"},{"line_number":19,"context_line":"      - ^releasenotes/.*$"},{"line_number":20,"context_line":"    vars:"},{"line_number":21,"context_line":"      OVN_BRANCH: v20.03.0"},{"line_number":22,"context_line":"      # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created."},{"line_number":23,"context_line":"      OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":24,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_b76e9492","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"in_reply_to":"bf51134e_d7022809","updated":"2020-06-19 14:29:26.000000000","message":"Then perhaps having it an ansible var is not the best solution and you should pass it as a var to devstack local.conf?\n\nYou can claim this reasoning of using grep to any variable :)","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4aadece849b6a736b404893adcf11e8c5222e790","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - ^neutron/locale/.*$"},{"line_number":19,"context_line":"      - ^releasenotes/.*$"},{"line_number":20,"context_line":"    vars:"},{"line_number":21,"context_line":"      OVN_BRANCH: v20.03.0"},{"line_number":22,"context_line":"      # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created."},{"line_number":23,"context_line":"      OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":24,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_88fed1ab","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"in_reply_to":"bf51134e_e2632c19","updated":"2020-06-19 16:27:12.000000000","message":"Let\u0027s first merge this patch and then we\u0027ll continue this discussion. Do you agree?","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e5544c1bbe8069ffecb4e9658844f96fbd0c548b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - ^neutron/locale/.*$"},{"line_number":19,"context_line":"      - ^releasenotes/.*$"},{"line_number":20,"context_line":"    vars:"},{"line_number":21,"context_line":"      OVN_BRANCH: v20.03.0"},{"line_number":22,"context_line":"      # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created."},{"line_number":23,"context_line":"      OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":24,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_d7022809","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":16},"in_reply_to":"bf51134e_f4be4a63","updated":"2020-06-19 14:16:26.000000000","message":"By changing the branch version we usually do `grep OVN_BRANCH` and change all the occurrences. Having it lower-case only in this particular place could lead someone, for example me, to forget to update the version here in future.\nI would stick to the same naming of those two particular vars everywhere.\n\nwdyf?","commit_id":"d0860588957730b97fe3ebbefa77c6421da45adc"}],"zuul.d/tempest-singlenode.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"25d18770d28893089c5b5d1c120f55a54a7c0b50","unresolved":false,"context_lines":[{"line_number":300,"context_line":"      devstack_localrc:"},{"line_number":301,"context_line":"        OVN_BRANCH: v20.03.0"},{"line_number":302,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":303,"context_line":"        OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"- job:"},{"line_number":306,"context_line":"    name: neutron-ovn-tempest-ovs-release"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_96fe4703","line":303,"updated":"2020-06-16 08:59:58.000000000","message":"Just an idea, I haven\u0027t tested but, what if we stop compiling the kernel module ? See [0]. There\u0027s already a TODO there to stop doing that anyway.\n\nWould that work you think ?\n\n[0] https://github.com/openstack/neutron/blob/7d8f400791707e5db7839dcdf3ef4dbbd1dd39bc/zuul.d/tempest-singlenode.yaml#L210-L213","commit_id":"2f13342d59499d27394f4a64e2394f7d3251ae71"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"fa03d7c12a2006a57e5e5e9958f428073f8ffa72","unresolved":false,"context_lines":[{"line_number":300,"context_line":"      devstack_localrc:"},{"line_number":301,"context_line":"        OVN_BRANCH: v20.03.0"},{"line_number":302,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":303,"context_line":"        OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"- job:"},{"line_number":306,"context_line":"    name: neutron-ovn-tempest-ovs-release"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_b6d54bbc","line":303,"in_reply_to":"bf51134e_56214ffb","updated":"2020-06-16 09:39:29.000000000","message":"With Ubuntu Focal we will be okay:\n\nhttps://packages.ubuntu.com/focal/linux-generic\n\nSo we could just use new Ubuntu.","commit_id":"2f13342d59499d27394f4a64e2394f7d3251ae71"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e21057a6bdebdbb0d2ef04fade36d1323556c402","unresolved":false,"context_lines":[{"line_number":300,"context_line":"      devstack_localrc:"},{"line_number":301,"context_line":"        OVN_BRANCH: v20.03.0"},{"line_number":302,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":303,"context_line":"        OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"- job:"},{"line_number":306,"context_line":"    name: neutron-ovn-tempest-ovs-release"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_56214ffb","line":303,"in_reply_to":"bf51134e_96fe4703","updated":"2020-06-16 09:32:53.000000000","message":"The best would be to stop compiling OVS at all. :) But as Maciej says, we need to compile kernel modules for QoS as the one shipped with Ubuntu is not good enough for us.","commit_id":"2f13342d59499d27394f4a64e2394f7d3251ae71"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"c06b951fb709a93092d8711770c942a26d683872","unresolved":false,"context_lines":[{"line_number":300,"context_line":"      devstack_localrc:"},{"line_number":301,"context_line":"        OVN_BRANCH: v20.03.0"},{"line_number":302,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":303,"context_line":"        OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"- job:"},{"line_number":306,"context_line":"    name: neutron-ovn-tempest-ovs-release"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_16f9977f","line":303,"in_reply_to":"bf51134e_96fe4703","updated":"2020-06-16 09:30:26.000000000","message":"We could stop, but we first need kernel 4.18.0 that supports OVS meter action. That is shipped in newest ubuntu, afair. So I believe we could try to update ubuntu on gates.","commit_id":"2f13342d59499d27394f4a64e2394f7d3251ae71"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c0b17c995910c2dc589765e86136dfc96dbd7762","unresolved":false,"context_lines":[{"line_number":300,"context_line":"      devstack_localrc:"},{"line_number":301,"context_line":"        OVN_BRANCH: v20.03.0"},{"line_number":302,"context_line":"        # TODO(jlibosva): v2.13.0 is incompatible with kernel 4.15.0, sticking to commit hash until new v2.13 tag is created"},{"line_number":303,"context_line":"        OVS_BRANCH: 51e9479da62edb04a5be47a7655de75c299b9fa1"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"- job:"},{"line_number":306,"context_line":"    name: neutron-ovn-tempest-ovs-release"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_9459205c","line":303,"in_reply_to":"bf51134e_b6d54bbc","updated":"2020-06-16 10:29:24.000000000","message":"ah fair enough, I thought Bionic was enough due to the comment there mentioning it.","commit_id":"2f13342d59499d27394f4a64e2394f7d3251ae71"}]}