)]}'
{"neutron/agent/l3/agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"167cfa5dbc77d4f658f95e6c6fe3a6be16f7ac1a","unresolved":false,"context_lines":[{"line_number":515,"context_line":"            if ri:"},{"line_number":516,"context_line":"                self.l3_ext_manager.delete_router(self.context, ri.router)"},{"line_number":517,"context_line":"                LOG.debug(\"Agent extension router %s \""},{"line_number":518,"context_line":"                          \"delete action done.\", router_id)"},{"line_number":519,"context_line":"        except Exception:"},{"line_number":520,"context_line":"            LOG.exception(\u0027Error while deleting router %s\u0027, router_id)"},{"line_number":521,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_1f49c45f","line":518,"updated":"2020-06-30 12:32:43.000000000","message":"why not move this log to the l3_ext_manager.delete_router() method?","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b30cebdc4c920c3212fd9d5a30ec7a394e6d36f5","unresolved":false,"context_lines":[{"line_number":515,"context_line":"            if ri:"},{"line_number":516,"context_line":"                self.l3_ext_manager.delete_router(self.context, ri.router)"},{"line_number":517,"context_line":"                LOG.debug(\"Agent extension router %s \""},{"line_number":518,"context_line":"                          \"delete action done.\", router_id)"},{"line_number":519,"context_line":"        except Exception:"},{"line_number":520,"context_line":"            LOG.exception(\u0027Error while deleting router %s\u0027, router_id)"},{"line_number":521,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_26449ab7","line":518,"in_reply_to":"bf51134e_1f49c45f","updated":"2020-09-27 01:16:04.000000000","message":"Done","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"167cfa5dbc77d4f658f95e6c6fe3a6be16f7ac1a","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            LOG.exception(\u0027Error while deleting router %s\u0027, router_id)"},{"line_number":521,"context_line":"            return False"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        self._resize_process_pool()"},{"line_number":524,"context_line":"        return True"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def _router_removed(self, ri, router_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_7f73a0b2","line":523,"updated":"2020-06-30 12:32:43.000000000","message":"Maybe instead of log added above You can add one here to check when exactly this method is finished for the router.","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b30cebdc4c920c3212fd9d5a30ec7a394e6d36f5","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            LOG.exception(\u0027Error while deleting router %s\u0027, router_id)"},{"line_number":521,"context_line":"            return False"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        self._resize_process_pool()"},{"line_number":524,"context_line":"        return True"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def _router_removed(self, ri, router_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_868126c5","line":523,"in_reply_to":"bf51134e_7f73a0b2","updated":"2020-09-27 01:16:04.000000000","message":"Hmm, _router_removed and l3_ext_manager.delete_router have the finish-log for the router. IMO, we can use that.","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"167cfa5dbc77d4f658f95e6c6fe3a6be16f7ac1a","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        except Exception:"},{"line_number":551,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":552,"context_line":"                self.router_info[router_id] \u003d ri"},{"line_number":553,"context_line":"        LOG.debug(\"Router info %s delete action done.\", router_id)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_5f997cce","line":553,"updated":"2020-06-30 12:32:43.000000000","message":"I would maybe say something like:\n\n\"router_info of the router %s removed.\"","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b30cebdc4c920c3212fd9d5a30ec7a394e6d36f5","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        except Exception:"},{"line_number":551,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":552,"context_line":"                self.router_info[router_id] \u003d ri"},{"line_number":553,"context_line":"        LOG.debug(\"Router info %s delete action done.\", router_id)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        registry.notify(resources.ROUTER, events.AFTER_DELETE, self, router\u003dri)"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a609ca84","line":553,"in_reply_to":"bf51134e_5f997cce","updated":"2020-09-27 01:16:04.000000000","message":"I will mixed these two, because the log is also for the ri.delete().","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"167cfa5dbc77d4f658f95e6c6fe3a6be16f7ac1a","unresolved":false,"context_lines":[{"line_number":615,"context_line":"            raise l3_exc.RouterNotCompatibleWithAgent(router_id\u003drouter[\u0027id\u0027])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        if router[\u0027id\u0027] not in self.router_info:"},{"line_number":618,"context_line":"            LOG.debug(\"Router info not in cache, do router add action.\")"},{"line_number":619,"context_line":"            self._process_added_router(router)"},{"line_number":620,"context_line":"        else:"},{"line_number":621,"context_line":"            LOG.debug(\"Router info in cache, do router update action.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_32f32076","line":618,"updated":"2020-06-30 12:32:43.000000000","message":"would be good to have router id logged here","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b30cebdc4c920c3212fd9d5a30ec7a394e6d36f5","unresolved":false,"context_lines":[{"line_number":615,"context_line":"            raise l3_exc.RouterNotCompatibleWithAgent(router_id\u003drouter[\u0027id\u0027])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        if router[\u0027id\u0027] not in self.router_info:"},{"line_number":618,"context_line":"            LOG.debug(\"Router info not in cache, do router add action.\")"},{"line_number":619,"context_line":"            self._process_added_router(router)"},{"line_number":620,"context_line":"        else:"},{"line_number":621,"context_line":"            LOG.debug(\"Router info in cache, do router update action.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_661332b9","line":618,"in_reply_to":"bf51134e_32f32076","updated":"2020-09-27 01:16:04.000000000","message":"Done","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"167cfa5dbc77d4f658f95e6c6fe3a6be16f7ac1a","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            LOG.debug(\"Router info not in cache, do router add action.\")"},{"line_number":619,"context_line":"            self._process_added_router(router)"},{"line_number":620,"context_line":"        else:"},{"line_number":621,"context_line":"            LOG.debug(\"Router info in cache, do router update action.\")"},{"line_number":622,"context_line":"            self._process_updated_router(router)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def _process_added_router(self, router):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_92e82c7d","line":621,"updated":"2020-06-30 12:32:43.000000000","message":"same here","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b30cebdc4c920c3212fd9d5a30ec7a394e6d36f5","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            LOG.debug(\"Router info not in cache, do router add action.\")"},{"line_number":619,"context_line":"            self._process_added_router(router)"},{"line_number":620,"context_line":"        else:"},{"line_number":621,"context_line":"            LOG.debug(\"Router info in cache, do router update action.\")"},{"line_number":622,"context_line":"            self._process_updated_router(router)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def _process_added_router(self, router):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4616eea8","line":621,"in_reply_to":"bf51134e_92e82c7d","updated":"2020-09-27 01:16:04.000000000","message":"Done","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"}],"neutron/agent/l3/l3_agent_extensions_manager.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"07e390f570f20cf3c5307d4ca98685f3bd8b6e8a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":48,"context_line":"                )"},{"line_number":49,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":50,"context_line":"                  \"add action.\", router_id)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def update_router(self, context, data):"},{"line_number":53,"context_line":"        \"\"\"Notify all agent extensions to update router.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_d1cab64c","line":50,"updated":"2020-09-27 04:19:12.000000000","message":"pep8: F821 undefined name \u0027router_id\u0027","commit_id":"842f60efd4ce9addce70a988eab4e42cf18570a9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"07e390f570f20cf3c5307d4ca98685f3bd8b6e8a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":62,"context_line":"                )"},{"line_number":63,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":64,"context_line":"                  \"update action.\", router_id)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete_router(self, context, data):"},{"line_number":67,"context_line":"        \"\"\"Notify all agent extensions to delete router.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b1c5823f","line":64,"updated":"2020-09-27 04:19:12.000000000","message":"pep8: F821 undefined name \u0027router_id\u0027","commit_id":"842f60efd4ce9addce70a988eab4e42cf18570a9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"07e390f570f20cf3c5307d4ca98685f3bd8b6e8a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":76,"context_line":"                )"},{"line_number":77,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":78,"context_line":"                  \"delete action.\", router_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def ha_state_change(self, context, data):"},{"line_number":81,"context_line":"        \"\"\"Notify all agent extensions for HA router state change.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_11c1ce2f","line":78,"updated":"2020-09-27 04:19:12.000000000","message":"pep8: F821 undefined name \u0027router_id\u0027","commit_id":"842f60efd4ce9addce70a988eab4e42cf18570a9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f5a042783947438b89de44ccc763199b64a5e1b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    \"implement method add_router\","},{"line_number":47,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":48,"context_line":"                )"},{"line_number":49,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":50,"context_line":"                  \"add action.\", data[\u0027id\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def update_router(self, context, data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_2851650e","line":49,"updated":"2020-10-08 07:48:33.000000000","message":"nit: s/finish/finished","commit_id":"4f6fd83d4e470c763ff80dc5836b1f488470495e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"be38de9b38e254f829bf9e6c6f980106e39defa5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    \"implement method add_router\","},{"line_number":47,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":48,"context_line":"                )"},{"line_number":49,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":50,"context_line":"                  \"add action.\", data[\u0027id\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def update_router(self, context, data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f65232a_796378b2","line":49,"in_reply_to":"9f560f44_2851650e","updated":"2020-10-27 11:07:57.000000000","message":"Done","commit_id":"4f6fd83d4e470c763ff80dc5836b1f488470495e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f5a042783947438b89de44ccc763199b64a5e1b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                    \"implement method update_router\","},{"line_number":61,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":62,"context_line":"                )"},{"line_number":63,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":64,"context_line":"                  \"update action.\", data[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete_router(self, context, data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_08562106","line":63,"updated":"2020-10-08 07:48:33.000000000","message":"same nit here also","commit_id":"4f6fd83d4e470c763ff80dc5836b1f488470495e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"be38de9b38e254f829bf9e6c6f980106e39defa5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                    \"implement method update_router\","},{"line_number":61,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":62,"context_line":"                )"},{"line_number":63,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":64,"context_line":"                  \"update action.\", data[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete_router(self, context, data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f65232a_d95a8cf1","line":63,"in_reply_to":"9f560f44_08562106","updated":"2020-10-27 11:07:57.000000000","message":"Done","commit_id":"4f6fd83d4e470c763ff80dc5836b1f488470495e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f5a042783947438b89de44ccc763199b64a5e1b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                    \"implement method delete_router\","},{"line_number":75,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":76,"context_line":"                )"},{"line_number":77,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":78,"context_line":"                  \"delete action.\", data[\u0027id\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def ha_state_change(self, context, data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_683ebdb9","line":77,"updated":"2020-10-08 07:48:33.000000000","message":"and here","commit_id":"4f6fd83d4e470c763ff80dc5836b1f488470495e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"be38de9b38e254f829bf9e6c6f980106e39defa5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                    \"implement method delete_router\","},{"line_number":75,"context_line":"                    {\u0027name\u0027: extension.name}"},{"line_number":76,"context_line":"                )"},{"line_number":77,"context_line":"        LOG.debug(\"L3 agent extension(s) finish router %s \""},{"line_number":78,"context_line":"                  \"delete action.\", data[\u0027id\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def ha_state_change(self, context, data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f65232a_b95d10eb","line":77,"in_reply_to":"9f560f44_683ebdb9","updated":"2020-10-27 11:07:57.000000000","message":"Done","commit_id":"4f6fd83d4e470c763ff80dc5836b1f488470495e"}],"neutron/privileged/agent/linux/ip_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"167cfa5dbc77d4f658f95e6c6fe3a6be16f7ac1a","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    except OSError as e:"},{"line_number":550,"context_line":"        if e.errno !\u003d errno.ENOENT:"},{"line_number":551,"context_line":"            raise"},{"line_number":552,"context_line":"    LOG.debug(\"Namespece %s deleted.\", name)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"@privileged.default.entrypoint"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_9f7cb473","line":552,"range":{"start_line":552,"start_character":15,"end_line":552,"end_character":24},"updated":"2020-06-30 12:32:43.000000000","message":"s/Namespace\n\nAlso, If You are adding such log here, why not to other methods also?","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b30cebdc4c920c3212fd9d5a30ec7a394e6d36f5","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    except OSError as e:"},{"line_number":550,"context_line":"        if e.errno !\u003d errno.ENOENT:"},{"line_number":551,"context_line":"            raise"},{"line_number":552,"context_line":"    LOG.debug(\"Namespece %s deleted.\", name)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"@privileged.default.entrypoint"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_261dbabd","line":552,"range":{"start_line":552,"start_character":15,"end_line":552,"end_character":24},"in_reply_to":"bf51134e_9f7cb473","updated":"2020-09-27 01:16:04.000000000","message":"IMO, we had some log size issue in upstream CI, so I\u0027d perfer to wait a bit to see how this line works.","commit_id":"ac95bd2d1904081f795016f7f95ab411882bd652"}]}