)]}'
{"neutron/plugins/nicira/common/sync.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"4e955fd03d2fe948eb2e2620244e5575586972e5","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            neutron_nvp_mappings[neutron_id] \u003d ("},{"line_number":297,"context_line":"                neutron_nvp_mappings.get(neutron_id, []) +"},{"line_number":298,"context_line":"                [self._nvp_cache[ls_uuid]])"},{"line_number":299,"context_line":"        with ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":300,"context_line":"            # Fetch neutron networks from database"},{"line_number":301,"context_line":"            filters \u003d {\u0027router:external\u0027: [False]}"},{"line_number":302,"context_line":"            if not scan_missing:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FKDY%3D","side":"PARENT","line":299,"updated":"2014-02-15 18:37:57.000000000","message":"are you sure that removing transaction here won\u0027t make inconsistent state of DB?","commit_id":"15a912b1ca3c24ba8851b8b77d6de8027e120d78"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"6d2ae0c494b7de49ba26c8cf462f9bd532ec3f3b","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            neutron_nvp_mappings[neutron_id] \u003d ("},{"line_number":297,"context_line":"                neutron_nvp_mappings.get(neutron_id, []) +"},{"line_number":298,"context_line":"                [self._nvp_cache[ls_uuid]])"},{"line_number":299,"context_line":"        with ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":300,"context_line":"            # Fetch neutron networks from database"},{"line_number":301,"context_line":"            filters \u003d {\u0027router:external\u0027: [False]}"},{"line_number":302,"context_line":"            if not scan_missing:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FJ0g%3D","side":"PARENT","line":299,"in_reply_to":"AAAAUX%2F%2FJ2c%3D","updated":"2014-02-15 21:33:11.000000000","message":"but take a look at self.synchronize_network(ctx, network, lswitches) at line 280 (it makes as well db updates)..","commit_id":"15a912b1ca3c24ba8851b8b77d6de8027e120d78"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e0620427505fb62badb4290bb7eb827be562b9ae","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            neutron_nvp_mappings[neutron_id] \u003d ("},{"line_number":297,"context_line":"                neutron_nvp_mappings.get(neutron_id, []) +"},{"line_number":298,"context_line":"                [self._nvp_cache[ls_uuid]])"},{"line_number":299,"context_line":"        with ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":300,"context_line":"            # Fetch neutron networks from database"},{"line_number":301,"context_line":"            filters \u003d {\u0027router:external\u0027: [False]}"},{"line_number":302,"context_line":"            if not scan_missing:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FJ2c%3D","side":"PARENT","line":299,"in_reply_to":"AAAAUX%2F%2FKDY%3D","updated":"2014-02-15 21:22:25.000000000","message":"yes, it\u0027s just reading out the the networks from the db here.","commit_id":"15a912b1ca3c24ba8851b8b77d6de8027e120d78"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a8fd989b1593d341cc64fbc2de04a71e1d7ba1b","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # Get an admin context"},{"line_number":578,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":579,"context_line":"        # Synchronize with database"},{"line_number":580,"context_line":"        with ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":581,"context_line":"            self._synchronize_lswitches(ctx, ls_uuids,"},{"line_number":582,"context_line":"                                        scan_missing\u003dscan_missing)"},{"line_number":583,"context_line":"            self._synchronize_lrouters(ctx, lr_uuids,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FKF4%3D","line":580,"updated":"2014-02-15 18:20:27.000000000","message":"i think this particular place also needs to be fixed","commit_id":"4e8c7e7d13a18e65463aa65487f99910632766bf"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e0620427505fb62badb4290bb7eb827be562b9ae","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # Get an admin context"},{"line_number":578,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":579,"context_line":"        # Synchronize with database"},{"line_number":580,"context_line":"        with ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":581,"context_line":"            self._synchronize_lswitches(ctx, ls_uuids,"},{"line_number":582,"context_line":"                                        scan_missing\u003dscan_missing)"},{"line_number":583,"context_line":"            self._synchronize_lrouters(ctx, lr_uuids,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FJ2Y%3D","line":580,"in_reply_to":"AAAAUX%2F%2FKF4%3D","updated":"2014-02-15 21:22:25.000000000","message":"Gah i don\u0027t know how that got dropped I had removed that in patchset 3 but lost the change in 4. Fixed here: https://review.openstack.org/#/c/73835/ thanks","commit_id":"4e8c7e7d13a18e65463aa65487f99910632766bf"}]}