)]}'
{"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"89015a8d9584d3ce9f142000ef4f8806f424b9da","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                self._get_dvr_router_ids_for_host(context, agent_db[\u0027host\u0027]))"},{"line_number":437,"context_line":"            if not router_ids:"},{"line_number":438,"context_line":"                result_set |\u003d dvr_routers"},{"line_number":439,"context_line":"            else:"},{"line_number":440,"context_line":"                for router_id in (dvr_routers - result_set):"},{"line_number":441,"context_line":"                    subnet_ids \u003d self.get_subnet_ids_on_router("},{"line_number":442,"context_line":"                        context, router_id, keep_gateway_port\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_63aabbd2","line":439,"range":{"start_line":439,"start_character":12,"end_line":439,"end_character":17},"updated":"2020-07-03 06:59:07.000000000","message":"so router_id parameter is completely ignored after this line. Is it intended?","commit_id":"16cb1908efab70df3efc3176c6ababfd74b278ff"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"167d653ee401e776a598e064481877a0bd1e54d8","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                self._get_dvr_router_ids_for_host(context, agent_db[\u0027host\u0027]))"},{"line_number":437,"context_line":"            if not router_ids:"},{"line_number":438,"context_line":"                result_set |\u003d dvr_routers"},{"line_number":439,"context_line":"            else:"},{"line_number":440,"context_line":"                for router_id in (dvr_routers - result_set):"},{"line_number":441,"context_line":"                    subnet_ids \u003d self.get_subnet_ids_on_router("},{"line_number":442,"context_line":"                        context, router_id, keep_gateway_port\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_91360ae7","line":439,"range":{"start_line":439,"start_character":12,"end_line":439,"end_character":17},"in_reply_to":"bf51134e_63aabbd2","updated":"2020-07-07 14:00:24.000000000","message":"no, it wasn\u0027t intended. Actually I did it differently now.","commit_id":"16cb1908efab70df3efc3176c6ababfd74b278ff"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"89015a8d9584d3ce9f142000ef4f8806f424b9da","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                      \"serviceable ports in host %(host)s\","},{"line_number":451,"context_line":"                      {\u0027router_ids\u0027: result_set,"},{"line_number":452,"context_line":"                       \u0027host\u0027: agent_db[\u0027host\u0027]})"},{"line_number":453,"context_line":"            related_routers_set \u003d set()"},{"line_number":454,"context_line":"            for router_id in result_set:"},{"line_number":455,"context_line":"                related_routers_set |\u003d set("},{"line_number":456,"context_line":"                    self._get_other_dvr_router_ids_connected_router("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e387eb60","line":453,"range":{"start_line":453,"start_character":12,"end_line":453,"end_character":39},"updated":"2020-07-03 06:59:07.000000000","message":"why need it?","commit_id":"16cb1908efab70df3efc3176c6ababfd74b278ff"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a1b4c0e49331cfac8b84281abebbb58ac172c56a","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                      \"serviceable ports in host %(host)s\","},{"line_number":451,"context_line":"                      {\u0027router_ids\u0027: result_set,"},{"line_number":452,"context_line":"                       \u0027host\u0027: agent_db[\u0027host\u0027]})"},{"line_number":453,"context_line":"            related_routers_set \u003d set()"},{"line_number":454,"context_line":"            for router_id in result_set:"},{"line_number":455,"context_line":"                related_routers_set |\u003d set("},{"line_number":456,"context_line":"                    self._get_other_dvr_router_ids_connected_router("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_51bbd270","line":453,"range":{"start_line":453,"start_character":12,"end_line":453,"end_character":39},"in_reply_to":"bf51134e_3128de84","updated":"2020-07-07 14:30:42.000000000","message":"Ah, indeed, thanks for clarification","commit_id":"16cb1908efab70df3efc3176c6ababfd74b278ff"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"167d653ee401e776a598e064481877a0bd1e54d8","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                      \"serviceable ports in host %(host)s\","},{"line_number":451,"context_line":"                      {\u0027router_ids\u0027: result_set,"},{"line_number":452,"context_line":"                       \u0027host\u0027: agent_db[\u0027host\u0027]})"},{"line_number":453,"context_line":"            related_routers_set \u003d set()"},{"line_number":454,"context_line":"            for router_id in result_set:"},{"line_number":455,"context_line":"                related_routers_set |\u003d set("},{"line_number":456,"context_line":"                    self._get_other_dvr_router_ids_connected_router("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3128de84","line":453,"range":{"start_line":453,"start_character":12,"end_line":453,"end_character":39},"in_reply_to":"bf51134e_e387eb60","updated":"2020-07-07 14:00:24.000000000","message":"otherwise if I iterate over result_set and try to change it in the loop I have exception. So I need some additional, temporary set to store those related routers.","commit_id":"16cb1908efab70df3efc3176c6ababfd74b278ff"}]}
