)]}'
{"tools/ovn_migration/tripleo_environment/ovn_migration.sh":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"db3400b6f282159233fcf68aa59843536c851781","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_564d3ec2","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"updated":"2020-06-24 10:12:05.000000000","message":"this is the stack name, you cannot assume it is \u0027overcloud\u0027","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"c2a7ef537b29f37abe9718b3178315148adcccc0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_57019405","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_53954532","updated":"2020-06-25 21:39:44.000000000","message":"The goal is specified in the commit title. :)\nThe problem is that retrieving the current stack name for this specific fix seems will not help for the entire script to run properly if the stack name is something other than \u0027overcloud\u0027. The \u0027overcloud\u0027 is hard-coded in many other places there. Rewriting the script to support arbitrary stack name is out of the scope of the patch.","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"831cb3d54ca51013d57ad29cd855678e93f67edf","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_ab3d4fde","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_564d3ec2","updated":"2020-06-24 10:16:36.000000000","message":"This script assumes stack is \u0027overcloud\u0027 in several other places as well. As purpose of this patch was a small fix but not refactoring of legacy code I think it is OK to leave \u0027overcloud\u0027 here.","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"1688a3ab8145019ab7ff805bc8d45e6cd0c59732","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_b3c3ddec","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_57019405","updated":"2020-06-26 10:17:40.000000000","message":"Are you sure it\u0027s hard-coded (as the stack name) in other places? I could only see it in the generated inventory and ansible tasks. In that context it\u0027s an ansible group, not the heat stack name.","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"41ecec25ac9fb26cb9f539fcd68ed1adc74b3fbd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_53954532","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_5def161d","updated":"2020-06-24 13:03:55.000000000","message":"What is the goal here? If it\u0027s just to get a specific CI job passing then I guess it\u0027s ok to hack this in. If this needs to work in general on customer deployments then it\u0027s not ok IMO","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"4598a07aebaced10ad4610a3ac6e1aac77cf2511","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_aef53659","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_6efcbeb4","updated":"2020-06-26 11:00:47.000000000","message":"I am a QE engineer, my job is to report the issue. I tried to provide a working solution and tested that it fixes the problem on a new version and does not break old version. I can\u0027t invest more time for this fix, sorry. Decided to abandon.","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"fe239cbfe0345743f3c878a46bc306b7edbdfae1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_5def161d","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_7d4e5a6f","updated":"2020-06-24 10:38:34.000000000","message":"Seems like the script sources stackrc before running this function, so OS_CLOUDNAME will be undercloud. \nI would like to keep the fix as small as possible. Refactoring can be done in separate patch if someone wants to deal with it.","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0d2b95e39709b4a2cf55b4ebba70641108cee789","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_7d4e5a6f","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_ab3d4fde","updated":"2020-06-24 10:29:43.000000000","message":"could use OS_CLOUDNAME from the rc file","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"992ae3d17b825c9a62d0096ed7688011c523fe1d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_6efcbeb4","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_b3c3ddec","updated":"2020-06-26 10:18:33.000000000","message":"But why not just switch to ansible-inventory? Most of these problems disappear e.g stack name wouldn\u0027t matter, internal inventory structure wouldn\u0027t matter. I can help with the changes if necessary.","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"4598a07aebaced10ad4610a3ac6e1aac77cf2511","unresolved":false,"context_lines":[{"line_number":90,"context_line":"get_role_hosts() {"},{"line_number":91,"context_line":"    inventory_file\u003d$1"},{"line_number":92,"context_line":"    role_name\u003d$2"},{"line_number":93,"context_line":"    roles\u003d`jq -r  \\.overcloud_$role_name\\.children\\[\\] $inventory_file || jq -r  \\.$role_name\\.children\\[\\] $inventory_file`"},{"line_number":94,"context_line":"    for role in $roles; do"},{"line_number":95,"context_line":"        # During the rocky cycle the format changed to have .value.hosts"},{"line_number":96,"context_line":"        hosts\u003d`jq -r --arg role \"$role\" \u0027to_entries[] | select(.key \u003d\u003d $role) | .value.hosts[]\u0027 $inventory_file`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_eed28ed0","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":29},"in_reply_to":"bf51134e_b3c3ddec","updated":"2020-06-26 11:00:47.000000000","message":"There are already 25 line with \u0027overcloud\u0027 or \u0027OVERCLOUD\u0027 mentioned.","commit_id":"3dabe0c6f5214ffae3181fa61f25afb5335f3393"}]}