)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4f34ec5178f8d7b323f5f8c8d591fd5520efbe26","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  169.254.169.254/16"},{"line_number":20,"context_line":"    - when checking if a metadata subnet is present"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We wer not always using them correctly in either the"},{"line_number":23,"context_line":"DHCP or OVN code, try and correct the usage. This will"},{"line_number":24,"context_line":"make it easier to update the code when adding support"},{"line_number":25,"context_line":"for metadata over IPv6."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_1fe54439","line":22,"range":{"start_line":22,"start_character":3,"end_line":22,"end_character":6},"updated":"2020-06-30 12:38:00.000000000","message":"shouldn\u0027t be \"were\"? I\u0027m just asking as I\u0027m curious if that isnt\u0027s some shorter form which I don\u0027t know maybe :)","commit_id":"bb98be28a5d2562e44210824880fde3f1c5f0ece"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6e7433cf6f6e70ea9132f90149c6bbb3d60c5ec0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  169.254.169.254/16"},{"line_number":20,"context_line":"    - when checking if a metadata subnet is present"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We wer not always using them correctly in either the"},{"line_number":23,"context_line":"DHCP or OVN code, try and correct the usage. This will"},{"line_number":24,"context_line":"make it easier to update the code when adding support"},{"line_number":25,"context_line":"for metadata over IPv6."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_7fea80ac","line":22,"range":{"start_line":22,"start_character":3,"end_line":22,"end_character":6},"in_reply_to":"bf51134e_1fe54439","updated":"2020-06-30 13:17:17.000000000","message":"This is a special, US-only shorthand :)","commit_id":"bb98be28a5d2562e44210824880fde3f1c5f0ece"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f5eaf3dc8c463c12dcd21cbf5cd498da82be5128","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  169.254.169.254/16"},{"line_number":20,"context_line":"    - when checking if a metadata subnet is present"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We wer not always using them correctly in either the"},{"line_number":23,"context_line":"DHCP or OVN code, try and correct the usage. This will"},{"line_number":24,"context_line":"make it easier to update the code when adding support"},{"line_number":25,"context_line":"for metadata over IPv6."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_82257bae","line":22,"range":{"start_line":22,"start_character":3,"end_line":22,"end_character":6},"in_reply_to":"bf51134e_7fea80ac","updated":"2020-06-30 13:21:19.000000000","message":"Thx, good to know :)","commit_id":"bb98be28a5d2562e44210824880fde3f1c5f0ece"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4f34ec5178f8d7b323f5f8c8d591fd5520efbe26","unresolved":false,"context_lines":[{"line_number":52,"context_line":"DHCPV6_PORT \u003d 547"},{"line_number":53,"context_line":"METADATA_DEFAULT_IP \u003d \u0027169.254.169.254\u0027"},{"line_number":54,"context_line":"METADATA_SUBNET_PREFIX \u003d 16"},{"line_number":55,"context_line":"METADATA_SUBNET_CIDR \u003d \u0027%s/%d\u0027 % (METADATA_DEFAULT_IP,"},{"line_number":56,"context_line":"                                  METADATA_SUBNET_PREFIX)"},{"line_number":57,"context_line":"METADATA_PORT \u003d 80"},{"line_number":58,"context_line":"WIN2k3_STATIC_DNS \u003d 249"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_1fbee4fe","line":55,"updated":"2020-06-30 12:38:00.000000000","message":"just asking: shouldn\u0027t this be \"normalized\", so something like 168.254.0.0/16 ?","commit_id":"bb98be28a5d2562e44210824880fde3f1c5f0ece"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6e7433cf6f6e70ea9132f90149c6bbb3d60c5ec0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"DHCPV6_PORT \u003d 547"},{"line_number":53,"context_line":"METADATA_DEFAULT_IP \u003d \u0027169.254.169.254\u0027"},{"line_number":54,"context_line":"METADATA_SUBNET_PREFIX \u003d 16"},{"line_number":55,"context_line":"METADATA_SUBNET_CIDR \u003d \u0027%s/%d\u0027 % (METADATA_DEFAULT_IP,"},{"line_number":56,"context_line":"                                  METADATA_SUBNET_PREFIX)"},{"line_number":57,"context_line":"METADATA_PORT \u003d 80"},{"line_number":58,"context_line":"WIN2k3_STATIC_DNS \u003d 249"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_5fc5fc09","line":55,"in_reply_to":"bf51134e_1fbee4fe","updated":"2020-06-30 13:17:17.000000000","message":"I did notice that as well when I saw Bence\u0027s change moving this to neutron-lib, https://review.opendev.org/#/c/738205/ but don\u0027t know why I didn\u0027t fix this.\n\nOh, I think the netaddr.IPNetwork call on L1308 below is actually fixing it for us?","commit_id":"bb98be28a5d2562e44210824880fde3f1c5f0ece"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8e0746322640d165951ad0e8adfee0a139568ecc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"DHCPV6_PORT \u003d 547"},{"line_number":53,"context_line":"METADATA_DEFAULT_IP \u003d \u0027169.254.169.254\u0027"},{"line_number":54,"context_line":"METADATA_SUBNET_PREFIX \u003d 16"},{"line_number":55,"context_line":"METADATA_SUBNET_CIDR \u003d \u0027%s/%d\u0027 % (METADATA_DEFAULT_IP,"},{"line_number":56,"context_line":"                                  METADATA_SUBNET_PREFIX)"},{"line_number":57,"context_line":"METADATA_PORT \u003d 80"},{"line_number":58,"context_line":"WIN2k3_STATIC_DNS \u003d 249"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_ff8df0d3","line":55,"in_reply_to":"bf51134e_1fbee4fe","updated":"2020-06-30 13:13:07.000000000","message":"as I see it\u0027s possible to use normalized cidr here","commit_id":"bb98be28a5d2562e44210824880fde3f1c5f0ece"}],"neutron/common/ovn/constants.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8e0746322640d165951ad0e8adfee0a139568ecc","unresolved":false,"context_lines":[{"line_number":276,"context_line":"# TODO(lucasagomes): Move this to neutron-lib later."},{"line_number":277,"context_line":"# Metadata constants"},{"line_number":278,"context_line":"METADATA_DEFAULT_PREFIX \u003d 16"},{"line_number":279,"context_line":"METADATA_DEFAULT_IP \u003d \u0027169.254.169.254\u0027"},{"line_number":280,"context_line":"METADATA_DEFAULT_CIDR \u003d \u0027%s/%d\u0027 % (METADATA_DEFAULT_IP,"},{"line_number":281,"context_line":"                                   METADATA_DEFAULT_PREFIX)"},{"line_number":282,"context_line":"METADATA_PORT \u003d 80"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_5f77bc09","side":"PARENT","line":279,"range":{"start_line":279,"start_character":0,"end_line":279,"end_character":39},"updated":"2020-06-30 13:13:07.000000000","message":"This ones seems to be a duplicate of the same const defined in neutron/agent/linux/dhcp.py","commit_id":"d9d273e53864acaa1266cda8996dfb6594e804ab"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"590dc0827ac18d8a9c4d7587c1d8d44be2512fc7","unresolved":false,"context_lines":[{"line_number":276,"context_line":"# TODO(lucasagomes): Move this to neutron-lib later."},{"line_number":277,"context_line":"# Metadata constants"},{"line_number":278,"context_line":"METADATA_DEFAULT_PREFIX \u003d 16"},{"line_number":279,"context_line":"METADATA_DEFAULT_IP \u003d \u0027169.254.169.254\u0027"},{"line_number":280,"context_line":"METADATA_DEFAULT_CIDR \u003d \u0027%s/%d\u0027 % (METADATA_DEFAULT_IP,"},{"line_number":281,"context_line":"                                   METADATA_DEFAULT_PREFIX)"},{"line_number":282,"context_line":"METADATA_PORT \u003d 80"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a29d1f0c","side":"PARENT","line":279,"range":{"start_line":279,"start_character":0,"end_line":279,"end_character":39},"in_reply_to":"bf51134e_5f77bc09","updated":"2020-06-30 13:55:30.000000000","message":"Yes, it is, but it can go away once Bence\u0027s change to neutron-lib merges so I\u0027m just going to leave it for now.","commit_id":"d9d273e53864acaa1266cda8996dfb6594e804ab"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"db61b7c17804bc50c3ba1541045c6c672d5beed6","unresolved":false,"context_lines":[{"line_number":276,"context_line":"# TODO(lucasagomes): Move this to neutron-lib later."},{"line_number":277,"context_line":"# Metadata constants"},{"line_number":278,"context_line":"METADATA_DEFAULT_PREFIX \u003d 16"},{"line_number":279,"context_line":"METADATA_DEFAULT_IP \u003d \u0027169.254.169.254\u0027"},{"line_number":280,"context_line":"METADATA_DEFAULT_CIDR \u003d \u0027%s/%d\u0027 % (METADATA_DEFAULT_IP,"},{"line_number":281,"context_line":"                                   METADATA_DEFAULT_PREFIX)"},{"line_number":282,"context_line":"METADATA_PORT \u003d 80"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_93ae6b96","side":"PARENT","line":279,"range":{"start_line":279,"start_character":0,"end_line":279,"end_character":39},"in_reply_to":"bf51134e_a29d1f0c","updated":"2020-06-30 16:01:35.000000000","message":"ack","commit_id":"d9d273e53864acaa1266cda8996dfb6594e804ab"}]}