)]}'
{"neutron/db/address_group_db.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"eb8d8067ffba539a91cd2f17072a23625e4d8642","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib import constants"},{"line_number":15,"context_line":"from neutron_lib.db import resource_extend"},{"line_number":16,"context_line":"from neutron_lib.db import utils as db_utils"},{"line_number":17,"context_line":"from neutron_lib.exceptions import address_group as ag_exc"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"from oslo_utils import uuidutils"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_009a9161","line":17,"updated":"2020-08-01 01:44:41.000000000","message":"pep8: E0611: No name \u0027address_group\u0027 in module \u0027neutron_lib.exceptions\u0027 (no-name-in-module)","commit_id":"c5ac27cece867ecba4809abbb027a4910fac6b5c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ba83a9ac5789ef1133a7bba07e0ae77edab0d3c3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron_lib import constants"},{"line_number":15,"context_line":"from neutron_lib.db import resource_extend"},{"line_number":16,"context_line":"from neutron_lib.db import utils as db_utils"},{"line_number":17,"context_line":"from neutron_lib.exceptions import address_group as ag_exc"},{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.extensions import address_group as ag_ext"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_77b955ca","line":17,"updated":"2020-08-05 20:47:22.000000000","message":"pep8: E0611: No name \u0027address_group\u0027 in module \u0027neutron_lib.exceptions\u0027 (no-name-in-module)","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1ce07e0670627e2e0c667e292e4c5a7c8d32d293","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        for addr in addrs_not_in_ag:"},{"line_number":65,"context_line":"            addr \u003d netaddr.IPNetwork(addr)"},{"line_number":66,"context_line":"            args \u003d {\u0027address_group_id\u0027: address_group_id,"},{"line_number":67,"context_line":"                    \u0027address\u0027: addr}"},{"line_number":68,"context_line":"            addr_assoc \u003d ag_obj.AddressAssociation(context, **args)"},{"line_number":69,"context_line":"            addr_assoc.create()"},{"line_number":70,"context_line":"        ag.update()  # reload synthetic fields"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_80124a61","line":67,"range":{"start_line":67,"start_character":31,"end_line":67,"end_character":35},"updated":"2020-09-02 20:02:00.000000000","message":"just a question here: shouldn\u0027t we use here \"normalized cidrs\" in case if user will e.g. set something like 10.0.0.20/24 - shouldn\u0027t we then store in group 10.0.0.0/24? I\u0027m asking because we already had similar problem with remote_ip_prefix in e.g. ovn backend recently.","commit_id":"dd20cab3713712126470145b22345a7217576faa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e99475bf687530fc4a519ecf8b6e7591b2b39d51","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        for addr in addrs_not_in_ag:"},{"line_number":65,"context_line":"            addr \u003d netaddr.IPNetwork(addr)"},{"line_number":66,"context_line":"            args \u003d {\u0027address_group_id\u0027: address_group_id,"},{"line_number":67,"context_line":"                    \u0027address\u0027: addr}"},{"line_number":68,"context_line":"            addr_assoc \u003d ag_obj.AddressAssociation(context, **args)"},{"line_number":69,"context_line":"            addr_assoc.create()"},{"line_number":70,"context_line":"        ag.update()  # reload synthetic fields"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_a4e5d9de","line":67,"range":{"start_line":67,"start_character":31,"end_line":67,"end_character":35},"in_reply_to":"9f560f44_4bc5f309","updated":"2020-09-03 08:57:06.000000000","message":"Yes, I was talking exactly about that patch :)\nI\u0027m ok for follow-up patch but please do it soon so we can include it in Victoria release","commit_id":"dd20cab3713712126470145b22345a7217576faa"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"5ee8f83bf31064108f492e27bff4169312247103","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        for addr in addrs_not_in_ag:"},{"line_number":65,"context_line":"            addr \u003d netaddr.IPNetwork(addr)"},{"line_number":66,"context_line":"            args \u003d {\u0027address_group_id\u0027: address_group_id,"},{"line_number":67,"context_line":"                    \u0027address\u0027: addr}"},{"line_number":68,"context_line":"            addr_assoc \u003d ag_obj.AddressAssociation(context, **args)"},{"line_number":69,"context_line":"            addr_assoc.create()"},{"line_number":70,"context_line":"        ag.update()  # reload synthetic fields"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_4bc5f309","line":67,"range":{"start_line":67,"start_character":31,"end_line":67,"end_character":35},"in_reply_to":"9f560f44_80124a61","updated":"2020-09-02 21:00:53.000000000","message":"I think you\u0027re referring to this fix? https://review.opendev.org/#/c/736386/ Yup, that\u0027s a good point. I can fix it in my follow-up patch if that\u0027s ok with you.","commit_id":"dd20cab3713712126470145b22345a7217576faa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1ce07e0670627e2e0c667e292e4c5a7c8d32d293","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def create_address_group(self, context, address_group):"},{"line_number":87,"context_line":"        \"\"\"Create an address group.\"\"\""},{"line_number":88,"context_line":"        fields \u003d address_group[\u0027address_group\u0027]"},{"line_number":89,"context_line":"        args \u003d {\u0027project_id\u0027: fields[\u0027tenant_id\u0027],"},{"line_number":90,"context_line":"                \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":91,"context_line":"                \u0027name\u0027: fields[\u0027name\u0027],"},{"line_number":92,"context_line":"                \u0027description\u0027: fields[\u0027description\u0027]}"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_c00ba228","line":89,"range":{"start_line":89,"start_character":38,"end_line":89,"end_character":47},"updated":"2020-09-02 20:02:00.000000000","message":"why not \"project_id\"?","commit_id":"dd20cab3713712126470145b22345a7217576faa"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"5ee8f83bf31064108f492e27bff4169312247103","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def create_address_group(self, context, address_group):"},{"line_number":87,"context_line":"        \"\"\"Create an address group.\"\"\""},{"line_number":88,"context_line":"        fields \u003d address_group[\u0027address_group\u0027]"},{"line_number":89,"context_line":"        args \u003d {\u0027project_id\u0027: fields[\u0027tenant_id\u0027],"},{"line_number":90,"context_line":"                \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":91,"context_line":"                \u0027name\u0027: fields[\u0027name\u0027],"},{"line_number":92,"context_line":"                \u0027description\u0027: fields[\u0027description\u0027]}"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_eb7967c5","line":89,"range":{"start_line":89,"start_character":38,"end_line":89,"end_character":47},"in_reply_to":"9f560f44_c00ba228","updated":"2020-09-02 21:00:53.000000000","message":"I may follow an example of old implementation. Can also do the change in a follow-up patch.","commit_id":"dd20cab3713712126470145b22345a7217576faa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e99475bf687530fc4a519ecf8b6e7591b2b39d51","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def create_address_group(self, context, address_group):"},{"line_number":87,"context_line":"        \"\"\"Create an address group.\"\"\""},{"line_number":88,"context_line":"        fields \u003d address_group[\u0027address_group\u0027]"},{"line_number":89,"context_line":"        args \u003d {\u0027project_id\u0027: fields[\u0027tenant_id\u0027],"},{"line_number":90,"context_line":"                \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":91,"context_line":"                \u0027name\u0027: fields[\u0027name\u0027],"},{"line_number":92,"context_line":"                \u0027description\u0027: fields[\u0027description\u0027]}"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_c4c44d44","line":89,"range":{"start_line":89,"start_character":38,"end_line":89,"end_character":47},"in_reply_to":"9f560f44_eb7967c5","updated":"2020-09-03 08:57:06.000000000","message":"ok for me","commit_id":"dd20cab3713712126470145b22345a7217576faa"}],"neutron/db/migration/alembic_migrations/versions/victoria/expand/1ea5dab0897a_add_address_group.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"28cb98a2120ee28129d6a2a1152d16afc27c98cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_ff1d4cbe","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":37},"updated":"2020-07-10 22:55:44.000000000","message":"Fix this. You don\u0027t work for the foundation","commit_id":"ed3ce7141c65f26b8fa378feb872b6369d945fb6"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"9b432947d51cc67fbfae882925c25dbc58201342","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0523c3a9","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":37},"in_reply_to":"bf51134e_ff1d4cbe","updated":"2020-07-31 22:20:21.000000000","message":"Done","commit_id":"ed3ce7141c65f26b8fa378feb872b6369d945fb6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027address_groups\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027project_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9ecec6b1","line":34,"range":{"start_line":34,"start_character":64,"end_line":34,"end_character":68},"updated":"2020-08-05 18:07:28.000000000","message":"Is this going to be nullable?","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027address_groups\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027project_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fedd4270","line":34,"range":{"start_line":34,"start_character":49,"end_line":34,"end_character":52},"updated":"2020-08-05 18:07:28.000000000","message":"Please, use db_const.PROJECT_ID_FIELD_SIZE","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d3b20b7d66081b7abc4cc1b3fa9ec8ca629f69a0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027address_groups\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027project_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_528ce434","line":34,"range":{"start_line":34,"start_character":64,"end_line":34,"end_character":68},"in_reply_to":"9f560f44_9ecec6b1","updated":"2020-08-10 16:35:28.000000000","message":"It comes from the base HasProject model by default, but I agree this should not be null in AG so updated it.","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d3b20b7d66081b7abc4cc1b3fa9ec8ca629f69a0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027address_groups\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027project_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b27aa020","line":34,"range":{"start_line":34,"start_character":49,"end_line":34,"end_character":52},"in_reply_to":"9f560f44_fedd4270","updated":"2020-08-10 16:35:28.000000000","message":"Done and updated for all the following places as well.","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027address_groups\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027project_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1ebab608","line":35,"range":{"start_line":35,"start_character":46,"end_line":35,"end_character":60},"updated":"2020-08-05 18:07:28.000000000","message":"1) This should be  primary_key\u003dTrue\n2) If  primary_key\u003dTrue, then nullable\u003dFalse (not needed)\n3) L38 not needed","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027address_groups\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027project_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5e342e93","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":43},"updated":"2020-08-05 18:07:28.000000000","message":"db_const.UUID_FIELD_SIZE","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d3b20b7d66081b7abc4cc1b3fa9ec8ca629f69a0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    op.create_table("},{"line_number":33,"context_line":"        \u0027address_groups\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027project_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b29f404e","line":35,"range":{"start_line":35,"start_character":46,"end_line":35,"end_character":60},"in_reply_to":"9f560f44_1ebab608","updated":"2020-08-10 16:35:28.000000000","message":"Done","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":39,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":"    op.create_index(op.f(\u0027ix_address_groups_project_id\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5e3d4e8d","line":38,"updated":"2020-08-05 18:07:28.000000000","message":"no needed if changes in L35 are done","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":39,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":"    op.create_index(op.f(\u0027ix_address_groups_project_id\u0027),"},{"line_number":42,"context_line":"                    \u0027address_groups\u0027, [\u0027project_id\u0027], unique\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1e4f5634","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":29},"updated":"2020-08-05 18:07:28.000000000","message":"please remove, this is done by default and is set globally","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d3b20b7d66081b7abc4cc1b3fa9ec8ca629f69a0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(length\u003d1024), nullable\u003dTrue),"},{"line_number":38,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":39,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":"    op.create_index(op.f(\u0027ix_address_groups_project_id\u0027),"},{"line_number":42,"context_line":"                    \u0027address_groups\u0027, [\u0027project_id\u0027], unique\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_52ba24c0","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":29},"in_reply_to":"9f560f44_1e4f5634","updated":"2020-08-10 16:35:28.000000000","message":"Done","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":39,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":"    op.create_index(op.f(\u0027ix_address_groups_project_id\u0027),"},{"line_number":42,"context_line":"                    \u0027address_groups\u0027, [\u0027project_id\u0027], unique\u003dFalse)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    op.create_table("},{"line_number":45,"context_line":"        \u0027address_associations\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5e0b8ed4","line":42,"range":{"start_line":41,"start_character":4,"end_line":42,"end_character":67},"updated":"2020-08-05 18:07:28.000000000","message":"you can add \"index\u003dTrue\" to the \"project_id\" column definition","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d3b20b7d66081b7abc4cc1b3fa9ec8ca629f69a0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":39,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":"    op.create_index(op.f(\u0027ix_address_groups_project_id\u0027),"},{"line_number":42,"context_line":"                    \u0027address_groups\u0027, [\u0027project_id\u0027], unique\u003dFalse)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    op.create_table("},{"line_number":45,"context_line":"        \u0027address_associations\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_32bdf0b6","line":42,"range":{"start_line":41,"start_character":4,"end_line":42,"end_character":67},"in_reply_to":"9f560f44_5e0b8ed4","updated":"2020-08-10 16:35:28.000000000","message":"Done","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    op.create_table("},{"line_number":45,"context_line":"        \u0027address_associations\u0027,"},{"line_number":46,"context_line":"        sa.Column(\u0027address\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":47,"context_line":"        sa.Column(\u0027address_group_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":48,"context_line":"        sa.ForeignKeyConstraint([\u0027address_group_id\u0027], [\u0027address_groups.id\u0027],"},{"line_number":49,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":50,"context_line":"        sa.PrimaryKeyConstraint(\u0027address\u0027, \u0027address_group_id\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_be258a5e","line":47,"range":{"start_line":47,"start_character":48,"end_line":47,"end_character":57},"updated":"2020-08-05 18:07:28.000000000","message":"db_const.UUID_FIELD_SIZE","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        sa.Column(\u0027address_group_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":48,"context_line":"        sa.ForeignKeyConstraint([\u0027address_group_id\u0027], [\u0027address_groups.id\u0027],"},{"line_number":49,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":50,"context_line":"        sa.PrimaryKeyConstraint(\u0027address\u0027, \u0027address_group_id\u0027),"},{"line_number":51,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":52,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7e2f723e","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":63},"updated":"2020-08-05 18:07:28.000000000","message":"same here: use \"primary_key\u003dTrue\" in \"address_group_id\" column definition","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        sa.ForeignKeyConstraint([\u0027address_group_id\u0027], [\u0027address_groups.id\u0027],"},{"line_number":49,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":50,"context_line":"        sa.PrimaryKeyConstraint(\u0027address\u0027, \u0027address_group_id\u0027),"},{"line_number":51,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":52,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fef9c2c7","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":29},"updated":"2020-08-05 18:07:28.000000000","message":"ditto","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"}],"neutron/db/models/address_group.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3de618256907c2ceaa4c6357e84f7d2723e3600","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    __tablename__ \u003d \"address_associations\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    address \u003d sa.Column(sa.String(length\u003ddb_const.IP_ADDR_FIELD_SIZE),"},{"line_number":24,"context_line":"                        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":25,"context_line":"    address_group_id \u003d sa.Column(sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":26,"context_line":"                                 sa.ForeignKey(\"address_groups.id\","},{"line_number":27,"context_line":"                                               ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3e197a21","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":51},"updated":"2020-08-05 18:07:28.000000000","message":"This is not a primary key, at least in https://review.opendev.org/#/c/738274/5/neutron/db/migration/alembic_migrations/versions/victoria/expand/1ea5dab0897a_add_address_group.py","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d3b20b7d66081b7abc4cc1b3fa9ec8ca629f69a0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    __tablename__ \u003d \"address_associations\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    address \u003d sa.Column(sa.String(length\u003ddb_const.IP_ADDR_FIELD_SIZE),"},{"line_number":24,"context_line":"                        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":25,"context_line":"    address_group_id \u003d sa.Column(sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":26,"context_line":"                                 sa.ForeignKey(\"address_groups.id\","},{"line_number":27,"context_line":"                                               ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_92fe7c68","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":51},"in_reply_to":"9f560f44_3e197a21","updated":"2020-08-10 16:35:28.000000000","message":"I intend to use address and address_group_id as the composite primary keys in the association table.","commit_id":"2d1841bcd0d962a1c08765f06684887190e4c72b"}],"neutron/objects/address_group.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"28cb98a2120ee28129d6a2a1152d16afc27c98cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_bf275412","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":38},"updated":"2020-07-10 22:55:44.000000000","message":"Need to fix this","commit_id":"ed3ce7141c65f26b8fa378feb872b6369d945fb6"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"9b432947d51cc67fbfae882925c25dbc58201342","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_453c9bc7","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":38},"in_reply_to":"bf51134e_bf275412","updated":"2020-07-31 22:20:21.000000000","message":"Done","commit_id":"ed3ce7141c65f26b8fa378feb872b6369d945fb6"}],"neutron/tests/unit/objects/test_address_group.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"28cb98a2120ee28129d6a2a1152d16afc27c98cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_9f24100f","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":35},"updated":"2020-07-10 22:55:44.000000000","message":"Need to fix this","commit_id":"ed3ce7141c65f26b8fa378feb872b6369d945fb6"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"9b432947d51cc67fbfae882925c25dbc58201342","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2537e7e5","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":35},"in_reply_to":"bf51134e_9f24100f","updated":"2020-07-31 22:20:21.000000000","message":"Done","commit_id":"ed3ce7141c65f26b8fa378feb872b6369d945fb6"}]}