)]}'
{"neutron/services/firewall/agents/l3reference/firewall_l3_agent.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fe1b38e382818dd15088b3d652a52f9eed87adfd","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                          for ri in router_info_list])"},{"line_number":261,"context_line":"                            # no need to apply sync data for ACTIVE fw"},{"line_number":262,"context_line":"                            if fw[\u0027status\u0027] not in [constants.ACTIVE,"},{"line_number":263,"context_line":"                                                    constants.DOWN]:"},{"line_number":264,"context_line":"                                self._invoke_driver_for_sync_from_plugin("},{"line_number":265,"context_line":"                                    ctx,"},{"line_number":266,"context_line":"                                    router_info_list,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F%2B8k%3D","line":263,"updated":"2014-02-27 01:06:12.000000000","message":"This firewall is not active so do we really need to sync. The comment we put here earlier suggests that we want to sync only when the firewall is active.","commit_id":"31f1fbf19ba30b2e92c69a0b87bb42975abdbe39"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"1597c381f3fa6283d3a3ae5967e9aa6ce9baeb94","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                          for ri in router_info_list])"},{"line_number":261,"context_line":"                            # no need to apply sync data for ACTIVE fw"},{"line_number":262,"context_line":"                            if fw[\u0027status\u0027] not in [constants.ACTIVE,"},{"line_number":263,"context_line":"                                                    constants.DOWN]:"},{"line_number":264,"context_line":"                                self._invoke_driver_for_sync_from_plugin("},{"line_number":265,"context_line":"                                    ctx,"},{"line_number":266,"context_line":"                                    router_info_list,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2Fyak%3D","line":263,"in_reply_to":"AAAAVX%2F%2F%2B8k%3D","updated":"2014-02-28 09:30:58.000000000","message":"Will do in next patch. Thanks for the comment.","commit_id":"31f1fbf19ba30b2e92c69a0b87bb42975abdbe39"}],"neutron/services/firewall/fwaas_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"2d8e3616034cc6bb163d4c708f13ff7c14e93aca","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        LOG.debug(_(\"set_firewall_status() called\"))"},{"line_number":50,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":51,"context_line":"            fw_db \u003d self.plugin._get_firewall(context, firewall_id)"},{"line_number":52,"context_line":"            if status in (const.ACTIVE, const.DOWN):"},{"line_number":53,"context_line":"                fw_db.status \u003d status"},{"line_number":54,"context_line":"                return True"},{"line_number":55,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAU3%2F%2F9EA%3D","line":52,"updated":"2014-02-23 16:09:15.000000000","message":"Why was inactive dropped here?","commit_id":"33418d932fa3c27d375def8b1c79d6eab072c580"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"1d7d11286a1b34a05e03b2851c14ce6439e7497a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        LOG.debug(_(\"set_firewall_status() called\"))"},{"line_number":50,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":51,"context_line":"            fw_db \u003d self.plugin._get_firewall(context, firewall_id)"},{"line_number":52,"context_line":"            if status in (const.ACTIVE, const.DOWN):"},{"line_number":53,"context_line":"                fw_db.status \u003d status"},{"line_number":54,"context_line":"                return True"},{"line_number":55,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAU3%2F%2F7Mc%3D","line":52,"in_reply_to":"AAAAU3%2F%2F9EA%3D","updated":"2014-02-24 02:28:42.000000000","message":"Mark, I dropped INACTIVE because I didn\u0027t find any existing code which set status of firewall to INACTIVE. The only place will set the status to DOWN is in this patch. \n\nBTW, I set the status into DOWN instead of INACTIVE to address Nachi\u0027s previous comments. The reason is other network resources are using DOWN so we want to keep consistent.\n\nI will fix the commit message in next patch.","commit_id":"33418d932fa3c27d375def8b1c79d6eab072c580"}]}