)]}'
{"neutron/tests/unit/ml2/test_ml2_plugin.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"62726330dac5d110cc666cfb8daf9a07776ea22d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.vlan_range \u003d \u00271:100\u0027"},{"line_number":55,"context_line":"        self.phys_vrange \u003d \u0027:\u0027.join([self.physnet, self.vlan_range])"},{"line_number":56,"context_line":"        config.cfg.CONF.set_override(\u0027network_vlan_ranges\u0027, [self.phys_vrange],"},{"line_number":57,"context_line":"                                     group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":58,"context_line":"        self.addCleanup(config.cfg.CONF.reset)"},{"line_number":59,"context_line":"        super(Ml2PluginV2TestCase, self).setUp(PLUGIN_NAME,"},{"line_number":60,"context_line":"                                               service_plugins\u003dservice_plugins)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FBOA%3D","line":57,"updated":"2014-02-17 16:25:43.000000000","message":"This config override is done before the config is loaded by the super class (line 59 below). I don\u0027t understand why the test cases work when run from tox, but they fail when run via nosetests. If someone can explain how tox/testr initializes things to make this work, I am all ears.\n\nIf I move the super setUp() call from line 59 to line 47, then all tests work via nosetests, except these three:\n\n  TestMultiSegmentNetworks.test_create_network_multiprovider ... ERROR\n  TestMultiSegmentNetworks.test_create_network_provider ... ERROR\n  TestMultiSegmentNetworks.test_create_network_single_multiprovider ... ERROR\n\nI apologize for bringing this up against this review, but I think we should fix the tests so they work in both environments before adding more tests. However, I am stumped on the error in the MultiSegment tests after moving the super setUp() line. Maybe we can meet up on IRC and troubleshoot?","commit_id":"5fb347ca6fd70750861cf1a49808f68125288f38"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7ec450527716c579788be5e8190ecbf30364d8e7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.vlan_range \u003d \u00271:100\u0027"},{"line_number":55,"context_line":"        self.phys_vrange \u003d \u0027:\u0027.join([self.physnet, self.vlan_range])"},{"line_number":56,"context_line":"        config.cfg.CONF.set_override(\u0027network_vlan_ranges\u0027, [self.phys_vrange],"},{"line_number":57,"context_line":"                                     group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":58,"context_line":"        self.addCleanup(config.cfg.CONF.reset)"},{"line_number":59,"context_line":"        super(Ml2PluginV2TestCase, self).setUp(PLUGIN_NAME,"},{"line_number":60,"context_line":"                                               service_plugins\u003dservice_plugins)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2ByHY%3D","line":57,"in_reply_to":"AAAAUX%2F%2Byj8%3D","updated":"2014-02-19 03:52:15.000000000","message":"Sorry, forgot to follow up. Yes, nosetests are broken even without your patch. It is a separate issue and should not block your patch.","commit_id":"5fb347ca6fd70750861cf1a49808f68125288f38"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"8fd6199065ead4c93293801a712860969ad560e5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.vlan_range \u003d \u00271:100\u0027"},{"line_number":55,"context_line":"        self.phys_vrange \u003d \u0027:\u0027.join([self.physnet, self.vlan_range])"},{"line_number":56,"context_line":"        config.cfg.CONF.set_override(\u0027network_vlan_ranges\u0027, [self.phys_vrange],"},{"line_number":57,"context_line":"                                     group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":58,"context_line":"        self.addCleanup(config.cfg.CONF.reset)"},{"line_number":59,"context_line":"        super(Ml2PluginV2TestCase, self).setUp(PLUGIN_NAME,"},{"line_number":60,"context_line":"                                               service_plugins\u003dservice_plugins)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Byj8%3D","line":57,"in_reply_to":"AAAAUX%2F%2FBOA%3D","updated":"2014-02-19 02:12:51.000000000","message":"So, how do we proceed here Henry? Are you implying that the existing unit tests are broken with nosetests even without my patch?","commit_id":"5fb347ca6fd70750861cf1a49808f68125288f38"}]}