)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c517a9fbe3a983407bc07811cab76d7fdb0bef6d","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def update_port(self, txn, port, original_port, reset\u003dFalse, delete\u003dFalse,"},{"line_number":190,"context_line":"                    qos_rules\u003dNone):"},{"line_number":191,"context_line":"        if (not reset and not original_port) and not delete:"},{"line_number":192,"context_line":"            # If there is no information about the previous QoS policy, do not"},{"line_number":193,"context_line":"            # make any change, unless the port is new or the QoS information"},{"line_number":194,"context_line":"            # must be reset (delete any previous configuration and set new"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_3f30089f","line":191,"updated":"2020-07-17 11:05:16.000000000","message":"Ahhhh yes, good catch.","commit_id":"0e53673c5d4f49846bb439b2e1ab8e984c20d6f8"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4c2d06ed1b7198b0221fdbc2d4274ca174621361","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def update_port(self, txn, port, original_port, reset\u003dFalse, delete\u003dFalse,"},{"line_number":190,"context_line":"                    qos_rules\u003dNone):"},{"line_number":191,"context_line":"        if (not reset and not original_port) and not delete:"},{"line_number":192,"context_line":"            # If there is no information about the previous QoS policy, do not"},{"line_number":193,"context_line":"            # make any change, unless the port is new or the QoS information"},{"line_number":194,"context_line":"            # must be reset (delete any previous configuration and set new"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_76be13d5","line":191,"range":{"start_line":191,"start_character":43,"end_line":191,"end_character":44},"updated":"2020-07-20 09:29:15.000000000","message":"The parens are not needed.","commit_id":"0e53673c5d4f49846bb439b2e1ab8e984c20d6f8"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"07a74e92aa1f10b712509b47fcbb68a3445352e2","unresolved":false,"context_lines":[{"line_number":572,"context_line":"            ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":573,"context_line":"        network_id \u003d ovn_network_name.strip(\u0027neutron-\u0027)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # TODO(lucasagomes): For backward compatibility, if network_id"},{"line_number":576,"context_line":"        # is not in the OVNDB, look at the port_object"},{"line_number":577,"context_line":"        if not network_id and port_object:"},{"line_number":578,"context_line":"            network_id \u003d port_object[\u0027network_id\u0027]"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":581,"context_line":"            txn.add(self._nb_idl.delete_lswitch_port("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_136e09c8","line":578,"range":{"start_line":575,"start_character":0,"end_line":578,"end_character":50},"updated":"2020-07-15 10:22:11.000000000","message":"I think that as part of this patch we need to remove this logic here, because now the code is assuming that OVN_NETWORK_NAME_EXT_ID_KEY is set. If not set the code will fail on L573 with an AttributeError when None is returned and won\u0027t even get to this conditional.","commit_id":"c02dc2a72ad350d5c996b2c05e661f4fc56c351e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"67ff79a41141011ea52da3c0e01874b607093d33","unresolved":false,"context_lines":[{"line_number":572,"context_line":"            ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":573,"context_line":"        network_id \u003d ovn_network_name.strip(\u0027neutron-\u0027)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # TODO(lucasagomes): For backward compatibility, if network_id"},{"line_number":576,"context_line":"        # is not in the OVNDB, look at the port_object"},{"line_number":577,"context_line":"        if not network_id and port_object:"},{"line_number":578,"context_line":"            network_id \u003d port_object[\u0027network_id\u0027]"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":581,"context_line":"            txn.add(self._nb_idl.delete_lswitch_port("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_8ebdd203","line":578,"range":{"start_line":575,"start_character":0,"end_line":578,"end_character":50},"in_reply_to":"bf51134e_136e09c8","updated":"2020-07-15 11:19:27.000000000","message":"Sure I can clean up this.","commit_id":"c02dc2a72ad350d5c996b2c05e661f4fc56c351e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c517a9fbe3a983407bc07811cab76d7fdb0bef6d","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        ovn_network_name \u003d ovn_port.external_ids.get("},{"line_number":572,"context_line":"            ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":573,"context_line":"        network_id \u003d ovn_network_name.strip(\u0027neutron-\u0027)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":576,"context_line":"            txn.add(self._nb_idl.delete_lswitch_port("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_9fb3140b","line":573,"updated":"2020-07-17 11:05:16.000000000","message":"Is this related to this patch?","commit_id":"0e53673c5d4f49846bb439b2e1ab8e984c20d6f8"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"292b80410f5cea563e82af43d71bd32ee859cc8a","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        ovn_network_name \u003d ovn_port.external_ids.get("},{"line_number":572,"context_line":"            ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":573,"context_line":"        network_id \u003d ovn_network_name.strip(\u0027neutron-\u0027)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":576,"context_line":"            txn.add(self._nb_idl.delete_lswitch_port("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_df00ec38","line":573,"in_reply_to":"bf51134e_9fb3140b","updated":"2020-07-17 11:32:26.000000000","message":"Yes, because we need both \u0027ovn_network_name\u0027 which is neutron-uuid, and network_id which is uuid","commit_id":"0e53673c5d4f49846bb439b2e1ab8e984c20d6f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1f0e94d7ea35d716e070e6d0b57b3700873589b1","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        ovn_network_name \u003d ovn_port.external_ids.get("},{"line_number":572,"context_line":"            ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":573,"context_line":"        network_id \u003d ovn_network_name.strip(\u0027neutron-\u0027)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":576,"context_line":"            txn.add(self._nb_idl.delete_lswitch_port("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_9f9cb40f","line":573,"in_reply_to":"bf51134e_df00ec38","updated":"2020-07-17 11:34:21.000000000","message":"+1","commit_id":"0e53673c5d4f49846bb439b2e1ab8e984c20d6f8"}]}