)]}'
{"neutron/services/portforwarding/pf_plugin.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"30d2230657b43921d04169a75aa71875e04750c2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    l3_router \u003d SvcPlugin(l3.ROUTER, True)"},{"line_number":61,"context_line":"    supported_svc_plugins \u003d ["},{"line_number":62,"context_line":"        l3_router,"},{"line_number":63,"context_line":"        SvcPlugin(\u0027ovn-router\u0027, False),"},{"line_number":64,"context_line":"        SvcPlugin(\u0027neutron.services.ovn_l3.plugin.OVNL3RouterPlugin\u0027, False)]"},{"line_number":65,"context_line":"    plugins \u003d []"},{"line_number":66,"context_line":"    rpc_required \u003d False"},{"line_number":67,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_42dfe30b","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":77},"updated":"2020-07-17 12:21:18.000000000","message":"Based on setup.cfg those two points the same code?\nCan\u0027t we just require the one from L63?","commit_id":"61bf68de3185c48363a6c6c9187773368152ffdd"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"ae630018519d0ab1b67f3f0a6a1065d43f049c42","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    l3_router \u003d SvcPlugin(l3.ROUTER, True)"},{"line_number":61,"context_line":"    supported_svc_plugins \u003d ["},{"line_number":62,"context_line":"        l3_router,"},{"line_number":63,"context_line":"        SvcPlugin(\u0027ovn-router\u0027, False),"},{"line_number":64,"context_line":"        SvcPlugin(\u0027neutron.services.ovn_l3.plugin.OVNL3RouterPlugin\u0027, False)]"},{"line_number":65,"context_line":"    plugins \u003d []"},{"line_number":66,"context_line":"    rpc_required \u003d False"},{"line_number":67,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_039cb45b","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":77},"in_reply_to":"bf51134e_42dfe30b","updated":"2020-07-20 15:46:25.000000000","message":"Yeah, that would be ideal but unfortunately that is not what we currently have.\n\nFunctional tests do not use setup.cfg so these begin to fail if I only use ovn-router.\n\nMy approach here then was to honor either-or until we have a unified value for the svc plugin.","commit_id":"61bf68de3185c48363a6c6c9187773368152ffdd"}]}