)]}'
{"neutron/cmd/ovn/migration_mtu.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1d09692d74a3ba162e1ab6ea3811ba28f3f116d3","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_connection():"},{"line_number":26,"context_line":"    user_domain_name \u003d os.environ.get(\u0027OS_USER_DOMAIN_NAME\u0027)"},{"line_number":27,"context_line":"    project_domain_name \u003d os.environ.get(\u0027OS_PROJECT_DOMAIN_NAME\u0027)"},{"line_number":28,"context_line":"    user_domain_id \u003d os.environ.get("},{"line_number":29,"context_line":"        \u0027OS_USER_DOMAIN_ID\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f0304fa1","line":26,"updated":"2020-07-21 15:30:44.000000000","message":"I know this is obvious when reading the code, but I would add a comment here about the prevalence order: if *_DOMAIN_NAME are defined, will override *_DOMAIN_ID","commit_id":"75757f60e1ba605237ec06f69d29d411a77c1c0b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"207f2180c43764b02410a85de9f8d6056d0f73b8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    project_domain_name \u003d os.environ.get(\u0027OS_PROJECT_DOMAIN_NAME\u0027)"},{"line_number":28,"context_line":"    user_domain_id \u003d os.environ.get("},{"line_number":29,"context_line":"        \u0027OS_USER_DOMAIN_ID\u0027,"},{"line_number":30,"context_line":"        \u0027default\u0027) if user_domain_name is None else None"},{"line_number":31,"context_line":"    project_domain_id \u003d os.environ.get("},{"line_number":32,"context_line":"        \u0027OS_PROJECT_DOMAIN_ID\u0027,"},{"line_number":33,"context_line":"        \u0027default\u0027) if project_domain_name is None else None"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a254ffff","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":46},"updated":"2020-07-17 11:59:36.000000000","message":"nit: not user_domain_name","commit_id":"75757f60e1ba605237ec06f69d29d411a77c1c0b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"207f2180c43764b02410a85de9f8d6056d0f73b8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027default\u0027) if user_domain_name is None else None"},{"line_number":31,"context_line":"    project_domain_id \u003d os.environ.get("},{"line_number":32,"context_line":"        \u0027OS_PROJECT_DOMAIN_ID\u0027,"},{"line_number":33,"context_line":"        \u0027default\u0027) if project_domain_name is None else None"},{"line_number":34,"context_line":"    conn \u003d connection.Connection(auth_url\u003dos.environ[\u0027OS_AUTH_URL\u0027],"},{"line_number":35,"context_line":"                                 project_name\u003dos.environ[\u0027OS_PROJECT_NAME\u0027],"},{"line_number":36,"context_line":"                                 username\u003dos.environ[\u0027OS_USERNAME\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2248ef5a","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":49},"updated":"2020-07-17 11:59:36.000000000","message":"nit: ditto.\nwith \"not project_domain_name\" the condition will be true for \u0027\u0027 (empty string) as well, I am not sure if that is good for this case or not.","commit_id":"75757f60e1ba605237ec06f69d29d411a77c1c0b"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"d3153826d3211f586038391210a7428319ad00b4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027default\u0027) if user_domain_name is None else None"},{"line_number":31,"context_line":"    project_domain_id \u003d os.environ.get("},{"line_number":32,"context_line":"        \u0027OS_PROJECT_DOMAIN_ID\u0027,"},{"line_number":33,"context_line":"        \u0027default\u0027) if project_domain_name is None else None"},{"line_number":34,"context_line":"    conn \u003d connection.Connection(auth_url\u003dos.environ[\u0027OS_AUTH_URL\u0027],"},{"line_number":35,"context_line":"                                 project_name\u003dos.environ[\u0027OS_PROJECT_NAME\u0027],"},{"line_number":36,"context_line":"                                 username\u003dos.environ[\u0027OS_USERNAME\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e270b776","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":49},"in_reply_to":"bf51134e_2248ef5a","updated":"2020-07-17 12:07:45.000000000","message":"I intentionally used `is None` check as I found it improbable that anyone would actually set a environment variable to the empty string, and Dict.get() returns None when the key is not found.\n\nBut I have no issue with updating to `not X` to include the empty string if that makes it more readable.","commit_id":"75757f60e1ba605237ec06f69d29d411a77c1c0b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2f4e36bf7e043e0e10642e06550ea74e49160c93","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027default\u0027) if user_domain_name is None else None"},{"line_number":31,"context_line":"    project_domain_id \u003d os.environ.get("},{"line_number":32,"context_line":"        \u0027OS_PROJECT_DOMAIN_ID\u0027,"},{"line_number":33,"context_line":"        \u0027default\u0027) if project_domain_name is None else None"},{"line_number":34,"context_line":"    conn \u003d connection.Connection(auth_url\u003dos.environ[\u0027OS_AUTH_URL\u0027],"},{"line_number":35,"context_line":"                                 project_name\u003dos.environ[\u0027OS_PROJECT_NAME\u0027],"},{"line_number":36,"context_line":"                                 username\u003dos.environ[\u0027OS_USERNAME\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f30fe72c","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":49},"in_reply_to":"bf51134e_e270b776","updated":"2020-07-17 14:26:47.000000000","message":"that was my feeling as well, so Ok","commit_id":"75757f60e1ba605237ec06f69d29d411a77c1c0b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"251e41a8f858ad7c074c2f028e1a6fe32920700e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        OS_PROJECT_DOMAIN_ID ID of domain for authorization"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    NOTE: If both OS_*_DOMAIN_NAME and OS_*_DOMAIN_ID variables are present in"},{"line_number":51,"context_line":"    the environment the OS_*_DOMAIN_NAME variables will be used."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    user_domain_name \u003d os.environ.get(\u0027OS_USER_DOMAIN_NAME\u0027)"},{"line_number":54,"context_line":"    project_domain_name \u003d os.environ.get(\u0027OS_PROJECT_DOMAIN_NAME\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_267c36ea","line":51,"updated":"2020-07-30 13:04:33.000000000","message":"+1 to this documentation","commit_id":"c6574321bae262d2eb8ed2ad12ebf6c420ea5bf8"}]}