)]}'
{"neutron/db/migration/alembic_migrations/versions/fcac4c42e2cc_bsn_addresspairs.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"69088377101a74bd161ce08f53532581d8205d43","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVn%2F%2F%2Fhs%3D","line":2,"updated":"2014-03-02 21:01:35.000000000","message":"We have started to drop this in new modules","commit_id":"df0242f4df67ba229b4d6b46a0f82250063ed244"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a2a95987bc1736101915dc944704d45ea26f70c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVn%2F%2F9so%3D","line":2,"in_reply_to":"AAAAVn%2F%2F%2Fhs%3D","updated":"2014-03-03 06:01:07.000000000","message":"Done","commit_id":"df0242f4df67ba229b4d6b46a0f82250063ed244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca2e1fccca476d50ca63061719980aba0251d9d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVn%2F%2F9rs%3D","line":2,"in_reply_to":"AAAAVn%2F%2F%2Fhs%3D","updated":"2014-03-03 06:09:21.000000000","message":"It is generated from the template file. It is better to fix the root cause.\nI filed bug 1286991 and fix it soon.","commit_id":"df0242f4df67ba229b4d6b46a0f82250063ed244"}],"neutron/plugins/bigswitch/plugin.py":[{"author":{"_account_id":7591,"name":"Kanzhe Jiang","email":"kanzhe@gmail.com","username":"kanzhe"},"change_message_id":"5f501fc7f798550bcd164428f61949e0f8c6f54f","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                pairs \u003d self._process_create_allowed_address_pairs("},{"line_number":591,"context_line":"                    context, new_port, port[\u0027port\u0027][addr_pair.ADDRESS_PAIRS])"},{"line_number":592,"context_line":"                new_port[addr_pair.ADDRESS_PAIRS] \u003d pairs"},{"line_number":593,"context_line":"            elif \u0027fixed_ips\u0027 in port[\u0027port\u0027]:"},{"line_number":594,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":595,"context_line":"                    context, new_port)"},{"line_number":596,"context_line":"            self._update_extra_dhcp_opts_on_port(context, port_id, port,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2Fyt8%3D","line":593,"updated":"2014-02-24 19:08:11.000000000","message":"Should the overlap be also checked if address_pair is modified?\nIt may be clearer to move the elif block to a separate if block. If both address_pair and fixed_ips present, check for overlap.","commit_id":"1dbc3ff90ca387386e2eee5f9f87e26d9fbe5bd0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a35c1514101d9bfc325849c5ef579e6a8a7ed45a","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                pairs \u003d self._process_create_allowed_address_pairs("},{"line_number":591,"context_line":"                    context, new_port, port[\u0027port\u0027][addr_pair.ADDRESS_PAIRS])"},{"line_number":592,"context_line":"                new_port[addr_pair.ADDRESS_PAIRS] \u003d pairs"},{"line_number":593,"context_line":"            elif \u0027fixed_ips\u0027 in port[\u0027port\u0027]:"},{"line_number":594,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":595,"context_line":"                    context, new_port)"},{"line_number":596,"context_line":"            self._update_extra_dhcp_opts_on_port(context, port_id, port,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2Fx3o%3D","line":593,"in_reply_to":"AAAAU3%2F%2Fyt8%3D","updated":"2014-02-24 20:35:59.000000000","message":"Looks like I can just check if fixed_ips are in the port. The overlap check function will just return if there are no address pairs for the port anyway.","commit_id":"1dbc3ff90ca387386e2eee5f9f87e26d9fbe5bd0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca2e1fccca476d50ca63061719980aba0251d9d2","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                self._delete_allowed_address_pairs(context, port_id)"},{"line_number":681,"context_line":"                pairs \u003d self._process_create_allowed_address_pairs("},{"line_number":682,"context_line":"                    context, new_port, port[\u0027port\u0027][addr_pair.ADDRESS_PAIRS])"},{"line_number":683,"context_line":"                new_port[addr_pair.ADDRESS_PAIRS] \u003d pairs"},{"line_number":684,"context_line":"            if (\u0027fixed_ips\u0027 in port[\u0027port\u0027]):"},{"line_number":685,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":686,"context_line":"                    context, new_port)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVn%2F%2F9k8%3D","line":683,"updated":"2014-03-03 06:09:21.000000000","message":"Could you consider catching up with https://review.openstack.org/#/c/58847/20/neutron/plugins/openvswitch/ovs_neutron_plugin.py ?\nThe patch is under the gate. I believe it simplifies the logic.","commit_id":"df0242f4df67ba229b4d6b46a0f82250063ed244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a1e022144e203bc80e085957f98a957a92dbc8ce","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                self._delete_allowed_address_pairs(context, port_id)"},{"line_number":717,"context_line":"                pairs \u003d self._process_create_allowed_address_pairs("},{"line_number":718,"context_line":"                    context, new_port, port[\u0027port\u0027][addr_pair.ADDRESS_PAIRS])"},{"line_number":719,"context_line":"                new_port[addr_pair.ADDRESS_PAIRS] \u003d pairs"},{"line_number":720,"context_line":"            if (\u0027fixed_ips\u0027 in port[\u0027port\u0027]):"},{"line_number":721,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":722,"context_line":"                    context, new_port)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVn%2F%2F9XU%3D","line":719,"updated":"2014-03-03 06:53:53.000000000","message":"Could you rebase the logic on top of https://review.openstack.org/#/c/58847/ . It was just merged.","commit_id":"ed1cf9a921002684e5871bbf79bdab6846ffeb22"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"35773308eb75490d2e5293d9402e0edf785f509a","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                self._delete_allowed_address_pairs(context, port_id)"},{"line_number":717,"context_line":"                pairs \u003d self._process_create_allowed_address_pairs("},{"line_number":718,"context_line":"                    context, new_port, port[\u0027port\u0027][addr_pair.ADDRESS_PAIRS])"},{"line_number":719,"context_line":"                new_port[addr_pair.ADDRESS_PAIRS] \u003d pairs"},{"line_number":720,"context_line":"            if (\u0027fixed_ips\u0027 in port[\u0027port\u0027]):"},{"line_number":721,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":722,"context_line":"                    context, new_port)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVn%2F%2F86I%3D","line":719,"in_reply_to":"AAAAVn%2F%2F9XU%3D","updated":"2014-03-03 08:17:03.000000000","message":"Done","commit_id":"ed1cf9a921002684e5871bbf79bdab6846ffeb22"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"42e4094561877409c71b99f18c2b871823734676","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            if (addr_pair.ADDRESS_PAIRS in port[\u0027port\u0027] and"},{"line_number":710,"context_line":"                self.update_address_pairs_on_port(context, port_id, port,"},{"line_number":711,"context_line":"                                                  orig_port, new_port)):"},{"line_number":712,"context_line":"                ctrl_update_required \u003d True"},{"line_number":713,"context_line":"            if (\u0027fixed_ips\u0027 in port[\u0027port\u0027]):"},{"line_number":714,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":715,"context_line":"                    context, new_port)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVn%2F%2F8ic%3D","line":712,"updated":"2014-03-03 09:04:53.000000000","message":"Please consider:\n\n  if addr_pair.ADDRESS_PAIRS in port[\u0027port\u0027]:\n      need_port_update_notify |\u003d (\n          self.update_address_pairs_on_port(context, id, port,\n                                            original_port,\n                                            updated_port))\n\nupdate_address_pairs_on_port actually does update, so it seems better if it is inside if-clause.","commit_id":"c2042b1e84074290a475f3b355743e4457099c73"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"592a4905865d1628e2997fe806da74660598c470","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            if (addr_pair.ADDRESS_PAIRS in port[\u0027port\u0027] and"},{"line_number":710,"context_line":"                self.update_address_pairs_on_port(context, port_id, port,"},{"line_number":711,"context_line":"                                                  orig_port, new_port)):"},{"line_number":712,"context_line":"                ctrl_update_required \u003d True"},{"line_number":713,"context_line":"            if (\u0027fixed_ips\u0027 in port[\u0027port\u0027]):"},{"line_number":714,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":715,"context_line":"                    context, new_port)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVn%2F%2F7wI%3D","line":712,"in_reply_to":"AAAAVn%2F%2F8ic%3D","updated":"2014-03-03 10:24:22.000000000","message":"Done","commit_id":"c2042b1e84074290a475f3b355743e4457099c73"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"42e4094561877409c71b99f18c2b871823734676","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                self.update_address_pairs_on_port(context, port_id, port,"},{"line_number":711,"context_line":"                                                  orig_port, new_port)):"},{"line_number":712,"context_line":"                ctrl_update_required \u003d True"},{"line_number":713,"context_line":"            if (\u0027fixed_ips\u0027 in port[\u0027port\u0027]):"},{"line_number":714,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":715,"context_line":"                    context, new_port)"},{"line_number":716,"context_line":"            self._update_extra_dhcp_opts_on_port(context, port_id, port,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVn%2F%2F8hs%3D","line":713,"updated":"2014-03-03 09:04:53.000000000","message":"(nit) No parentheses are required.","commit_id":"c2042b1e84074290a475f3b355743e4457099c73"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"592a4905865d1628e2997fe806da74660598c470","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                self.update_address_pairs_on_port(context, port_id, port,"},{"line_number":711,"context_line":"                                                  orig_port, new_port)):"},{"line_number":712,"context_line":"                ctrl_update_required \u003d True"},{"line_number":713,"context_line":"            if (\u0027fixed_ips\u0027 in port[\u0027port\u0027]):"},{"line_number":714,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":715,"context_line":"                    context, new_port)"},{"line_number":716,"context_line":"            self._update_extra_dhcp_opts_on_port(context, port_id, port,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAVn%2F%2F7wE%3D","line":713,"in_reply_to":"AAAAVn%2F%2F8hs%3D","updated":"2014-03-03 10:24:22.000000000","message":"Done","commit_id":"c2042b1e84074290a475f3b355743e4457099c73"}]}