)]}'
{"neutron/extensions/agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"674f2047957869ca34f437f5aa52375f44bbac26","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        controller \u003d base.create_resource(apidef.COLLECTION_NAME,"},{"line_number":38,"context_line":"                                          apidef.RESOURCE_NAME,"},{"line_number":39,"context_line":"                                          plugin, params,"},{"line_number":40,"context_line":"                                          allow_pagination\u003dTrue)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        ex \u003d extensions.ResourceExtension(apidef.COLLECTION_NAME,"},{"line_number":43,"context_line":"                                          controller)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_84a4e74c","line":40,"updated":"2020-09-07 09:55:54.000000000","message":"And \"allow_sorting\"?","commit_id":"d06c119721cb840529aad43c08f4e2143339a5a5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"19f43199137deaaa3776215c82ba3762828f4516","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        controller \u003d base.create_resource(apidef.COLLECTION_NAME,"},{"line_number":38,"context_line":"                                          apidef.RESOURCE_NAME,"},{"line_number":39,"context_line":"                                          plugin, params,"},{"line_number":40,"context_line":"                                          allow_pagination\u003dTrue)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        ex \u003d extensions.ResourceExtension(apidef.COLLECTION_NAME,"},{"line_number":43,"context_line":"                                          controller)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d3b9f07c","line":40,"in_reply_to":"9f560f44_84a4e74c","updated":"2020-09-30 06:59:17.000000000","message":"+1","commit_id":"d06c119721cb840529aad43c08f4e2143339a5a5"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"19f43199137deaaa3776215c82ba3762828f4516","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        populate_agents(self)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Override agents API methods"},{"line_number":270,"context_line":"        self.patch_plugin_merge(\"get_agents\", get_agents)"},{"line_number":271,"context_line":"        self.patch_plugin_choose(\"get_agent\", get_agent)"},{"line_number":272,"context_line":"        self.patch_plugin_choose(\"update_agent\", update_agent)"},{"line_number":273,"context_line":"        self.patch_plugin_choose(\"delete_agent\", delete_agent)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_93e0189a","line":270,"updated":"2020-09-30 06:59:17.000000000","message":"If I understand well here ovn code overwrites get_agent method.","commit_id":"d06c119721cb840529aad43c08f4e2143339a5a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"674f2047957869ca34f437f5aa52375f44bbac26","unresolved":false,"context_lines":[{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"def get_agents(self, context, filters\u003dNone, fields\u003dNone, _driver\u003dNone,"},{"line_number":1196,"context_line":"               **kwargs):"},{"line_number":1197,"context_line":"    update_db \u003d _driver.ping_all_chassis()"},{"line_number":1198,"context_line":"    filters \u003d filters or {}"},{"line_number":1199,"context_line":"    agent_list \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_44ae4f2e","line":1196,"updated":"2020-09-07 09:55:54.000000000","message":"Why this change?","commit_id":"d06c119721cb840529aad43c08f4e2143339a5a5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cafd868570f6456a4c954dde6c4b02cd2d27425b","unresolved":false,"context_lines":[{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"def get_agents(self, context, filters\u003dNone, fields\u003dNone, _driver\u003dNone,"},{"line_number":1196,"context_line":"               **kwargs):"},{"line_number":1197,"context_line":"    update_db \u003d _driver.ping_all_chassis()"},{"line_number":1198,"context_line":"    filters \u003d filters or {}"},{"line_number":1199,"context_line":"    agent_list \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9fa8ae78","line":1196,"in_reply_to":"9f560f44_44ae4f2e","updated":"2020-09-07 10:56:31.000000000","message":"This is the reason:\nhttps://review.opendev.org/#/c/743953/5/neutron/db/agents_db.py@298","commit_id":"d06c119721cb840529aad43c08f4e2143339a5a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e35426b996041e16f1f61b548b45d84ba8c9fa51","unresolved":false,"context_lines":[{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"def get_agents(self, context, filters\u003dNone, fields\u003dNone, _driver\u003dNone,"},{"line_number":1196,"context_line":"               **kwargs):"},{"line_number":1197,"context_line":"    update_db \u003d _driver.ping_all_chassis()"},{"line_number":1198,"context_line":"    filters \u003d filters or {}"},{"line_number":1199,"context_line":"    agent_list \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5f415aa6","line":1196,"in_reply_to":"9f560f44_73f62460","updated":"2020-09-30 14:57:36.000000000","message":"Exactly, you are right. Thanks for the explanation!","commit_id":"d06c119721cb840529aad43c08f4e2143339a5a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba3da81a4509416c5f363959d90c94a0d56b65df","unresolved":false,"context_lines":[{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"def get_agents(self, context, filters\u003dNone, fields\u003dNone, _driver\u003dNone,"},{"line_number":1196,"context_line":"               **kwargs):"},{"line_number":1197,"context_line":"    update_db \u003d _driver.ping_all_chassis()"},{"line_number":1198,"context_line":"    filters \u003d filters or {}"},{"line_number":1199,"context_line":"    agent_list \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d5ac3da1","line":1196,"in_reply_to":"9f560f44_9fa8ae78","updated":"2020-09-15 08:27:42.000000000","message":"I don\u0027t understand. Where are we calling this method from this function? Or the other way around","commit_id":"d06c119721cb840529aad43c08f4e2143339a5a5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"19f43199137deaaa3776215c82ba3762828f4516","unresolved":false,"context_lines":[{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"def get_agents(self, context, filters\u003dNone, fields\u003dNone, _driver\u003dNone,"},{"line_number":1196,"context_line":"               **kwargs):"},{"line_number":1197,"context_line":"    update_db \u003d _driver.ping_all_chassis()"},{"line_number":1198,"context_line":"    filters \u003d filters or {}"},{"line_number":1199,"context_line":"    agent_list \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_73f62460","line":1196,"in_reply_to":"9f560f44_d5ac3da1","updated":"2020-09-30 06:59:17.000000000","message":"Rodolfo: https://review.opendev.org/#/c/743953/5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py@270\nIf I understand well l270. is where get_agents code is changed to this one, so **kwargs is necessary or an even better solution can be to add sorts\u003dNone, limit\u003dNone, marker\u003dNone, page_reverse\u003dFalse,\nOr am I oversee something?","commit_id":"d06c119721cb840529aad43c08f4e2143339a5a5"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"aac0847f32e166fc9ecabf1fbf8cd06a8453a063","unresolved":false,"context_lines":[{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"def get_agents(self, context, filters\u003dNone, fields\u003dNone, _driver\u003dNone,"},{"line_number":1204,"context_line":"               sorts\u003dNone, limit\u003dNone, marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":1205,"context_line":"    update_db \u003d _driver.ping_all_chassis()"},{"line_number":1206,"context_line":"    filters \u003d filters or {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f5e20fd4","line":1203,"updated":"2020-09-30 16:29:24.000000000","message":"pep8: E303 too many blank lines (3)","commit_id":"af4d001d980230caffb7f62a5aea1b0c199b0e2f"}]}