)]}'
{"neutron/db/migration/alembic_migrations/versions/CONTRACT_HEAD":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d96126e4f3977c7e5254ed3a6915ea869ed45a6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"cd11ce8284dc"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9f560f44_c36a42b1","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":12},"updated":"2020-08-04 15:11:11.000000000","message":"why is this updated?","commit_id":"3d726c92b0c57c9b48a1f273315228fdbf686c71"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8c362827e961845f9147b8c66cace95a32787844","unresolved":false,"context_lines":[{"line_number":1,"context_line":"cd11ce8284dc"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9f560f44_4a8f4d74","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":12},"in_reply_to":"9f560f44_c36a42b1","updated":"2020-08-06 09:33:41.000000000","message":"Ups, my bad. When I executed the neutron-db-manage script, I didn\u0027t specify --expand\n\nVery good catch!","commit_id":"3d726c92b0c57c9b48a1f273315228fdbf686c71"}],"neutron/db/migration/alembic_migrations/versions/victoria/expand/49d8622c5221_propagate_uplink_status_defaults_to_true.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"04b953020db129eacf6b3275cfa651da3375885e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.alter_column(\u0027portuplinkstatuspropagation\u0027, \u0027propagate_uplink_status\u0027,"},{"line_number":35,"context_line":"                    existing_server_default\u003dsa.sql.false(),"},{"line_number":36,"context_line":"                    server_default\u003dsa.sql.true())"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_057d677e","line":35,"range":{"start_line":35,"start_character":20,"end_line":35,"end_character":42},"updated":"2020-08-04 07:38:56.000000000","message":"existing_server_default should be used when we do not want to change existing value, you may want to and existing_nullable instead.","commit_id":"0e2844746f7a9a4be120b0879f55374b79faa752"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"97224763ee00d3eaa271a004c53783816ca1f395","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.alter_column(\u0027portuplinkstatuspropagation\u0027, \u0027propagate_uplink_status\u0027,"},{"line_number":35,"context_line":"                    existing_server_default\u003dsa.sql.false(),"},{"line_number":36,"context_line":"                    server_default\u003dsa.sql.true())"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f13751fe","line":35,"range":{"start_line":35,"start_character":20,"end_line":35,"end_character":42},"in_reply_to":"9f560f44_057d677e","updated":"2020-08-04 13:38:53.000000000","message":"You are right. What I need to specify in \"existing_\" is those parameters not changing. Thanks!\n\nhttps://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.alter_column","commit_id":"0e2844746f7a9a4be120b0879f55374b79faa752"}],"neutron/objects/port/extensions/uplink_status_propagation.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"499449381098d33ba2ace163938d471a36bfa53a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"@base.NeutronObjectRegistry.register"},{"line_number":21,"context_line":"class PortUplinkStatusPropagation(base.NeutronDbObject):"},{"line_number":22,"context_line":"    # Version 1.0: Initial version"},{"line_number":23,"context_line":"    VERSION \u003d \"1.0\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    db_model \u003d db_models.PortUplinkStatusPropagation"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_0fec3d8d","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":18},"updated":"2020-08-06 06:23:36.000000000","message":"I think this should be incremented","commit_id":"901369854651404397a379d4ed49b6c41331a762"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8c362827e961845f9147b8c66cace95a32787844","unresolved":false,"context_lines":[{"line_number":20,"context_line":"@base.NeutronObjectRegistry.register"},{"line_number":21,"context_line":"class PortUplinkStatusPropagation(base.NeutronDbObject):"},{"line_number":22,"context_line":"    # Version 1.0: Initial version"},{"line_number":23,"context_line":"    VERSION \u003d \"1.0\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    db_model \u003d db_models.PortUplinkStatusPropagation"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_38e6a5e9","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":18},"in_reply_to":"9f560f44_0fec3d8d","updated":"2020-08-06 09:33:41.000000000","message":"I had a conflict with this because this is only modifying a default parameter, only used in new objects. But you are right, and the thumb rule here is very easy: if the hash is modified, the version should be bumped.\n\nBTW, because this only affects new objects, there is no need to create a compatibility method.","commit_id":"901369854651404397a379d4ed49b6c41331a762"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4d214fe8f7a804d421e0e5d01c0a379fb82fb4df","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027port_id\u0027: common_types.UUIDField(),"},{"line_number":32,"context_line":"        \u0027propagate_uplink_status\u0027: obj_fields.BooleanField(default\u003dTrue),"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    foreign_keys \u003d {\u0027Port\u0027: {\u0027port_id\u0027: \u0027id\u0027}}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_8042c5a9","line":32,"updated":"2020-08-07 11:01:54.000000000","message":"maybe UT to check that version 1.0 has got default value as False may be useful? What do You think?","commit_id":"bc7d18826a1eb95b4f0e9ae10a58f4cac1eee510"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"33adde19cab216e17f509ba38d8b3751d754d4b5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027port_id\u0027: common_types.UUIDField(),"},{"line_number":32,"context_line":"        \u0027propagate_uplink_status\u0027: obj_fields.BooleanField(default\u003dTrue),"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    foreign_keys \u003d {\u0027Port\u0027: {\u0027port_id\u0027: \u0027id\u0027}}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_003d15dc","line":32,"in_reply_to":"9f560f44_8042c5a9","updated":"2020-08-07 11:19:08.000000000","message":"That\u0027s what I commented in https://review.opendev.org/#/c/744210/4/neutron/objects/port/extensions/uplink_status_propagation.py@23\n\nThere is not need because:\n- This will affect only to the creation of a new OVO.\n- When dehydrating an OVO to be submitted via RPC (\"obj_to_primitive\"), the value of the parameter will be already set. The default value won\u0027t affect to this process.","commit_id":"bc7d18826a1eb95b4f0e9ae10a58f4cac1eee510"}]}