)]}'
{"neutron/agent/linux/pd.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2bcdda6942c85ca39b5cc772111c86b97313bafd","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                self.intf_driver.add_ipv6_addr(router[\u0027gw_interface\u0027],"},{"line_number":214,"context_line":"                                               lla_with_mask,"},{"line_number":215,"context_line":"                                               router[\u0027ns_name\u0027],"},{"line_number":216,"context_line":"                                               \u0027link\u0027)"},{"line_number":217,"context_line":"                # There is a delay before the LLA becomes active."},{"line_number":218,"context_line":"                # This is because the kernel runs DAD to make sure LLA"},{"line_number":219,"context_line":"                # uniqueness"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_37c23d35","line":216,"updated":"2020-08-24 15:42:45.000000000","message":"The solution is OK but I would use \"ip address replace\".\n\nOf course, that means you need to change \"add_ipv6_addr\" to use this new method and create \"replace_ip_address\" or modify \"add_ip_address\" to use \"replace\" if requested.","commit_id":"81d375d39ab1affe4b0a29437eaabc387fb1c570"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"03e846357bf4e2abec62536e563a828c053b67ea","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                self.intf_driver.add_ipv6_addr(router[\u0027gw_interface\u0027],"},{"line_number":214,"context_line":"                                               lla_with_mask,"},{"line_number":215,"context_line":"                                               router[\u0027ns_name\u0027],"},{"line_number":216,"context_line":"                                               \u0027link\u0027)"},{"line_number":217,"context_line":"                # There is a delay before the LLA becomes active."},{"line_number":218,"context_line":"                # This is because the kernel runs DAD to make sure LLA"},{"line_number":219,"context_line":"                # uniqueness"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7ee805e1","line":216,"in_reply_to":"9f560f44_28edbcef","updated":"2020-08-25 07:05:13.000000000","message":"@Rodolfo: lets fix it for now and I will propose follow-up patch to propose \"replace_ip_address\" function in ip_lib module. Will that work for You?","commit_id":"81d375d39ab1affe4b0a29437eaabc387fb1c570"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e444ef16f2cb99efca9d793954e6dca592bb89a9","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                self.intf_driver.add_ipv6_addr(router[\u0027gw_interface\u0027],"},{"line_number":214,"context_line":"                                               lla_with_mask,"},{"line_number":215,"context_line":"                                               router[\u0027ns_name\u0027],"},{"line_number":216,"context_line":"                                               \u0027link\u0027)"},{"line_number":217,"context_line":"                # There is a delay before the LLA becomes active."},{"line_number":218,"context_line":"                # This is because the kernel runs DAD to make sure LLA"},{"line_number":219,"context_line":"                # uniqueness"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_28edbcef","line":216,"in_reply_to":"9f560f44_37c23d35","updated":"2020-08-24 18:01:14.000000000","message":"Since there are other places we do this same thing (see add_centralized_floatingip() in dvr_egde_router.py) I\u0027m fine with adding this as-is then doing a follow-up if necessary to change to use \u0027replace\u0027.","commit_id":"81d375d39ab1affe4b0a29437eaabc387fb1c570"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"14c2e0f9ae153d580026c11f1beaffc39638412e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                self.intf_driver.add_ipv6_addr(router[\u0027gw_interface\u0027],"},{"line_number":214,"context_line":"                                               lla_with_mask,"},{"line_number":215,"context_line":"                                               router[\u0027ns_name\u0027],"},{"line_number":216,"context_line":"                                               \u0027link\u0027)"},{"line_number":217,"context_line":"                # There is a delay before the LLA becomes active."},{"line_number":218,"context_line":"                # This is because the kernel runs DAD to make sure LLA"},{"line_number":219,"context_line":"                # uniqueness"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3eb4cdf1","line":216,"in_reply_to":"9f560f44_7ee805e1","updated":"2020-08-25 07:06:47.000000000","message":"OK with this","commit_id":"81d375d39ab1affe4b0a29437eaabc387fb1c570"}]}