)]}'
{"doc/source/contributor/internals/openvswitch_firewall.rst":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"985419ff0ee388a2e3bc36d6ca365ca928a86e73","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"::"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"table\u003d60, priority\u003d50,ip,dl_vlan\u003d1,nw_dst\u003d224.0.0.0/24 actions\u003dload:0x1-\u003eNXM_NX_REG6[],strip_vlan,resubmit(,101)"},{"line_number":514,"context_line":"table\u003d60, priority\u003d50,ip,dl_vlan\u003d1,nw_dst\u003d224.0.0.0/24 actions\u003dload:0x2-\u003eNXM_NX_REG6[],strip_vlan,resubmit(,101)"},{"line_number":515,"context_line":"table\u003d101, priority\u003d70 actions\u003doutput:1,resubmit(,102)"},{"line_number":516,"context_line":"table\u003d101, priority\u003d0 actions\u003ddrop"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_dc2d2baf","line":513,"updated":"2020-10-06 14:17:39.000000000","message":"docs: Literal block expected; none found.","commit_id":"f5641955cfaca796ed7506aa3dbe52726d093f19"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"88230a99b1a9ddfb1e30bc10b38a5d4e3f54768c","unresolved":false,"context_lines":[{"line_number":502,"context_line":"in the 224.0.0.X range which are not IGMP must be forwarded on all ports.\" That"},{"line_number":503,"context_line":"means those packets will be forwarded to all ports regardless of any ingress"},{"line_number":504,"context_line":"rule. Therefore those packets are processed independently. Any ingress packet"},{"line_number":505,"context_line":"incoming from an local VM is sent to the multicast ingress table, |table_101|."},{"line_number":506,"context_line":"This table has one rule that sends the received packets directly to the"},{"line_number":507,"context_line":"physical bridges, the tunnel bridges and the multicast rule processing table,"},{"line_number":508,"context_line":"|table_102|. Port 1 (output:1) is the integration bridge to physical bridge"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_05028709","line":505,"range":{"start_line":505,"start_character":14,"end_line":505,"end_character":16},"updated":"2020-10-08 12:51:29.000000000","message":"nit: an -\u003e a","commit_id":"b8be1a05facff2ba8b484902494ce1663e0aae7c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"88230a99b1a9ddfb1e30bc10b38a5d4e3f54768c","unresolved":false,"context_lines":[{"line_number":529,"context_line":"according to the protocol number defined in each rule, per network (internal"},{"line_number":530,"context_line":"VLAN used by Neutron to segment the tenant traffic). The OVS firewall class"},{"line_number":531,"context_line":"``OVSFirewallDriver`` instance will keep a list of ports per internal VLAN and"},{"line_number":532,"context_line":"rule. When a rule is added or updated, a OpenFlow rule will be added to this"},{"line_number":533,"context_line":"|table_102|. This rule matches the rule protocol and outputs the packets to all"},{"line_number":534,"context_line":"ports assigned to this rule in a specific VLAN network."},{"line_number":535,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_254b4b5f","line":532,"range":{"start_line":532,"start_character":39,"end_line":532,"end_character":40},"updated":"2020-10-08 12:51:29.000000000","message":"nit: a -\u003e an","commit_id":"b8be1a05facff2ba8b484902494ce1663e0aae7c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"88230a99b1a9ddfb1e30bc10b38a5d4e3f54768c","unresolved":false,"context_lines":[{"line_number":495,"context_line":"  migrated to a port on a different node, then the new port won\u0027t contain"},{"line_number":496,"context_line":"  conntrack information about previous traffic that happened with VIP."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Multicast traffic for addresses in 224.0.0.X"},{"line_number":499,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"By default, as commented in [1]_, \"packets with a destination IP (DIP) address"},{"line_number":502,"context_line":"in the 224.0.0.X range which are not IGMP must be forwarded on all ports.\" That"},{"line_number":503,"context_line":"means those packets will be forwarded to all ports regardless of any ingress"},{"line_number":504,"context_line":"rule. Therefore those packets are processed independently. Any ingress packet"},{"line_number":505,"context_line":"incoming from an local VM is sent to the multicast ingress table, |table_101|."},{"line_number":506,"context_line":"This table has one rule that sends the received packets directly to the"},{"line_number":507,"context_line":"physical bridges, the tunnel bridges and the multicast rule processing table,"},{"line_number":508,"context_line":"|table_102|. Port 1 (output:1) is the integration bridge to physical bridge"},{"line_number":509,"context_line":"patch port."},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"::"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":" table\u003d60, priority\u003d50,ip,dl_vlan\u003d1,nw_dst\u003d224.0.0.0/24 actions\u003dload:0x1-\u003eNXM_NX_REG6[],strip_vlan,resubmit(,101)"},{"line_number":514,"context_line":" table\u003d60, priority\u003d50,ip,dl_vlan\u003d1,nw_dst\u003d224.0.0.0/24 actions\u003dload:0x2-\u003eNXM_NX_REG6[],strip_vlan,resubmit(,101)"},{"line_number":515,"context_line":" table\u003d101, priority\u003d70 actions\u003doutput:1,resubmit(,102)"},{"line_number":516,"context_line":" table\u003d101, priority\u003d0 actions\u003ddrop"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"The goal of this table is to avoid the NORMAl action processing for those"},{"line_number":519,"context_line":"packets, not allowing OVS to forward them to all ports. Instead of this, those"},{"line_number":520,"context_line":"packets are sent to other hosts via the physical and the tunnel bridges."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"The packets comming from external sources are sent directly to |table_102|."},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"::"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":" table\u003d73, priority\u003d95,ip,nw_dst\u003d224.0.0.0/24 actions\u003dresubmit(,102)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"The next table will process the ingress rules for those multicast packets"},{"line_number":529,"context_line":"according to the protocol number defined in each rule, per network (internal"},{"line_number":530,"context_line":"VLAN used by Neutron to segment the tenant traffic). The OVS firewall class"},{"line_number":531,"context_line":"``OVSFirewallDriver`` instance will keep a list of ports per internal VLAN and"},{"line_number":532,"context_line":"rule. When a rule is added or updated, a OpenFlow rule will be added to this"},{"line_number":533,"context_line":"|table_102|. This rule matches the rule protocol and outputs the packets to all"},{"line_number":534,"context_line":"ports assigned to this rule in a specific VLAN network."},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"::"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":" table\u003d102, priority\u003d70,ip,reg6\u003d0x1,nw_proto\u003d112 actions\u003doutput:11"},{"line_number":539,"context_line":" table\u003d102, priority\u003d70,ip,reg6\u003d0x2,nw_proto\u003d122 actions\u003doutput:12"},{"line_number":540,"context_line":" table\u003d102, priority\u003d0 actions\u003ddrop"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"OVS firewall integration points"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_0550c709","line":540,"range":{"start_line":498,"start_character":0,"end_line":540,"end_character":35},"updated":"2020-10-08 12:51:29.000000000","message":"+1","commit_id":"b8be1a05facff2ba8b484902494ce1663e0aae7c"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b3fcb9871e210a77613dcb50ff591821b42e3f7f","unresolved":false,"context_lines":[{"line_number":1223,"context_line":"            dl_type\u003dlib_const.ETHERTYPE_IP,"},{"line_number":1224,"context_line":"            nw_dst\u003d\u0027224.0.0.0/24\u0027,"},{"line_number":1225,"context_line":"            actions\u003d\u0027resubmit(,%d)\u0027 % ovs_consts.DROPPED_TRAFFIC_TABLE"},{"line_number":1226,"context_line":"            )"},{"line_number":1227,"context_line":"        for state in ("},{"line_number":1228,"context_line":"            ovsfw_consts.OF_STATE_ESTABLISHED_REPLY,"},{"line_number":1229,"context_line":"            ovsfw_consts.OF_STATE_RELATED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ddd62954","line":1226,"updated":"2020-08-28 20:47:52.000000000","message":"pep8: E123 closing bracket does not match indentation of opening bracket\u0027s line","commit_id":"dc4ff79bcc2c2510d9fb5145db60178649f9a6fc"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b2cd1a9effa8e62d463c09c176b54dba80e56de","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                                enable_tunneling):"},{"line_number":854,"context_line":"        ofports \u003d list(phy_br_ofports.values())"},{"line_number":855,"context_line":"        if enable_tunneling:"},{"line_number":856,"context_line":"           for network_type in ovs_consts.TUNNEL_NETWORK_TYPES:"},{"line_number":857,"context_line":"               ofports +\u003d list(tun_br_ofports[network_type].values())"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        actions \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b60693cc","line":856,"updated":"2020-09-04 12:46:09.000000000","message":"pep8: E111 indentation is not a multiple of four","commit_id":"3493037b08e0390f8c228e34e3df28c0245b8c7a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b2cd1a9effa8e62d463c09c176b54dba80e56de","unresolved":false,"context_lines":[{"line_number":854,"context_line":"        ofports \u003d list(phy_br_ofports.values())"},{"line_number":855,"context_line":"        if enable_tunneling:"},{"line_number":856,"context_line":"           for network_type in ovs_consts.TUNNEL_NETWORK_TYPES:"},{"line_number":857,"context_line":"               ofports +\u003d list(tun_br_ofports[network_type].values())"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        actions \u003d \u0027\u0027"},{"line_number":860,"context_line":"        for ofport in ofports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_160e5fe4","line":857,"updated":"2020-09-04 12:46:09.000000000","message":"pep8: E111 indentation is not a multiple of four","commit_id":"3493037b08e0390f8c228e34e3df28c0245b8c7a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b2cd1a9effa8e62d463c09c176b54dba80e56de","unresolved":false,"context_lines":[{"line_number":925,"context_line":"            nw_dst\u003d\u0027224.0.0.0/24\u0027,"},{"line_number":926,"context_line":"            actions\u003d\u0027set_field:{:d}-\u003ereg{:d},\u0027"},{"line_number":927,"context_line":"                    \u0027strip_vlan,resubmit(,{:d})\u0027.format("},{"line_number":928,"context_line":"                port.vlan_tag,"},{"line_number":929,"context_line":"                ovsfw_consts.REG_NET,"},{"line_number":930,"context_line":"                ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":931,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f6100b03","line":928,"updated":"2020-09-04 12:46:09.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"3493037b08e0390f8c228e34e3df28c0245b8c7a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b2cd1a9effa8e62d463c09c176b54dba80e56de","unresolved":false,"context_lines":[{"line_number":926,"context_line":"            actions\u003d\u0027set_field:{:d}-\u003ereg{:d},\u0027"},{"line_number":927,"context_line":"                    \u0027strip_vlan,resubmit(,{:d})\u0027.format("},{"line_number":928,"context_line":"                port.vlan_tag,"},{"line_number":929,"context_line":"                ovsfw_consts.REG_NET,"},{"line_number":930,"context_line":"                ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":931,"context_line":"            )"},{"line_number":932,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_56f737d5","line":929,"updated":"2020-09-04 12:46:09.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"3493037b08e0390f8c228e34e3df28c0245b8c7a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b2cd1a9effa8e62d463c09c176b54dba80e56de","unresolved":false,"context_lines":[{"line_number":927,"context_line":"                    \u0027strip_vlan,resubmit(,{:d})\u0027.format("},{"line_number":928,"context_line":"                port.vlan_tag,"},{"line_number":929,"context_line":"                ovsfw_consts.REG_NET,"},{"line_number":930,"context_line":"                ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":931,"context_line":"            )"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        self._initialize_egress(port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_36f283e4","line":930,"updated":"2020-09-04 12:46:09.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"3493037b08e0390f8c228e34e3df28c0245b8c7a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b2cd1a9effa8e62d463c09c176b54dba80e56de","unresolved":false,"context_lines":[{"line_number":928,"context_line":"                port.vlan_tag,"},{"line_number":929,"context_line":"                ovsfw_consts.REG_NET,"},{"line_number":930,"context_line":"                ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":931,"context_line":"            )"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        self._initialize_egress(port)"},{"line_number":934,"context_line":"        self._initialize_ingress(port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9601cfb2","line":931,"updated":"2020-09-04 12:46:09.000000000","message":"pep8: E123 closing bracket does not match indentation of opening bracket\u0027s line","commit_id":"3493037b08e0390f8c228e34e3df28c0245b8c7a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0681cdb37be10b204bc18aa7493828796c7c507","unresolved":false,"context_lines":[{"line_number":854,"context_line":"                                enable_tunneling):"},{"line_number":855,"context_line":"        ofports \u003d list(phy_br_ofports.values())"},{"line_number":856,"context_line":"        if enable_tunneling:"},{"line_number":857,"context_line":"           for network_type in ovs_consts.TUNNEL_NETWORK_TYPES:"},{"line_number":858,"context_line":"               ofports +\u003d list(tun_br_ofports[network_type].values())"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"        actions \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_076626ee","line":857,"updated":"2020-09-04 20:05:36.000000000","message":"pep8: E111 indentation is not a multiple of four","commit_id":"812f309d4bbbc219a840990606ec4ca653b47e82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0681cdb37be10b204bc18aa7493828796c7c507","unresolved":false,"context_lines":[{"line_number":855,"context_line":"        ofports \u003d list(phy_br_ofports.values())"},{"line_number":856,"context_line":"        if enable_tunneling:"},{"line_number":857,"context_line":"           for network_type in ovs_consts.TUNNEL_NETWORK_TYPES:"},{"line_number":858,"context_line":"               ofports +\u003d list(tun_br_ofports[network_type].values())"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"        actions \u003d \u0027\u0027"},{"line_number":861,"context_line":"        for ofport in ofports:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_675f220f","line":858,"updated":"2020-09-04 20:05:36.000000000","message":"pep8: E111 indentation is not a multiple of four","commit_id":"812f309d4bbbc219a840990606ec4ca653b47e82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0681cdb37be10b204bc18aa7493828796c7c507","unresolved":false,"context_lines":[{"line_number":926,"context_line":"            nw_dst\u003d\u0027224.0.0.0/24\u0027,"},{"line_number":927,"context_line":"            actions\u003d\u0027set_field:{:d}-\u003ereg{:d},\u0027"},{"line_number":928,"context_line":"                    \u0027strip_vlan,resubmit(,{:d})\u0027.format("},{"line_number":929,"context_line":"                port.vlan_tag,"},{"line_number":930,"context_line":"                ovsfw_consts.REG_NET,"},{"line_number":931,"context_line":"                ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":932,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_475c9e18","line":929,"updated":"2020-09-04 20:05:36.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"812f309d4bbbc219a840990606ec4ca653b47e82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0681cdb37be10b204bc18aa7493828796c7c507","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            actions\u003d\u0027set_field:{:d}-\u003ereg{:d},\u0027"},{"line_number":928,"context_line":"                    \u0027strip_vlan,resubmit(,{:d})\u0027.format("},{"line_number":929,"context_line":"                port.vlan_tag,"},{"line_number":930,"context_line":"                ovsfw_consts.REG_NET,"},{"line_number":931,"context_line":"                ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":932,"context_line":"            )"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a79adac1","line":930,"updated":"2020-09-04 20:05:36.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"812f309d4bbbc219a840990606ec4ca653b47e82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0681cdb37be10b204bc18aa7493828796c7c507","unresolved":false,"context_lines":[{"line_number":928,"context_line":"                    \u0027strip_vlan,resubmit(,{:d})\u0027.format("},{"line_number":929,"context_line":"                port.vlan_tag,"},{"line_number":930,"context_line":"                ovsfw_consts.REG_NET,"},{"line_number":931,"context_line":"                ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":932,"context_line":"            )"},{"line_number":933,"context_line":""},{"line_number":934,"context_line":"        self._initialize_egress(port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_879fd6b2","line":931,"updated":"2020-09-04 20:05:36.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"812f309d4bbbc219a840990606ec4ca653b47e82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0681cdb37be10b204bc18aa7493828796c7c507","unresolved":false,"context_lines":[{"line_number":929,"context_line":"                port.vlan_tag,"},{"line_number":930,"context_line":"                ovsfw_consts.REG_NET,"},{"line_number":931,"context_line":"                ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":932,"context_line":"            )"},{"line_number":933,"context_line":""},{"line_number":934,"context_line":"        self._initialize_egress(port)"},{"line_number":935,"context_line":"        self._initialize_ingress(port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e7a052f6","line":932,"updated":"2020-09-04 20:05:36.000000000","message":"pep8: E123 closing bracket does not match indentation of opening bracket\u0027s line","commit_id":"812f309d4bbbc219a840990606ec4ca653b47e82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0681cdb37be10b204bc18aa7493828796c7c507","unresolved":false,"context_lines":[{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"        LOG.warning(\"RAH - ofport: %s\", port.ofport)"},{"line_number":1528,"context_line":"        if port.ofport \u003d\u003d -1:"},{"line_number":1529,"context_line":"            a\u003d1"},{"line_number":1530,"context_line":"        modified_vlan_protocols \u003d set()"},{"line_number":1531,"context_line":"        for protocol, ofports in self.vlan_rule_ofports[port.vlan_tag].items():"},{"line_number":1532,"context_line":"            if port.ofport not in ofports:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_27aecae6","line":1529,"updated":"2020-09-04 20:05:36.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"812f309d4bbbc219a840990606ec4ca653b47e82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0681cdb37be10b204bc18aa7493828796c7c507","unresolved":false,"context_lines":[{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"        LOG.warning(\"RAH - ofport: %s\", port.ofport)"},{"line_number":1528,"context_line":"        if port.ofport \u003d\u003d -1:"},{"line_number":1529,"context_line":"            a\u003d1"},{"line_number":1530,"context_line":"        modified_vlan_protocols \u003d set()"},{"line_number":1531,"context_line":"        for protocol, ofports in self.vlan_rule_ofports[port.vlan_tag].items():"},{"line_number":1532,"context_line":"            if port.ofport not in ofports:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c7a54e05","line":1529,"updated":"2020-09-04 20:05:36.000000000","message":"pep8: F841 local variable \u0027a\u0027 is assigned to but never used","commit_id":"812f309d4bbbc219a840990606ec4ca653b47e82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c94ba056601de579fed85e4a0052851532100f16","unresolved":false,"context_lines":[{"line_number":928,"context_line":"                        port.vlan_tag,"},{"line_number":929,"context_line":"                        ovsfw_consts.REG_NET,"},{"line_number":930,"context_line":"                        ovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":931,"context_line":"            )"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        self._initialize_egress(port)"},{"line_number":934,"context_line":"        self._initialize_ingress(port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7ff67a5f","line":931,"updated":"2020-09-07 11:24:22.000000000","message":"pep8: E123 closing bracket does not match indentation of opening bracket\u0027s line","commit_id":"10fda8a71561fe4cf949b1bdc41ec68feae538bc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3bc5448a3b7cb324bfdcc9e3fe2a1cf0a1748e18","unresolved":false,"context_lines":[{"line_number":871,"context_line":"            table\u003dovs_consts.ACCEPT_OR_INGRESS_TABLE,"},{"line_number":872,"context_line":"            priority\u003d95,"},{"line_number":873,"context_line":"            dl_type\u003dlib_const.ETHERTYPE_IP,"},{"line_number":874,"context_line":"            nw_dst\u003d\u0027224.0.0.0/24\u0027,"},{"line_number":875,"context_line":"            actions\u003d\u0027resubmit(,{:d})\u0027.format("},{"line_number":876,"context_line":"                ovs_consts.MCAST_RULES_INGRESS_TABLE))"},{"line_number":877,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_4cb81a74","line":874,"range":{"start_line":874,"start_character":20,"end_line":874,"end_character":32},"updated":"2020-09-08 20:42:09.000000000","message":"nit: this can be defined as some constant","commit_id":"1ae74330a739b7de9d9bf1ad917f789e2dd68bc4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1abf1343a647e67d565a8798d7c2b2f4beb6b54c","unresolved":false,"context_lines":[{"line_number":871,"context_line":"            table\u003dovs_consts.ACCEPT_OR_INGRESS_TABLE,"},{"line_number":872,"context_line":"            priority\u003d95,"},{"line_number":873,"context_line":"            dl_type\u003dlib_const.ETHERTYPE_IP,"},{"line_number":874,"context_line":"            nw_dst\u003d\u0027224.0.0.0/24\u0027,"},{"line_number":875,"context_line":"            actions\u003d\u0027resubmit(,{:d})\u0027.format("},{"line_number":876,"context_line":"                ovs_consts.MCAST_RULES_INGRESS_TABLE))"},{"line_number":877,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_abaa2117","line":874,"range":{"start_line":874,"start_character":20,"end_line":874,"end_character":32},"in_reply_to":"9f560f44_4cb81a74","updated":"2020-09-14 10:37:45.000000000","message":"+1","commit_id":"1ae74330a739b7de9d9bf1ad917f789e2dd68bc4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0faa9ad760c71f8bcc6fc16af3df72cd684106b0","unresolved":false,"context_lines":[{"line_number":871,"context_line":"            table\u003dovs_consts.ACCEPT_OR_INGRESS_TABLE,"},{"line_number":872,"context_line":"            priority\u003d95,"},{"line_number":873,"context_line":"            dl_type\u003dlib_const.ETHERTYPE_IP,"},{"line_number":874,"context_line":"            nw_dst\u003d\u0027224.0.0.0/24\u0027,"},{"line_number":875,"context_line":"            actions\u003d\u0027resubmit(,{:d})\u0027.format("},{"line_number":876,"context_line":"                ovs_consts.MCAST_RULES_INGRESS_TABLE))"},{"line_number":877,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_889c6cc0","line":874,"range":{"start_line":874,"start_character":20,"end_line":874,"end_character":32},"in_reply_to":"9f560f44_abaa2117","updated":"2020-09-23 13:09:58.000000000","message":"Done","commit_id":"1ae74330a739b7de9d9bf1ad917f789e2dd68bc4"}],"neutron/tests/unit/agent/linux/openvswitch_firewall/test_firewall.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c94ba056601de579fed85e4a0052851532100f16","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                      table\u003dovs_consts.MCAST_INGRESS_TABLE),"},{"line_number":514,"context_line":"            mock.call(actions\u003d\u0027drop\u0027, priority\u003d0,"},{"line_number":515,"context_line":"                      table\u003dovs_consts.MCAST_RULES_INGRESS_TABLE),"},{"line_number":516,"context_line":"            ]"},{"line_number":517,"context_line":"        actual_calls \u003d self.firewall.int_br.br.add_flow.call_args_list"},{"line_number":518,"context_line":"        self.assertEqual(expected_calls, actual_calls)"},{"line_number":519,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_9ff9ce4f","line":516,"updated":"2020-09-07 11:24:22.000000000","message":"pep8: E123 closing bracket does not match indentation of opening bracket\u0027s line","commit_id":"10fda8a71561fe4cf949b1bdc41ec68feae538bc"}]}