)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8153ae76b3ebff40357b109c86a32071c032612","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lajos Katona \u003ckatonalala@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-28 12:48:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fullstack: Use smaller subnets to avoid clashes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie5db7c3c7e182aba07cd6da99c6c70b905f6de47"},{"line_number":10,"context_line":"Closes-Bug: #1893188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_2bfe1604","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":30},"updated":"2020-09-28 12:54:52.000000000","message":"Where are we creating smaller subnets? I though the goal of the patch was to create this subnet_create retry method. Maybe I\u0027m missing something","commit_id":"bc1d1ca612a297ca5b01d88b0e84f5f5524bb5e3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c993c2054aac8dff0be47b47c0d771c33c71a272","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lajos Katona \u003ckatonalala@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-28 12:48:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fullstack: Use smaller subnets to avoid clashes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie5db7c3c7e182aba07cd6da99c6c70b905f6de47"},{"line_number":10,"context_line":"Closes-Bug: #1893188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_81b7d021","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":30},"in_reply_to":"9f560f44_2bfe1604","updated":"2020-10-06 13:27:06.000000000","message":"Sorry I missed this comment in the rush.\nHere is the subnet reduction: \nipaddress.ip_network(cidr).subnets(prefixlen_diff\u003d4)\n(see: https://docs.python.org/3/library/ipaddress.html#ipaddress.IPv4Network.subnets ), so prefix /24 for example will be cut to /28 subnets and that will be tried in the cycle.","commit_id":"bc1d1ca612a297ca5b01d88b0e84f5f5524bb5e3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"62e2d19c787f8b267cba47b3c368118f1fabebb2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fullstack: Fetch created subnet in loop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case neutron-server raises BadRequest, try to list subnets for the"},{"line_number":10,"context_line":"given network in the hope that some internal delay causes the issue, but"},{"line_number":11,"context_line":"the subnet creation is ready."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie5db7c3c7e182aba07cd6da99c6c70b905f6de47"},{"line_number":14,"context_line":"Closes-Bug: #1893188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f560f44_5b2b817a","line":11,"range":{"start_line":9,"start_character":42,"end_line":11,"end_character":29},"updated":"2020-10-13 05:24:36.000000000","message":"this looks like we\u0027re not fully inderstanding the issue. What\u0027s internal delay here?","commit_id":"1bc13c6667e200775d7b347980f91081e391856b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a38bccf096f4a0b2f88b09378aca6491cfd39496","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fullstack: Fetch created subnet in loop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case neutron-server raises BadRequest, try to list subnets for the"},{"line_number":10,"context_line":"given network in the hope that some internal delay causes the issue, but"},{"line_number":11,"context_line":"the subnet creation is ready."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie5db7c3c7e182aba07cd6da99c6c70b905f6de47"},{"line_number":14,"context_line":"Closes-Bug: #1893188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f560f44_8df83ec1","line":11,"range":{"start_line":9,"start_character":42,"end_line":11,"end_character":29},"in_reply_to":"9f560f44_5b2b817a","updated":"2020-10-13 09:09:59.000000000","message":"You are right,\n\nPerhaps osprofiler results can help here:\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_94b/749041/12/check/neutron-rally-task/94b4a1f/results/report.html#/NeutronNetworks.create_and_delete_subnets/output","commit_id":"1bc13c6667e200775d7b347980f91081e391856b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f121fc91d4aac8ae38fbc2ef4c4ba2bd3dfc80c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fullstack: Fetch created subnet in loop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case neutron-server raises BadRequest, try to list subnets for the"},{"line_number":10,"context_line":"given network in the hope that some internal delay causes the issue, but"},{"line_number":11,"context_line":"the subnet creation is ready."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie5db7c3c7e182aba07cd6da99c6c70b905f6de47"},{"line_number":14,"context_line":"Closes-Bug: #1893188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7f6b1bfe_caf793d4","line":11,"range":{"start_line":9,"start_character":42,"end_line":11,"end_character":29},"in_reply_to":"9f560f44_8df83ec1","updated":"2020-10-13 15:25:54.000000000","message":"I\u0027m not sure if result from rally job will help us understand issue in fullstack test really as fullstack is working sligtly different way than \"regular\" deploymens (for example there is no keystone at all there).\nI would like to see similar issue again to try to investigate that first.\nI was trying to find it using logstash but I couldn\u0027t. I also didn\u0027t saw similar issues recently. So maybe it\u0027s not real issue for us now and we don\u0027t need that patch at all? Wdyt to wait a bit more until we will e.g. hit something like that again?","commit_id":"1bc13c6667e200775d7b347980f91081e391856b"}],"neutron/tests/fullstack/base.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f1f5de3d4f986d450280376591bbbf60592abb2d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import netaddr"},{"line_number":23,"context_line":"from neutronclient.common import exceptions as nc_exceptions"},{"line_number":24,"context_line":"from neutron_lib.tests import tools"},{"line_number":25,"context_line":"from oslo_config import cfg"},{"line_number":26,"context_line":"from oslo_log import log as logging"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_14bcdc6a","line":24,"updated":"2020-09-01 09:53:31.000000000","message":"pep8: H306: imports not in alphabetical order (neutronclient.common.exceptions, neutron_lib.tests.tools)","commit_id":"a9b38b00cd5d787cf2dbd8ecf28114b4179223b3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bfa248febe887ad2e7b3652f2d2e58311837cd6d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import netaddr"},{"line_number":23,"context_line":"from neutronclient.common import exceptions as nc_exceptions"},{"line_number":24,"context_line":"from neutron_lib.tests import tools"},{"line_number":25,"context_line":"from oslo_config import cfg"},{"line_number":26,"context_line":"from oslo_log import log as logging"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_75f1df95","line":24,"updated":"2020-08-31 16:01:37.000000000","message":"pep8: H306: imports not in alphabetical order (neutronclient.common.exceptions, neutron_lib.tests.tools)","commit_id":"a9b38b00cd5d787cf2dbd8ecf28114b4179223b3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8153ae76b3ebff40357b109c86a32071c032612","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            lambda: ip_lib.network_namespace_exists(ns_name,"},{"line_number":168,"context_line":"                                                    try_is_ready\u003dTrue))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def create_subnet_retry(self, tenant_id, network_id, cidr,"},{"line_number":171,"context_line":"                            max_attempts\u003d16, **kwargs):"},{"line_number":172,"context_line":"        attempts \u003d 0"},{"line_number":173,"context_line":"        for s_net in ipaddress.ip_network(cidr).subnets(prefixlen_diff\u003d4):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_700f5b38","line":170,"updated":"2020-09-28 12:54:52.000000000","message":"I think you can create this method in in fullstack.resources.client, same as create_subnet","commit_id":"bc1d1ca612a297ca5b01d88b0e84f5f5524bb5e3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c993c2054aac8dff0be47b47c0d771c33c71a272","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            lambda: ip_lib.network_namespace_exists(ns_name,"},{"line_number":168,"context_line":"                                                    try_is_ready\u003dTrue))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def create_subnet_retry(self, tenant_id, network_id, cidr,"},{"line_number":171,"context_line":"                            max_attempts\u003d16, **kwargs):"},{"line_number":172,"context_line":"        attempts \u003d 0"},{"line_number":173,"context_line":"        for s_net in ipaddress.ip_network(cidr).subnets(prefixlen_diff\u003d4):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_81b07042","line":170,"in_reply_to":"9f560f44_700f5b38","updated":"2020-10-06 13:27:06.000000000","message":"I moved it to client, perhaps it is a better place for it","commit_id":"bc1d1ca612a297ca5b01d88b0e84f5f5524bb5e3"}],"neutron/tests/fullstack/resources/client.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f11c3f4619daa61f1c24fd8f0843339caf28182f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                    network_id\u003dnetwork_id,"},{"line_number":142,"context_line":"                    cidr\u003dstr(s_net),"},{"line_number":143,"context_line":"                    **kwargs"},{"line_number":144,"context_line":"                )"},{"line_number":145,"context_line":"            except exceptions.BadRequest:"},{"line_number":146,"context_line":"                attempts +\u003d 1"},{"line_number":147,"context_line":"                if attempts \u003e max_attempts:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_488f792d","line":144,"updated":"2020-10-08 08:11:52.000000000","message":"according to the fact that in fullstack tests each test in fact has got own neutron-server and own db, there is no way that some other test will create resources which overlays with resources created in \"our\" test.\nSo I suspect that the issue described in the related bug is more due to fact that create_subnet POST request was processed for long time and it was retried already (something what we have seen pretty often in e.g. some tempest jobs).\nAnd if my undestanding is true, we will end up here with 2 subnets created in the same network, which may lead to some other unpredictable failures in the future.\nSo maybe, instead of retrying here creation of subnet, we should in the except block try to get subnet for specific network, compare it\u0027s cidr (and maybe other attributes which were given) and simply return that subnet if it exists.","commit_id":"b52412ab59d859c2f18b0bb6241dcb11c89a7d10"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6afb325bc0fb94a8dc3dc9d44871716483fc239e","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                    network_id\u003dnetwork_id,"},{"line_number":142,"context_line":"                    cidr\u003dstr(s_net),"},{"line_number":143,"context_line":"                    **kwargs"},{"line_number":144,"context_line":"                )"},{"line_number":145,"context_line":"            except exceptions.BadRequest:"},{"line_number":146,"context_line":"                attempts +\u003d 1"},{"line_number":147,"context_line":"                if attempts \u003e max_attempts:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_e51b13c8","line":144,"in_reply_to":"9f560f44_488f792d","updated":"2020-10-08 13:23:56.000000000","message":"hmmm, I check this","commit_id":"b52412ab59d859c2f18b0bb6241dcb11c89a7d10"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f175daf7c13a483413e29cdbe2fcff79c5794233","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return self._create_resource(resource_type, spec)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def create_subnet_retry(self, tenant_id, network_id, cidr,"},{"line_number":134,"context_line":"                            max_attempts\u003d16, **kwargs):"},{"line_number":135,"context_line":"        try:"},{"line_number":136,"context_line":"            return self.create_subnet("}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_82f31b9f","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":27},"updated":"2020-10-09 12:59:34.000000000","message":"I think this name is still good, but if you have a better name, please suggest","commit_id":"1bc13c6667e200775d7b347980f91081e391856b"}]}