)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8c34d8aa2d4e06fd9e9359bf0d7f44b9e41b9406","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-09-01 18:13:29 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add support record domain from neutron network as dhcp domain options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0820f92afbc876ce6df7304739e7982a768a13a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_39eaa7d7","line":8,"updated":"2020-09-02 03:50:38.000000000","message":"please limit 1st line to 50 chars. Also please add link to the bug (Closes-Bug: #\u003cid\u003e) so everyone understands the context and for the bug to get link to this fix. More details on commit messages: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ea4f86286dd72b8528b5590ebff6389deabd8b0a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"99b52f4d0ce0d81a5152a519a0ce705d427812d2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-09-01 18:13:29 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add support record domain from neutron network as dhcp domain options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0820f92afbc876ce6df7304739e7982a768a13a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_7ebd20d6","line":8,"in_reply_to":"9f560f44_39eaa7d7","updated":"2020-09-02 09:07:08.000000000","message":"+1\nCloses-Bug: #1893802","commit_id":"ea4f86286dd72b8528b5590ebff6389deabd8b0a"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8c34d8aa2d4e06fd9e9359bf0d7f44b9e41b9406","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        if self.network.dns_domain:"},{"line_number":469,"context_line":"            cmd.append(\u0027--domain\u003d%s\u0027 % self.network.dns_domain)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if self.network.dns_domain \u003d\u003d None or self.network.dns_domain \u003d\u003d \"\" :"},{"line_number":472,"context_line":"            if self.conf.dns_domain:"},{"line_number":473,"context_line":"                cmd.append(\u0027--domain\u003d%s\u0027 % self.conf.dns_domain)"},{"line_number":474,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_79bd3fd6","line":471,"range":{"start_line":471,"start_character":8,"end_line":471,"end_character":77},"updated":"2020-09-02 03:50:38.000000000","message":"if not self.network.dns_domain:","commit_id":"ea4f86286dd72b8528b5590ebff6389deabd8b0a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6f7e829556f25b025b422ad3ddc95616948db4ec","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        if self.network.dns_domain:"},{"line_number":469,"context_line":"            cmd.append(\u0027--domain\u003d%s\u0027 % self.network.dns_domain)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if self.network.dns_domain \u003d\u003d None or self.network.dns_domain \u003d\u003d \"\" :"},{"line_number":472,"context_line":"            if self.conf.dns_domain:"},{"line_number":473,"context_line":"                cmd.append(\u0027--domain\u003d%s\u0027 % self.conf.dns_domain)"},{"line_number":474,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_086b131f","line":471,"updated":"2020-09-01 21:43:57.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"ea4f86286dd72b8528b5590ebff6389deabd8b0a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6f7e829556f25b025b422ad3ddc95616948db4ec","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        if self.network.dns_domain:"},{"line_number":469,"context_line":"            cmd.append(\u0027--domain\u003d%s\u0027 % self.network.dns_domain)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if self.network.dns_domain \u003d\u003d None or self.network.dns_domain \u003d\u003d \"\" :"},{"line_number":472,"context_line":"            if self.conf.dns_domain:"},{"line_number":473,"context_line":"                cmd.append(\u0027--domain\u003d%s\u0027 % self.conf.dns_domain)"},{"line_number":474,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a884a7d4","line":471,"updated":"2020-09-01 21:43:57.000000000","message":"pep8: E711 comparison to None should be \u0027if cond is None:\u0027","commit_id":"ea4f86286dd72b8528b5590ebff6389deabd8b0a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7acba37f1cafecfe4a667ed1b921df6fa4dc1df5","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if self.network.dns_domain \u003d\u003d None or self.network.dns_domain \u003d\u003d \"\" :"},{"line_number":472,"context_line":"            if self.conf.dns_domain:"},{"line_number":473,"context_line":"                cmd.append(\u0027--domain\u003d%s\u0027 % self.conf.dns_domain)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        if self.conf.dhcp_broadcast_reply:"},{"line_number":476,"context_line":"            cmd.append(\u0027--dhcp-broadcast\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_58cafe6d","line":473,"updated":"2020-09-01 16:24:22.000000000","message":"These changes look like they will re-introduce an issue we had to revert last year with https://review.opendev.org/#/c/657806/","commit_id":"ea4f86286dd72b8528b5590ebff6389deabd8b0a"},{"author":{"_account_id":32372,"name":"StreSS.t","email":"stress.t@gmail.com","username":"stress_t"},"change_message_id":"94e35c6828983f96fe6e586d892a41b71348f739","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if self.network.dns_domain \u003d\u003d None or self.network.dns_domain \u003d\u003d \"\" :"},{"line_number":472,"context_line":"            if self.conf.dns_domain:"},{"line_number":473,"context_line":"                cmd.append(\u0027--domain\u003d%s\u0027 % self.conf.dns_domain)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        if self.conf.dhcp_broadcast_reply:"},{"line_number":476,"context_line":"            cmd.append(\u0027--dhcp-broadcast\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bf5a1f80","line":473,"in_reply_to":"9f560f44_58cafe6d","updated":"2020-09-01 19:42:38.000000000","message":"If I set dns_domain in the config file, it\u0027s ok that I have the zone option in dhcp. But if I set dns_domain for some network, I really want to see this dns_domain for that network in dhcp options.\nAm i wrong?","commit_id":"ea4f86286dd72b8528b5590ebff6389deabd8b0a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2abced9a678d2278eceb49322f1da73e093f815f","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if self.network.dns_domain \u003d\u003d None or self.network.dns_domain \u003d\u003d \"\" :"},{"line_number":472,"context_line":"            if self.conf.dns_domain:"},{"line_number":473,"context_line":"                cmd.append(\u0027--domain\u003d%s\u0027 % self.conf.dns_domain)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        if self.conf.dhcp_broadcast_reply:"},{"line_number":476,"context_line":"            cmd.append(\u0027--dhcp-broadcast\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e5208afb","line":473,"in_reply_to":"9f560f44_bf5a1f80","updated":"2020-09-01 20:30:08.000000000","message":"Can you add Miguel to this review?  I don\u0027t have the context of this more recent change but did remember the one that broke things and needed to be reverted.  Just didn\u0027t want it to merge by accident.","commit_id":"ea4f86286dd72b8528b5590ebff6389deabd8b0a"}]}