)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"2be14ff6d1b8677b4a5b0e379d3992a2e2021e38","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix DetachedInstanceError for Agent instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The stacktrace observed seems to hint to a"},{"line_number":10,"context_line":"situation where a session is not properly"},{"line_number":11,"context_line":"rolled back when duplicate agent entries are"},{"line_number":12,"context_line":"found."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAVn%2F%2FasE%3D","line":9,"updated":"2014-03-06 07:40:03.000000000","message":"I think you should line wrap this even more :)","commit_id":"237746a6d63c96726e7966770a602b62205ee333"}],"neutron/scheduler/dhcp_agent_scheduler.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"bd0063f7a68d1ce23ad376df83e5d011faeeb6d4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                context.session.commit()"},{"line_number":49,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":50,"context_line":"                # it\u0027s totally ok, someone just did our job!"},{"line_number":51,"context_line":"                LOG.warn(_(\u0027Agent %s already present\u0027), agent)"},{"line_number":52,"context_line":"                context.session.rollback()"},{"line_number":53,"context_line":"            LOG.debug(_(\u0027Network %(network_id)s is scheduled to be \u0027"},{"line_number":54,"context_line":"                        \u0027hosted by DHCP agent %(agent_id)s\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Bae8%3D","line":51,"updated":"2014-02-21 10:09:38.000000000","message":"i don\u0027t think it worth issuing a warning; it doesn\u0027t look like a condition to worry about.","commit_id":"d5e922915a38737ada205332c40364d594b6a1ea"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"81ddc28f4c384c68f166b37a04c46929673549a0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                context.session.commit()"},{"line_number":49,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":50,"context_line":"                # it\u0027s totally ok, someone just did our job!"},{"line_number":51,"context_line":"                LOG.warn(_(\u0027Agent %s already present\u0027), agent)"},{"line_number":52,"context_line":"                context.session.rollback()"},{"line_number":53,"context_line":"            LOG.debug(_(\u0027Network %(network_id)s is scheduled to be \u0027"},{"line_number":54,"context_line":"                        \u0027hosted by DHCP agent %(agent_id)s\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BWj0%3D","line":51,"in_reply_to":"AAAAUX%2F%2Bae8%3D","updated":"2014-02-21 17:24:32.000000000","message":"I wanted to have a trace in the log to show me that we did get in the except block. I can lower it to info.","commit_id":"d5e922915a38737ada205332c40364d594b6a1ea"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"421be1306d6a6228c762ac3b86d6ff76bbb2ec1a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _schedule_bind_network(self, context, agents, network_id):"},{"line_number":39,"context_line":"        for agent in agents:"},{"line_number":40,"context_line":"            context.session.begin(subtransactions\u003dTrue)"},{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                binding \u003d agentschedulers_db.NetworkDhcpAgentBinding()"},{"line_number":43,"context_line":"                binding.dhcp_agent \u003d agent"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2Fqzo%3D","line":40,"updated":"2014-03-01 12:13:30.000000000","message":"Can\u0027t we use with-clause here? I think if an exception occurs in with-clause, the transaction will be rollback.","commit_id":"237746a6d63c96726e7966770a602b62205ee333"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"34763f354553302cb0a1d346a5b88425d1360136","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _schedule_bind_network(self, context, agents, network_id):"},{"line_number":39,"context_line":"        for agent in agents:"},{"line_number":40,"context_line":"            context.session.begin(subtransactions\u003dTrue)"},{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                binding \u003d agentschedulers_db.NetworkDhcpAgentBinding()"},{"line_number":43,"context_line":"                binding.dhcp_agent \u003d agent"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FizE%3D","line":40,"in_reply_to":"AAAAVX%2F%2Fpds%3D","updated":"2014-03-05 14:08:24.000000000","message":"No problem. We usually use with-clause for this case and I thought keeping consistency would be better.","commit_id":"237746a6d63c96726e7966770a602b62205ee333"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bd863647d8ac5b4b20d57b99e03afb32eec43a2a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _schedule_bind_network(self, context, agents, network_id):"},{"line_number":39,"context_line":"        for agent in agents:"},{"line_number":40,"context_line":"            context.session.begin(subtransactions\u003dTrue)"},{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                binding \u003d agentschedulers_db.NetworkDhcpAgentBinding()"},{"line_number":43,"context_line":"                binding.dhcp_agent \u003d agent"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2Fpds%3D","line":40,"in_reply_to":"AAAAVX%2F%2Fqzo%3D","updated":"2014-03-02 01:18:27.000000000","message":"we can, but this does exactly the same thing.","commit_id":"237746a6d63c96726e7966770a602b62205ee333"}]}