)]}'
{"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"d874ad25a4ade8ff17bb92fafb4867bd6235d0ab","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # TODO(matrohon): revisit once the original bound segment will be"},{"line_number":47,"context_line":"        # available in delete_port_postcommit. in delete_port_postcommit"},{"line_number":48,"context_line":"        # agent_active_ports will be equal to 0, and the code could be"},{"line_number":49,"context_line":"        # shared again with _update_port_down"},{"line_number":50,"context_line":"        port_context \u003d context.current"},{"line_number":51,"context_line":"        port_infos \u003d self._get_port_infos(context, port_context)"},{"line_number":52,"context_line":"        if not port_infos:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F%2B%2BM%3D","line":49,"updated":"2014-02-23 03:41:33.000000000","message":"I don\u0027t fully understand why _update_port_down cannot be used here since it seems like the number of agent_active_ports is the only difference here. Maybe I miss something but can we just pass agent_active_ports as a parameter to avoid the code duplication?","commit_id":"4081feb81f8430715b8262b5fcbc58a096eb84d8"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8deac5c2f08f15bd251bbcb094734f3007faf100","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # TODO(matrohon): revisit once the original bound segment will be"},{"line_number":47,"context_line":"        # available in delete_port_postcommit. in delete_port_postcommit"},{"line_number":48,"context_line":"        # agent_active_ports will be equal to 0, and the code could be"},{"line_number":49,"context_line":"        # shared again with _update_port_down"},{"line_number":50,"context_line":"        port_context \u003d context.current"},{"line_number":51,"context_line":"        port_infos \u003d self._get_port_infos(context, port_context)"},{"line_number":52,"context_line":"        if not port_infos:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F9RQ%3D","line":49,"in_reply_to":"AAAAU3%2F%2F%2B%2BM%3D","updated":"2014-02-23 14:49:03.000000000","message":"I agree, this code duplication is completely unnecessary.","commit_id":"4081feb81f8430715b8262b5fcbc58a096eb84d8"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"04094d684ce2293461f0e7056da2508af12d6134","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # TODO(matrohon): revisit once the original bound segment will be"},{"line_number":47,"context_line":"        # available in delete_port_postcommit. in delete_port_postcommit"},{"line_number":48,"context_line":"        # agent_active_ports will be equal to 0, and the code could be"},{"line_number":49,"context_line":"        # shared again with _update_port_down"},{"line_number":50,"context_line":"        port_context \u003d context.current"},{"line_number":51,"context_line":"        port_infos \u003d self._get_port_infos(context, port_context)"},{"line_number":52,"context_line":"        if not port_infos:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F16k%3D","line":49,"in_reply_to":"AAAAU3%2F%2F9RQ%3D","updated":"2014-02-24 14:50:07.000000000","message":"Done","commit_id":"4081feb81f8430715b8262b5fcbc58a096eb84d8"}],"neutron/tests/unit/ml2/drivers/test_l2population.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"c8b3bb5b1900004c389f28e6fd5b6d0731fcaa67","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        with self.subnet(network\u003dself._network) as subnet:"},{"line_number":384,"context_line":"            host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":385,"context_line":"            with self.port(subnet\u003dsubnet,"},{"line_number":386,"context_line":"                           arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":387,"context_line":"                           **host_arg):"},{"line_number":388,"context_line":"                with self.port(subnet\u003dsubnet,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FpWQ%3D","line":385,"updated":"2014-02-25 13:52:30.000000000","message":"why do we need to create two ports here since we are testing the \"last\" up port?","commit_id":"043b4dde00216e71e855ff353e41695e4ed940a9"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"f66c5e3abc73e598057ea9d65aab2b5d5af163c7","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        with self.subnet(network\u003dself._network) as subnet:"},{"line_number":384,"context_line":"            host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":385,"context_line":"            with self.port(subnet\u003dsubnet,"},{"line_number":386,"context_line":"                           arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":387,"context_line":"                           **host_arg):"},{"line_number":388,"context_line":"                with self.port(subnet\u003dsubnet,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FoCM%3D","line":385,"in_reply_to":"AAAAU3%2F%2FolM%3D","updated":"2014-02-25 15:41:59.000000000","message":"Thanks for the clarification.","commit_id":"043b4dde00216e71e855ff353e41695e4ed940a9"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"476ad3f18f77b8c2c5611f4b8b7ab2cb8f0404f6","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        with self.subnet(network\u003dself._network) as subnet:"},{"line_number":384,"context_line":"            host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":385,"context_line":"            with self.port(subnet\u003dsubnet,"},{"line_number":386,"context_line":"                           arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":387,"context_line":"                           **host_arg):"},{"line_number":388,"context_line":"                with self.port(subnet\u003dsubnet,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FolM%3D","line":385,"in_reply_to":"AAAAU3%2F%2FpWQ%3D","updated":"2014-02-25 15:03:41.000000000","message":"this will also test that even if another port exists on the same host, the flooding entry will be sent if this port is down. Otherwise, this case won\u0027t be tested.","commit_id":"043b4dde00216e71e855ff353e41695e4ed940a9"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"c8b3bb5b1900004c389f28e6fd5b6d0731fcaa67","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":466,"context_line":"            with self.port(subnet\u003dsubnet,"},{"line_number":467,"context_line":"                           arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":468,"context_line":"                           **host_arg):"},{"line_number":469,"context_line":"                with self.port(subnet\u003dsubnet,"},{"line_number":470,"context_line":"                               arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":471,"context_line":"                               **host_arg) as port:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FpV4%3D","line":468,"updated":"2014-02-25 13:52:30.000000000","message":"Same question above.","commit_id":"043b4dde00216e71e855ff353e41695e4ed940a9"}]}