)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d68a6900a8b80f04be077946f6f00f5b74e67e4d","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"    # raise AgentNotFound if this isn\u0027t an ml2/ovn-related agent"},{"line_number":1257,"context_line":"    agent \u003d get_agent(self, None, id, _driver\u003d_driver)"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    # NOTE(twilson) According to the API docs, an agent must be disabled before"},{"line_number":1260,"context_line":"    # before deletion. Otherwise, behavior seems to be undefined. We could"},{"line_number":1261,"context_line":"    # check that alive\u003dFalse before allowing deletion, but depending on the"},{"line_number":1262,"context_line":"    # agent_down_time setting, that could take quite a while."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ee2bc27e","line":1259,"range":{"start_line":1259,"start_character":73,"end_line":1259,"end_character":79},"updated":"2020-09-10 08:32:17.000000000","message":"before is here twice","commit_id":"73eb8d80fedb879939a0f78cccafda8b82baf18a"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"28c1448de9f66589b5fc59d7c37c454f2f4c2fb4","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"    # raise AgentNotFound if this isn\u0027t an ml2/ovn-related agent"},{"line_number":1257,"context_line":"    agent \u003d get_agent(self, None, id, _driver\u003d_driver)"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    # NOTE(twilson) According to the API docs, an agent must be disabled before"},{"line_number":1260,"context_line":"    # before deletion. Otherwise, behavior seems to be undefined. We could"},{"line_number":1261,"context_line":"    # check that alive\u003dFalse before allowing deletion, but depending on the"},{"line_number":1262,"context_line":"    # agent_down_time setting, that could take quite a while."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_01b3640b","line":1259,"range":{"start_line":1259,"start_character":73,"end_line":1259,"end_character":79},"in_reply_to":"9f560f44_ee2bc27e","updated":"2020-09-10 13:26:06.000000000","message":"Mostly it\u0027s the fact that it annoys me that deleting the Controller/Controller Gateway agent will cause the Metadata agent to be deleted. So the test very specifically had to order the agent_types to pass. :p I was imagining a situation where a user did a single \u0027openstack network agent list\u0027, saw the controller and metadata agents, then did \u0027openstack network agent delete $controller\u0027 and then \u0027openstack network agent delete $agent\u0027 and then got an error because the metadata disappeared automatically.\n\nAlso, you have sharp eyes. :)","commit_id":"73eb8d80fedb879939a0f78cccafda8b82baf18a"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"98bc90d81510f162106b36b38f9c6534afb9543a","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        # metadata agent as well."},{"line_number":1279,"context_line":"        _driver._sb_ovn.chassis_del(chassis_name, if_exists\u003dTrue).execute("},{"line_number":1280,"context_line":"            check_error\u003dTrue)"},{"line_number":1281,"context_line":"        del AGENTS[chassis_name]"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"def create_default_drop_port_group(nb_idl):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_afcdad87","line":1281,"updated":"2020-09-18 13:35:53.000000000","message":"This del only works on the API process that receives the requests. The cached chassis will not be deleted from other API workers.","commit_id":"992c9fb822f7e8bf77d1f0a97f98fb5047efbb93"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d68a6900a8b80f04be077946f6f00f5b74e67e4d","unresolved":false,"context_lines":[{"line_number":752,"context_line":"        super().setUp()"},{"line_number":753,"context_line":"        self.plugin \u003d self.mech_driver._plugin"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    def create_chassis_and_agents(self, host\u003dNone):"},{"line_number":756,"context_line":"        if host is None:"},{"line_number":757,"context_line":"            host \u003d n_utils.get_rand_name(prefix\u003d\u0027testhost-\u0027)"},{"line_number":758,"context_line":"        chassis \u003d self.add_fake_chassis("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ae426a39","line":755,"range":{"start_line":755,"start_character":40,"end_line":755,"end_character":49},"updated":"2020-09-10 08:32:17.000000000","message":"We never use the parameter so perhaps we can remove it","commit_id":"73eb8d80fedb879939a0f78cccafda8b82baf18a"}]}