)]}'
{"neutron/objects/base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0399f659554cf8408def511d54d130ee61ebf78d","unresolved":false,"context_lines":[{"line_number":903,"context_line":"                    self.modify_fields_to_db(updates),"},{"line_number":904,"context_line":"                    **self.modify_fields_to_db("},{"line_number":905,"context_line":"                        self._get_composite_keys()))"},{"line_number":906,"context_line":"            except obj_exc.DBDuplicateEntry as db_exc:"},{"line_number":907,"context_line":"                raise o_exc.NeutronDbObjectDuplicateEntry("},{"line_number":908,"context_line":"                    object_class\u003dself.__class__, db_exception\u003ddb_exc)"},{"line_number":909,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e28dce31","line":906,"updated":"2020-09-22 10:53:57.000000000","message":"This should be implemented only in class PortForwarding(base.NeutronDbObject) [1], not in the base class.\n\n[1]https://github.com/openstack/neutron/blob/cb95815649c4b7cd4534fd125c9d74387a990442/neutron/objects/port_forwarding.py#L32","commit_id":"0a04eac61800da9a6b74f054f5edc31ec31d52e4"},{"author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"change_message_id":"cb5024a3457bfa18a20d6b6f766f3ddab7e5cca7","unresolved":false,"context_lines":[{"line_number":903,"context_line":"                    self.modify_fields_to_db(updates),"},{"line_number":904,"context_line":"                    **self.modify_fields_to_db("},{"line_number":905,"context_line":"                        self._get_composite_keys()))"},{"line_number":906,"context_line":"            except obj_exc.DBDuplicateEntry as db_exc:"},{"line_number":907,"context_line":"                raise o_exc.NeutronDbObjectDuplicateEntry("},{"line_number":908,"context_line":"                    object_class\u003dself.__class__, db_exception\u003ddb_exc)"},{"line_number":909,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0278c2f5","line":906,"in_reply_to":"9f560f44_e28dce31","updated":"2020-09-22 11:05:42.000000000","message":"I mainly refer to the implementation of create and keep it consistent","commit_id":"0a04eac61800da9a6b74f054f5edc31ec31d52e4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0399f659554cf8408def511d54d130ee61ebf78d","unresolved":false,"context_lines":[{"line_number":904,"context_line":"                    **self.modify_fields_to_db("},{"line_number":905,"context_line":"                        self._get_composite_keys()))"},{"line_number":906,"context_line":"            except obj_exc.DBDuplicateEntry as db_exc:"},{"line_number":907,"context_line":"                raise o_exc.NeutronDbObjectDuplicateEntry("},{"line_number":908,"context_line":"                    object_class\u003dself.__class__, db_exception\u003ddb_exc)"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"            self.from_db_object(db_obj)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2299866c","line":907,"range":{"start_line":907,"start_character":16,"end_line":907,"end_character":58},"updated":"2020-09-22 10:53:57.000000000","message":"This is not the best and most descriptive exception to raise if we have a duplicated external_port.\n\nBTW, this bug could be extended to the internal port too (socket).","commit_id":"0a04eac61800da9a6b74f054f5edc31ec31d52e4"}]}