)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4505b90bbc1c4d535f47596fef3aef13f0fe1d82","unresolved":false,"context_lines":[{"line_number":12,"context_line":"create networks, bypassing the layer that inserts this default value."},{"line_number":13,"context_line":"Commit 68625686a40b3eb75502c8116f23d2297e288ca1 introduced a different"},{"line_number":14,"context_line":"default value at the DB layer, defined by a constant in neutron-lib."},{"line_number":15,"context_line":"If the maximum MTU size has been configured lower than this constant,"},{"line_number":16,"context_line":"then the user receives an exception, even though they didn\u0027t provide"},{"line_number":17,"context_line":"a value for MTU."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch changes the default value used in the DB layer, so that"},{"line_number":20,"context_line":"it\u0027s consistent with the workflow seen via REST APIs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_d2baeabd","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":16},"updated":"2020-09-24 05:59:03.000000000","message":"Could you file a bug for this?","commit_id":"152db28d33e6ebea65e3ebdfffcdaf2b273c3f6a"},{"author":{"_account_id":18031,"name":"Thomas Bachman","email":"tbachman@yahoo.com","username":"bachmantech"},"change_message_id":"dbfdddc94b3ef3b8cac951b4e2b99529b3dc7fd6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"create networks, bypassing the layer that inserts this default value."},{"line_number":13,"context_line":"Commit 68625686a40b3eb75502c8116f23d2297e288ca1 introduced a different"},{"line_number":14,"context_line":"default value at the DB layer, defined by a constant in neutron-lib."},{"line_number":15,"context_line":"If the maximum MTU size has been configured lower than this constant,"},{"line_number":16,"context_line":"then the user receives an exception, even though they didn\u0027t provide"},{"line_number":17,"context_line":"a value for MTU."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch changes the default value used in the DB layer, so that"},{"line_number":20,"context_line":"it\u0027s consistent with the workflow seen via REST APIs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_44fc5471","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":16},"in_reply_to":"9f560f44_d2baeabd","updated":"2020-09-24 10:34:10.000000000","message":"Done (Bug ID: 1896933). Also added to the commit message.","commit_id":"152db28d33e6ebea65e3ebdfffcdaf2b273c3f6a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5cba2bdc9267249eb73b25caa3f99faeb0ebf8ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a43909b5_50f23ba0","updated":"2023-01-16 12:17:00.000000000","message":"oops.. I did not noticed that you already rechecked it. I hope that is not going to create error","commit_id":"f759915ab0c30ebba6d3d970943b596b5c245599"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"57cf1ee93b6850e85b1bec94139f49ff70e08196","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99bda0fa_929f95bc","updated":"2023-01-16 12:16:20.000000000","message":"recheck","commit_id":"f759915ab0c30ebba6d3d970943b596b5c245599"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"47c3e0080b662aa1898132b0fa1af5410b1c672d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf7178ac_7c0ac70e","updated":"2023-01-16 10:15:23.000000000","message":"recheck fullstack timeout","commit_id":"f759915ab0c30ebba6d3d970943b596b5c245599"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63e0f4df65bf959306c90c3458b94cf1829fe92d","unresolved":true,"context_lines":[{"line_number":402,"context_line":"            args \u003d {\u0027tenant_id\u0027: n[\u0027tenant_id\u0027],"},{"line_number":403,"context_line":"                    \u0027id\u0027: n.get(\u0027id\u0027) or uuidutils.generate_uuid(),"},{"line_number":404,"context_line":"                    \u0027name\u0027: n[\u0027name\u0027],"},{"line_number":405,"context_line":"                    \u0027mtu\u0027: n.get(\u0027mtu\u0027, 0),"},{"line_number":406,"context_line":"                    \u0027admin_state_up\u0027: n[\u0027admin_state_up\u0027],"},{"line_number":407,"context_line":"                    \u0027status\u0027: n.get(\u0027status\u0027, constants.NET_STATUS_ACTIVE),"},{"line_number":408,"context_line":"                    \u0027description\u0027: n.get(\u0027description\u0027)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"6e6d3713_66c53b60","line":405,"updated":"2021-01-21 15:55:28.000000000","message":"Agree, as you said, rest calls will set 0 by default.\n\nIf this parameter is not set, should be 0. Then Ml2plugin._create_network_db --\u003e _get_network_mtu should be responsible of reading the MTU values from the segments or the physical network.\n\nIMO we should also backport this patch to older branches (U, V) where [1] is also included to keep the previous behavior.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/679399","commit_id":"c5c6965916c822459c48f07a054a469fc05453d9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"57cf1ee93b6850e85b1bec94139f49ff70e08196","unresolved":true,"context_lines":[{"line_number":402,"context_line":"            args \u003d {\u0027tenant_id\u0027: n[\u0027tenant_id\u0027],"},{"line_number":403,"context_line":"                    \u0027id\u0027: n.get(\u0027id\u0027) or uuidutils.generate_uuid(),"},{"line_number":404,"context_line":"                    \u0027name\u0027: n[\u0027name\u0027],"},{"line_number":405,"context_line":"                    \u0027mtu\u0027: n.get(\u0027mtu\u0027, 0),"},{"line_number":406,"context_line":"                    \u0027admin_state_up\u0027: n[\u0027admin_state_up\u0027],"},{"line_number":407,"context_line":"                    \u0027status\u0027: n.get(\u0027status\u0027, constants.NET_STATUS_ACTIVE),"},{"line_number":408,"context_line":"                    \u0027description\u0027: n.get(\u0027description\u0027)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"687076de_f3a65ea4","line":405,"in_reply_to":"1ee42045_59703f0b","updated":"2023-01-16 12:16:20.000000000","message":"I would have added a comment here to share how it is expected to behave","commit_id":"c5c6965916c822459c48f07a054a469fc05453d9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"253d9fb25b03287edd8de9c4a9c38686ab0c0b70","unresolved":true,"context_lines":[{"line_number":402,"context_line":"            args \u003d {\u0027tenant_id\u0027: n[\u0027tenant_id\u0027],"},{"line_number":403,"context_line":"                    \u0027id\u0027: n.get(\u0027id\u0027) or uuidutils.generate_uuid(),"},{"line_number":404,"context_line":"                    \u0027name\u0027: n[\u0027name\u0027],"},{"line_number":405,"context_line":"                    \u0027mtu\u0027: n.get(\u0027mtu\u0027, 0),"},{"line_number":406,"context_line":"                    \u0027admin_state_up\u0027: n[\u0027admin_state_up\u0027],"},{"line_number":407,"context_line":"                    \u0027status\u0027: n.get(\u0027status\u0027, constants.NET_STATUS_ACTIVE),"},{"line_number":408,"context_line":"                    \u0027description\u0027: n.get(\u0027description\u0027)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ee42045_59703f0b","line":405,"in_reply_to":"6e6d3713_66c53b60","updated":"2021-01-23 10:21:12.000000000","message":"I think it\u0027s ok to set 0 as default value here. It should then be set properly based on get_mtu() method from the type driver","commit_id":"c5c6965916c822459c48f07a054a469fc05453d9"}]}
