)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"894eb76be69766e232d3a5c76040ef285042bf2f","unresolved":true,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @classmethod"},{"line_number":169,"context_line":"    def schema_helper(cls):"},{"line_number":170,"context_line":"        return super().schema_helper(cfg.get_ovn_nb_connection())"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @classmethod"},{"line_number":173,"context_line":"    def from_worker(cls, worker_class, driver\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"f6c78c54_232292b3","line":170,"updated":"2021-01-15 14:28:11.000000000","message":"same here","commit_id":"d1ad4e94ba29648f41919c7b455f2a1f2c3acf17"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"77c8edd10c6967e108cf984666f2b1c985d261f9","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @classmethod"},{"line_number":169,"context_line":"    def schema_helper(cls):"},{"line_number":170,"context_line":"        return super().schema_helper(cfg.get_ovn_nb_connection())"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @classmethod"},{"line_number":173,"context_line":"    def from_worker(cls, worker_class, driver\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fe012f5f_32fc99d9","line":170,"in_reply_to":"f6c78c54_232292b3","updated":"2021-01-29 17:30:15.000000000","message":"Done","commit_id":"d1ad4e94ba29648f41919c7b455f2a1f2c3acf17"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"894eb76be69766e232d3a5c76040ef285042bf2f","unresolved":true,"context_lines":[{"line_number":751,"context_line":"        super(OvsdbSbOvnIdl, self).__init__(connection)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    @classmethod"},{"line_number":754,"context_line":"    def schema_helper(cls):"},{"line_number":755,"context_line":"        return super().schema_helper(cfg.get_ovn_sb_connection())"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"b7b5c782_249b4bfa","line":754,"updated":"2021-01-15 14:28:11.000000000","message":"small nit: instead of overriding this method with a different signature, I would have called it providing the input parameter.\n\nBut this is just a nit.","commit_id":"d1ad4e94ba29648f41919c7b455f2a1f2c3acf17"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"77c8edd10c6967e108cf984666f2b1c985d261f9","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        super(OvsdbSbOvnIdl, self).__init__(connection)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    @classmethod"},{"line_number":754,"context_line":"    def schema_helper(cls):"},{"line_number":755,"context_line":"        return super().schema_helper(cfg.get_ovn_sb_connection())"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"df627d9d_5cdbc775","line":754,"in_reply_to":"67fa5ad4_80e31722","updated":"2021-01-29 17:30:15.000000000","message":"Done","commit_id":"d1ad4e94ba29648f41919c7b455f2a1f2c3acf17"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f387291f62b8c8e7d540f5d658ce648a08e78804","unresolved":true,"context_lines":[{"line_number":751,"context_line":"        super(OvsdbSbOvnIdl, self).__init__(connection)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    @classmethod"},{"line_number":754,"context_line":"    def schema_helper(cls):"},{"line_number":755,"context_line":"        return super().schema_helper(cfg.get_ovn_sb_connection())"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"67fa5ad4_80e31722","line":754,"in_reply_to":"b7b5c782_249b4bfa","updated":"2021-01-29 00:29:45.000000000","message":"Went ahead and changed it to have a \"classproperty\" for connection_string that subclasses would define, and then made schema_helper a one as well.","commit_id":"d1ad4e94ba29648f41919c7b455f2a1f2c3acf17"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f76b6b428be8b01b72309b44f60ccf58b4e00ec5","unresolved":true,"context_lines":[{"line_number":597,"context_line":"                                          self._fip_create_delete_event])"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @classmethod"},{"line_number":600,"context_line":"    def from_server(cls, connection_string, helper, driver):"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        helper.register_all()"},{"line_number":603,"context_line":"        return cls(driver, connection_string, helper)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3b0af32e_05624c74","line":600,"range":{"start_line":600,"start_character":44,"end_line":600,"end_character":50},"updated":"2020-11-23 09:50:03.000000000","message":"this change will break ovn-octavia-provider https://opendev.org/openstack/ovn-octavia-provider/src/branch/master/ovn_octavia_provider/ovsdb/impl_idl_ovn.py#L159 so You should probably propose patch there too.","commit_id":"653730a49a5ac596e534631dfb87458fe50e3f31"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"77c8edd10c6967e108cf984666f2b1c985d261f9","unresolved":true,"context_lines":[{"line_number":597,"context_line":"                                          self._fip_create_delete_event])"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @classmethod"},{"line_number":600,"context_line":"    def from_server(cls, connection_string, helper, driver):"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        helper.register_all()"},{"line_number":603,"context_line":"        return cls(driver, connection_string, helper)"}],"source_content_type":"text/x-python","patch_set":9,"id":"6cd41f5d_9f9749f9","line":600,"range":{"start_line":600,"start_character":44,"end_line":600,"end_character":50},"in_reply_to":"3b0af32e_05624c74","updated":"2021-01-29 17:30:15.000000000","message":"Will it break, or is it that it could also be enhanced like this? from_server() is usually overridden and super() never called. And the __init__() hasn\u0027t changed and it looks like it handles it\u0027s own schema helper stuff.","commit_id":"653730a49a5ac596e534631dfb87458fe50e3f31"}],"neutron/tests/functional/base.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"da3b0a53d986c6e497d9f3bb7fd508b356fec743","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        base.setup_test_logging("},{"line_number":75,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":76,"context_line":"        cfg.CONF.set_override(\u0027use_helper_for_ns_read\u0027, False, group\u003d\u0027AGENT\u0027)"},{"line_number":77,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":78,"context_line":"        warnings.simplefilter(\"ignore\")  # warnings get reset by super"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_28f53752","line":77,"updated":"2020-10-02 03:47:49.000000000","message":"This is because of the fun of multiple inheritance where I\u0027m trying to get the logging changes to happen while also being able to start the ovsdb-servers before the plugin is init\u0027d when both of those things happen in ways that it is hard to control. I\u0027m more than happy if someone comes up with a magical solution to this other than moving the super call down here and doing the weird preSetup() thing in Ml2PluginV2TestCase.","commit_id":"3bb368ee9fcddfc98583d10b3d8d3ad399b30a82"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"888cdefbd08b085e13da891cd62dd22beadd095f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        base.setup_test_logging("},{"line_number":75,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":76,"context_line":"        cfg.CONF.set_override(\u0027use_helper_for_ns_read\u0027, False, group\u003d\u0027AGENT\u0027)"},{"line_number":77,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":78,"context_line":"        warnings.simplefilter(\"ignore\")  # warnings get reset by super"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_69c08c4b","line":77,"in_reply_to":"9f560f44_28f53752","updated":"2020-10-07 18:26:13.000000000","message":"super() is nicer than super(BaseLoggingTestCase, self)  ;)","commit_id":"3bb368ee9fcddfc98583d10b3d8d3ad399b30a82"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bf37b95c06c5845f9dee604ab0e0f53e84b35112","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        base.setup_test_logging("},{"line_number":75,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":76,"context_line":"        cfg.CONF.set_override(\u0027use_helper_for_ns_read\u0027, False, group\u003d\u0027AGENT\u0027)"},{"line_number":77,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":78,"context_line":"        warnings.simplefilter(\"ignore\")  # warnings get reset by super"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f1f61f5e","line":77,"in_reply_to":"9f560f44_69c08c4b","updated":"2020-10-09 14:39:17.000000000","message":"I agree. Just changing as little as possible. I wish there was an easy way to avoid making this part of the change at all :(","commit_id":"3bb368ee9fcddfc98583d10b3d8d3ad399b30a82"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"b3e78d0ee7cdfc3a59a54b659d0d0af29d51ef8c","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        base.setup_test_logging("},{"line_number":77,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":78,"context_line":"        cfg.CONF.set_override(\u0027use_helper_for_ns_read\u0027, False, group\u003d\u0027AGENT\u0027)"},{"line_number":79,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":80,"context_line":"        warnings.simplefilter(\"ignore\")  # warnings get reset by super"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"b02cc4ff_ee5b6225","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":48},"updated":"2021-01-14 18:45:42.000000000","message":"super().setup()","commit_id":"1c30979e05d08ad33dd4d57b8e26ff82103ae0d9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"50002472ac9f3d793dc1937288e7b8b4beb3b0c5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        base.setup_test_logging("},{"line_number":77,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":78,"context_line":"        cfg.CONF.set_override(\u0027use_helper_for_ns_read\u0027, False, group\u003d\u0027AGENT\u0027)"},{"line_number":79,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":80,"context_line":"        warnings.simplefilter(\"ignore\")  # warnings get reset by super"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"2ff56d5d_808d7bed","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":48},"in_reply_to":"b02cc4ff_ee5b6225","updated":"2021-01-14 20:42:23.000000000","message":"Done","commit_id":"1c30979e05d08ad33dd4d57b8e26ff82103ae0d9"}],"neutron/tests/unit/services/ovn_l3/test_plugin.py":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"888cdefbd08b085e13da891cd62dd22beadd095f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return patch"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def setUp(self):"},{"line_number":58,"context_line":"        mock.patch(\u0027neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.\u0027"},{"line_number":59,"context_line":"                   \u0027impl_idl_ovn.Backend.schema_helper\u0027).start()"},{"line_number":60,"context_line":"        super(TestOVNL3RouterPlugin, self).setUp()"},{"line_number":61,"context_line":"        revision_plugin.RevisionPlugin()"},{"line_number":62,"context_line":"        network_attrs \u003d {external_net.EXTERNAL: True, \u0027mtu\u0027: 1500}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_e9813cc4","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":64},"updated":"2020-10-07 18:26:13.000000000","message":"just an idea -- and possibly not a good one: would it be helpful to test/ensure that this mock was invoked/use as part of the test?","commit_id":"3bb368ee9fcddfc98583d10b3d8d3ad399b30a82"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bf37b95c06c5845f9dee604ab0e0f53e84b35112","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return patch"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def setUp(self):"},{"line_number":58,"context_line":"        mock.patch(\u0027neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.\u0027"},{"line_number":59,"context_line":"                   \u0027impl_idl_ovn.Backend.schema_helper\u0027).start()"},{"line_number":60,"context_line":"        super(TestOVNL3RouterPlugin, self).setUp()"},{"line_number":61,"context_line":"        revision_plugin.RevisionPlugin()"},{"line_number":62,"context_line":"        network_attrs \u003d {external_net.EXTERNAL: True, \u0027mtu\u0027: 1500}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_519d4b07","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":64},"in_reply_to":"9f560f44_e9813cc4","updated":"2020-10-09 14:39:17.000000000","message":"I really don\u0027t know. I\u0027ll look into it. The whole thing is a little weird, as doing things in a way where we try to stop the patch with an addCleanup actually fails. All of this was really starting to drive me a little crazy. :p","commit_id":"3bb368ee9fcddfc98583d10b3d8d3ad399b30a82"}]}