)]}'
{"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2bb58d05bf3a03eda6ab9bcddeeacf54e877326a","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        if self.ip_wrapper.netns.exists(self.name):"},{"line_number":616,"context_line":"            for pid in ip_lib.list_namespace_pids(self.name):"},{"line_number":617,"context_line":"                utils.kill_process(pid, signal.SIGKILL, run_as_root\u003dTrue)"},{"line_number":618,"context_line":"            self.ip_wrapper.netns.delete(self.name)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"class VethFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d99c6f72","line":618,"range":{"start_line":618,"start_character":12,"end_line":618,"end_character":51},"updated":"2020-09-30 08:34:23.000000000","message":"What about catching TimeoutException here and go without delete?\nThat would allow to delete in most cases the namespace, and leave only leftover netns in case the issue appears.","commit_id":"b1a1f769dd9c5c619d516a125022a00230917b58"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0088252e75a0cf1942e587ecf462f270fc09a96f","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        if self.ip_wrapper.netns.exists(self.name):"},{"line_number":616,"context_line":"            for pid in ip_lib.list_namespace_pids(self.name):"},{"line_number":617,"context_line":"                utils.kill_process(pid, signal.SIGKILL, run_as_root\u003dTrue)"},{"line_number":618,"context_line":"            self.ip_wrapper.netns.delete(self.name)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"class VethFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_88a45f4d","line":618,"range":{"start_line":618,"start_character":12,"end_line":618,"end_character":51},"in_reply_to":"9f560f44_d99c6f72","updated":"2020-09-30 13:55:55.000000000","message":"Hmmmm that\u0027s a much better idea! I\u0027ll update the patch right now.","commit_id":"b1a1f769dd9c5c619d516a125022a00230917b58"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b77b3dfcd5589fc7fddc567395ee3b0c48b5305a","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                for pid in ip_lib.list_namespace_pids(self.name):"},{"line_number":618,"context_line":"                    utils.kill_process(pid, signal.SIGKILL, run_as_root\u003dTrue)"},{"line_number":619,"context_line":"                self.ip_wrapper.netns.delete(self.name)"},{"line_number":620,"context_line":"        except fixtures._fixtures.timeout.TimeoutException as exc:"},{"line_number":621,"context_line":"            LOG.warning(\u0027Namespace %s was not deleted due to a timeout. \u0027"},{"line_number":622,"context_line":"                        \u0027Exception: %s\u0027 % (self.name, str(exc)))"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d4e26430","line":620,"updated":"2020-10-01 13:47:16.000000000","message":"The default test case timeout (180 seconds) is too much. I need a way to reduce it temporarily.","commit_id":"9ea3f3629722c41d2bc7fbb25391c2060f45e4b6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"cfc176d9d387b97b6b3f2e3282c5797b363b2c37","unresolved":false,"context_lines":[{"line_number":618,"context_line":"                    utils.kill_process(pid, signal.SIGKILL, run_as_root\u003dTrue)"},{"line_number":619,"context_line":"                self.ip_wrapper.netns.delete(self.name)"},{"line_number":620,"context_line":"        except fixtures._fixtures.timeout.TimeoutException as exc:"},{"line_number":621,"context_line":"            LOG.warning(\u0027Namespace %s was not deleted due to a timeout. \u0027"},{"line_number":622,"context_line":"                        \u0027Exception: %s\u0027 % (self.name, str(exc)))"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_01d94555","line":621,"updated":"2020-09-30 21:29:22.000000000","message":"pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.","commit_id":"9ea3f3629722c41d2bc7fbb25391c2060f45e4b6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a9f97cc1d8e5eb7c6d304174a02bf3bc868b7dc1","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        self.addCleanup(self.destroy)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    def destroy(self):"},{"line_number":616,"context_line":"        with helpers.TestTimer(5):"},{"line_number":617,"context_line":"            try:"},{"line_number":618,"context_line":"                if self.ip_wrapper.netns.exists(self.name):"},{"line_number":619,"context_line":"                    for pid in ip_lib.list_namespace_pids(self.name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_ded9cc56","line":616,"updated":"2020-10-02 12:49:27.000000000","message":"can You maybe add short TODO note to remove this once related bug will be fixed?","commit_id":"45b05a1c9a764fe83d938cc5bc859bd3b7388678"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"21515f5070f4017c966a7aad9a93ac28897da5da","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        self.addCleanup(self.destroy)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    def destroy(self):"},{"line_number":616,"context_line":"        with helpers.TestTimer(5):"},{"line_number":617,"context_line":"            try:"},{"line_number":618,"context_line":"                if self.ip_wrapper.netns.exists(self.name):"},{"line_number":619,"context_line":"                    for pid in ip_lib.list_namespace_pids(self.name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2100ad35","line":616,"in_reply_to":"9f560f44_ded9cc56","updated":"2020-10-02 14:19:46.000000000","message":"Right now","commit_id":"45b05a1c9a764fe83d938cc5bc859bd3b7388678"}]}