)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a39a96b1224bed474784ee7673d45a694630792a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OVS] Remove sleep during polling cycle"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. We should not give the GIL during the"},{"line_number":11,"context_line":"polling cycle but at the end of it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch removes a sleep introduced in the middle of a OF creation"},{"line_number":14,"context_line":"and forces to have a sleep (even with time 0) at the end of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_6b3d7b8d","line":11,"range":{"start_line":10,"start_character":27,"end_line":11,"end_character":35},"updated":"2020-10-01 05:21:17.000000000","message":"Could you elaborate please?","commit_id":"e6f842a4b73c43dc84bb082feaa769fe0f63a6cd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a5964d2564fd690677df39722cc1031d37c9bf37","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OVS] Remove sleep during polling cycle"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. We should not give the GIL during the"},{"line_number":11,"context_line":"polling cycle but at the end of it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch removes a sleep introduced in the middle of a OF creation"},{"line_number":14,"context_line":"and forces to have a sleep (even with time 0) at the end of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f621f24_8b552f20","line":11,"range":{"start_line":10,"start_character":27,"end_line":11,"end_character":35},"in_reply_to":"9f560f44_6b3d7b8d","updated":"2020-11-05 17:32:31.000000000","message":"Of course","commit_id":"e6f842a4b73c43dc84bb082feaa769fe0f63a6cd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4c94b301e21f44db0fd5731e30495aab6af2e5fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. During the polling cycle, the green thread"},{"line_number":11,"context_line":"executing this code should not return or give the execution token to"},{"line_number":12,"context_line":"other thread. Any other thread attending to RPC messages or OVSDB"},{"line_number":13,"context_line":"events will be attended but should be processed at the end of the"},{"line_number":14,"context_line":"cycle."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_69a89676","line":12,"range":{"start_line":11,"start_character":20,"end_line":12,"end_character":12},"updated":"2020-11-06 06:04:48.000000000","message":"so what\u0027s the main issue with giving GIL to other greenthreads during polling cycle? Sorry for bothering, just want to understand what is fixed here.","commit_id":"a84d31e8f89b55d85797c2c9ccd7c87d3e85f9a1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f1bb97c17fc4327754b227c0aba5a06cce0c34a9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. During the polling cycle, the green thread"},{"line_number":11,"context_line":"executing this code should not return or give the execution token to"},{"line_number":12,"context_line":"other thread. Any other thread attending to RPC messages or OVSDB"},{"line_number":13,"context_line":"events will be attended but should be processed at the end of the"},{"line_number":14,"context_line":"cycle."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_6dbbf971","line":12,"range":{"start_line":11,"start_character":20,"end_line":12,"end_character":12},"in_reply_to":"1f621f24_69a89676","updated":"2020-11-18 09:05:30.000000000","message":"I\u0027m generally ok with change but would like to see info asked by Oleg.","commit_id":"a84d31e8f89b55d85797c2c9ccd7c87d3e85f9a1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fbac79d9d8a734f613b85679fc06112e93f0a833","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. During the polling cycle, the green thread"},{"line_number":11,"context_line":"executing this code should not return or give the execution token to"},{"line_number":12,"context_line":"other thread. Any other thread attending to RPC messages or OVSDB"},{"line_number":13,"context_line":"events will be attended but should be processed at the end of the"},{"line_number":14,"context_line":"cycle."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_a1b4f5f3","line":12,"range":{"start_line":11,"start_character":20,"end_line":12,"end_character":12},"in_reply_to":"1f621f24_69a89676","updated":"2020-11-18 17:51:20.000000000","message":"The main issue is that the cycle operation is interrupted. For example, if you are adding a set of new ports or updating the SGs. The L2 population driver introduces, in system with a high amount of ports, continue interruptions in the normal port processing.\n\nAny callback from an RPC call (those are the interruptions we have in the OVS agent) should be attended at the end of the cycle, not in the middle of a batch processing. Any updated information processing about any port should be delayed to the next iteration.","commit_id":"a84d31e8f89b55d85797c2c9ccd7c87d3e85f9a1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5f3053581e7ce79aa32ec2067557f14dedd24ea2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. During the polling cycle, the green thread"},{"line_number":11,"context_line":"executing this code should not return or give the execution token to"},{"line_number":12,"context_line":"other thread. Any other thread attending to RPC messages or OVSDB"},{"line_number":13,"context_line":"events will be attended but should be processed at the end of the"},{"line_number":14,"context_line":"cycle."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fffc6b78_2c090fdd","line":12,"range":{"start_line":11,"start_character":20,"end_line":12,"end_character":12},"in_reply_to":"1f621f24_a1b4f5f3","updated":"2020-11-19 06:11:03.000000000","message":"One reason for letting other greenthreads a chance is to make agent more responsive during restarts for example, when it needs to process a large set of ports. Otherwise new resources creation could fail during that time.","commit_id":"a84d31e8f89b55d85797c2c9ccd7c87d3e85f9a1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"31b3cb0be690ca8fa6dc0e1dcfc4e0e278f57846","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. During the polling cycle, the green thread"},{"line_number":11,"context_line":"executing this code should not return or give the execution token to"},{"line_number":12,"context_line":"other thread. Any other thread attending to RPC messages or OVSDB"},{"line_number":13,"context_line":"events will be attended but should be processed at the end of the"},{"line_number":14,"context_line":"cycle."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fffc6b78_c7ce5c82","line":12,"range":{"start_line":11,"start_character":20,"end_line":12,"end_character":12},"in_reply_to":"fffc6b78_2c090fdd","updated":"2020-11-19 08:27:57.000000000","message":"ok, I understant what issue Rodolfo is trying to improve now. We have seen that already at our customer\u0027s - when they were using l2_population and spawning many ports - agent was overloaded and took very long time to provision ports as it was most of the time doing l2_population related things.\n\nThere is no ideal solution there but maybe we can try with that new way now :)","commit_id":"a84d31e8f89b55d85797c2c9ccd7c87d3e85f9a1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28db58892fea2c51a25f19e7830e0592ea9a1657","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. During the polling cycle, the green thread"},{"line_number":11,"context_line":"executing this code should not return or give the execution token to"},{"line_number":12,"context_line":"other thread. Any other thread attending to RPC messages or OVSDB"},{"line_number":13,"context_line":"events will be attended but should be processed at the end of the"},{"line_number":14,"context_line":"cycle."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fb910069_9120c1d9","line":12,"range":{"start_line":11,"start_character":20,"end_line":12,"end_character":12},"in_reply_to":"fffc6b78_392cb098","updated":"2020-11-23 12:35:12.000000000","message":"Done","commit_id":"a84d31e8f89b55d85797c2c9ccd7c87d3e85f9a1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ad85ca51ad2ae6d466b27c6084cd56fd1d1ab483","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent is a single threaded process with several eventlet threads"},{"line_number":10,"context_line":"listening to RPC messages. During the polling cycle, the green thread"},{"line_number":11,"context_line":"executing this code should not return or give the execution token to"},{"line_number":12,"context_line":"other thread. Any other thread attending to RPC messages or OVSDB"},{"line_number":13,"context_line":"events will be attended but should be processed at the end of the"},{"line_number":14,"context_line":"cycle."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fffc6b78_392cb098","line":12,"range":{"start_line":11,"start_character":20,"end_line":12,"end_character":12},"in_reply_to":"fffc6b78_c7ce5c82","updated":"2020-11-19 09:13:43.000000000","message":"Probably worth to file a bug for this then..","commit_id":"a84d31e8f89b55d85797c2c9ccd7c87d3e85f9a1"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2aa59f54d2e159c9347e6d0f4bf1360475d95c61","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import eventlet"},{"line_number":25,"context_line":"import netaddr"},{"line_number":26,"context_line":"from neutron_lib.agent import constants as agent_consts"},{"line_number":27,"context_line":"from neutron_lib.agent import topics"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_61700142","line":24,"updated":"2020-09-30 21:38:08.000000000","message":"pep8: F401 \u0027eventlet\u0027 imported but unused","commit_id":"e6f842a4b73c43dc84bb082feaa769fe0f63a6cd"}]}