)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3900e355a7aad8fc7980ef23769eb3f7367ae4c3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to always listen on all interfaces in the namespace regardless"},{"line_number":13,"context_line":"of what the system default config specifies."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1891360"},{"line_number":16,"context_line":"Change-Id: Ib800d15fb5ae33c0082a9c28019fb7a784ec7526"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b2154d4f","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"updated":"2020-09-30 16:04:09.000000000","message":"Wrong bug number","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"09ab0f64ac84c82fef2dcf0c468659c188333c4c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to always listen on all interfaces in the namespace regardless"},{"line_number":13,"context_line":"of what the system default config specifies."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1891360"},{"line_number":16,"context_line":"Change-Id: Ib800d15fb5ae33c0082a9c28019fb7a784ec7526"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_15a7c30b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"9f560f44_b2154d4f","updated":"2020-09-30 16:13:13.000000000","message":"Thx fixed it.","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5c60626af69fec45995dc8ec2d680902d94dd2d","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027--dhcp-userclass\u003dset:ipxe6,iPXE\u0027,"},{"line_number":396,"context_line":"            \u0027--local-service\u0027,"},{"line_number":397,"context_line":"            \u0027--bind-dynamic\u0027,"},{"line_number":398,"context_line":"            \u0027--interface\u003d*\u0027,"},{"line_number":399,"context_line":"        ]"},{"line_number":400,"context_line":"        if not self.device_manager.driver.bridged:"},{"line_number":401,"context_line":"            cmd +\u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_32513d65","line":398,"updated":"2020-09-30 15:54:28.000000000","message":"Only one question. Before [1], what interfaces were used? Is  [1] affecting to older dnsmasq releases?\n\n[1]https://src.fedoraproject.org/rpms/dnsmasq/c/744ba31be775c11b1f52104d6285509b06b81035?branch\u003dmaster","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"09ab0f64ac84c82fef2dcf0c468659c188333c4c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027--dhcp-userclass\u003dset:ipxe6,iPXE\u0027,"},{"line_number":396,"context_line":"            \u0027--local-service\u0027,"},{"line_number":397,"context_line":"            \u0027--bind-dynamic\u0027,"},{"line_number":398,"context_line":"            \u0027--interface\u003d*\u0027,"},{"line_number":399,"context_line":"        ]"},{"line_number":400,"context_line":"        if not self.device_manager.driver.bridged:"},{"line_number":401,"context_line":"            cmd +\u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b57ff767","line":398,"in_reply_to":"9f560f44_32513d65","updated":"2020-09-30 16:13:13.000000000","message":"The default in the system dnsmasq.conf file was \"interfaces\u003d\". Fedora added \"interfaces\u003dlo\".","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"21e5d9bb992471d7cfe92a8b624a694b1934655f","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027--dhcp-userclass\u003dset:ipxe6,iPXE\u0027,"},{"line_number":396,"context_line":"            \u0027--local-service\u0027,"},{"line_number":397,"context_line":"            \u0027--bind-dynamic\u0027,"},{"line_number":398,"context_line":"            \u0027--interface\u003d*\u0027,"},{"line_number":399,"context_line":"        ]"},{"line_number":400,"context_line":"        if not self.device_manager.driver.bridged:"},{"line_number":401,"context_line":"            cmd +\u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b2b9cd7d","line":398,"in_reply_to":"9f560f44_32513d65","updated":"2020-09-30 16:00:52.000000000","message":"We removed the --interface\u003d options to resolve a security advisory in https://review.opendev.org/#/c/333829/ - https://bugs.launchpad.net/neutron/+bug/1501206\n\nNot sure we should add it back.","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"09ab0f64ac84c82fef2dcf0c468659c188333c4c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027--dhcp-userclass\u003dset:ipxe6,iPXE\u0027,"},{"line_number":396,"context_line":"            \u0027--local-service\u0027,"},{"line_number":397,"context_line":"            \u0027--bind-dynamic\u0027,"},{"line_number":398,"context_line":"            \u0027--interface\u003d*\u0027,"},{"line_number":399,"context_line":"        ]"},{"line_number":400,"context_line":"        if not self.device_manager.driver.bridged:"},{"line_number":401,"context_line":"            cmd +\u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_15d50348","line":398,"in_reply_to":"9f560f44_527951c3","updated":"2020-09-30 16:13:13.000000000","message":"I\u0027ll ask about this and see if that addresses the issue. The system dnsmasq.conf file says the default is \u0027interfaces\u003d\u0027. If you take out the \u0027interfaces\u003dlo\u0027 line in the system default file things work.","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"fd3ded7bc84063bd78e0ea1c2609fedfd590d126","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027--dhcp-userclass\u003dset:ipxe6,iPXE\u0027,"},{"line_number":396,"context_line":"            \u0027--local-service\u0027,"},{"line_number":397,"context_line":"            \u0027--bind-dynamic\u0027,"},{"line_number":398,"context_line":"            \u0027--interface\u003d*\u0027,"},{"line_number":399,"context_line":"        ]"},{"line_number":400,"context_line":"        if not self.device_manager.driver.bridged:"},{"line_number":401,"context_line":"            cmd +\u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_75ec3ff4","line":398,"in_reply_to":"9f560f44_527951c3","updated":"2020-09-30 16:20:22.000000000","message":"Nope, --local-service docs read: Accept DNS queries only from hosts whose address is on a local subnet, ie a subnet for which an interface exists on the server. This option only has effect if there are no --interface, --except-interface, --listen-address or --auth-server options. It is intended to be set as a default on installation, to allow unconfigured installations to be useful but also safe from being used for DNS amplification attacks.","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5ef9ed6c1e6c93cd0dfda542254e36c158d6bfef","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027--dhcp-userclass\u003dset:ipxe6,iPXE\u0027,"},{"line_number":396,"context_line":"            \u0027--local-service\u0027,"},{"line_number":397,"context_line":"            \u0027--bind-dynamic\u0027,"},{"line_number":398,"context_line":"            \u0027--interface\u003d*\u0027,"},{"line_number":399,"context_line":"        ]"},{"line_number":400,"context_line":"        if not self.device_manager.driver.bridged:"},{"line_number":401,"context_line":"            cmd +\u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_527951c3","line":398,"in_reply_to":"9f560f44_b2b9cd7d","updated":"2020-09-30 16:03:05.000000000","message":"Unless a combination of this and --local-service do the right thing?  Or we just tell Fedora they broke this :(","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d04e4474f106c4ff0de6b8350eb8b15400332b24","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027--dhcp-userclass\u003dset:ipxe6,iPXE\u0027,"},{"line_number":396,"context_line":"            \u0027--local-service\u0027,"},{"line_number":397,"context_line":"            \u0027--bind-dynamic\u0027,"},{"line_number":398,"context_line":"            \u0027--interface\u003d*\u0027,"},{"line_number":399,"context_line":"        ]"},{"line_number":400,"context_line":"        if not self.device_manager.driver.bridged:"},{"line_number":401,"context_line":"            cmd +\u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_35464724","line":398,"in_reply_to":"9f560f44_b57ff767","updated":"2020-09-30 16:14:35.000000000","message":"Thanks, just didn\u0027t want to re-introduce a security issue.","commit_id":"69ba0c4e059859f5d47a5786604ada5927e9cabb"}]}
