)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"2c2d609e120f53b5ac6a7e58fa3f058d87963d38","unresolved":false,"context_lines":[{"line_number":14,"context_line":"default conf file."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I22570a44f84d14a792633747c04d7426ab231009"},{"line_number":17,"context_line":"Closes-Bug: #1876094"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_615c8119","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":20},"updated":"2020-09-30 21:04:21.000000000","message":"Related but still not correct one :)\nThis is 1896945","commit_id":"fa243f772c8be2ca7cf9cdc2de4790bb3429e6d2"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"18df94a1ea7738abdfb8b50a4b5b7b8288c59aec","unresolved":false,"context_lines":[{"line_number":14,"context_line":"default conf file."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I22570a44f84d14a792633747c04d7426ab231009"},{"line_number":17,"context_line":"Closes-Bug: #1876094"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_3fa0d942","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":20},"in_reply_to":"9f560f44_615c8119","updated":"2020-10-01 11:37:49.000000000","message":"Thank you Bernard. I seemed to have a real problem with this yesterday for some reason. :/","commit_id":"fa243f772c8be2ca7cf9cdc2de4790bb3429e6d2"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"be7ab8a0ca4c7c7c99ebd2958996a69ac44355fc","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                       self.conf.dhcp_rebinding_time)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        cmd.append(\u0027--conf-file\u003d%s\u0027 %"},{"line_number":466,"context_line":"                   self.conf.dnsmasq_config_file or \u0027/dev/null\u0027)"},{"line_number":467,"context_line":"        for server in self.conf.dnsmasq_dns_servers:"},{"line_number":468,"context_line":"            cmd.append(\u0027--server\u003d%s\u0027 % server)"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ce2775c7","line":466,"range":{"start_line":466,"start_character":19,"end_line":466,"end_character":48},"updated":"2020-10-01 08:33:33.000000000","message":"Here the precedence works strangely (for me at least) so you need a bracket:\ncmd.append(\u0027--conf-file\u003d%s\u0027 %\n           (self.conf.dnsmasq_config_file or \u0027/dev/null\u0027))\n\nOtherwise as dnsmasq_config_file is by default \u0027\u0027 (https://opendev.org/openstack/neutron/src/commit/6ccfc34227b46451ba915b48189f208434481989/neutron/conf/agent/dhcp.py#L87-L90 ) it will be used instead of /dev/null.","commit_id":"fa243f772c8be2ca7cf9cdc2de4790bb3429e6d2"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"1016cfff99d65d47a2b3aa838b75c3a7af29aa0e","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                       self.conf.dhcp_rebinding_time)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        cmd.append(\u0027--conf-file\u003d%s\u0027 %"},{"line_number":466,"context_line":"                   self.conf.dnsmasq_config_file or \u0027/dev/null\u0027)"},{"line_number":467,"context_line":"        for server in self.conf.dnsmasq_dns_servers:"},{"line_number":468,"context_line":"            cmd.append(\u0027--server\u003d%s\u0027 % server)"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1ae5233f","line":466,"range":{"start_line":466,"start_character":19,"end_line":466,"end_character":48},"in_reply_to":"9f560f44_1afb6315","updated":"2020-10-01 12:02:50.000000000","message":"Huh, well look at that!\nI\u0027m just working on reviewing the test now. I\u0027ll make an update to it. Thanks!","commit_id":"fa243f772c8be2ca7cf9cdc2de4790bb3429e6d2"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"18df94a1ea7738abdfb8b50a4b5b7b8288c59aec","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                       self.conf.dhcp_rebinding_time)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        cmd.append(\u0027--conf-file\u003d%s\u0027 %"},{"line_number":466,"context_line":"                   self.conf.dnsmasq_config_file or \u0027/dev/null\u0027)"},{"line_number":467,"context_line":"        for server in self.conf.dnsmasq_dns_servers:"},{"line_number":468,"context_line":"            cmd.append(\u0027--server\u003d%s\u0027 % server)"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ff95c1e4","line":466,"range":{"start_line":466,"start_character":19,"end_line":466,"end_character":48},"in_reply_to":"9f560f44_ce2775c7","updated":"2020-10-01 11:37:49.000000000","message":"I think we\u0027ll get the same result with or without the ().\nIf dnsmasq_config_file is empty, which is is by default, /dev/null is used. Otherwise dnsmasq_config_file is used because it has a value other than empty string.","commit_id":"fa243f772c8be2ca7cf9cdc2de4790bb3429e6d2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"71e8b9cfe679dfaa9236ae3eaa100a62ebfbb29d","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                       self.conf.dhcp_rebinding_time)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        cmd.append(\u0027--conf-file\u003d%s\u0027 %"},{"line_number":466,"context_line":"                   self.conf.dnsmasq_config_file or \u0027/dev/null\u0027)"},{"line_number":467,"context_line":"        for server in self.conf.dnsmasq_dns_servers:"},{"line_number":468,"context_line":"            cmd.append(\u0027--server\u003d%s\u0027 % server)"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1afb6315","line":466,"range":{"start_line":466,"start_character":19,"end_line":466,"end_character":48},"in_reply_to":"9f560f44_ff95c1e4","updated":"2020-10-01 11:43:12.000000000","message":"yeah that was my thought as well, but this is string operation and works some different way, but anyway I checked with dummy console probe:\nIn [26]: \u0027--conf-file\u003d%s\u0027 % \u0027\u0027 or \u0027/dev/null\u0027                                                                                                                                                                      \nOut[26]: \u0027--conf-file\u003d\u0027\n\nand in devstack as well.","commit_id":"fa243f772c8be2ca7cf9cdc2de4790bb3429e6d2"}]}