)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f95a48889a029868d16ce03e69ae1caf63b8451","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            return int(self._nb_ovn.nb_global.options.get(\u0027max_tunid\u0027))"},{"line_number":415,"context_line":"        except (ValueError, TypeError):"},{"line_number":416,"context_line":"            # max_tunid may be absent in older OVN versions"},{"line_number":417,"context_line":"            return 2 ** 64"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def _validate_network_segments(self, network_segments):"},{"line_number":420,"context_line":"        for network_segment in network_segments:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_cd971beb","line":417,"updated":"2020-10-08 07:33:19.000000000","message":"one question: why we are falling back to 2**64 here? In neutron-lib both MAX_GENEVE_VNI and MAX_VXLAN_ID are defined as 2**24-1, See https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L329","commit_id":"c06441ce6a1b138601629e9757856c9a0282bfbf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a2c5a1cc2480fec4f356ab80516f7f2064d29f2e","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            return int(self._nb_ovn.nb_global.options.get(\u0027max_tunid\u0027))"},{"line_number":415,"context_line":"        except (ValueError, TypeError):"},{"line_number":416,"context_line":"            # max_tunid may be absent in older OVN versions"},{"line_number":417,"context_line":"            return 2 ** 64"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def _validate_network_segments(self, network_segments):"},{"line_number":420,"context_line":"        for network_segment in network_segments:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f8ebb60e","line":417,"in_reply_to":"9f560f44_cd971beb","updated":"2020-10-08 13:52:29.000000000","message":"Just a \"so larger a number that will make the validation ineffective\". We could make it more explicit by e.g. returning None and then dealing with it below. Let me do that.","commit_id":"c06441ce6a1b138601629e9757856c9a0282bfbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"05dbfd28542170b2bf57b3d65f3fa50415e8f3dd","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            return int(self._nb_ovn.nb_global.options.get(\u0027max_tunid\u0027))"},{"line_number":415,"context_line":"        except (ValueError, TypeError):"},{"line_number":416,"context_line":"            # max_tunid may be absent in older OVN versions"},{"line_number":417,"context_line":"            return 2 ** 64"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def _validate_network_segments(self, network_segments):"},{"line_number":420,"context_line":"        for network_segment in network_segments:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_e6e28001","line":417,"in_reply_to":"9f560f44_f8ebb60e","updated":"2020-10-21 20:05:12.000000000","message":"ok, thx. I was just curious :)","commit_id":"c06441ce6a1b138601629e9757856c9a0282bfbf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6737356c7dc0c959c7ef8a25b014c4c6032503c2","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            return int(self._nb_ovn.nb_global.options.get(\u0027max_tunid\u0027))"},{"line_number":415,"context_line":"        except (ValueError, TypeError):"},{"line_number":416,"context_line":"            # max_tunid may be absent in older OVN versions, return None"},{"line_number":417,"context_line":"            return"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def _validate_network_segments(self, network_segments):"},{"line_number":420,"context_line":"        for network_segment in network_segments:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_2c133067","line":417,"range":{"start_line":417,"start_character":12,"end_line":417,"end_character":18},"updated":"2020-10-08 17:05:59.000000000","message":"nit: pass, then just let the implied return None happen.","commit_id":"e80ff3865941c57264cfb838bc13cb4acf2b7d85"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c604a85528b79dcd804ce2f8a608befd9a238633","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            return int(self._nb_ovn.nb_global.options.get(\u0027max_tunid\u0027))"},{"line_number":415,"context_line":"        except (ValueError, TypeError):"},{"line_number":416,"context_line":"            # max_tunid may be absent in older OVN versions, return None"},{"line_number":417,"context_line":"            return"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def _validate_network_segments(self, network_segments):"},{"line_number":420,"context_line":"        for network_segment in network_segments:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_56b83729","line":417,"range":{"start_line":417,"start_character":12,"end_line":417,"end_character":18},"in_reply_to":"9f560f44_2c133067","updated":"2020-10-19 17:28:01.000000000","message":"no reason to change but I will to comply, I don\u0027t mind","commit_id":"e80ff3865941c57264cfb838bc13cb4acf2b7d85"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6737356c7dc0c959c7ef8a25b014c4c6032503c2","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            if not self._is_network_type_supported(network_type):"},{"line_number":432,"context_line":"                msg \u003d _(\u0027Network type %s is not supported\u0027) % network_type"},{"line_number":433,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":434,"context_line":"            max_tunid \u003d self._get_max_tunid()"},{"line_number":435,"context_line":"            if segmentation_id and max_tunid and segmentation_id \u003e max_tunid:"},{"line_number":436,"context_line":"                m \u003d _(\u0027Segmentation ID %d is not supported\u0027) % segmentation_id"},{"line_number":437,"context_line":"                raise n_exc.InvalidInput(error_message\u003dm)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ac2580c1","line":434,"updated":"2020-10-08 17:05:59.000000000","message":"This can be outside the loop as it\u0027s always returning the same value","commit_id":"e80ff3865941c57264cfb838bc13cb4acf2b7d85"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8074951dc0f613c02c18562c9239bedfca71e487","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                msg \u003d _(\u0027Network type %s is not supported\u0027) % network_type"},{"line_number":434,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":435,"context_line":"            if segmentation_id and max_tunid and segmentation_id \u003e max_tunid:"},{"line_number":436,"context_line":"                m \u003d _(\u0027Segmentation ID %d is not supported\u0027) % segmentation_id"},{"line_number":437,"context_line":"                raise n_exc.InvalidInput(error_message\u003dm)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def create_segment_provnet_port(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f65232a_541321b9","line":436,"updated":"2020-10-21 15:30:10.000000000","message":"nit: \"Segmentation ID should be lower or equal to \u003cmax_tunid\u003e\"","commit_id":"fe8e550ef0aea35e0c920703c69403ab50270f21"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0c3b5b228bb20fa0ff592dd2ac0639473df0e585","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                msg \u003d _(\u0027Network type %s is not supported\u0027) % network_type"},{"line_number":434,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":435,"context_line":"            if segmentation_id and max_tunid and segmentation_id \u003e max_tunid:"},{"line_number":436,"context_line":"                m \u003d _(\u0027Segmentation ID should be lower or equal to %d\u0027) % max_tunid"},{"line_number":437,"context_line":"                raise n_exc.InvalidInput(error_message\u003dm)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def create_segment_provnet_port(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f65232a_8f275fb7","line":436,"updated":"2020-10-22 00:26:12.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"1890ad851936f3ca5f44a87e9646eb512437e85b"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"05dbfd28542170b2bf57b3d65f3fa50415e8f3dd","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test__get_max_tunid_wrong_key_value(self):"},{"line_number":163,"context_line":"        self.mech_driver._nb_ovn.nb_global.options.get.return_value \u003d \u002711wrong\u0027"},{"line_number":164,"context_line":"        self.assertIsNone(None, self.mech_driver._get_max_tunid())"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test__get_max_tunid_key_set(self):"},{"line_number":167,"context_line":"        self.mech_driver._nb_ovn.nb_global.options.get.return_value \u003d \u0027100\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f65232a_86bbcce3","line":164,"range":{"start_line":164,"start_character":26,"end_line":164,"end_character":30},"updated":"2020-10-21 20:05:12.000000000","message":"This is wrong as it will always pass","commit_id":"fe8e550ef0aea35e0c920703c69403ab50270f21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"702caf2f116129c9abdb7b5379d73238c0141173","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test__get_max_tunid_wrong_key_value(self):"},{"line_number":163,"context_line":"        self.mech_driver._nb_ovn.nb_global.options.get.return_value \u003d \u002711wrong\u0027"},{"line_number":164,"context_line":"        self.assertIsNone(None, self.mech_driver._get_max_tunid())"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test__get_max_tunid_key_set(self):"},{"line_number":167,"context_line":"        self.mech_driver._nb_ovn.nb_global.options.get.return_value \u003d \u0027100\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f65232a_89275fb7","line":164,"range":{"start_line":164,"start_character":26,"end_line":164,"end_character":30},"in_reply_to":"3f65232a_86bbcce3","updated":"2020-10-21 20:45:54.000000000","message":"Done","commit_id":"fe8e550ef0aea35e0c920703c69403ab50270f21"}]}