)]}'
{"neutron/services/ovn_l3/plugin.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"154534570e0e8721daa1870106d2fe484c1b8d70","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @staticmethod"},{"line_number":98,"context_line":"    def disable_qos_fip_extension_by_extension_drivers(aliases):"},{"line_number":99,"context_line":"        qos_service_plugin \u003d qos_api.ALIAS in cfg.CONF.service_plugins"},{"line_number":100,"context_line":"        qos_aliases \u003d qos_fip_api.FIP_QOS_ALIAS in aliases"},{"line_number":101,"context_line":"        if not qos_service_plugin and qos_aliases:"},{"line_number":102,"context_line":"            aliases.remove(qos_fip_api.FIP_QOS_ALIAS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_cec9d125","line":99,"updated":"2020-10-08 11:02:00.000000000","message":"what if user will configure full class path instead of alias in neutron\u0027s config file, then this will not work as expected, right? Maybe if would be better to use \"neutron_lib.plugins.directory.get_plugin(qos_api.ALIAS)\"?","commit_id":"234707c2e70b5492d3bb333db46d090266796558"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c7dd654f69b1b8f105de722bc33f2fc86123f168","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @staticmethod"},{"line_number":98,"context_line":"    def disable_qos_fip_extension_by_extension_drivers(aliases):"},{"line_number":99,"context_line":"        qos_service_plugin \u003d qos_api.ALIAS in cfg.CONF.service_plugins"},{"line_number":100,"context_line":"        qos_aliases \u003d qos_fip_api.FIP_QOS_ALIAS in aliases"},{"line_number":101,"context_line":"        if not qos_service_plugin and qos_aliases:"},{"line_number":102,"context_line":"            aliases.remove(qos_fip_api.FIP_QOS_ALIAS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_05bf27d0","line":99,"in_reply_to":"9f560f44_cec9d125","updated":"2020-10-08 13:08:19.000000000","message":"Done","commit_id":"234707c2e70b5492d3bb333db46d090266796558"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"209cb5e74ec5137467565162daeb8a8413e967ac","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @staticmethod"},{"line_number":96,"context_line":"    def disable_qos_fip_extension_by_extension_drivers(aliases):"},{"line_number":97,"context_line":"        qos_service_plugin \u003d directory.get_plugin(plugin_constants.QOS)"},{"line_number":98,"context_line":"        qos_aliases \u003d qos_fip_api.FIP_QOS_ALIAS in aliases"},{"line_number":99,"context_line":"        if not qos_service_plugin and qos_aliases:"},{"line_number":100,"context_line":"            aliases.remove(qos_fip_api.FIP_QOS_ALIAS)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1b4e5295","line":98,"updated":"2020-10-09 12:53:48.000000000","message":"qos_fip_in_aliases would have maybe been a better name, but it\u0027s only a nit","commit_id":"7e31f2ae41b4512afd2b3dd4fb72fcd16ef0a373"}]}