)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"de3e88ebe782f37b4c5583fce169d37883777024","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                          worker.MaintenanceWorker)"},{"line_number":264,"context_line":"        if not is_maintenance:"},{"line_number":265,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":266,"context_line":"            self.node_uuid \u003d ovn_hash_ring_db.add_node(admin_context,"},{"line_number":267,"context_line":"                                                       self.hash_ring_group)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        self._nb_ovn, self._sb_ovn \u003d impl_idl_ovn.get_ovn_idls("},{"line_number":270,"context_line":"            self, trigger, binding_events\u003dnot is_maintenance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_82832da9","line":267,"range":{"start_line":266,"start_character":12,"end_line":267,"end_character":76},"updated":"2020-10-08 12:35:20.000000000","message":"Maybe before calling it again, let\u0027s check if self.node_uuid is already set.","commit_id":"df9081548b1b8f5f60b3f8164ea4de87a6eee07a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5e3c0a827c30c5c64e3de0655a19cdfcf4934391","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                          worker.MaintenanceWorker)"},{"line_number":264,"context_line":"        if not is_maintenance:"},{"line_number":265,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":266,"context_line":"            self.node_uuid \u003d ovn_hash_ring_db.add_node(admin_context,"},{"line_number":267,"context_line":"                                                       self.hash_ring_group)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        self._nb_ovn, self._sb_ovn \u003d impl_idl_ovn.get_ovn_idls("},{"line_number":270,"context_line":"            self, trigger, binding_events\u003dnot is_maintenance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c246c5a7","line":267,"range":{"start_line":266,"start_character":0,"end_line":267,"end_character":76},"updated":"2020-10-08 12:32:23.000000000","message":"One thing perhaps we need to check prior to adding this is what happens if this gets called twice. I think it may add two nodes to hash ring but only one will be operating.\n\nCan we double check this please ? Cause that could lead to some hard to debug problems if some events gets routed to the \"non-operation node\".","commit_id":"df9081548b1b8f5f60b3f8164ea4de87a6eee07a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a1e7880a59b65cabdfded4ede97224325dcd384e","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                          worker.MaintenanceWorker)"},{"line_number":264,"context_line":"        if not is_maintenance:"},{"line_number":265,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":266,"context_line":"            self.node_uuid \u003d ovn_hash_ring_db.add_node(admin_context,"},{"line_number":267,"context_line":"                                                       self.hash_ring_group)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        self._nb_ovn, self._sb_ovn \u003d impl_idl_ovn.get_ovn_idls("},{"line_number":270,"context_line":"            self, trigger, binding_events\u003dnot is_maintenance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c2f40558","line":267,"range":{"start_line":266,"start_character":0,"end_line":267,"end_character":76},"in_reply_to":"9f560f44_c246c5a7","updated":"2020-10-08 12:34:35.000000000","message":"That\u0027s a great point, thanks! I\u0027ll investigate.","commit_id":"df9081548b1b8f5f60b3f8164ea4de87a6eee07a"}]}
