)]}'
{"tools/ovn_migration/infrared/tripleo-ovn-migration/main.yml":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5ec2b06db92e9242e2e1a3ddd389194ddc1862fc","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      - name: Fail if sriov and dvr specified together"},{"line_number":51,"context_line":"        fail:"},{"line_number":52,"context_line":"            msg: \"Invalid arguments, DVR is not supported with SR-IOV\""},{"line_number":53,"context_line":"        when:"},{"line_number":54,"context_line":"            - is_sriov|bool and is_dvr|bool"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_5e0c2138","line":52,"updated":"2020-10-12 08:53:07.000000000","message":"Can we move this check \u0026 fail before L28, that means we will not delete and create a directory if the configuration is wrong.","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"268150a5d6fda3ea23e35f13fbd073c21536dca1","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      - name: Fail if sriov and dvr specified together"},{"line_number":51,"context_line":"        fail:"},{"line_number":52,"context_line":"            msg: \"Invalid arguments, DVR is not supported with SR-IOV\""},{"line_number":53,"context_line":"        when:"},{"line_number":54,"context_line":"            - is_sriov|bool and is_dvr|bool"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_694fb1bd","line":52,"in_reply_to":"9f560f44_5e0c2138","updated":"2020-10-12 10:03:31.000000000","message":"done","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5ec2b06db92e9242e2e1a3ddd389194ddc1862fc","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                  resources_type: \"{{ resources_type }}\""},{"line_number":136,"context_line":"              when: install is not defined"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            - name: Fail if resources_type is dvr while environment is SR-IOV"},{"line_number":139,"context_line":"              fail:"},{"line_number":140,"context_line":"                  msg: \"SR-IOV does not support dvr resources\""},{"line_number":141,"context_line":"              when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_7e3ac5cc","line":138,"updated":"2020-10-12 08:53:07.000000000","message":"Maybe we should also perform these checks before taking any action","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"268150a5d6fda3ea23e35f13fbd073c21536dca1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                  resources_type: \"{{ resources_type }}\""},{"line_number":136,"context_line":"              when: install is not defined"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            - name: Fail if resources_type is dvr while environment is SR-IOV"},{"line_number":139,"context_line":"              fail:"},{"line_number":140,"context_line":"                  msg: \"SR-IOV does not support dvr resources\""},{"line_number":141,"context_line":"              when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_a945499d","line":138,"in_reply_to":"9f560f44_7e3ac5cc","updated":"2020-10-12 10:03:31.000000000","message":"done","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"}],"tools/ovn_migration/infrared/tripleo-ovn-migration/roles/create-resources/templates/create-resources.sh.j2":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5ec2b06db92e9242e2e1a3ddd389194ddc1862fc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"then"},{"line_number":12,"context_line":"    if [[ \"$resources_type\" \u003d~ \"sriov\" ]]"},{"line_number":13,"context_line":"    then"},{"line_number":14,"context_line":"\timage_url\u003dhttps://cloud.centos.org/centos/8/x86_64/images/CentOS-8-GenericCloud-8.1.1911-20200113.3.x86_64.qcow2"},{"line_number":15,"context_line":"\timage_os\u003dcentos"},{"line_number":16,"context_line":"\tserver_user_name\u003dcentos"},{"line_number":17,"context_line":"    else"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_9e2b597a","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":1},"updated":"2020-10-12 08:53:07.000000000","message":"Use spaces instead of tabs","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"268150a5d6fda3ea23e35f13fbd073c21536dca1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"then"},{"line_number":12,"context_line":"    if [[ \"$resources_type\" \u003d~ \"sriov\" ]]"},{"line_number":13,"context_line":"    then"},{"line_number":14,"context_line":"\timage_url\u003dhttps://cloud.centos.org/centos/8/x86_64/images/CentOS-8-GenericCloud-8.1.1911-20200113.3.x86_64.qcow2"},{"line_number":15,"context_line":"\timage_os\u003dcentos"},{"line_number":16,"context_line":"\tserver_user_name\u003dcentos"},{"line_number":17,"context_line":"    else"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_e9c8e121","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":1},"in_reply_to":"9f560f44_9e2b597a","updated":"2020-10-12 10:03:31.000000000","message":"done","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5ec2b06db92e9242e2e1a3ddd389194ddc1862fc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    done"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"create_interface_template\u003d\"#cloud-config"},{"line_number":88,"context_line":"write_files:"},{"line_number":89,"context_line":"  - path: /etc/sysconfig/network-scripts/ifcfg-eth0.$vlan_tenant_id"},{"line_number":90,"context_line":"    owner: \\\"root\\\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_fee7f544","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":25},"updated":"2020-10-12 08:53:07.000000000","message":"Why do we create a variable here? Can we use just the cat command instead?","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"268150a5d6fda3ea23e35f13fbd073c21536dca1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    done"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"create_interface_template\u003d\"#cloud-config"},{"line_number":88,"context_line":"write_files:"},{"line_number":89,"context_line":"  - path: /etc/sysconfig/network-scripts/ifcfg-eth0.$vlan_tenant_id"},{"line_number":90,"context_line":"    owner: \\\"root\\\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_49cc6d33","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":25},"in_reply_to":"9f560f44_fee7f544","updated":"2020-10-12 10:03:31.000000000","message":"done","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5ec2b06db92e9242e2e1a3ddd389194ddc1862fc","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        num_attempts\u003d0"},{"line_number":152,"context_line":"        while true"},{"line_number":153,"context_line":"        do"},{"line_number":154,"context_line":"            openstack server show ovn-migration-server-$type_suffix-{{ resource_suffix }}$index_suffix  -c status | grep ACTIVE"},{"line_number":155,"context_line":"            if [ \"$?\" \u003d\u003d \"0\" ]; then"},{"line_number":156,"context_line":"                break"},{"line_number":157,"context_line":"            fi"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_beba9d07","line":154,"range":{"start_line":154,"start_character":116,"end_line":154,"end_character":120},"updated":"2020-10-12 08:53:07.000000000","message":"Maybe use \"grep -q\" if we don\u0027t care about the output but we care only about the RC","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"268150a5d6fda3ea23e35f13fbd073c21536dca1","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        num_attempts\u003d0"},{"line_number":152,"context_line":"        while true"},{"line_number":153,"context_line":"        do"},{"line_number":154,"context_line":"            openstack server show ovn-migration-server-$type_suffix-{{ resource_suffix }}$index_suffix  -c status | grep ACTIVE"},{"line_number":155,"context_line":"            if [ \"$?\" \u003d\u003d \"0\" ]; then"},{"line_number":156,"context_line":"                break"},{"line_number":157,"context_line":"            fi"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_29cf7928","line":154,"range":{"start_line":154,"start_character":116,"end_line":154,"end_character":120},"in_reply_to":"9f560f44_beba9d07","updated":"2020-10-12 10:03:31.000000000","message":"done","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5ec2b06db92e9242e2e1a3ddd389194ddc1862fc","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        do"},{"line_number":202,"context_line":"            num_attempts\u003d$((num_attempts+1))"},{"line_number":203,"context_line":"            sleep 5"},{"line_number":204,"context_line":"            openstack console log show ovn-migration-server-$type_suffix-{{ resource_suffix }}$index_suffix | grep \"login:\""},{"line_number":205,"context_line":"            if [ \"$?\" \u003d\u003d \"0\" ]"},{"line_number":206,"context_line":"            then"},{"line_number":207,"context_line":"                vm_status\u003d\"up\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_fe5ed5e6","line":204,"range":{"start_line":204,"start_character":110,"end_line":204,"end_character":114},"updated":"2020-10-12 08:53:07.000000000","message":"ditto","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"268150a5d6fda3ea23e35f13fbd073c21536dca1","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        do"},{"line_number":202,"context_line":"            num_attempts\u003d$((num_attempts+1))"},{"line_number":203,"context_line":"            sleep 5"},{"line_number":204,"context_line":"            openstack console log show ovn-migration-server-$type_suffix-{{ resource_suffix }}$index_suffix | grep \"login:\""},{"line_number":205,"context_line":"            if [ \"$?\" \u003d\u003d \"0\" ]"},{"line_number":206,"context_line":"            then"},{"line_number":207,"context_line":"                vm_status\u003d\"up\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_89d965f5","line":204,"range":{"start_line":204,"start_character":110,"end_line":204,"end_character":114},"in_reply_to":"9f560f44_fe5ed5e6","updated":"2020-10-12 10:03:31.000000000","message":"done","commit_id":"5afd6dd7ddd6cbf056f6db390a0fb2cc1b900f70"}]}