)]}'
{"neutron/agent/linux/ovs_lib.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b8de015477477bf4d5850b7e5e36bec0be29d33a","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            if switch !\u003d self.br_name:"},{"line_number":401,"context_line":"              LOG.debug(_(\"Port %s is on %s, not on %s\"),"},{"line_number":402,"context_line":"                        (port_name, switch, self.br_name))"},{"line_number":403,"context_line":"              return"},{"line_number":404,"context_line":"            ofport \u003d data[ofport_idx]"},{"line_number":405,"context_line":"            # ofport must be integer otherwise return None"},{"line_number":406,"context_line":"            if not isinstance(ofport, int) or ofport \u003d\u003d -1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2F87M%3D","line":403,"updated":"2014-02-23 17:09:19.000000000","message":"Indentation is not a multiple of 4. This won\u0027t pass pep8.","commit_id":"81fc64991de8bf4e5ec83eae26dbf8cc79ccb876"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f3d03bfb6474615ac40483b34c0388c2c12555f","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            port_name \u003d data[name_idx]"},{"line_number":399,"context_line":"            switch \u003d get_bridge_for_iface(self.root_helper, port_name)"},{"line_number":400,"context_line":"            if switch !\u003d self.br_name:"},{"line_number":401,"context_line":"                LOG.debug(_(\"Port %s is on %s, not on %s\"),"},{"line_number":402,"context_line":"                          (port_name, switch, self.br_name))"},{"line_number":403,"context_line":"                return"},{"line_number":404,"context_line":"            ofport \u003d data[ofport_idx]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAU3%2F%2F8g8%3D","line":401,"updated":"2014-02-23 19:27:19.000000000","message":"IMO higher log level is appropriate because it is not a usual case. LOG.warn? At least it should be LOG.info.","commit_id":"ba2de1b25a930c5ca3adfb57d029d40e33a19997"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f3d03bfb6474615ac40483b34c0388c2c12555f","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            switch \u003d get_bridge_for_iface(self.root_helper, port_name)"},{"line_number":400,"context_line":"            if switch !\u003d self.br_name:"},{"line_number":401,"context_line":"                LOG.debug(_(\"Port %s is on %s, not on %s\"),"},{"line_number":402,"context_line":"                          (port_name, switch, self.br_name))"},{"line_number":403,"context_line":"                return"},{"line_number":404,"context_line":"            ofport \u003d data[ofport_idx]"},{"line_number":405,"context_line":"            # ofport must be integer otherwise return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAU3%2F%2F8hA%3D","line":402,"updated":"2014-02-23 19:27:19.000000000","message":"Please use keyword substitution.\n\n  _(\"Port %(port_name)s is on %(bridge)s, not on %(br_name)s\"), ....","commit_id":"ba2de1b25a930c5ca3adfb57d029d40e33a19997"}],"neutron/tests/unit/openvswitch/test_ovs_lib.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a38b3ebd66f4b99a500ec40215c0f395b202b3b","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                        \u0027external_ids:iface-id\u003d\"%s\"\u0027 % iface_id],"},{"line_number":616,"context_line":"                       root_helper\u003dself.root_helper),"},{"line_number":617,"context_line":"             self._encode_ovs_json(headings, data))]"},{"line_number":618,"context_line":"        if data is not None and len(data):"},{"line_number":619,"context_line":"            if not br_name:"},{"line_number":620,"context_line":"                br_name \u003d self.BR_NAME"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2FeNw%3D","line":618,"updated":"2014-02-26 12:43:50.000000000","message":"Consider the following instead:\n\n  if data:\n\nWe can assume \"data\" is a list because it is a utility method in unit tests.","commit_id":"bb12d3a469e6f227d27b1ef6dea56d66d7b276af"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"066c0b251a2cc35468a320b91a285ccda44c8f88","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                        \u0027external_ids:iface-id\u003d\"%s\"\u0027 % iface_id],"},{"line_number":616,"context_line":"                       root_helper\u003dself.root_helper),"},{"line_number":617,"context_line":"             self._encode_ovs_json(headings, data))]"},{"line_number":618,"context_line":"        if data is not None and len(data):"},{"line_number":619,"context_line":"            if not br_name:"},{"line_number":620,"context_line":"                br_name \u003d self.BR_NAME"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Fbb8%3D","line":618,"in_reply_to":"AAAAU3%2F%2FeNw%3D","updated":"2014-02-26 17:43:55.000000000","message":"Done, thanks!","commit_id":"bb12d3a469e6f227d27b1ef6dea56d66d7b276af"}]}
