)]}'
{"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8ce1c4672c718975dba88d2581143825f65f5ea2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.scope \u003d scope"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _is_keepalived_use_no_track_supported(self):"},{"line_number":127,"context_line":"        if self._IS_NO_TRACK_SUPPORTED is None:"},{"line_number":128,"context_line":"            self._IS_NO_TRACK_SUPPORTED \u003d ("},{"line_number":129,"context_line":"                checks.keepalived_use_no_track_support())"},{"line_number":130,"context_line":"        return self._IS_NO_TRACK_SUPPORTED"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_de82da51","line":127,"range":{"start_line":127,"start_character":16,"end_line":127,"end_character":38},"updated":"2020-10-13 11:20:17.000000000","message":"You are accessing to the instance variable, not the class variable. You should access to KeepalivedVirtualRoute._IS_NO_TRACK_SUPPORTED","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"05ac9921cca86fb1fa02035cbb11e64dcb2b6534","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.scope \u003d scope"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _is_keepalived_use_no_track_supported(self):"},{"line_number":127,"context_line":"        if self._IS_NO_TRACK_SUPPORTED is None:"},{"line_number":128,"context_line":"            self._IS_NO_TRACK_SUPPORTED \u003d ("},{"line_number":129,"context_line":"                checks.keepalived_use_no_track_support())"},{"line_number":130,"context_line":"        return self._IS_NO_TRACK_SUPPORTED"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_f0bb600b","line":127,"range":{"start_line":127,"start_character":16,"end_line":127,"end_character":38},"in_reply_to":"9f560f44_de82da51","updated":"2020-10-13 16:37:59.000000000","message":"True","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c91af78b10a15b12002c36a942f2cf8c9008cd2a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            if self._is_keepalived_use_no_track_supported():"},{"line_number":142,"context_line":"                output +\u003d \u0027 no_track\u0027"},{"line_number":143,"context_line":"            else:"},{"line_number":144,"context_line":"                LOG.warning(\"keepalived_use_no_track cfg option is True but \""},{"line_number":145,"context_line":"                            \"keepalived on host seems to not support this \""},{"line_number":146,"context_line":"                            \"option\")"},{"line_number":147,"context_line":"        return output"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fb03750a","line":146,"range":{"start_line":144,"start_character":16,"end_line":146,"end_character":37},"updated":"2020-10-13 05:20:58.000000000","message":"Should this be a warning?","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"05ac9921cca86fb1fa02035cbb11e64dcb2b6534","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            if self._is_keepalived_use_no_track_supported():"},{"line_number":142,"context_line":"                output +\u003d \u0027 no_track\u0027"},{"line_number":143,"context_line":"            else:"},{"line_number":144,"context_line":"                LOG.warning(\"keepalived_use_no_track cfg option is True but \""},{"line_number":145,"context_line":"                            \"keepalived on host seems to not support this \""},{"line_number":146,"context_line":"                            \"option\")"},{"line_number":147,"context_line":"        return output"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_502df444","line":146,"range":{"start_line":144,"start_character":16,"end_line":146,"end_character":37},"in_reply_to":"9f560f44_1e045213","updated":"2020-10-13 16:37:59.000000000","message":"yeah if the config option can be removed I think it can be removed, otherwise I feel that some feedback for the user that the config option is not used as keepalived doesn\u0027t support it on the host is necessary","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8ce1c4672c718975dba88d2581143825f65f5ea2","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            if self._is_keepalived_use_no_track_supported():"},{"line_number":142,"context_line":"                output +\u003d \u0027 no_track\u0027"},{"line_number":143,"context_line":"            else:"},{"line_number":144,"context_line":"                LOG.warning(\"keepalived_use_no_track cfg option is True but \""},{"line_number":145,"context_line":"                            \"keepalived on host seems to not support this \""},{"line_number":146,"context_line":"                            \"option\")"},{"line_number":147,"context_line":"        return output"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1e045213","line":146,"range":{"start_line":144,"start_character":16,"end_line":146,"end_character":37},"in_reply_to":"9f560f44_fb03750a","updated":"2020-10-13 11:20:17.000000000","message":"I don\u0027t think we need to even log it.","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3359c44140a47185a879bdfdcfbdf988dc45652b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            output +\u003d \u0027 dev %s\u0027 % self.interface_name"},{"line_number":144,"context_line":"        if self.scope:"},{"line_number":145,"context_line":"            output +\u003d \u0027 scope %s\u0027 % self.scope"},{"line_number":146,"context_line":"        if cfg.CONF.keepalived_use_no_track:"},{"line_number":147,"context_line":"            if _is_keepalived_use_no_track_supported():"},{"line_number":148,"context_line":"                output +\u003d \u0027 no_track\u0027"},{"line_number":149,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_98fdd93c","line":146,"range":{"start_line":146,"start_character":20,"end_line":146,"end_character":43},"updated":"2020-10-22 19:55:38.000000000","message":"shouldn\u0027t we deprecate this config option?","commit_id":"4dca7fae87d9bea01e01f786465fdb4d8231dc69"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9b1c934b30b159b72daffc0296519a7527e177ad","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            output +\u003d \u0027 dev %s\u0027 % self.interface_name"},{"line_number":144,"context_line":"        if self.scope:"},{"line_number":145,"context_line":"            output +\u003d \u0027 scope %s\u0027 % self.scope"},{"line_number":146,"context_line":"        if cfg.CONF.keepalived_use_no_track:"},{"line_number":147,"context_line":"            if _is_keepalived_use_no_track_supported():"},{"line_number":148,"context_line":"                output +\u003d \u0027 no_track\u0027"},{"line_number":149,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_25ef2385","line":146,"range":{"start_line":146,"start_character":20,"end_line":146,"end_character":43},"in_reply_to":"3f65232a_98fdd93c","updated":"2020-10-26 10:11:25.000000000","message":"I pushed a patch for deprecation: https://review.opendev.org/759657\n\nNot sure how this could be done as this option was introduced in Victoria only.","commit_id":"4dca7fae87d9bea01e01f786465fdb4d8231dc69"}],"neutron/cmd/runtime_checks.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c91af78b10a15b12002c36a942f2cf8c9008cd2a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # First line is the interesting one here from stderr"},{"line_number":50,"context_line":"        version_line \u003d res[1].split(\u0027\\n\u0027)[0]"},{"line_number":51,"context_line":"        keepalived_version \u003d packaging.version.parse(version_line.split()[1])"},{"line_number":52,"context_line":"        return keepalived_version \u003e keepalived_with_track"},{"line_number":53,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1b0c6937","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":35},"updated":"2020-10-13 05:20:58.000000000","message":"\u003e\u003d ?","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8ce1c4672c718975dba88d2581143825f65f5ea2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # First line is the interesting one here from stderr"},{"line_number":50,"context_line":"        version_line \u003d res[1].split(\u0027\\n\u0027)[0]"},{"line_number":51,"context_line":"        keepalived_version \u003d packaging.version.parse(version_line.split()[1])"},{"line_number":52,"context_line":"        return keepalived_version \u003e keepalived_with_track"},{"line_number":53,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1eee1220","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":35},"in_reply_to":"9f560f44_1b0c6937","updated":"2020-10-13 11:20:17.000000000","message":"Yes, that should be \u003e\u003d","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"05ac9921cca86fb1fa02035cbb11e64dcb2b6534","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # First line is the interesting one here from stderr"},{"line_number":50,"context_line":"        version_line \u003d res[1].split(\u0027\\n\u0027)[0]"},{"line_number":51,"context_line":"        keepalived_version \u003d packaging.version.parse(version_line.split()[1])"},{"line_number":52,"context_line":"        return keepalived_version \u003e keepalived_with_track"},{"line_number":53,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_90278c65","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":35},"in_reply_to":"9f560f44_1eee1220","updated":"2020-10-13 16:37:59.000000000","message":"Done","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c91af78b10a15b12002c36a942f2cf8c9008cd2a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        keepalived_version \u003d packaging.version.parse(version_line.split()[1])"},{"line_number":52,"context_line":"        return keepalived_version \u003e keepalived_with_track"},{"line_number":53,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9b29998a","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":20},"updated":"2020-10-13 05:20:58.000000000","message":"config default is True, probably here should also be True","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"05ac9921cca86fb1fa02035cbb11e64dcb2b6534","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        keepalived_version \u003d packaging.version.parse(version_line.split()[1])"},{"line_number":52,"context_line":"        return keepalived_version \u003e keepalived_with_track"},{"line_number":53,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_50a054a6","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":20},"in_reply_to":"9f560f44_9b29998a","updated":"2020-10-13 16:37:59.000000000","message":"That should result a situation when keepalived doesn\u0027t support no-track but we add it to the config.","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"change_message_id":"77cc0fef1b43ae030193007da82445ede8f3fa00","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        keepalived_version \u003d packaging.version.parse(version_line.split()[1])"},{"line_number":52,"context_line":"        return keepalived_version \u003e keepalived_with_track"},{"line_number":53,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bb129db2","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":20},"in_reply_to":"9f560f44_9b29998a","updated":"2020-10-13 06:40:26.000000000","message":"it honestly seems to me that there is a much larger issue if we cannot actually run `keepalived --version`.","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c91af78b10a15b12002c36a942f2cf8c9008cd2a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return keepalived_version \u003e keepalived_with_track"},{"line_number":53,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5b126156","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":16},"updated":"2020-10-13 05:20:58.000000000","message":"this seems unreachable","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"05ac9921cca86fb1fa02035cbb11e64dcb2b6534","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return keepalived_version \u003e keepalived_with_track"},{"line_number":53,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":54,"context_line":"        return False"},{"line_number":55,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_b0e28800","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":16},"in_reply_to":"9f560f44_5b126156","updated":"2020-10-13 16:37:59.000000000","message":"True, I removed","commit_id":"d0f82a3fe5c8f83e9bc506ca60284965e4c117f5"}]}