)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7097954c48b39a6e4957b1ece5118f3ede918e7d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds server side code to enable the ML2 plugin to push notifications for"},{"line_number":10,"context_line":"address groups. A follow up patch adds the corresponding code for the"},{"line_number":11,"context_line":"OVS agent to process the notifications."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I49fc6e41a69f849a14da2ae67d1e4bff561dd4ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f6b1bfe_c1bbd5e2","line":12,"updated":"2020-10-15 11:53:14.000000000","message":"Could you please add Related-Bug: #1592028","commit_id":"329e160903dca43b7f77bcac64ce44d184157ad9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7c71f795f5861cdef82be39a27ee91f208c2aaa6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds server side code to enable the ML2 plugin to push notifications for"},{"line_number":10,"context_line":"address groups. A follow up patch adds the corresponding code for the"},{"line_number":11,"context_line":"OVS agent to process the notifications."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I49fc6e41a69f849a14da2ae67d1e4bff561dd4ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f6b1bfe_2e638d1c","line":12,"in_reply_to":"7f6b1bfe_c1bbd5e2","updated":"2020-10-15 22:20:49.000000000","message":"Done","commit_id":"329e160903dca43b7f77bcac64ce44d184157ad9"}],"neutron/db/address_group_db.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7097954c48b39a6e4957b1ece5118f3ede918e7d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        if fields.get(\u0027addresses\u0027) is not constants.ATTR_NOT_SPECIFIED:"},{"line_number":114,"context_line":"            self.add_addresses(context, ag.id, fields)"},{"line_number":115,"context_line":"        ag.update()  # reload synthetic fields"},{"line_number":116,"context_line":"        registry.notify(ADDRESS_GROUP, events.AFTER_CREATE, self,"},{"line_number":117,"context_line":"                        context\u003dcontext, address_group_id\u003dag.id)"},{"line_number":118,"context_line":"        return self._make_address_group_dict(ag)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_81c9dd79","line":116,"range":{"start_line":116,"start_character":17,"end_line":116,"end_character":23},"updated":"2020-10-15 11:53:14.000000000","message":"notify is deprecated, please add at least a TODO for it","commit_id":"329e160903dca43b7f77bcac64ce44d184157ad9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7c71f795f5861cdef82be39a27ee91f208c2aaa6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        if fields.get(\u0027addresses\u0027) is not constants.ATTR_NOT_SPECIFIED:"},{"line_number":114,"context_line":"            self.add_addresses(context, ag.id, fields)"},{"line_number":115,"context_line":"        ag.update()  # reload synthetic fields"},{"line_number":116,"context_line":"        registry.notify(ADDRESS_GROUP, events.AFTER_CREATE, self,"},{"line_number":117,"context_line":"                        context\u003dcontext, address_group_id\u003dag.id)"},{"line_number":118,"context_line":"        return self._make_address_group_dict(ag)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_ae6cbd36","line":116,"range":{"start_line":116,"start_character":17,"end_line":116,"end_character":23},"in_reply_to":"7f6b1bfe_81c9dd79","updated":"2020-10-15 22:20:49.000000000","message":"I am perfectly aware that notify is deprecated. You should be aware, though, that the target for this notifications, the ML2 OVO RPC callback handler (https://github.com/openstack/neutron/blob/0431531b0c52a3d2693e749cd4c33329c285255a/neutron/plugins/ml2/ovo_rpc.py#L81-L82), receives old style notifications, which requires a context argument plus *args and **kwargs, as opposed to the new style used by publish, which receives an event payload (https://github.com/openstack/neutron-lib/blob/master/neutron_lib/callbacks/events.py#L53-L158). In this new style, the context is an attribute of the payload argument, which carries other state data that was previously conveyed by *args and **kwargs in the old style.\n\nI\u0027ll add a TODO anyways","commit_id":"329e160903dca43b7f77bcac64ce44d184157ad9"}],"neutron/tests/unit/plugins/ml2/test_ovo_rpc.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"40b45c796ba2422b4c9c8f422a568a21739eb3c9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                               \u0027addresses\u0027: [\u002710.0.0.1/32\u0027,"},{"line_number":112,"context_line":"                                             \u00272001:db8::/32\u0027]}})"},{"line_number":113,"context_line":"        self._assert_object_received("},{"line_number":114,"context_line":"            address_group.AddressGroup, ag[\u0027id\u0027], \u0027updated\u0027)"},{"line_number":115,"context_line":"        self.plugin.update_address_group(self.ctx, ag[\u0027id\u0027],"},{"line_number":116,"context_line":"            {\u0027address_group\u0027: {\u0027name\u0027: \u0027an-address-group-other-name\u0027}})"},{"line_number":117,"context_line":"        self._assert_object_received("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9b77d99f","line":114,"range":{"start_line":114,"start_character":51,"end_line":114,"end_character":58},"updated":"2020-10-13 05:30:53.000000000","message":"created?","commit_id":"329e160903dca43b7f77bcac64ce44d184157ad9"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"136987cbe3d956bda1bf623adf43dd739f9bddfe","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                               \u0027addresses\u0027: [\u002710.0.0.1/32\u0027,"},{"line_number":112,"context_line":"                                             \u00272001:db8::/32\u0027]}})"},{"line_number":113,"context_line":"        self._assert_object_received("},{"line_number":114,"context_line":"            address_group.AddressGroup, ag[\u0027id\u0027], \u0027updated\u0027)"},{"line_number":115,"context_line":"        self.plugin.update_address_group(self.ctx, ag[\u0027id\u0027],"},{"line_number":116,"context_line":"            {\u0027address_group\u0027: {\u0027name\u0027: \u0027an-address-group-other-name\u0027}})"},{"line_number":117,"context_line":"        self._assert_object_received("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_3c7819f7","line":114,"range":{"start_line":114,"start_character":51,"end_line":114,"end_character":58},"in_reply_to":"7f6b1bfe_bce5490d","updated":"2020-10-13 14:23:23.000000000","message":"Yes, and test passed :)","commit_id":"329e160903dca43b7f77bcac64ce44d184157ad9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cf1515e21f1b77db77875994a9f428fa94340700","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                               \u0027addresses\u0027: [\u002710.0.0.1/32\u0027,"},{"line_number":112,"context_line":"                                             \u00272001:db8::/32\u0027]}})"},{"line_number":113,"context_line":"        self._assert_object_received("},{"line_number":114,"context_line":"            address_group.AddressGroup, ag[\u0027id\u0027], \u0027updated\u0027)"},{"line_number":115,"context_line":"        self.plugin.update_address_group(self.ctx, ag[\u0027id\u0027],"},{"line_number":116,"context_line":"            {\u0027address_group\u0027: {\u0027name\u0027: \u0027an-address-group-other-name\u0027}})"},{"line_number":117,"context_line":"        self._assert_object_received("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_bce5490d","line":114,"range":{"start_line":114,"start_character":51,"end_line":114,"end_character":58},"in_reply_to":"9f560f44_9b77d99f","updated":"2020-10-13 14:11:06.000000000","message":"No, it is correct as it is. Seems it is updated between it\u0027s creation and the moment the notification is sent.","commit_id":"329e160903dca43b7f77bcac64ce44d184157ad9"}]}