)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0c432cbfa94db17eab2e149297c71b66d34761ec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangtongjian \u003c125163227@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-26 20:48:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug for updating floating IP port forwarding rule IP and port mismatch update success."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we update forwarding rules of floating IP,"},{"line_number":10,"context_line":"if updated floating IP port forwarding rule internal_ Ip_ Address and internal_ port_ ID mismatch,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_96a8eb1f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":90},"updated":"2020-10-26 14:39:38.000000000","message":"Please make it fit 80 chars","commit_id":"3c34741db2b023b707c73cc8a83fb22a8dd59dbf"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0c432cbfa94db17eab2e149297c71b66d34761ec","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix bug for updating floating IP port forwarding rule IP and port mismatch update success."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we update forwarding rules of floating IP,"},{"line_number":10,"context_line":"if updated floating IP port forwarding rule internal_ Ip_ Address and internal_ port_ ID mismatch,"},{"line_number":11,"context_line":"we can update success, that is a problem"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I38dd0d0640ae7a8469291fbac2139bab45cdd5c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_f662ff15","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":98},"updated":"2020-10-26 14:39:38.000000000","message":"ditto","commit_id":"3c34741db2b023b707c73cc8a83fb22a8dd59dbf"}],"neutron/services/portforwarding/pf_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0c432cbfa94db17eab2e149297c71b66d34761ec","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                                          port_forwarding):"},{"line_number":396,"context_line":"        port_forwarding \u003d port_forwarding.get(apidef.RESOURCE_NAME)"},{"line_number":397,"context_line":"        new_internal_port_id \u003d None"},{"line_number":398,"context_line":"        internal_ip_address \u003d None"},{"line_number":399,"context_line":"        if port_forwarding and port_forwarding.get(\u0027internal_port_id\u0027):"},{"line_number":400,"context_line":"            new_internal_port_id \u003d port_forwarding.get(\u0027internal_port_id\u0027)"},{"line_number":401,"context_line":"            self._check_port_has_binding_floating_ip(context, port_forwarding)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_7676efda","line":398,"range":{"start_line":398,"start_character":8,"end_line":398,"end_character":27},"updated":"2020-10-26 14:39:38.000000000","message":"consider new_internal_ip_address for consistency","commit_id":"3c34741db2b023b707c73cc8a83fb22a8dd59dbf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4bc5a3e420ccb2a91538e2833156525ac426757","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                original_pf_obj \u003d copy.deepcopy(pf_obj)"},{"line_number":412,"context_line":"                ori_internal_port_id \u003d pf_obj.internal_port_id"},{"line_number":413,"context_line":"                ori_internal_ip_address \u003d str(pf_obj.internal_ip_address)"},{"line_number":414,"context_line":"                if (new_internal_port_id and (new_internal_port_id !\u003d"},{"line_number":415,"context_line":"                                             ori_internal_port_id) or"},{"line_number":416,"context_line":"                    (internal_ip_address and (internal_ip_address !\u003d"},{"line_number":417,"context_line":"                                             ori_internal_ip_address))):"},{"line_number":418,"context_line":"                    if not new_internal_port_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_a249628c","line":415,"range":{"start_line":414,"start_character":45,"end_line":415,"end_character":65},"updated":"2020-10-26 18:44:44.000000000","message":"To make this more readable, this could be:\n\nif ((X and\n        X !\u003d Y) or\n        (A and\n         A !\u003d B)):\n\nAnd I\u0027m assuming the first half needs the parens around the entire check now.","commit_id":"3c34741db2b023b707c73cc8a83fb22a8dd59dbf"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5d75472d473ef0d58858eedc6fe59a0c1c60e070","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                                             ori_internal_ip_address))):"},{"line_number":418,"context_line":"                    if not new_internal_port_id:"},{"line_number":419,"context_line":"                        port_forwarding.update({"},{"line_number":420,"context_line":"                            \u0027internal_port\u0027:ori_internal_port_id"},{"line_number":421,"context_line":"                        })"},{"line_number":422,"context_line":"                    router_id \u003d self._find_a_router_for_fip_port_forwarding("},{"line_number":423,"context_line":"                        context, port_forwarding, fip_obj)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_7fa1a3a9","line":420,"updated":"2020-10-26 16:25:30.000000000","message":"pep8: E231 missing whitespace after \u0027:\u0027","commit_id":"3c34741db2b023b707c73cc8a83fb22a8dd59dbf"}]}