)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0d11bdab168c4bdfd0f0d16dfc584d8362bd26da","unresolved":false,"context_lines":[{"line_number":14,"context_line":"for switch dev support for vdpa interfaces. this is defered"},{"line_number":15,"context_line":"until after the ptg discussion to adress."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-on: https://review.opendev.org/#/c/760043/"},{"line_number":18,"context_line":"Change-Id: If22aedc147f7e2256f8f8ad3bebb80b6bb2f6d3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f621f24_83f11304","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"updated":"2020-11-17 15:19:25.000000000","message":"ignoring the pep8 issue this failed because this should have been Depends-On: the case actully matters","commit_id":"d12ec125e35a03aa1e8065ac560e59e33cd4486c"}],"lower-constraints.txt":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28ce0aa327804d8fbaf773a95e17edf99a919f3a","unresolved":true,"context_lines":[{"line_number":51,"context_line":"munch\u003d\u003d2.1.0"},{"line_number":52,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":53,"context_line":"netifaces\u003d\u003d0.10.4"},{"line_number":54,"context_line":"neutron-lib\u003d\u003d2.7.0"},{"line_number":55,"context_line":"openstacksdk\u003d\u003d0.31.2"},{"line_number":56,"context_line":"os-client-config\u003d\u003d1.28.0"},{"line_number":57,"context_line":"os-ken\u003d\u003d0.3.0"}],"source_content_type":"text/plain","patch_set":3,"id":"da04fa8e_3a991a65","line":54,"range":{"start_line":54,"start_character":15,"end_line":54,"end_character":17},"updated":"2021-01-13 09:15:23.000000000","message":"Please, bump to 2.8.0 to avoid conflicts with other patches.","commit_id":"e80e74e2c9530beccff7235b9a2314f406ef38f9"}],"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"46fd7ec9aaca8b152e6d50f3c3b34c3ce17b9900","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.supported_vnic_types \u003d self.prohibit_list_supported_vnic_types("},{"line_number":76,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL,"},{"line_number":77,"context_line":"                        portbindings.VNIC_DIRECT,"},{"line_number":78,"context_line":"                        portbindings.VNIC_SMARTNIC],"},{"line_number":79,"context_line":"            prohibit_list\u003dcfg.CONF.OVS_DRIVER.vnic_type_prohibit_list"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"        LOG.info(\"%s\u0027s supported_vnic_types: %s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_fcb4d837","side":"PARENT","line":78,"updated":"2020-10-28 14:30:39.000000000","message":"Now you need to fix the pep8 errors in this file, can you keep the list in the current format? One type per line. \n\nSame in mech_driver code.","commit_id":"6397a03ed861adfd3300351489547a9dfeb26db9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0d11bdab168c4bdfd0f0d16dfc584d8362bd26da","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.supported_vnic_types \u003d self.prohibit_list_supported_vnic_types("},{"line_number":76,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL,"},{"line_number":77,"context_line":"                        portbindings.VNIC_DIRECT,"},{"line_number":78,"context_line":"                        portbindings.VNIC_SMARTNIC],"},{"line_number":79,"context_line":"            prohibit_list\u003dcfg.CONF.OVS_DRIVER.vnic_type_prohibit_list"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"        LOG.info(\"%s\u0027s supported_vnic_types: %s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_c3de6b6b","side":"PARENT","line":78,"in_reply_to":"1f621f24_fcb4d837","updated":"2020-11-17 15:19:25.000000000","message":"i could i just hate that format so i remove it whenever i see it.\n\nit was both vertical and horizontal space.\nnormally you are wasting only on but this actully wastes both\nif i put one per line i think i should still make it a hanging indent not on the same line.\n\ni have considerd writing a hacking check fo this several times but i never felt worth the effort and code changes it would required.","commit_id":"6397a03ed861adfd3300351489547a9dfeb26db9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"85339cb1c3a2f1974909d371c80eb13e0028225f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if profile:"},{"line_number":124,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":125,"context_line":"        # TODO(sean-k-mooney): in the case of the melonox connectx6 dx and lx"},{"line_number":126,"context_line":"        # nics vhost-vdpa is only supported in switchdev mode but that is not strictly"},{"line_number":127,"context_line":"        # required by other vendors so we should ideally add a config value to control"},{"line_number":128,"context_line":"        # checking of switchdev support per host via the agent[\u0027configurations\u0027]"},{"line_number":129,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d34bd4ad","line":126,"updated":"2020-10-28 06:42:49.000000000","message":"pep8: E501 line too long (86 \u003e 79 characters)","commit_id":"d12ec125e35a03aa1e8065ac560e59e33cd4486c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"85339cb1c3a2f1974909d371c80eb13e0028225f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":125,"context_line":"        # TODO(sean-k-mooney): in the case of the melonox connectx6 dx and lx"},{"line_number":126,"context_line":"        # nics vhost-vdpa is only supported in switchdev mode but that is not strictly"},{"line_number":127,"context_line":"        # required by other vendors so we should ideally add a config value to control"},{"line_number":128,"context_line":"        # checking of switchdev support per host via the agent[\u0027configurations\u0027]"},{"line_number":129,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":130,"context_line":"                \u0027switchdev\u0027 not in capabilities):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_33c68818","line":127,"updated":"2020-10-28 06:42:49.000000000","message":"pep8: E501 line too long (86 \u003e 79 characters)","commit_id":"d12ec125e35a03aa1e8065ac560e59e33cd4486c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"85339cb1c3a2f1974909d371c80eb13e0028225f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        # TODO(sean-k-mooney): in the case of the melonox connectx6 dx and lx"},{"line_number":126,"context_line":"        # nics vhost-vdpa is only supported in switchdev mode but that is not strictly"},{"line_number":127,"context_line":"        # required by other vendors so we should ideally add a config value to control"},{"line_number":128,"context_line":"        # checking of switchdev support per host via the agent[\u0027configurations\u0027]"},{"line_number":129,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":130,"context_line":"                \u0027switchdev\u0027 not in capabilities):"},{"line_number":131,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s with \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_13cb8c1e","line":128,"updated":"2020-10-28 06:42:49.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"d12ec125e35a03aa1e8065ac560e59e33cd4486c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"233bb3d96f126d5bf302812458186c6b0aeb691d","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        # of the vnic_types would be available for all mechanism drivers."},{"line_number":75,"context_line":"        self.supported_vnic_types \u003d self.prohibit_list_supported_vnic_types("},{"line_number":76,"context_line":"            vnic_types\u003d["},{"line_number":77,"context_line":"                portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT,"},{"line_number":78,"context_line":"                portbindings.VNIC_SMARTNIC, portbindings.VNIC_VHOST_VDPA"},{"line_number":79,"context_line":"            ],"},{"line_number":80,"context_line":"            prohibit_list\u003dcfg.CONF.OVS_DRIVER.vnic_type_prohibit_list"},{"line_number":81,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"d9b2d665_c4384568","line":78,"range":{"start_line":77,"start_character":16,"end_line":78,"end_character":72},"updated":"2021-01-13 07:46:27.000000000","message":"not sure I got the idea about changing format, original one is more readable imo..","commit_id":"e80e74e2c9530beccff7235b9a2314f406ef38f9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28ce0aa327804d8fbaf773a95e17edf99a919f3a","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        # of the vnic_types would be available for all mechanism drivers."},{"line_number":75,"context_line":"        self.supported_vnic_types \u003d self.prohibit_list_supported_vnic_types("},{"line_number":76,"context_line":"            vnic_types\u003d["},{"line_number":77,"context_line":"                portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT,"},{"line_number":78,"context_line":"                portbindings.VNIC_SMARTNIC, portbindings.VNIC_VHOST_VDPA"},{"line_number":79,"context_line":"            ],"},{"line_number":80,"context_line":"            prohibit_list\u003dcfg.CONF.OVS_DRIVER.vnic_type_prohibit_list"},{"line_number":81,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"00290dd7_1a041de9","line":78,"range":{"start_line":77,"start_character":16,"end_line":78,"end_character":72},"in_reply_to":"d9b2d665_c4384568","updated":"2021-01-13 09:15:23.000000000","message":"Agree","commit_id":"e80e74e2c9530beccff7235b9a2314f406ef38f9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"13f9abcdbaf07a0fd816b2e86ad6f93ab95aa242","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        capabilities \u003d []"},{"line_number":124,"context_line":"        if profile:"},{"line_number":125,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":126,"context_line":"        # TODO(sean-k-mooney): in the case of the melonox connectx6 dx and lx"},{"line_number":127,"context_line":"        # nics vhost-vdpa is only supported in switchdev mode but that is not"},{"line_number":128,"context_line":"        # strictly required by other vendors so we should ideally add a config"},{"line_number":129,"context_line":"        # value to control checking of switchdev support per host via the"}],"source_content_type":"text/x-python","patch_set":4,"id":"8aa6ea8a_64f7983c","line":126,"range":{"start_line":126,"start_character":50,"end_line":126,"end_character":57},"updated":"2021-02-17 08:37:46.000000000","message":"nitty nit: Mellanox","commit_id":"69215778555d0c99f3884bcdf7c3efcfab4082e5"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28ce0aa327804d8fbaf773a95e17edf99a919f3a","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        self.supported_vnic_types \u003d ["},{"line_number":162,"context_line":"            portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT,"},{"line_number":163,"context_line":"            portbindings.VNIC_DIRECT_PHYSICAL, portbindings.VNIC_MACVTAP,"},{"line_number":164,"context_line":"            portbindings.VNIC_VHOST_VDPA"},{"line_number":165,"context_line":"        ]"},{"line_number":166,"context_line":"        self.vif_details \u003d {"},{"line_number":167,"context_line":"            portbindings.VIF_TYPE_OVS: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"35e4e2c0_5b255f8d","line":164,"updated":"2021-01-13 09:15:23.000000000","message":"same here, it is easier to maintain the list keeping one element per line. You you also keep the git history.\n\nEven more, as we do in other lists, add a comma at the end of the last element. That will keep the git history if a new element is added.\n\nself.supported_vnic_types \u003d [portbindings.VNIC_NORMAL,\n                             portbindings.VNIC_DIRECT,\n                             portbindings.VNIC_DIRECT_PHYSICAL,\n                             portbindings.VNIC_MACVTAP,\n                             portbindings.VNIC_VHOST_VDPA,\n                            ]","commit_id":"e80e74e2c9530beccff7235b9a2314f406ef38f9"}],"releasenotes/notes/vhost-vdpa-4597a27de6232350.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"13f9abcdbaf07a0fd816b2e86ad6f93ab95aa242","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new vnic type \"vdpa\" has been added to allow requesting port that"},{"line_number":5,"context_line":"    utilize a vHost-vDPA offload. The ML2/OVS and ML2/OVN mech drivers now"},{"line_number":6,"context_line":"    have support for the vHost-vDPA vnic type. vHost-vDPA is similar to"},{"line_number":7,"context_line":"    vHost-user or kernel vhost offload but utilizes the newly added vDPA bus"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6c93d9c4_c63f9aad","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":26},"updated":"2021-02-17 08:37:46.000000000","message":"nitty nit: I think it would be better to have it inside `` `` instead of \"\"","commit_id":"69215778555d0c99f3884bcdf7c3efcfab4082e5"}],"requirements.txt":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28ce0aa327804d8fbaf773a95e17edf99a919f3a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"keystonemiddleware\u003e\u003d5.1.0 # Apache-2.0"},{"line_number":17,"context_line":"netaddr\u003e\u003d0.7.18 # BSD"},{"line_number":18,"context_line":"netifaces\u003e\u003d0.10.4 # MIT"},{"line_number":19,"context_line":"neutron-lib\u003e\u003d2.7.0 # Apache-2.0"},{"line_number":20,"context_line":"python-neutronclient\u003e\u003d6.7.0 # Apache-2.0"},{"line_number":21,"context_line":"tenacity\u003e\u003d6.0.0 # Apache-2.0"},{"line_number":22,"context_line":"SQLAlchemy\u003e\u003d1.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"91ecdcdc_13b9a7e3","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":18},"updated":"2021-01-13 09:15:23.000000000","message":"ditto, 2.8.0","commit_id":"e80e74e2c9530beccff7235b9a2314f406ef38f9"}]}