)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55ec68aca7cef73d94e4580c4c0a117f4f2d9eff","unresolved":true,"context_lines":[{"line_number":12,"context_line":"and agents will always report its liveness based on currently available"},{"line_number":13,"context_line":"tables."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/762562/"},{"line_number":16,"context_line":"Change-Id: I679945b68acf391901c8602fb1828c46cd1eec55"},{"line_number":17,"context_line":"Closes-bug: #1901527"},{"line_number":18,"context_line":"Signed-off-by: Jakub Libosvar \u003clibosvar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"30af2033_0a7c8bb5","line":15,"updated":"2020-11-23 10:54:03.000000000","message":"You don\u0027t need this Depends-On anymore as it\u0027s already merged and released in ovsdbapp 1.7.0 if I\u0027m not mistaken","commit_id":"9815175935c3224400cd5bc29bc5f8b1092136b4"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"828ddf0982c4594cc6087eca03ee96a1036d66fe","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        self.event_name \u003d self.__class__.__name__"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def initialize_schema_table(self, table):"},{"line_number":374,"context_line":"        from ovs.db import custom_index"},{"line_number":375,"context_line":"        for column in table.columns.values():"},{"line_number":376,"context_line":"            if not hasattr(column, \u0027alert\u0027):"},{"line_number":377,"context_line":"                column.alert \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_bd87ba0f","line":374,"updated":"2020-11-03 03:49:23.000000000","message":"pep8: C0415: Import outside toplevel (ovs.db) (import-outside-toplevel)","commit_id":"b24a75a92ceb6ed8fcd629e7df25fdd7018dcac9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"55e4dca27d870ce5cf35e4ccb3aeb3b05fc0d254","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        }"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def handle_db_schema_changes(self, event, row):"},{"line_number":554,"context_line":"        if event \u003d\u003d \u0027create\u0027 and row._table.name \u003d\u003d \u0027Database\u0027:"},{"line_number":555,"context_line":"            try:"},{"line_number":556,"context_line":"                tables \u003d self._tables_to_register[row.name]"},{"line_number":557,"context_line":"            except KeyError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"0f610ee7_d0e1a205","line":554,"range":{"start_line":554,"start_character":20,"end_line":554,"end_character":28},"updated":"2021-01-13 15:39:41.000000000","message":"nit: This could be ovs.db.idl.ROW_CREATE or row_event.RowEvent.ROW_CREATE","commit_id":"b8cbff8802296038c879adc04d88897ef65c3167"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8e35b480fbf9134261f7887c931c00c744f1d248","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        }"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def handle_db_schema_changes(self, event, row):"},{"line_number":554,"context_line":"        if event \u003d\u003d \u0027create\u0027 and row._table.name \u003d\u003d \u0027Database\u0027:"},{"line_number":555,"context_line":"            try:"},{"line_number":556,"context_line":"                tables \u003d self._tables_to_register[row.name]"},{"line_number":557,"context_line":"            except KeyError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9cbfd26f_2cb5ee9c","line":554,"range":{"start_line":554,"start_character":20,"end_line":554,"end_character":28},"in_reply_to":"0f610ee7_d0e1a205","updated":"2021-01-25 13:38:57.000000000","message":"Done","commit_id":"b8cbff8802296038c879adc04d88897ef65c3167"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c1ae66725439497e9dc83108de32a973678430c6","unresolved":true,"context_lines":[{"line_number":558,"context_line":"            except KeyError:"},{"line_number":559,"context_line":"                return"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"            self.update_tables(tables, row.schema[0])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"            if \u0027Chassis_Private\u0027 \u003d\u003d self.driver.agent_chassis_table:"},{"line_number":564,"context_line":"                if \u0027Chassis_Private\u0027 not in self.tables:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff6b23de_4091f1e3","line":561,"range":{"start_line":561,"start_character":39,"end_line":561,"end_character":53},"updated":"2021-01-26 09:48:12.000000000","message":"\"row\" is a \"database\" register, isn\u0027t it? Where can I find information about the table description? I didn\u0027t find it in NB or SB schemes.","commit_id":"72f970abc736a2bff6a15e91100066e061c4de58"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"968eb17598604a2e3e2d2fb5656c3d58502a3e81","unresolved":true,"context_lines":[{"line_number":558,"context_line":"            except KeyError:"},{"line_number":559,"context_line":"                return"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"            self.update_tables(tables, row.schema[0])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"            if \u0027Chassis_Private\u0027 \u003d\u003d self.driver.agent_chassis_table:"},{"line_number":564,"context_line":"                if \u0027Chassis_Private\u0027 not in self.tables:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ae043b4b_d65e2326","line":561,"range":{"start_line":561,"start_character":39,"end_line":561,"end_character":53},"in_reply_to":"d69b1146_99229ad5","updated":"2021-02-02 14:47:49.000000000","message":"Right, as commented in IRC: https://github.com/openvswitch/ovs/blob/master/ovsdb/_server.ovsschema","commit_id":"72f970abc736a2bff6a15e91100066e061c4de58"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"13a03dd2de3c1c8e9632a63ad76acf144ca5589a","unresolved":true,"context_lines":[{"line_number":558,"context_line":"            except KeyError:"},{"line_number":559,"context_line":"                return"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"            self.update_tables(tables, row.schema[0])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"            if \u0027Chassis_Private\u0027 \u003d\u003d self.driver.agent_chassis_table:"},{"line_number":564,"context_line":"                if \u0027Chassis_Private\u0027 not in self.tables:"}],"source_content_type":"text/x-python","patch_set":12,"id":"d69b1146_99229ad5","line":561,"range":{"start_line":561,"start_character":39,"end_line":561,"end_character":53},"in_reply_to":"dcae005d_4aadbb06","updated":"2021-02-02 09:33:16.000000000","message":"I was trying to find the definition of this table, something like https://github.com/ovn-org/ovn/blob/master/ovn-nb.ovsschema or https://github.com/ovn-org/ovn/blob/master/ovn-sb.ovsschema","commit_id":"72f970abc736a2bff6a15e91100066e061c4de58"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"baf61e958112d4aac252ae479a6e0af51cc78734","unresolved":true,"context_lines":[{"line_number":558,"context_line":"            except KeyError:"},{"line_number":559,"context_line":"                return"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"            self.update_tables(tables, row.schema[0])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"            if \u0027Chassis_Private\u0027 \u003d\u003d self.driver.agent_chassis_table:"},{"line_number":564,"context_line":"                if \u0027Chassis_Private\u0027 not in self.tables:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dcae005d_4aadbb06","line":561,"range":{"start_line":561,"start_character":39,"end_line":561,"end_character":53},"in_reply_to":"ff6b23de_4091f1e3","updated":"2021-01-26 16:01:12.000000000","message":"Can you expand a little bit on what information you\u0027re trying to seek?","commit_id":"72f970abc736a2bff6a15e91100066e061c4de58"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c1ae66725439497e9dc83108de32a973678430c6","unresolved":true,"context_lines":[{"line_number":562,"context_line":""},{"line_number":563,"context_line":"            if \u0027Chassis_Private\u0027 \u003d\u003d self.driver.agent_chassis_table:"},{"line_number":564,"context_line":"                if \u0027Chassis_Private\u0027 not in self.tables:"},{"line_number":565,"context_line":"                    self.driver.agent_chassis_table \u003d \u0027Chassis\u0027"},{"line_number":566,"context_line":"            else:"},{"line_number":567,"context_line":"                if \u0027Chassis_Private\u0027 in self.tables:"},{"line_number":568,"context_line":"                    self.driver.agent_chassis_table \u003d \u0027Chassis_Private\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ac8c5d7f_115b9439","line":565,"updated":"2021-01-26 09:48:12.000000000","message":"At this point, shouldn\u0027t you need to change tables_to_register?\n\nself._tables_to_register[\u0027OVN_Southbound\u0027] \u003d [\u0027Chassis\u0027]","commit_id":"72f970abc736a2bff6a15e91100066e061c4de58"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"baf61e958112d4aac252ae479a6e0af51cc78734","unresolved":true,"context_lines":[{"line_number":562,"context_line":""},{"line_number":563,"context_line":"            if \u0027Chassis_Private\u0027 \u003d\u003d self.driver.agent_chassis_table:"},{"line_number":564,"context_line":"                if \u0027Chassis_Private\u0027 not in self.tables:"},{"line_number":565,"context_line":"                    self.driver.agent_chassis_table \u003d \u0027Chassis\u0027"},{"line_number":566,"context_line":"            else:"},{"line_number":567,"context_line":"                if \u0027Chassis_Private\u0027 in self.tables:"},{"line_number":568,"context_line":"                    self.driver.agent_chassis_table \u003d \u0027Chassis_Private\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"fd56c294_8292494a","line":565,"in_reply_to":"ac8c5d7f_115b9439","updated":"2021-01-26 16:01:12.000000000","message":"No, because Chassis table is already registered before the first connection, here: https://github.com/openstack/neutron/blob/04694a3490844d0fa1b03326189c2ebe5c310afe/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L498 or here, depending on what is used: https://github.com/openstack/neutron/blob/04694a3490844d0fa1b03326189c2ebe5c310afe/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L486\n\nBut the bottomline is that Chassis table is always registered as it\u0027s present in all schemas of previous versions of OVN","commit_id":"72f970abc736a2bff6a15e91100066e061c4de58"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c1ae66725439497e9dc83108de32a973678430c6","unresolved":true,"context_lines":[{"line_number":565,"context_line":"                    self.driver.agent_chassis_table \u003d \u0027Chassis\u0027"},{"line_number":566,"context_line":"            else:"},{"line_number":567,"context_line":"                if \u0027Chassis_Private\u0027 in self.tables:"},{"line_number":568,"context_line":"                    self.driver.agent_chassis_table \u003d \u0027Chassis_Private\u0027"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def notify(self, event, row, updates\u003dNone):"},{"line_number":571,"context_line":"        self.handle_db_schema_changes(event, row)"}],"source_content_type":"text/x-python","patch_set":12,"id":"04a31abd_615e90c9","line":568,"updated":"2021-01-26 09:48:12.000000000","message":"same here","commit_id":"72f970abc736a2bff6a15e91100066e061c4de58"}],"requirements.txt":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55ec68aca7cef73d94e4580c4c0a117f4f2d9eff","unresolved":true,"context_lines":[{"line_number":45,"context_line":"osprofiler\u003e\u003d2.3.0 # Apache-2.0"},{"line_number":46,"context_line":"os-ken \u003e\u003d 0.3.0 # Apache-2.0"},{"line_number":47,"context_line":"ovs\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":48,"context_line":"ovsdbapp\u003e\u003d1.7.0 # Apache-2.0"},{"line_number":49,"context_line":"psutil\u003e\u003d3.2.2 # BSD"},{"line_number":50,"context_line":"pyroute2\u003e\u003d0.5.13;sys_platform!\u003d\u0027win32\u0027 # Apache-2.0 (+ dual licensed GPL2)"},{"line_number":51,"context_line":"pyOpenSSL\u003e\u003d17.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"2e045f96_ecd122dc","line":48,"updated":"2020-11-23 10:54:03.000000000","message":"You also need to update lower-constraint.txt file","commit_id":"9815175935c3224400cd5bc29bc5f8b1092136b4"}]}